ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed.
Thanks for the fix! A few nit-picky comments about the process, in case you'll be interested in sending more patches to LLVM. Could you please upload the patch with full context and based on the upstream monorepo or svn repo (see instructions here <https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface>)? The current patch mentions `clang-r361395` directory, it should normally be stripped. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62309/new/ https://reviews.llvm.org/D62309 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
