[PATCH] D62187: Delete default constructors, copy constructors, move constructors, copy assignment, move assignment operators on Expr, Stmt and Decl

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/AST/DeclBase.h:374 + Decl(const Decl&) = delete; + Decl(Decl &&) = delete; + Decl &operator=(const Decl&) = delete;

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:46 + + StringRef Message = "no explanation"; + if (Case.Explanation) { The users will see this for every case without explanation, right? I'd expec

r361355 - [PPC64] Parse -elfv1 -elfv2 when specified on target triple

Author: maskray Date: Wed May 22 00:29:59 2019 New Revision: 361355 URL: http://llvm.org/viewvc/llvm-project?rev=361355&view=rev Log: [PPC64] Parse -elfv1 -elfv2 when specified on target triple Summary: For big-endian powerpc64, the default ABI is ELFv1. OpenPower ABI ELFv2 is supported when -ma

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

MaskRay added a comment. Reordered the code a bit and committed for you... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61950/new/ https://reviews.llvm.org/D61950 ___ cfe-commits mailing list cfe-comm

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

This revision was automatically updated to reflect the committed changes. Closed by commit rL361355: [PPC64] Parse -elfv1 -elfv2 when specified on target triple (authored by MaskRay, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D61950?vs

[PATCH] D62187: Delete default constructors, copy constructors, move constructors, copy assignment, move assignment operators on Expr, Stmt and Decl

gribozavr marked 4 inline comments as done. gribozavr added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:374 + Decl(const Decl&) = delete; + Decl(Decl &&) = delete; + Decl &operator=(const Decl&) = delete; ilya-biryukov wrote: > NIT: move co

[PATCH] D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍

gribozavr added a comment. > I prefer Option 2 because it is a cleaner, more understandable design for the > matchers. I agree with Aaron. Clang or Clang Tooling provide no promise of source stability. Of course we should not break things just because we can, but API coherence and maintainabil

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Fznamznon updated this revision to Diff 200658. Fznamznon added a comment. Minor fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Sema/Se

r361363 - [PPC64] Fix PPC64TargetInfo after D61950

Author: maskray Date: Wed May 22 02:17:21 2019 New Revision: 361363 URL: http://llvm.org/viewvc/llvm-project?rev=361363&view=rev Log: [PPC64] Fix PPC64TargetInfo after D61950 Modified: cfe/trunk/lib/Basic/Targets/PPC.h Modified: cfe/trunk/lib/Basic/Targets/PPC.h URL: http://llvm.org/viewvc/

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

martong added a comment. The `ASTImporter.cpp` looks good to me. (Becasue the `BranchHint` is a simple an enum, so we don't need to specifically import that as we would in case of e.g. an `Expr`.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467

[PATCH] D62009: [clang] perform semantic checking in constant context

Tyker updated this revision to Diff 200662. Tyker added a comment. most comments were fixed. but there is a few point on which the direction isn't clear. > I think all of the new warnings in the test cases here are undesirable (they > duplicate errors produced by the constant evaluator) in the

r361365 - [PPC64] Fix PPC64TargetInfo ABI on clang side after D61950

Author: maskray Date: Wed May 22 02:26:46 2019 New Revision: 361365 URL: http://llvm.org/viewvc/llvm-project?rev=361365&view=rev Log: [PPC64] Fix PPC64TargetInfo ABI on clang side after D61950 Modified: cfe/trunk/lib/Basic/Targets/PPC.h Modified: cfe/trunk/lib/Basic/Targets/PPC.h URL: http:

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

MaskRay added a comment. @adalava You need to run both `check-llvm` and `check-clang`, but it was my fault that I hadn't done this before committing... Two clang tests failed (http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/24521) It should have been fixed by rC361365

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added a project: clang. Uses a heuristic to detect std::function and friends. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62238 Files: clang/lib/Sema/SemaCodeComplete.cpp clang/test/Co

[PATCH] D62187: Delete default constructors, copy constructors, move constructors, copy assignment, move assignment operators on Expr, Stmt and Decl

ilya-biryukov added a comment. LG either way, the comments were NITs. Comment at: clang/include/clang/AST/Stmt.h:1057 + Stmt() = delete; Stmt(const Stmt &) = delete; gribozavr wrote: > ilya-biryukov wrote: > > NIT: Move the deleted declarations to the sta

[PATCH] D62232: [Clang][Driver] recheck for nullptr

RKSimon added a comment. According to the coverage report we don't have any coverage of TC == null at all - not sure if its (a) possible to add tests or (b) if we can ever have a non-null TC - so should we just assert? http://lab.llvm.org:8080/coverage/coverage-reports/clang/coverage/Users/buil

[PATCH] D62187: Delete default constructors, copy constructors, move constructors, copy assignment, move assignment operators on Expr, Stmt and Decl

gribozavr marked 2 inline comments as done. gribozavr added inline comments. Comment at: clang/include/clang/AST/Stmt.h:1057 + Stmt() = delete; Stmt(const Stmt &) = delete; ilya-biryukov wrote: > gribozavr wrote: > > ilya-biryukov wrote: > > > NIT: Move the

[PATCH] D62187: Delete default constructors, copy constructors, move constructors, copy assignment, move assignment operators on Expr, Stmt and Decl

gribozavr updated this revision to Diff 200684. gribozavr marked 2 inline comments as done. gribozavr added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62187/new/ https://reviews.llvm.org/D62187 Files: clan

r361368 - [Driver][Windows] Add dependent lib argument for -fprofile-generate and -fcs-profile-generate

Author: russell_gallop Date: Wed May 22 03:06:49 2019 New Revision: 361368 URL: http://llvm.org/viewvc/llvm-project?rev=361368&view=rev Log: [Driver][Windows] Add dependent lib argument for -fprofile-generate and -fcs-profile-generate Follows on from r360674 which added it for -fprofile-instr-ge

[PATCH] D62200: [Driver][Windows] Add dependent lib argument for -fprofile-generate and -fcs-profile-generate

This revision was automatically updated to reflect the committed changes. Closed by commit rL361368: [Driver][Windows] Add dependent lib argument for -fprofile-generate and -fcs… (authored by russell_gallop, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Ch

[PATCH] D62149: [LibTooling] Update Transformer to use RangeSelector instead of NodePart enum.

ilya-biryukov accepted this revision. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. See the nit about the comment, might be a good idea to fix it before landing. Comment at: clang/include/c

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

gribozavr added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:457 + forwardDiagnostic(Info); + return; + } Indentation is 2 spaces. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:472 if (Info.hasS

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

chandlerc added a comment. Sorry I've been a bit slow to respond here... In D61634#1503089 , @hfinkel wrote: > In D61634#1502201 , @tejohnson wrote: > > > In D61634#1502138

[PATCH] D62244: [AMDGPU] Enable the implicit arguments for HIP (CLANG)

cdevadas created this revision. cdevadas added reviewers: b-sumner, yaxunl. Herald added subscribers: cfe-commits, t-tye, Anastasia, tpr, dstuttard, wdng, kzhuravl. Herald added a project: clang. Enable 48-bytes of implicit arguments for HIP as well. Earlier it was enabled for OpenCL. This code

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

hans added inline comments. Comment at: lib/Frontend/TextDiagnostic.cpp:768 if (Dir) { +#ifdef _WIN32 + SmallString<4096> DirName = Dir->getName(); I think this requires a comment explaining why Windows is handled differently. CHANGES SINCE LAST ACTIO

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

skan added a comment. In D62115#1511407 , @kimgr wrote: > Also, consider `././Inputs/empty.h`. Firstly, on linux write the `clang_H_opt.c` file as #include "../Index/Inputs/empty.h" #include "Inputs/empty.h" #include "./Inputs/empty.h" #include

r361372 - [ARM][AArch64] Fix incorrect handling of alignment in va_arg code generation

Author: john.brawn Date: Wed May 22 04:42:54 2019 New Revision: 361372 URL: http://llvm.org/viewvc/llvm-project?rev=361372&view=rev Log: [ARM][AArch64] Fix incorrect handling of alignment in va_arg code generation Overaligned and underaligned types (i.e. types where the alignment has been increas

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

kadircet added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4135 +!PotentialTemplateName.getAsIdentifierInfo()->getName().contains( +"function")) + return nullptr; This looks cheesy, do we really want to perform this o

[PATCH] D62152: [ARM][AArch64] Fix incorrect handling of alignment in va_arg code generation

This revision was automatically updated to reflect the committed changes. Closed by commit rC361372: [ARM][AArch64] Fix incorrect handling of alignment in va_arg code generation (authored by john.brawn, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

Re: [PATCH] D61861: DeleteNullPointerCheck now deletes until the end brace of the condition

Request to commit patch. On Tue, May 14, 2019 at 10:56 AM Mads Ravn via Phabricator < revi...@reviews.llvm.org> wrote: > madsravn added a comment. > > In D61861#1500900 , @J-Camilleri > wrote: > > > In D61861#1500868

r361374 - Mark tests from r361278 as unsupported on Windows.

Author: russell_gallop Date: Wed May 22 05:07:52 2019 New Revision: 361374 URL: http://llvm.org/viewvc/llvm-project?rev=361374&view=rev Log: Mark tests from r361278 as unsupported on Windows. Modified: cfe/trunk/test/Driver/darwin-header-search-libcxx.cpp cfe/trunk/test/Driver/darwin-head

[PATCH] D61939: AArch64: add support for arm64_23 (ILP32) IR generation

t.p.northover updated this revision to Diff 200707. t.p.northover added a comment. During upstreaming we've changed from detecting an "arm64_32" ArchName to using a Triple::aarch64_32 Arch. We recently discovered a bug that meant only AArch32 NEON types were permitted, which is fixed in this new

[PATCH] D61939: AArch64: add support for arm64_23 (ILP32) IR generation

lebedev.ri added a comment. The subject has a typo, 23 instead of 32 ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61939/new/ https://reviews.llvm.org/D61939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel marked 4 inline comments as done. ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:46 + + StringRef Message = "no explanation"; + if (Case.Explanation) { ilya-biryukov wrote: > The users will se

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

davezarzycki added a comment. This breaks non-PIC builds. Was this planned or expected? Can we revert this until a fix is found? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62174/new/ https://reviews.llvm.org/D62174 _

[PATCH] D62149: [LibTooling] Update Transformer to use RangeSelector instead of NodePart enum.

ymandel updated this revision to Diff 200712. ymandel marked an inline comment as done. ymandel added a comment. Updated comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62149/new/ https://reviews.llvm.org/D62149 Files: clang/include/clan

r361376 - [Frontend] Return an error on bad inputs to PrecompiledPreabmle

Author: ibiryukov Date: Wed May 22 05:50:01 2019 New Revision: 361376 URL: http://llvm.org/viewvc/llvm-project?rev=361376&view=rev Log: [Frontend] Return an error on bad inputs to PrecompiledPreabmle Summary: Instead of failing with assertions. Fixes a crash found by oss-fuzz: https://bugs.chromi

r361377 - Revert r361148 "[Syntax] Introduce TokenBuffer, start clangToolingSyntax library"

Author: russell_gallop Date: Wed May 22 05:50:52 2019 New Revision: 361377 URL: http://llvm.org/viewvc/llvm-project?rev=361377&view=rev Log: Revert r361148 "[Syntax] Introduce TokenBuffer, start clangToolingSyntax library" Also reverted r361264 "[Syntax] Rename TokensTest to SyntaxTests. NFC" wh

[PATCH] D62137: [Frontend] Return an error on bad inputs to PrecompiledPreabmle

This revision was automatically updated to reflect the committed changes. Closed by commit rC361376: [Frontend] Return an error on bad inputs to PrecompiledPreabmle (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D62137?vs=200253&id=200713#toc Reposito

[PATCH] D62192: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment

ztamas updated this revision to Diff 200714. ztamas added a comment. Fixed docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62192/new/ https://reviews.llvm.org/D62192 Files: clang-tools-extra/clang-tidy/bugprone/UnhandledSelfAssignmentCheck.c

r361378 - Clang-formatting the header in advance of other planned changes; NFC.

Author: aaronballman Date: Wed May 22 06:01:28 2019 New Revision: 361378 URL: http://llvm.org/viewvc/llvm-project?rev=361378&view=rev Log: Clang-formatting the header in advance of other planned changes; NFC. Modified: cfe/trunk/utils/TableGen/TableGenBackends.h Modified: cfe/trunk/utils/Tab

r361379 - [CGOpenMPRuntime] emitX86DeclareSimdFunction - assert simdlen/cdtsize is not zero. NFCI.

Author: rksimon Date: Wed May 22 06:02:19 2019 New Revision: 361379 URL: http://llvm.org/viewvc/llvm-project?rev=361379&view=rev Log: [CGOpenMPRuntime] emitX86DeclareSimdFunction - assert simdlen/cdtsize is not zero. NFCI. Fixes scan-build division by zero warning. Modified: cfe/trunk/lib/C

r361382 - [OpenCL] Support pipe keyword in C++ mode

Author: svenvh Date: Wed May 22 06:12:20 2019 New Revision: 361382 URL: http://llvm.org/viewvc/llvm-project?rev=361382&view=rev Log: [OpenCL] Support pipe keyword in C++ mode Support the OpenCL C pipe feature in C++ for OpenCL mode, to preserve backwards compatibility with OpenCL C. Various chan

[PATCH] D62181: [OpenCL] Support pipe keyword in C++ mode

This revision was automatically updated to reflect the committed changes. Closed by commit rC361382: [OpenCL] Support pipe keyword in C++ mode (authored by svenvh, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62181/new/ https://reviews.llvm.org/D6

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

ilya-biryukov updated this revision to Diff 200717. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. - Add placeholder for captures. - Only accept classes that have exactly one template argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

ilya-biryukov marked an inline comment as done and an inline comment as not done. ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4135 +!PotentialTemplateName.getAsIdentifierInfo()->getName().contains( +"function")) +

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/HeaderGuardCheck.cpp:30 +} +std::string BugproneHeaderGuardCheck::getHeaderGuard(StringRef Filename, + StringRe

[PATCH] D61939: AArch64: add support for arm64_23 (ILP32) IR generation

t.p.northover added a comment. Oops, yes. I'll leave it wrong though, the best that could come out of any attempt to change it would be to split the thread on llvm-commits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61939/new/ https://reviews.llvm.org/D61939 _

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet updated this revision to Diff 200732. kadircet marked 5 inline comments as done. kadircet added a comment. - Added tests, and went over implementation. I am looking for input on: - Behavior on lambdas, currently it just keeps the old behaviour. I believe they should look more like func

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:940 )cpp", - "class std::initializer_list", + "template<> class initializer_list {}", }, kadircet wrote: > sammccall wrote: > > hmm,

[PATCH] D61865: [clangd] improve help message for limit-results

kadircet added a comment. I can land it for you, you can learn more about commit access from https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61865/new/ https://reviews.llvm.org/D61865

[clang-tools-extra] r361388 - [clangd] improve help message for limit-results

Author: kadircet Date: Wed May 22 07:19:40 2019 New Revision: 361388 URL: http://llvm.org/viewvc/llvm-project?rev=361388&view=rev Log: [clangd] improve help message for limit-results Summary: Make it clear that the default is 100. Patch by Brennan Vincent(@umanwizard)! Reviewers: #clang-tools-e

[PATCH] D61865: [clangd] improve help message for limit-results

This revision was automatically updated to reflect the committed changes. Closed by commit rL361388: [clangd] improve help message for limit-results (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

gchatelet added a comment. AFAIU here is a coarse plan of what needs to happen 1. Add a `no-builtin` clang function attribute that has the same semantic as the `no-builtin` cmd line argument 2. Propagate it to

[PATCH] D61914: [Support][Test] Time profiler: add regression test

aganea added a comment. Could you please move the test to a more approriate location? (ie. clang/trunk/test/Driver/) Comment at: clang/tools/driver/cc1_main.cpp:245 + +llvm::errs() << "Time trace json-file dumped to " << Path.str() << "\n"; +llvm::errs() --

[PATCH] D59407: [clangd] Add RelationSlab

nridge updated this revision to Diff 200735. nridge added a comment. Herald added a subscriber: mgrang. Implemented discussed design approach ("Add a RelationSlab storing (subject, predicate, object) triples, intended for sparse relations") Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D62005: [libunwind] [test] Fix inferring source paths

mgorny added a comment. Ping. Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62005/new/ https://reviews.llvm.org/D62005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik marked 4 inline comments as done. nik added a comment. As I've commented on, this change is not finished. However, I've addressed the inline comments nevertheless. There is one TODO left for which I would like to have an opinion. Comment at: clang-tidy/ClangTidyDiagnostic

[PATCH] D61487: [clang-tidy] Make the plugin honor NOLINT

nik updated this revision to Diff 200736. nik marked an inline comment as done. nik added a comment. Addressed comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61487/new/ https://reviews.llvm.org/D61487 Files: clang-tidy/ClangTidyDiagnosti

r361391 - Reland r361148 with a fix to the buildbot failure.

Author: ibiryukov Date: Wed May 22 07:44:45 2019 New Revision: 361391 URL: http://llvm.org/viewvc/llvm-project?rev=361391&view=rev Log: Reland r361148 with a fix to the buildbot failure. Reverted in r361377. Also reland the '.gn' files (reverted in r361389). Added: cfe/trunk/include/clang/To

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

kadircet added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4135 +!PotentialTemplateName.getAsIdentifierInfo()->getName().contains( +"function")) + return nullptr; ilya-biryukov wrote: > kadircet wrote: > > This looks

r361392 - [LibTooling] Update Transformer to use RangeSelector instead of NodePart enum.

Author: ymandel Date: Wed May 22 07:48:19 2019 New Revision: 361392 URL: http://llvm.org/viewvc/llvm-project?rev=361392&view=rev Log: [LibTooling] Update Transformer to use RangeSelector instead of NodePart enum. Transformer provides an enum to indicate the range of source text to be edited. That

[PATCH] D62149: [LibTooling] Update Transformer to use RangeSelector instead of NodePart enum.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361392: [LibTooling] Update Transformer to use RangeSelector instead of NodePart enum. (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

jdenny added a subscriber: Meinersbur. jdenny added a comment. Now that D61643 is pushed, we're back to this patch. My recollection is there are two remaining issues: 1. Should we store both the `#pragma` location and the `omp` location in the AST, or is it fi

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

ilya-biryukov updated this revision to Diff 200745. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Only work on sugared types - Do not check for 'function' in the name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4135 +!PotentialTemplateName.getAsIdentifierInfo()->getName().contains( +"function")) + return nullptr; kadircet wrote: > ilya-biryukov wrote: > > kadirc

[PATCH] D62160: [LibTooling] Update Stencil to use RangeSelector

ymandel updated this revision to Diff 200747. ymandel added a comment. Add back `node` and `sNode`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62160/new/ https://reviews.llvm.org/D62160 Files: clang/include/clang/Tooling/Refactoring/Stencil.h

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:46 + + StringRef Message = "no explanation"; + if (Case.Explanation) { ymandel wrote: > ilya-biryuk

[PATCH] D59407: [clangd] Add RelationSlab

kadircet added a comment. Mostly LG from my side, thanks! Comment at: clang-tools-extra/clangd/index/Relation.cpp:19 +llvm::iterator_range +RelationSlab::lookup(const SymbolID &Subject, + index::SymbolRole Predicate) const { I would suggest

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

kadircet accepted this revision. kadircet marked an inline comment as done. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4142 + // Handle other cases. + if (T->isPointerType()) +T

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

ikudrin updated this revision to Diff 200749. ikudrin edited the summary of this revision. ikudrin added a comment. Added a comment explaining the differences in the implementations. I would really appreciate any corrections. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59415/new/ htt

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

ilya-biryukov added a comment. Thanks for a quick review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62238/new/ https://reviews.llvm.org/D62238 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel marked 4 inline comments as done. ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:46 + + StringRef Message = "no explanation"; + if (Case.Explanation) { ilya-biryukov wrote: > ymandel wrote: >

[PATCH] D62244: [AMDGPU] Enable the implicit arguments for HIP (CLANG)

yaxunl added a comment. Currently HIP and CUDA share the same test directories, so better put the test in CodeGenCUDA. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62244/new/ https://reviews.llvm.org/D62244 ___ cfe

[PATCH] D62208: [OpenCL] Enable queue_t and clk_event_t comparisons in C++ mode

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62208/new/ https://reviews.llvm.org/D62208 ___

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim added inline comments. Comment at: compiler-rt/lib/gwp_asan/platform_specific/mutex_posix.cpp:43 + +Mutex::Mutex() : PImpl(new Impl) {} +Mutex::~Mutex() { delete PImpl; } eugenis wrote: > This is a dependency on libc++ / libstdc++. > > I'm not sure about u

[PATCH] D61923: [GWP-ASan] Mutex implementation [2].

hctim updated this revision to Diff 200760. hctim marked 2 inline comments as done. hctim added a comment. - Ifdef-d headers into mutex.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61923/new/ https://reviews.llvm.org/D61923 Files: clang/runti

r361400 - Combine two if cases because the second one is never reached.

Author: akhuang Date: Wed May 22 08:48:59 2019 New Revision: 361400 URL: http://llvm.org/viewvc/llvm-project?rev=361400&view=rev Log: Combine two if cases because the second one is never reached. Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D62214 Modif

[PATCH] D62214: Remove extra if case.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361400: Combine two if cases because the second one is never reached. (authored by akhuang, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

davezarzycki added a comment. Fixed: r361399 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62174/new/ https://reviews.llvm.org/D62174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

Rakete updated this revision to Diff 200767. Rakete marked 11 inline comments as done. Rakete added a comment. - rebased - addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D5384

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

Rakete added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:4321 + isCXXDeclarationSpecifier(ITC_Never, TPResult::True) != + TPResult::True) || +(!getLangOpts().CPlusPlus && !isDeclarationSpecifier(ITC_Yes))) { -

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

Rakete marked an inline comment as done. Rakete added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:3377-3379 // FIXME: This is not quite correct recovery as we don't transform SS // into the corresponding dependent form (and we don't diagnose

[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

Meinersbur added a comment. 1. Is there a diagnostic that would point to the `omp` token? As much as I like complete info (such as SourceLoc of semicolons), I cannot think of a use case for it. 2. I would like to see all of them all adjusted. There is an immediate improvement in that improves t

[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

ABataev added a comment. In D61509#1512293 , @Meinersbur wrote: > 1. Is there a diagnostic that would point to the `omp` token? As much as I > like complete info (such as SourceLoc of semicolons), I cannot think of a use > case for it. > 2. I would like

[PATCH] D62225: [clang][NewPM] Fixing -O0 tests that are broken under new PM

leonardchan marked 4 inline comments as done. leonardchan added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1104-1105 // which is just that always inlining occurs. - MPM.addPass(AlwaysInlinerPass()); + // We always pass false here since accordi

[PATCH] D62192: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment

ztamas updated this revision to Diff 200775. ztamas added a comment. Herald added a subscriber: mgorny. Link burprone module to cert module Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62192/new/ https://reviews.llvm.org/D62192 Files: clang-too

[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

jdenny added a comment. In D61509#1512294 , @ABataev wrote: > In D61509#1512293 , @Meinersbur > wrote: > > > 1. Is there a diagnostic that would point to the `omp` token? As much as I > > like complete info (such

[PATCH] D37813: clang-format: better handle namespace macros

Typz added a comment. The patch goal is indeed to indent the content of namespace-macro blocks like the content of any 'regular' namespace. So it should look like the content of a namespace, possibly depending on the choose style options. To sumarize, here is a detailed summary of the observabl

[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

Meinersbur added a comment. In D61509#1512311 , @jdenny wrote: > 2. I too think it likely makes sense to adjust them all eventually. But do > people think it's important to write patches adjusting all pragmas before > pushing the adjustment for any of t

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added a comment. Herald added a project: clang. ping ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50078/new/ https://reviews.llvm.org/D50078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

jdenny added a comment. In D61509#1512321 , @Meinersbur wrote: > In D61509#1512311 , @jdenny wrote: > > > 2. I too think it likely makes sense to adjust them all eventually. But do > > people think it's important

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

aaronpuchert added a comment. Ping. I'm sorry that the change turned out so big, but note that it doesn't change the behavior of any non-cc1 flags. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59673/new/ https://reviews.llvm.org/D59673 __

[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

aaronpuchert added a reviewer: ed. aaronpuchert added a comment. Another ping. I've tried to add the original authors as reviewers, but both warnings are several years old and you might not remember. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59402/new/ https

[PATCH] D52395: Thread safety analysis: Require exclusive lock for passing by non-const reference

aaronpuchert planned changes to this revision. aaronpuchert added a comment. Herald added a project: clang. I don't actually want to change anything, but remove this from your review queues until I have an idea how often the warning fires and how many false positives we have. Repository: rC

[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

gtbercea updated this revision to Diff 200782. gtbercea added a comment. - Fix function call. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60883/new/ https://reviews.llvm.org/D60883 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h Inde

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

Anastasia added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1017 + let LangOpts = [SYCL]; + let Documentation = [Undocumented]; +} Ok, I thought the earlier request was not to add undocumented attributes with the spelling? Also did `__kerne

[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:7956 +// If using unified memory, no need to do the mappings. +if (CGF.CGM.getOpenMPRuntime().hasUnifiedAddressingSupport()) + return; -

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

kadircet added inline comments. Comment at: clang/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp:48 + return llvm::None; +} else { + DirectoryWatcher::Event Front = Events.front(); nit: get rid of the else Comment at: clang

[PATCH] D58375: [Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3

phosek updated this revision to Diff 200784. phosek retitled this revision from "[Clang][NewPM] Disable tests that are broken under new PM" to "[Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3". phosek edited the summary of this revision. Repository: rC Clang CHAN

  1   2   >