aganea added a comment.
Could you please move the test to a more approriate location? (ie.
clang/trunk/test/Driver/)
================
Comment at: clang/tools/driver/cc1_main.cpp:245
+
+ llvm::errs() << "Time trace json-file dumped to " << Path.str() << "\n";
+ llvm::errs()
----------------
This seems a bit too chatty. Suround these two lines with `if
(Config->Verbose)` ?
================
Comment at: llvm/test/Support/check-time-trace.cxx:4
+
+// CHECK: "args":{"name":"clang"}
+
----------------
I don't see any other `-ftime-trace` tests, I would add a few more exhaustive
file format checks here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61914/new/
https://reviews.llvm.org/D61914
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
