[PATCH] D61364: [libcxx] [test] Fix incorrect allocator::construct assertions in associative container tests

BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists, ldionne. Herald added a subscriber: dexonsmith. In $:\Dev\msvc\src\qa\VC\Libs\libcxx\upstream\test\std\containers\map_allocator_requirement_test_templates.h and $\test\std\containers\set_allocator_requirement_test

[PATCH] D61365: [libcxx] [test] Suppress float->int narrowing warning in vector range-construction test.

BillyONeal created this revision. BillyONeal added reviewers: mclow.lists, EricWF, ldionne. Herald added a subscriber: dexonsmith. https://reviews.llvm.org/D61365 Files: test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp Index: test/std/containers/sequences/vector/

[PATCH] D61366: [libcxx] [test] Don't assert that moved-from containers with non-POCMA allocators are empty.

BillyONeal created this revision. BillyONeal added reviewers: mclow.lists, EricWF, ldionne. Herald added a subscriber: dexonsmith. The standard only requires that moved-from standard library types are in a 'valid but unspecified state', not that any moved-from container is empty. When the contai

[PATCH] D61319: [PR41674] [OpenCL] Fix initialisation of this via pointer

Anastasia added a comment. I would suggest an IR test, especially since what you want to achieve is addrspacecast in IR output. We use AST dump only if there is no other good way to test something. In fact we already have a test with similar logic that tests various OpenCL address spaces: test/

[PATCH] D61318: [Sema] Prevent binding references with mismatching address spaces to temporaries

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/SemaInit.cpp:4836 + if (T1Quals.hasAddressSpace()) { +if (!T1Quals.isAddressSpaceSupersetOf(cv1T1IgnoreAS.getQualifiers())) { + Sequence.SetFailed( rjmccal

[PATCH] D61304: [OpenCL][PR41609] Deduce static data members to __global addr space

Anastasia added a comment. In D61304#1485125 , @rjmccall wrote: > Presumably a similar rule would apply to thread-locals if you supported them. We don't support them in OpenCL. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61304/new/ https://r

r359662 - Change llvm-{objdump, readobj} -long-option to --long-option or well-known short options in tests. NFC

Author: maskray Date: Wed May 1 02:30:45 2019 New Revision: 359662 URL: http://llvm.org/viewvc/llvm-project?rev=359662&view=rev Log: Change llvm-{objdump,readobj} -long-option to --long-option or well-known short options in tests. NFC Modified: cfe/trunk/test/CodeGen/split-debug-filename.c

[PATCH] D61297: [clang-format] Fix bug that misses some function-like macro usages

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61297/new/ https://reviews.llvm.org/D61297 __

[PATCH] D61281: [clang-format] Fixed self assignment

MyDeveloperDay added a comment. Did this case some issue? Does this fix something if so can we add a test, because maybe the line isn't needed Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61281/new/ https://reviews.llvm.org/D61281 ___

[PATCH] D61276: [clang-format] Fix bug in block comment reflow that joins * and /

MyDeveloperDay added a comment. Thanks for the patch, is this case only limited to * Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61276/new/ https://reviews.llvm.org/D61276 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D61256: [clang-format][docs] Fix the Google C++ and Chromium style guide URLs

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thanks for the patch, thanks also for changing to https as I believe this was a change suggested in clang tidy docs too Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D61370: Add a C2x mode and allow attributes in it

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, dblaikie. WG14 has a working draft for C2x (WG14 N2346) and we've begun voting new features into it, so I think it's time for use to expose a C2x flag and use it. The new features we adopted this week that Clang already

[PATCH] D61097: [Sema] Emit warning for visibility attribute on internal-linkage declaration

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:2621 +if (!ND->isExternallyVisible()) { + S.Diag(AL.getRange().getBegin(), diag::warn_attribute_ignored) << AL; + return; scott.linder wrote: > aaron.ballman wrote: > > I thi

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2579 +assert( +!ES.getExpr() || +CXXConstructorDeclBits.HasTrailingExplicitSpecifier && Rakete wrote: > Your or needs parens or the disambiguation is wrong. i don't

[PATCH] D61209: [clang-tidy] Fix readability-redundant-smartptr-get for MSVC STL

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a commenting nit. Comment at: clang-tools-extra/clang-tidy/readability/RedundantSmartptrGetCheck.cpp:46 + // Make sure we are not missing th

[PATCH] D61260: [clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to structures)

aaron.ballman added a comment. Aside from the testing request, this LGTM. Comment at: test/clang-tidy/bugprone-sizeof-expression.cpp:231 + sum += sizeof(MyStruct*); + // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of 'sizeof(A*)'; pointer to aggregate + sum +

[PATCH] D61222: [clang-format] Fix a bug in AlignConsecutiveDeclarations

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61222/new/ https://reviews.llvm.org/D61222 __

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: lib/Format/FormatTokenLexer.cpp:249 + Identifier->ColumnWidth += Question->ColumnWidth; + Identifier->Type = Identifier->Type; + Tokens.erase(Tokens.end() - 1);

[PATCH] D59702: Unbreak the build of compiler-rt on Linux/mips64el

sylvestre.ledru added a comment. @atanasyan, I tried with -DCMAKE_C_FLAGS="-mabi=32" -DCMAKE_CXX_FLAGS="-mabi=32" but it still fails with: cd /<>/build-llvm/projects/compiler-rt/lib/sanitizer_common && /usr/bin/g++-8 -DHAVE_RPC_XDR_H=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FO

[clang-tools-extra] r359674 - [clangd] Delete an unused declaration

Author: maskray Date: Wed May 1 05:16:37 2019 New Revision: 359674 URL: http://llvm.org/viewvc/llvm-project?rev=359674&view=rev Log: [clangd] Delete an unused declaration Modified: clang-tools-extra/trunk/clangd/index/BackgroundIndexStorage.cpp Modified: clang-tools-extra/trunk/clangd/index

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

aaron.ballman added inline comments. Comment at: test/Index/print-type-size.c:22 + +// RUN: c-index-test -test-print-type-size %s | FileCheck %s +// CHECK: FieldDecl=size:2:9 (Definition) [type=int] [typekind=Int] [sizeof=4] [alignof=4] [offsetof=0] This should

[PATCH] D59520: [WebAssembly] Address review comments on r352930

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticIDs.h:39 DIAG_SIZE_CROSSTU = 100, - DIAG_SIZE_SEMA = 3500, + DIAG_SIZE_SEMA = 3504, DIAG_SIZE_ANALYSIS = 100, I think this should

[PATCH] D61288: [Diagnostics] Implemented support for -Wswitch-default

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/DiagnosticIDs.h:39 DIAG_SIZE_CROSSTU = 100, - DIAG_SIZE_SEMA = 3500, + DIAG_SIZE_SEMA = 3600, DIAG_SIZE_ANALYSIS = 100

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee updated this revision to Diff 197532. JornVernee marked 2 inline comments as done. JornVernee added a comment. - Restructured test source file to put CHECK comments inline - Removed IAT comments. - holding of on adding helper method until hearing back. CHANGES SINCE LAST ACTION htt

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee updated this revision to Diff 197533. JornVernee added a comment. Add forgotten newline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61239/new/ https://reviews.llvm.org/D61239 Files: test/Index/print-type-size.c tools/libclang/CXType.cpp Index: tools/libclang/CXType.c

[PATCH] D61288: [Diagnostics] Implemented support for -Wswitch-default

aaron.ballman added a comment. Do we have evidence of false positive vs true positive rates for this catching actual problems in real world code? I realize that this is for GCC compatibility, but because it's default-off, I'm wondering where the utilities lies. Comment at: i

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

aaron.ballman added a comment. In D61239#1485994 , @JornVernee wrote: > - holding of on adding helper method until hearing back. My rationale for wanting a helper method is because we already have two places were incompleteness is important but has spec

[PATCH] D61288: [Diagnostics] Implemented support for -Wswitch-default

xbolva00 added a comment. Some coding guidelines may require switch to have always default label. Even if devs know that default is not reachable, they can add default: abort(); or assert to increase safety (and warning will be silenced). Yes, it not suitable to be enabled by default, but I sti

[PATCH] D61288: [Diagnostics] Implemented support for -Wswitch-default

aaron.ballman added a comment. In D61288#1486006 , @xbolva00 wrote: > Some coding guidelines may require switch to have always default label. Even > if devs know that default is not reachable, they can add default: abort(); or > assert to increase safety

[PATCH] D61288: [Diagnostics] Implemented support for -Wswitch-default

lebedev.ri added a comment. In D61288#1486008 , @aaron.ballman wrote: > In D61288#1486006 , @xbolva00 wrote: > > > Some coding guidelines may require switch to have always default label. > > Even if devs know that

[PATCH] D61288: [Diagnostics] Implemented support for -Wswitch-default

xbolva00 added a comment. I am not familiar with clang-tidy’s codebase and I personally prefer good compiler warnings than dependency on another tool (clang-tidy). I mean the cases when diagnostic check is easy to do in the compiler. And in semaexpr we have all we need and it is simple to do it

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee marked 4 inline comments as done. JornVernee added a comment. In D61239#1486005 , @aaron.ballman wrote: > In D61239#1485994 , @JornVernee > wrote: > > > - holding of on adding helper method until hearin

[PATCH] D61288: [Diagnostics] Implemented support for -Wswitch-default

aaron.ballman added a comment. In D61288#1486034 , @xbolva00 wrote: > I am not familiar with clang-tidy’s codebase and I personally prefer good > compiler warnings than dependency on another tool (clang-tidy). I mean the > cases when diagnostic check is

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee updated this revision to Diff 197543. JornVernee marked an inline comment as done. JornVernee added a comment. - Replaced plane predicates with helper methods describing their function. - Fixed test file indentation Changing the logic for `clang_Type_getAlignOf` was not needed after al

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

aaron.ballman added inline comments. Comment at: test/Index/print-type-size.c:6 + // CHECK: FieldDecl=size:4:7 (Definition) [type=int] [typekind=Int] [sizeof=4] [alignof=4] [offsetof=0] + void* data[]; + // CHECK: FieldDecl=data:6:9 (Definition) [type=void *[]] [typekind=Inc

r359687 - [clang-format] Fix bug that misses some function-like macro usages

Author: owenpan Date: Wed May 1 08:03:41 2019 New Revision: 359687 URL: http://llvm.org/viewvc/llvm-project?rev=359687&view=rev Log: [clang-format] Fix bug that misses some function-like macro usages Fixes PR41483 Differential Revision: https://reviews.llvm.org/D61297 Modified: cfe/trunk/l

[PATCH] D61297: [clang-format] Fix bug that misses some function-like macro usages

This revision was automatically updated to reflect the committed changes. Closed by commit rL359687: [clang-format] Fix bug that misses some function-like macro usages (authored by owenpan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D61276: [clang-format] Fix bug in block comment reflow that joins * and /

owenpan added a comment. @MyDeveloperDay In theory, any whitespace character other than a blank might trigger the bug, but in practice, we only need to handle the tab, IMO. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61276/new/ https://reviews.llvm.org/D61276

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee updated this revision to Diff 197557. JornVernee marked an inline comment as done. JornVernee added a comment. - Removed const& QualType and passing by-value instead - Ran print-type-size.c through clang-format FWIW, clang-format was removing the newline at the end of the file, so I ad

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

thakis added a comment. In case anyone else runs into this: When doing incremental builds, the old ClangdTests binary stays around in `./tools/clang/tools/unittests/clangd` and is still run by `check-clang-tools`. In case you don't want that (it makes the old test target slower; or maybe your l

r359691 - [analyzer][tests] Use diff_plist, correct order of arguments for missed cases; NFC

Author: hubert.reinterpretcast Date: Wed May 1 08:53:56 2019 New Revision: 359691 URL: http://llvm.org/viewvc/llvm-project?rev=359691&view=rev Log: [analyzer][tests] Use diff_plist, correct order of arguments for missed cases; NFC For various files under `clang/test/Analysis`, D52036 applied `%

r359692 - [analyzer][tests][NFC] Add EOF newlines, normalize reference expected files

Author: hubert.reinterpretcast Date: Wed May 1 08:57:00 2019 New Revision: 359692 URL: http://llvm.org/viewvc/llvm-project?rev=359692&view=rev Log: [analyzer][tests][NFC] Add EOF newlines, normalize reference expected files Reference expected files not ending with a newline are normalized to hav

[PATCH] D61383: [Driver] Explicitly request platform rtlib in the Driver pic test

phosek created this revision. phosek added a reviewer: juliehockett. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test checks whether crtbegin.o and crtend.o appear on the link line, but names of these files may be affected by the choice of the rtlib, specifically wh

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

probinson added a comment. FYI, we had to disable clangd entirely after this patch, getting a weird problem with lit that we haven't figured out yet. In case anybody else has seen something like this, and knows what's going on, please let us know. Running all regression tests llvm-lit.p

[PATCH] D61097: [Sema] Emit warning for visibility attribute on internal-linkage declaration

scott.linder updated this revision to Diff 197570. scott.linder added a comment. Use distinct sema diagnostic and do not return early. I am going to bump `DIAG_SIZE_SEMA` in another patch, as it seems like we have hit the current limit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D610

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel created this revision. ymandel added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. This revision introduces an adaptor from Transformer's rewrite rules (`clang::tooling::RewriteRule`) to `ClangTidyCheck`. For example, g

r359702 - Bump DIAG_SIZE_SEMA, as we've hit it.

Author: scott.linder Date: Wed May 1 09:45:49 2019 New Revision: 359702 URL: http://llvm.org/viewvc/llvm-project?rev=359702&view=rev Log: Bump DIAG_SIZE_SEMA, as we've hit it. $ grep 'DIAG_SIZE_SEMA =' include/clang/Basic/DiagnosticIDs.h DIAG_SIZE_SEMA = 4000, $ grep DIAG

r359706 - [Driver] Explicitly request platform rtlib in the Driver pic test

Author: phosek Date: Wed May 1 09:52:45 2019 New Revision: 359706 URL: http://llvm.org/viewvc/llvm-project?rev=359706&view=rev Log: [Driver] Explicitly request platform rtlib in the Driver pic test This test checks whether crtbegin.o and crtend.o appear on the link line, but names of these files

[PATCH] D61383: [Driver] Explicitly request platform rtlib in the Driver pic test

This revision was automatically updated to reflect the committed changes. Closed by commit rL359706: [Driver] Explicitly request platform rtlib in the Driver pic test (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.cpp:22 + // Verify the existence and validity of the AST node that roots this rule. + auto &NodesMap = Result.Nodes.getMap(); + auto Root = NodesMap.find(tooling::RewriteRule::

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee updated this revision to Diff 197583. JornVernee marked 3 inline comments as done. JornVernee added a comment. Removed spurious newline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61239/new/ https://reviews.llvm.org/D61239 Files: test/Index/print-type-size.c tools/libc

[PATCH] D61304: [OpenCL][PR41609] Deduce static data members to __global addr space

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay. This seems reasonable to me, then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61304/new/ https://reviews.llvm.org/D61304 _

[PATCH] D61318: [Sema] Prevent binding references with mismatching address spaces to temporaries

rjmccall added inline comments. Comment at: lib/Sema/SemaInit.cpp:4836 + if (T1Quals.hasAddressSpace()) { +if (!T1Quals.isAddressSpaceSupersetOf(cv1T1IgnoreAS.getQualifiers())) { + Sequence.SetFailed( Anastasia wrote: > rjmccall wrote: > > Isn't `cv1T1I

[PATCH] D61319: [PR41674] [OpenCL] Fix initialisation of this via pointer

kpet added a comment. Ok, I'll replace the test with an IR-level test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61319/new/ https://reviews.llvm.org/D61319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60974: Clang IFSO driver action.

compnerd added a comment. @jakehehrlich - unfortunately, removing the attributes on the sections will make the content look different with `nm` which is something we do need to appear proper for consumers of the interface libraries. Versioning has a number of problems inherent to it (unfortuna

[PATCH] D61389: Bump DIAG_SIZE_SEMA up to 4000

sunfish created this revision. sunfish added a reviewer: aaron.ballman. Herald added a subscriber: aheejin. Herald added a project: clang. https://reviews.llvm.org/D59520 adds a few new diagnostics, which happens to run into a limit with DIAG_SIZE_SEMA. As suggested here

[PATCH] D58321: Support for relative vtables

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58321/new/ https://reviews.llvm.org/D58321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel updated this revision to Diff 197589. ymandel added a comment. Reduced use of auto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 Files: clang-tools-extra/clang-tidy/utils/CMakeLists.txt clang

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.cpp:22 + // Verify the existence and validity of the AST node that roots this rule. + auto &NodesMap = Result.Nodes.getMap(); + auto Root = N

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.cpp:51 + DiagnosticBuilder Diag = diag(RootLoc, Message); + for (const tooling::Transformation &T : *Transformations) { +Diag << FixItHint::CreateReplacement(T.Range, T.Repl

[PATCH] D58321: Support for relative vtables

rjmccall added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:531 +/// \brief Whether the class uses the relative C++ vtable ABI. +unsigned IsRelativeCXXABI : 1; + Should we proactively generalize this as a "CXXABIVariant" enum, which for

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel updated this revision to Diff 197597. ymandel marked an inline comment as done. ymandel added a comment. reinstated an auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 Files: clang-tools-extra

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerTidy.cpp:51 + DiagnosticBuilder Diag = diag(RootLoc, Message); + for (const tooling::Transformation &T : *Transformations) { +Diag << FixItHint

[PATCH] D61222: [clang-format] Fix a bug in AlignConsecutiveDeclarations

owenpan updated this revision to Diff 197566. owenpan added a comment. Removed a redundant test case. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61222/new/ https://reviews.llvm.org/D61222 Files: clang/lib/Format/WhitespaceManager.cpp clang/unittests/Forma

[PATCH] D61324: Make check-clang depend on the clang-check binary always

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61324/new/ https://reviews.llvm.org/D61324 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D58321: Support for relative vtables

pcc added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:531 +/// \brief Whether the class uses the relative C++ vtable ABI. +unsigned IsRelativeCXXABI : 1; + rjmccall wrote: > Should we proactively generalize this as a "CXXABIVariant" enu

[PATCH] D61222: [clang-format] Fix a bug in AlignConsecutiveDeclarations

This revision was automatically updated to reflect the committed changes. Closed by commit rL359711: [clang-format] Fix a bug in AlignConsecutiveDeclarations. (authored by owenpan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

r359711 - [clang-format] Fix a bug in AlignConsecutiveDeclarations.

Author: owenpan Date: Wed May 1 11:23:44 2019 New Revision: 359711 URL: http://llvm.org/viewvc/llvm-project?rev=359711&view=rev Log: [clang-format] Fix a bug in AlignConsecutiveDeclarations. Fixes PR37175 Differential Revision: https://reviews.llvm.org/D61222 Modified: cfe/trunk/lib/Format

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea added a comment. Ping! Is this good to go? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61046/new/ https://reviews.llvm.org/D61046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D61392: [clang] Handle lround/llround builtins

zatrazz created this revision. zatrazz added reviewers: efriedma, rengolin, javed.absar, huntergr, SjoerdMeijer, t.p.northover, echristo, evandro. zatrazz added a project: clang. Herald added subscribers: kristina, kristof.beyls. As for other floating-point rounding builtins that can be optimized

[PATCH] D61392: [clang] Handle lround/llround builtins

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Looks fine, once the LLVM changes are settled. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61392/new/ https://reviews.llvm.org/D61392

[PATCH] D61389: Bump DIAG_SIZE_SEMA up to 4000

riccibruno added a comment. Already done in r359702 :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61389/new/ https://reviews.llvm.org/D61389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

r359713 - [Parser] Avoid correcting delayed typos in array subscript multiple times.

Author: vsapsai Date: Wed May 1 12:24:50 2019 New Revision: 359713 URL: http://llvm.org/viewvc/llvm-project?rev=359713&view=rev Log: [Parser] Avoid correcting delayed typos in array subscript multiple times. We correct some typos in `ActOnArraySubscriptExpr` and `ActOnOMPArraySectionExpr`, so wh

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Rakete added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2579 +assert( +!ES.getExpr() || +CXXConstructorDeclBits.HasTrailingExplicitSpecifier && Tyker wrote: > Rakete wrote: > > Your or needs parens or the disambigua

[PATCH] D60848: [Parser] Avoid correcting delayed typos in array subscript multiple times.

This revision was automatically updated to reflect the committed changes. Closed by commit rL359713: [Parser] Avoid correcting delayed typos in array subscript multiple times. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[PATCH] D60925: [analyzer] Don't display implementation checkers under -analyzer-checker-help, but do under the new flag -analyzer-checker-help-hidden

Szelethus updated this revision to Diff 197609. Szelethus edited the summary of this revision. Szelethus added a comment. Hide `security.insecureAPI.SecuritySyntaxChecker` by default. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60925/new/ https://reviews.llvm.org/D60925 Files: incl

r359717 - Make check-clang depend on the clang-check binary always

Author: nico Date: Wed May 1 12:34:00 2019 New Revision: 359717 URL: http://llvm.org/viewvc/llvm-project?rev=359717&view=rev Log: Make check-clang depend on the clang-check binary always check-clang (the target that runs all clang tests) used to only depend on clang-check (a binary like clang-ti

[PATCH] D61324: Make check-clang depend on the clang-check binary always

This revision was automatically updated to reflect the committed changes. Closed by commit rL359717: Make check-clang depend on the clang-check binary always (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D61324?vs=197370&id=197614#toc Repository: rL LLV

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. In D60974#1486384 , @compnerd wrote: > @jakehehrlich - unfortunately, removing the attributes on the sections will > make the content look different with `nm` which is something we do need to > appear proper for consumers of

[PATCH] D61319: [PR41674] [OpenCL] Fix initialisation of this via pointer

kpet updated this revision to Diff 197617. kpet added a comment. Replaced the AST dump test with an IR test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61319/new/ https://reviews.llvm.org/D61319 Files: lib/Sema/SemaOverload.cpp test/CodeGenOpenCLCXX/addrs

[PATCH] D61097: [Sema] Emit warning for visibility attribute on internal-linkage declaration

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61097/new/ https://reviews.llvm.org/D61097 ___ cfe-commits

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! That's strange that clang-format would remove the newline from the end of the file. I don't get that behavior when I try it, so it makes me wonder what's differe

r359720 - [analyzer] Don't display implementation checkers under -analyzer-checker-help, but do under the new flag -analyzer-checker-help-hidden

Author: szelethus Date: Wed May 1 12:56:47 2019 New Revision: 359720 URL: http://llvm.org/viewvc/llvm-project?rev=359720&view=rev Log: [analyzer] Don't display implementation checkers under -analyzer-checker-help, but do under the new flag -analyzer-checker-help-hidden During my work on analyze

[PATCH] D60925: [analyzer] Don't display implementation checkers under -analyzer-checker-help, but do under the new flag -analyzer-checker-help-hidden

This revision was automatically updated to reflect the committed changes. Closed by commit rL359720: [analyzer] Don't display implementation checkers under -analyzer-checker-help… (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Change

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

rsmith added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:9361 // Only consider converting constructors. -if (GD->isExplicit()) +if (!GD->isMaybeNotExplicit()) continue; Tyker wrote: > rsmith wrote: > > Tyker wrote:

[PATCH] D59744: Fix i386 ABI "__m64" type bug

rnk added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:919 /// IsX86_MMXType - Return true if this is an MMX type. bool IsX86_MMXType(llvm::Type *IRType) { - // Return true if the type is an MMX type <2 x i32>, <4 x i16>, or <8 x i8>. wxiao3 wrote:

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

hliao created this revision. hliao added reviewers: tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - For template arguments ending with `>>>`, we should cease lookahead and treat it as type-id firstly, so that deduction could work properly. Repository: rG

r359722 - Make clang/utils/creduce-clang-crash.py executable

Author: rnk Date: Wed May 1 13:15:39 2019 New Revision: 359722 URL: http://llvm.org/viewvc/llvm-project?rev=359722&view=rev Log: Make clang/utils/creduce-clang-crash.py executable Modified: cfe/trunk/utils/creduce-clang-crash.py (props changed) Propchange: cfe/trunk/utils/creduce-clang-cr

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee added a comment. In D61239#1486634 , @aaron.ballman wrote: > LGTM, thank you! That's strange that clang-format would remove the newline > from the end of the file. I don't get that behavior when I try it, so it > makes me wonder what's differ

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

richard.townsend.arm added a comment. And with those modifications, everything seems to work correctly. I'd be fine with the LLVM portion landing at this stage, but one more rev and another test cycle for this patch would be ideal. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

tra added a comment. LGTM, but I've added @rsmith who is way more familiar with this code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61396/new/ https://reviews.llvm.org/D61396 ___ cfe-commits maili

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

hliao added a comment. In D61396#1486706 , @tra wrote: > LGTM, but I've added @rsmith who is way more familiar with this code. sure, no rush, let's wait for comments from @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D42642: [CUDA] Detect installation in PATH

aganea added a subscriber: rnk. aganea added a comment. So it turns out this is a symlink issue. The file `clang/trunk/test/Driver/Inputs/CUDA-symlinks/usr/bin/ptxas` has been synchronized on my Windows 10 PC as a regular text file, not a symlink. It looks like TortoiseSVN doesn't implement sym

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

gtbercea created this revision. gtbercea added reviewers: hfinkel, caomhin, ABataev, tra. Herald added subscribers: cfe-commits, guansong, mgorny. Herald added a project: clang. In this patch we propose a temporary solution to resolving math functions for the NVPTX toolchain, temporary until Open

r359727 - [analyzer] Fix buildbot failures caused by a forgotten initialization

Author: szelethus Date: Wed May 1 14:09:32 2019 New Revision: 359727 URL: http://llvm.org/viewvc/llvm-project?rev=359727&view=rev Log: [analyzer] Fix buildbot failures caused by a forgotten initialization Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h Modified: cfe/

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

gtbercea updated this revision to Diff 197638. gtbercea edited the summary of this revision. gtbercea added a comment. - Minor fixes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61399/new/ https://reviews.llvm.org/D61399 Files: lib/Driver/ToolChains/Clang.cp

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

yaxunl added a comment. LGTM too. Thanks Michael for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61396/new/ https://reviews.llvm.org/D61396 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm The only remaining change I find questionable is the R600 backend change, but on the whole I think it's fine and you don't need to wait for more review. Better to fix the warnings and people w

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

jdoerfert added a comment. For the record, this is an implementation of the scheme proposed in https://reviews.llvm.org/D60907#1484756. There are drawbacks, see the TODO, but it will give most people a short term solution until we get OpenMP 5.0 variants. Finally, there is a remote chance this

Re: [PATCH] D42642: [CUDA] Detect installation in PATH

Hi, I had my own difficulties with this. It depends on how the repository containing the symlink has been checked-out. For instance: 1. Using a windows git (such as git extensions, mingw-git, git for windows) 2. Using git inside wsl on a drvfs mount (i.e. a windows folder mounted into the Unix fi

  1   2   >