pcc added inline comments.
================ Comment at: clang/include/clang/AST/DeclCXX.h:531 + /// \brief Whether the class uses the relative C++ vtable ABI. + unsigned IsRelativeCXXABI : 1; + ---------------- rjmccall wrote: > Should we proactively generalize this as a "CXXABIVariant" enum, which for > now can just be "Standard" and "RelativeVTables"? > > Also, I don't want to pre-empt your secret plans, but if Fuchsia is just > going to use this as its system C++ ABI, maybe we should plan for that, too. At this point I probably would remove this bitfield entirely. This implementation does not support enabling the ABI on a per-class basis, so everywhere that we are currently checking this field we should just be able to check `RelativeCXXABIVTables` in `LangOptions`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58321/new/ https://reviews.llvm.org/D58321 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
