[PATCH] D48292: use modern type trait implementations when available

2019-04-24 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Herald added subscribers: libcxx-commits, miyuki, jfb, ldionne. LGTM minus nits. Comment at: include/type_traits:3683 + +#elif __has_feature(has_trivial_destructor) || (_GNUC

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

2019-04-24 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added a comment. In D56571#1476266 , @nickdesaulniers wrote: > @compudj email me the preprocessed output of basic_percpu_ops_test.c and I'll > take a look. (Should be able to find my email via `git log`). @nickdesaulniers, thanks for looking into

[PATCH] D48292: use modern type trait implementations when available

2019-04-24 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith marked an inline comment as done. rsmith added inline comments. Comment at: include/type_traits:3683 + +#elif __has_feature(has_trivial_destructor) || (_GNUC_VER >= 403) + EricWF wrote: > We don't support anything before GCC 4.9, so you can replace the GCC

r359158 - Fix typo in comment in r312851.

2019-04-24 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Apr 24 17:22:11 2019 New Revision: 359158 URL: http://llvm.org/viewvc/llvm-project?rev=359158&view=rev Log: Fix typo in comment in r312851. Thanks to Nico Weber for pointing this out! Modified: cfe/trunk/include/clang/Basic/SourceManager.h Modified: cfe/trunk/includ

Re: r312851 - Fix ownership of the MemoryBuffer in a FrontendInputFile.

2019-04-24 Thread Richard Smith via cfe-commits
On Fri, 29 Mar 2019 at 05:41, Nico Weber via cfe-commits wrote: > > > (below) > > On Fri, Sep 8, 2017 at 9:15 PM Richard Smith via cfe-commits > wrote: >> >> Author: rsmith >> Date: Fri Sep 8 18:14:04 2017 >> New Revision: 312851 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=312851&view=re

[PATCH] D61106: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive

2019-04-24 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: NoQ, dcoughlin, baloghadamsoftware, Charusso, rnkovacs, xazax.hun, gribozavr. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, jfb, mikhail.ramalho, a.sidorin, szepet, whisperity. h

[PATCH] D48292: use modern type trait implementations when available

2019-04-24 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCXX359159: Use modern type trait implementations when available. (authored by rsmith, committed by ). Changed prior to commit: https://reviews.llvm.org/D48292?vs=151761&id=196559#toc Repository: rCXX

[PATCH] D48292: use modern type trait implementations when available

2019-04-24 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. This patch is OK to land as-is. Doing the cleanup separately makes sense. Comment at: include/type_traits:3683 + +#elif __has_feature(has_trivial_destructor) || (_GNUC_VER >= 403) + rsmith wrote: > EricWF wrote: > > We don't support any

[PATCH] D61106: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive

2019-04-24 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks for the fix! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61106/new/ https://reviews.llvm.org/D61106 ___

[PATCH] D48292: use modern type trait implementations when available

2019-04-24 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith marked an inline comment as done. rsmith added inline comments. Comment at: include/type_traits:3683 + +#elif __has_feature(has_trivial_destructor) || (_GNUC_VER >= 403) + EricWF wrote: > rsmith wrote: > > EricWF wrote: > > > We don't support anything befo

[PATCH] D57435: [clang-tidy] Add abseil-wrap-unique check

2019-04-24 Thread Ryan Piantedosi via Phabricator via cfe-commits
Dosi-Dough added a comment. gentle ping Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57435/new/ https://reviews.llvm.org/D57435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

Re: r359067 - [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

2019-04-24 Thread Eric Fiselier via cfe-commits
Do I just edit the HTML file directly? Or is it generated by something? On Wed, Apr 24, 2019 at 3:35 PM Richard Smith wrote: > Thanks! Can you update cxx_status.html to mark P0595R2 as done? > > On Tue, 23 Apr 2019 at 19:21, Eric Fiselier via cfe-commits > wrote: > > > > Author: ericwf > > Date

[PATCH] D61112: AMDGPU: Enable _Float16

2019-04-24 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: b-sumner, rampitec, arsenm. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. https://reviews.llvm.org/D61112 Files: lib/Basic/Targets/AMDGPU.cpp test/CodeGenCXX/amdgpu-float16.cpp Index: test/CodeGenCX

r359164 - [PowerPC][NFC]Update licence to Apache 2

2019-04-24 Thread Jinsong Ji via cfe-commits
Author: jsji Date: Wed Apr 24 19:40:06 2019 New Revision: 359164 URL: http://llvm.org/viewvc/llvm-project?rev=359164&view=rev Log: [PowerPC][NFC]Update licence to Apache 2 Modified: cfe/trunk/lib/Headers/ppc_wrappers/mmintrin.h Modified: cfe/trunk/lib/Headers/ppc_wrappers/mmintrin.h URL: ht

[PATCH] D47358: : Implement {un,}synchronized_pool_resource.

2019-04-24 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone updated this revision to Diff 196575. Quuxplusone added a comment. Rebased on D47111 . Replaced all instances of `__release` with `__release_ptr`, to match what @EricWF did in https://github.com/llvm-mirror/libcxx/commit/8e365750a0299ee0cbef70a3f3492c

[PATCH] D61106: [analyzer][UninitializedObjectChecker] PR41590: Regard _Atomic types as primitive

2019-04-24 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr accepted this revision. gribozavr added a comment. Thanks for the fix! Comment at: test/Analysis/cxx-uninitialized-object.cpp:1145 + +void entry() { + MyAtomicInt b; `c11atomicTest()` Repository: rC Clang CHANGES SINCE LAST ACTION https://revi

[PATCH] D60974: Clang IFSO driver action.

2019-04-24 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi added a comment. In D60974#1477761 , @jakehehrlich wrote: > In D60974#1477690 , @compnerd wrote: > > > @jakehehrlich - when do you expect to have your idea put up? I don't think > > that it is fair to have

[PATCH] D60764: Add clang cc1 option to generate OpenCL builtin functions

2019-04-24 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60764/new/ https://reviews.llvm.org/D60764 ___ cfe-commits mailing lis

<    1   2