rsmith marked an inline comment as done. rsmith added inline comments.
================ Comment at: include/type_traits:3683 + +#elif __has_feature(has_trivial_destructor) || (_GNUC_VER >= 403) + ---------------- EricWF wrote: > rsmith wrote: > > EricWF wrote: > > > We don't support anything before GCC 4.9, so you can replace the GCC > > > guard with `|| defined(_LIBCPP_COMPILER_GCC)` > > Nice. I'll do this more broadly as a separate patch, if that's OK with you. > > There's lots of support for older GCCs scattered around in this file and > > elsewhere. > That sounds good to me. > > I'm happy to take over the cleanup if you want. https://reviews.llvm.org/D61107 for that :) Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48292/new/ https://reviews.llvm.org/D48292 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
