[PATCH] D60943: Delay diagnosing "n" constraint until after inlining

void created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An inline asm call may result in an immediate input value after inlining. Therefore, don't emit a diagnostic here if the input isn't an immediate. Repository: rC Clang https://reviews.llvm.org/D

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker updated this revision to Diff 195990. Tyker added a comment. @Quuxplusone @riccibruno fixed / answered feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60934/new/ https://reviews.llvm.org/D60934 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/DeclBase.h

[PATCH] D60943: Delay diagnosing "n" constraint until after inlining

void updated this revision to Diff 195992. void added a comment. Put constraint string check in the correct place. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60943/new/ https://reviews.llvm.org/D60943 Files: lib/CodeGen/CGStmt.cpp lib/Sema/SemaStmtAsm.cpp

[PATCH] D60943: Delay diagnosing "n" constraint until after inlining

void updated this revision to Diff 195994. void added a comment. Herald added a subscriber: eraman. Fix test. Use "e" instead of "n". Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60943/new/ https://reviews.llvm.org/D60943 Files: lib/CodeGen/CGStmt.cpp lib/S

[PATCH] D29707: Fix improper microsoft-pure-definition warning on template class

riccibruno accepted this revision. riccibruno added a comment. This revision is now accepted and ready to land. This looks reasonable to me (although I think that the test should be in `SemaCXX/` and not in `Parser/`, but the test for the non-template case is already in `Parser/` so ok). CHANG

r358849 - [Sema][MSVC] Fix bogus microsoft-pure-definition warning on member function of class template

Author: brunoricci Date: Sun Apr 21 06:12:10 2019 New Revision: 358849 URL: http://llvm.org/viewvc/llvm-project?rev=358849&view=rev Log: [Sema][MSVC] Fix bogus microsoft-pure-definition warning on member function of class template Clang emits a warning when using a pure specifier =0 in a functio

[PATCH] D29707: Fix improper microsoft-pure-definition warning on template class

This revision was automatically updated to reflect the committed changes. Closed by commit rL358849: [Sema][MSVC] Fix bogus microsoft-pure-definition warning on member function of… (authored by brunoricci, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

[PATCH] D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map

lebedev.ri added a comment. Abandon this? Sorry for this fruitless effort. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60778/new/ https://reviews.llvm.org/D60778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/rename_check.py:218 header_guard_variants = [ + (args.old_check_name.replace('-', '_') + '_Check').upper(), + (old_module + '_' + check_name_camel).upp

[PATCH] D50860: [libc++][test] Remove non-portable assumption that thread's constructor allocates with ::new

CaseyCarter added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50860/new/ https://reviews.llvm.org/D50860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40381: Parse concept definition

saar.raz updated this revision to Diff 196009. saar.raz added a comment. Herald added a reviewer: martong. Address CR comments by rsmith Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40381/new/ https://reviews.llvm.org/D40381 Files: include/clang/AST/ASTNodeTr

[PATCH] D50360: [Concepts] Requires Expressions

riccibruno added inline comments. Comment at: include/clang/AST/ExprCXX.h:4671 + bool IsSatisfied; + SourceLocation RequiresKWLoc; + RequiresExprBodyDecl *Body; You can stash these in the bit-field classes of `Stmt` to save some space. Comme

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

hintonda updated this revision to Diff 196011. hintonda added a comment. - Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60629/new/ https://reviews.llvm.org/D60629 Files: clang-tools-extra/clang-tidy/add_new_check.py clang-to

[PATCH] D59711: PR41183: Don't emit Wstrict-prototypes warning for an implicit function declaration.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59711/new/ https://reviews.llvm.org/D59711 ___

r358858 - Attempt to fix LLVM_ENABLE_THREADS=OFF build after r358665

Author: nico Date: Sun Apr 21 12:18:41 2019 New Revision: 358858 URL: http://llvm.org/viewvc/llvm-project?rev=358858&view=rev Log: Attempt to fix LLVM_ENABLE_THREADS=OFF build after r358665 Modified: cfe/trunk/tools/libclang/CIndex.cpp Modified: cfe/trunk/tools/libclang/CIndex.cpp URL: http

Re: r358665 - [clang][CIndex] Use llvm::set_thread_priority

r358858 might help with this. On Sat, Apr 20, 2019 at 7:15 PM Nico Weber wrote: > This breaks building with LLVM_ENABLE_THREADS=OFF. The call probably needs > to be behind a `#if LLVM_ENABLE_THREADS`. > > FAILED: bin/c-index-test > ... > lib/libclang.a(CIndex.cpp.o): In function `void llvm::func

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:2069-2072 +if (!VerifyOnly && HasDesignatedInit && SemaRef.getLangOpts().CPlusPlus2a) { + SemaRef.Diag(Init->getBeginLoc(), diag::ext_c20_designated_init)

[PATCH] D60953: [clangd] Respect clang-tidy suppression comments

nridge created this revision. nridge added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. This partially fixes https://bugs.llvm.org/show_bug.cgi?id=41218. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D59756: [clangd] Support dependent bases in type hierarchy

nridge added a comment. Ping - could this be committed please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59756/new/ https://reviews.llvm.org/D59756 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D59407: [clangd] Add RelationSlab

nridge added a comment. Hi, any update here? I would appreciate some guidance so I can move forward with this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59407/new/ https://reviews.llvm.org/D59407

[PATCH] D60954: [clangd] Test case demonstrating variable template issue

nridge created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. This is not meant to be committed, it's meant to demonstrate an issue with using RecursiveASTVisitor with TestTU on code that contains a

[PATCH] D60954: [clangd] Test case demonstrating variable template issue

nridge added a comment. Please see further details in this clangd-dev post . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60954/new/ https://reviews.llvm.org/D60954 ___

[PATCH] D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator (bogus use of LookupResult::getAsSingle)

riccibruno created this revision. riccibruno added reviewers: aaron.ballman, rnk, rsmith. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Currently the lookup for a declaration conflicting with an enumerator is pretty broken, because of the use of `LookupResult::getAsSi

[PATCH] D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup

riccibruno added a comment. @Quuxplusone Do you have other objections apart from the template-id issue ? If not, since D60573 depends on this patch, I would like to commit this with a comment explaining the issue instead of the FIXME. Repository: rC Clang

[PATCH] D60523: [clang] Don't segfault on incorrect using directive (PR41400)

riccibruno added a reviewer: riccibruno. riccibruno added a comment. I will take a look at this tomorrow, I know that it is annoying to get no feedback! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60523/new/ https://reviews.llvm.org/D60523 _

[PATCH] D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup

Quuxplusone added a comment. > @Quuxplusone Do you have other objections apart from the template-id issue ? > If not, since D60573 depends on this patch, > I would like to commit this with a comment explaining the issue instead of > the FIXME. Sure, go for it!

[PATCH] D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup

riccibruno accepted this revision. riccibruno added a comment. This revision is now accepted and ready to land. In D60570#1473873 , @Quuxplusone wrote: > > @Quuxplusone Do you have other objections apart from the template-id issue > > ? If not, since D605

[PATCH] D60943: Delay diagnosing "n" constraint until after inlining

void added a comment. This relies upon D60943 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60943/new/ https://reviews.llvm.org/D60943 ___ cfe-commits mailing list cfe-commits@lists

[clang-tools-extra] r358866 - [clangd] Support dependent bases in type hierarchy

Author: maskray Date: Sun Apr 21 18:38:53 2019 New Revision: 358866 URL: http://llvm.org/viewvc/llvm-project?rev=358866&view=rev Log: [clangd] Support dependent bases in type hierarchy Patch by Nathan Ridge! Dependent bases are handled heuristically, by replacing them with the class template tha

[PATCH] D59756: [clangd] Support dependent bases in type hierarchy

This revision was automatically updated to reflect the committed changes. Closed by commit rL358866: [clangd] Support dependent bases in type hierarchy (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D59756: [clangd] Support dependent bases in type hierarchy

nridge added a comment. Thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59756/new/ https://reviews.llvm.org/D59756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l