r358745 - [LibTooling] Fix -Wsign-compare after r358697

Author: bjope Date: Fri Apr 19 02:10:42 2019 New Revision: 358745 URL: http://llvm.org/viewvc/llvm-project?rev=358745&view=rev Log: [LibTooling] Fix -Wsign-compare after r358697 Modified: cfe/trunk/unittests/Tooling/TransformerTest.cpp Modified: cfe/trunk/unittests/Tooling/TransformerTest.cp

r358750 - [analyzer] Fix an assertion failure if plugins added dependencies

Author: szelethus Date: Fri Apr 19 04:01:35 2019 New Revision: 358750 URL: http://llvm.org/viewvc/llvm-project?rev=358750&view=rev Log: [analyzer] Fix an assertion failure if plugins added dependencies Ideally, there is no reason behind not being able to depend on checkers that come from a differ

[PATCH] D59461: [analyzer] Fix an assertion failure if plugins added dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit rC358750: [analyzer] Fix an assertion failure if plugins added dependencies (authored by Szelethus, committed by ). Changed prior to commit: https://reviews.llvm.org/D59461?vs=190976&id=195869#toc Reposi

[PATCH] D60516: [LTO] Add plumbing to save stats during LTO on Darwin.

fhahn marked 2 inline comments as done. fhahn added a comment. In D60516#1470518 , @tejohnson wrote: > LGTM with a minor fix needed below. > > Darwin still uses the old LTO API, which is why the lto Config based handling > in the new LTO API (LTO.h/LTO.cp

r358752 - [analyzer][NFC] Reimplement checker options

Author: szelethus Date: Fri Apr 19 05:32:10 2019 New Revision: 358752 URL: http://llvm.org/viewvc/llvm-project?rev=358752&view=rev Log: [analyzer][NFC] Reimplement checker options TL;DR: * Add checker and package options to the TableGen files * Added a new class called CmdLineOption, and both Pa

[PATCH] D57855: [analyzer][NFC] Reimplement checker options

This revision was automatically updated to reflect the committed changes. Closed by commit rC358752: [analyzer][NFC] Reimplement checker options (authored by Szelethus, committed by ). Changed prior to commit: https://reviews.llvm.org/D57855?vs=190977&id=195872#toc Repository: rC Clang CHAN

r358753 - [LTO] Add plumbing to save stats during LTO on Darwin.

Author: fhahn Date: Fri Apr 19 05:36:41 2019 New Revision: 358753 URL: http://llvm.org/viewvc/llvm-project?rev=358753&view=rev Log: [LTO] Add plumbing to save stats during LTO on Darwin. Gold and ld on Linux already support saving stats, but the infrastructure is missing on Darwin. Unfortunately

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Anastasia added a comment. > SYCL is similar to OpenMP 5 for C++, where you use only C++ classes instead > of #pragma. So it is quite C++-friendlier than OpenMP. I am not sure what you mean by friendlier? OpenMP concept is very clear to be - a program written in C/C++ or Fortran can be complime

[PATCH] D60516: [LTO] Add plumbing to save stats during LTO on Darwin.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358753: [LTO] Add plumbing to save stats during LTO on Darwin. (authored by fhahn, committed by ). Changed prior to commit: https://reviews.llvm.org/D60516?vs=194524&id=195873#toc Repository: rL LLVM

[PATCH] D58573: [analyzer] Move UninitializedObjectChecker out of alpha

Szelethus added a comment. Gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58573/new/ https://reviews.llvm.org/D58573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

r358756 - Add support of the next Ubuntu (Ubuntu 19.10 - Eoan EANIMAL)

Author: sylvestre Date: Fri Apr 19 06:43:28 2019 New Revision: 358756 URL: http://llvm.org/viewvc/llvm-project?rev=358756&view=rev Log: Add support of the next Ubuntu (Ubuntu 19.10 - Eoan EANIMAL) Modified: cfe/trunk/include/clang/Driver/Distro.h cfe/trunk/lib/Driver/Distro.cpp Modified

r358757 - Add support of the future Debian (Debian 11 - Bullseye)

Author: sylvestre Date: Fri Apr 19 06:46:58 2019 New Revision: 358757 URL: http://llvm.org/viewvc/llvm-project?rev=358757&view=rev Log: Add support of the future Debian (Debian 11 - Bullseye) https://wiki.debian.org/DebianBullseye Modified: cfe/trunk/include/clang/Driver/Distro.h cfe/tru

r358758 - Debian: Add two missing version code in sid

Author: sylvestre Date: Fri Apr 19 06:48:52 2019 New Revision: 358758 URL: http://llvm.org/viewvc/llvm-project?rev=358758&view=rev Log: Debian: Add two missing version code in sid Modified: cfe/trunk/lib/Driver/Distro.cpp Modified: cfe/trunk/lib/Driver/Distro.cpp URL: http://llvm.org/viewvc

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon added a comment. I tried to reuse OpenCL kernel attribute with "__kernel" keyword in our current SYCL implementation. PR with this try is here - https://github.com/intel/llvm/pull/97 Now It looks feasible but with a couple notes: From SYCL specification "SYCL is designed to be as clos

[PATCH] D58573: [analyzer] Move UninitializedObjectChecker out of alpha

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ouch, forgot to accept it. Here you go! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58573/new/ https://reviews.llvm.org/D58573 ___ cfe-commi

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang updated this revision to Diff 195877. akhuang added a comment. whitespace fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60800/new/ https://reviews.llvm.org/D60800 Files: clang/lib/CodeGen/CGDebugInfo.cpp llvm/include/llvm/CodeGen/M

r358765 - Update to use PipelineTuningOptions. Corresponds to llvm change: D59723.

Author: asbirlea Date: Fri Apr 19 09:32:08 2019 New Revision: 358765 URL: http://llvm.org/viewvc/llvm-project?rev=358765&view=rev Log: Update to use PipelineTuningOptions. Corresponds to llvm change: D59723. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp Modified: cfe/trunk/lib/CodeGen/Back

r358766 - [OPENMP][NVPTX] target [teams distribute] simd maybe run without

Author: abataev Date: Fri Apr 19 09:48:38 2019 New Revision: 358766 URL: http://llvm.org/viewvc/llvm-project?rev=358766&view=rev Log: [OPENMP][NVPTX] target [teams distribute] simd maybe run without runtime. target [teams distribute] simd costructs do not require full runtime for the correct exec

[PATCH] D60848: [Parser] Avoid correcting delayed typos in array subscript multiple times.

erik.pilkington added a comment. Wait, why is NumTypos incorrect here? I think its because we don't handle the typo on the line: `[self undeclaredMethod:undeclaredArg];`, even the following asserts now. Seems like the right fix would be to track down why we aren't handling the typo in the messa

[PATCH] D60748: Fix i386 struct and union parameter alignment

rnk added a comment. This is, obviously, an ABI break. I think Sony would probably want you to preserve the existing behavior of intentionally underaligning such byval parameters for PS4 targets. +@rjmccall in case he has other ABI thoughts. Comment at: lib/CodeGen/TargetInfo

[PATCH] D60748: Fix i386 struct and union parameter alignment

rjmccall added a subscriber: dexonsmith. rjmccall added a comment. I suspect Darwin also doesn't want to take this. We care very little about 32-bit Intel, and part of caring very little is not wanting to spend any effort dealing with the ramifications of ABI breaks. That would apply both to t

[PATCH] D60907: [OpenMP][WIP] Add math functions support in OpenMP offloading

gtbercea created this revision. gtbercea added reviewers: ABataev, hfinkel, caomhin. Herald added subscribers: cfe-commits, jdoerfert, guansong, mgorny. Herald added a project: clang. gtbercea added a reviewer: tra. gtbercea added parent revisions: D60906: [OpenMP][libomptarget][WIP] Add math func

[PATCH] D60748: Fix i386 struct and union parameter alignment

dexonsmith added a comment. In D60748#1472829 , @rjmccall wrote: > I suspect Darwin also doesn't want to take this. We care very little about > 32-bit Intel, and part of caring very little is not wanting to spend any > effort dealing with the ramificati

[PATCH] D60907: [OpenMP][WIP] Add math functions support in OpenMP offloading

ABataev added inline comments. Comment at: lib/Headers/__clang_openmp_math.h:14 +double __kmpc_pow(double, double); +double __kmpc_sin(double); + Also, versions for float and long double Comment at: lib/Headers/__clang_openmp_math.h:21 +// Defi

[PATCH] D60907: [OpenMP][WIP] Add math functions support in OpenMP offloading

ABataev added inline comments. Comment at: lib/Headers/__clang_openmp_math.h:2 + +#ifndef __CLANG_OMP_CMATH_H__ +#define __CLANG_OMP_CMATH_H__ Why `__CLANG_OMP_CMATH_H__`? Your file is `..._math.h`, not `..._cmath.h`. Plus, seems to me, you're missing standard h

[PATCH] D60094: [MSVC] If unable to find link.exe from a MSVC installation, look for link.exe next to cl.exe

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60094/new/ https://reviews.llvm.org/D60094 ___ cfe-commits mailing list cfe-commits@lists.l

r358775 - Enable frame pointer elimination for OpenBSD on powerpc.

Author: brad Date: Fri Apr 19 11:41:40 2019 New Revision: 358775 URL: http://llvm.org/viewvc/llvm-project?rev=358775&view=rev Log: Enable frame pointer elimination for OpenBSD on powerpc. Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp cfe/trunk/test/Driver/frame-pointer-elim.c Modif

[PATCH] D60910: [WIP] Dumping the AST to JSON

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, riccibruno, steveire, dblaikie. Herald added a subscriber: mgorny. This is a work in progress patch that adds the ability to specify an AST dump format on the command line. By default, we continue to dump the AST with its

[PATCH] D60912: MS ABI: handle inline static data member as template static data member

jyu2 created this revision. jyu2 added reviewers: rnk, majnemer, erichkeane, cfe-commits. Herald added a project: clang. MS only run time problem with inline static data member. A inline static data member’s init function gets called multiple time. To fix this, using template static data members

r358778 - [MSVC] If unable to find link.exe from a MSVC installation, look for link.exe next to cl.exe

Author: mstorsjo Date: Fri Apr 19 12:04:22 2019 New Revision: 358778 URL: http://llvm.org/viewvc/llvm-project?rev=358778&view=rev Log: [MSVC] If unable to find link.exe from a MSVC installation, look for link.exe next to cl.exe Previously, if the MSVC installation isn't detected properly, clang

[PATCH] D60094: [MSVC] If unable to find link.exe from a MSVC installation, look for link.exe next to cl.exe

This revision was automatically updated to reflect the committed changes. Closed by commit rC358778: [MSVC] If unable to find link.exe from a MSVC installation, look for link.exe… (authored by mstorsjo, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D60912: MS ABI: handle inline static data member as template static data member

rnk added a comment. Thanks, I think there's another case to handle, though. Comment at: lib/CodeGen/CGDeclCXX.cpp:471-473 + (getTarget().getCXXABI().isMicrosoft() && + D->isInlineSpecified() && D->isStaticDataMember() && + getLangOpts().CP

[PATCH] D60912: MS ABI: handle inline static data member as template static data member

rnk added a comment. In D60912#1472986 , @jyu2 wrote: > inline static int aoo = foo(); // C++17 inline variable, thus also a > definition This is a `static inline` global variable, so it technically creates two different globals, so calling foo twice i

[PATCH] D60912: MS ABI: handle inline static data member as template static data member

jyu2 added a comment. In D60912#1472983 , @rnk wrote: > Thanks, I think there's another case to handle, though. Hi Reid, Thank you so much for the review. Yes, I check the following test case, both gnu and cl call foo twice. Do we want to do different

r358781 - Reapply "[analyzer] Introduce a simplified API for adding custom path notes."

Author: dergachev Date: Fri Apr 19 13:23:29 2019 New Revision: 358781 URL: http://llvm.org/viewvc/llvm-project?rev=358781&view=rev Log: Reapply "[analyzer] Introduce a simplified API for adding custom path notes." This reapplies commit r357323, fixing memory leak found by LSan. Differential Revi

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358781: Reapply "[analyzer] Introduce a simplified API for adding custom path notes." (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D60907: [OpenMP][WIP] Add math functions support in OpenMP offloading

jdoerfert added inline comments. Comment at: include/clang/Driver/ToolChain.h:575 + /// Add arguments to use system-specific CUDA includes. + virtual void AddMathDeviceFunctions(const llvm::opt::ArgList &DriverArgs, Copy & Past comment Comm

[PATCH] D60907: [OpenMP][WIP] Add math functions support in OpenMP offloading

jdoerfert added a comment. To follow up on my comment why this is NVPTX specific: Is there a reason why this has to happen in the Cuda ToolChain part? I would have assumed us to add the declarations similar to the ones provided in `__clang_openmp_math.h` whenever we may compile for a target. So,

[PATCH] D60912: MS ABI: handle inline static data member as template static data member

jyu2 added a comment. In D60912#1472987 , @rnk wrote: > In D60912#1472986 , @jyu2 wrote: > > > inline static int aoo = foo(); // C++17 inline variable, thus also a > > definition > > > This is a `static inline` glo

[PATCH] D60920: [ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`, and `isInstanceMethod`

mwyman created this revision. mwyman added reviewers: benhamilton, klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. isClassMessage is an equivalent to isInstanceMessage for ObjCMessageExpr, but matches message expressions to classes. isClassMethod and isInstanceMeth

r358783 - [MS] Emit S_HEAPALLOCSITE debug info

Author: akhuang Date: Fri Apr 19 14:09:11 2019 New Revision: 358783 URL: http://llvm.org/viewvc/llvm-project?rev=358783&view=rev Log: [MS] Emit S_HEAPALLOCSITE debug info Summary: This emits labels around heapallocsite calls and S_HEAPALLOCSITE debug info in codeview. Currently only changes FastI

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

This revision was automatically updated to reflect the committed changes. Closed by commit rL358783: [MS] Emit S_HEAPALLOCSITE debug info (authored by akhuang, committed by ). Changed prior to commit: https://reviews.llvm.org/D60800?vs=195877&id=195909#toc Repository: rL LLVM CHANGES SINCE

[PATCH] D60920: [ASTMatchers] Introduce Objective-C matchers `isClassMessage`, `isClassMethod`, and `isInstanceMethod`

benhamilton accepted this revision. benhamilton added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60920/new/ https://reviews.llvm.org/D60920 ___ cfe

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a comment. Ping^2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus added a comment. Ping^2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/new/ https://reviews.llvm.org/D57860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60907: [OpenMP][WIP] Add math functions support in OpenMP offloading

gtbercea updated this revision to Diff 195915. gtbercea edited the summary of this revision. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60907/new/ https://reviews.llvm.org/D60907 Files: include/clang/Driver/Tool

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

phosek added a comment. In D59168#1472152 , @jdenny wrote: > In D59168#1470578 , @phosek wrote: > > > In D59168#1469186 , @jdenny wrote: > > > > > > > > > > > I was also thin

[PATCH] D59711: PR41183: Don't emit Wstrict-prototypes warning for an implicit function declaration.

jyknight added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59711/new/ https://reviews.llvm.org/D59711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D60892: Modules: Search for a visible definition of the decl context when computing visibility of a default template parameter

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, with a possible optimization. Thank you! I know this bug was incredibly hard to track down. =) Comment at: lib/Sema/SemaLookup.cpp:1551 + TemplateParameterLis

[PATCH] D60925: [analyzer] Don't display implementation checkers under -analyzer-checker-help, but do under the new flag -analyzer-checker-help-hidden

Szelethus created this revision. Szelethus added reviewers: NoQ, dcoughlin, baloghadamsoftware, Charusso, xazax.hun, rnkovacs. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, jfb, mikhail.ramalho, a.sidorin, JDevlieghere, szepet, whisperity.

[PATCH] D60872: Add new warning knob for unknown attribute namespaces

rsmith added a comment. Hmm. So there are a few different situations where we might meet an unknown attribute (I'm sure I missed some): 1. The attribute had a typo in it (eg: [[clagn::fallthrough]]). 2. The attribute has semantic effects (ignoring it is incorrect and will -- at best -- not comp

r358795 - Modules: Search for a visible definition of the decl context when computing visibility of a default template parameter

Author: dblaikie Date: Fri Apr 19 16:02:30 2019 New Revision: 358795 URL: http://llvm.org/viewvc/llvm-project?rev=358795&view=rev Log: Modules: Search for a visible definition of the decl context when computing visibility of a default template parameter The code is/was already correct for the ca

[PATCH] D60892: Modules: Search for a visible definition of the decl context when computing visibility of a default template parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rL358795: Modules: Search for a visible definition of the decl context when computing… (authored by dblaikie, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

r358796 - Modules: Adopt template parameters for variable templates to set their decl context correctly

Author: dblaikie Date: Fri Apr 19 16:04:05 2019 New Revision: 358796 URL: http://llvm.org/viewvc/llvm-project?rev=358796&view=rev Log: Modules: Adopt template parameters for variable templates to set their decl context correctly Exposed by a related bug about visibility of default arguments of n

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny added a comment. In D59712#1469392 , @lebedev.ri wrote: > Does this pass `check-all`? `check-all` of stage-2? test-suite? For me, all these tests behave with the current patch. As before, the only subproject I did not build was llgo. Repositor

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

mgrang updated this revision to Diff 195932. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349 Files: include/clang/CodeGen/CGFunctionInfo.h lib/CodeGen/CGCall.cpp lib/CodeGen/MicrosoftCXXABI.cpp lib/Sema/SemaDeclCXX.cpp test/CodeGen/arm64

[PATCH] D60926: [CMake] Replace the sanitizer support in runtimes build with multilib

phosek updated this revision to Diff 195934. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60926/new/ https://reviews.llvm.org/D60926 Files: clang/cmake/caches/Fuchsia-stage2.cmake llvm/runtimes/CMakeLists.txt Index: llvm/runtimes/CMakeLists.txt =

[PATCH] D60926: [CMake] Replace the sanitizer support in runtimes build with multilib

phosek created this revision. phosek added reviewers: beanz, smeenai. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. phosek updated this revision to Diff 195934. This is a more generic solution; while the sanitizer support can be used only for sani

r358797 - [analyzer] Move UninitializedObjectChecker out of alpha

Author: szelethus Date: Fri Apr 19 16:33:50 2019 New Revision: 358797 URL: http://llvm.org/viewvc/llvm-project?rev=358797&view=rev Log: [analyzer] Move UninitializedObjectChecker out of alpha Moved UninitializedObjectChecker from the 'alpha.cplusplus' to the 'optin.cplusplus' package. Differenti

[PATCH] D58573: [analyzer] Move UninitializedObjectChecker out of alpha

This revision was automatically updated to reflect the committed changes. Closed by commit rC358797: [analyzer] Move UninitializedObjectChecker out of alpha (authored by Szelethus, committed by ). Changed prior to commit: https://reviews.llvm.org/D58573?vs=194667&id=195937#toc Repository: rC

Re: r358724 - Add header guard to Reusables.h [NFC]

Whoops, thanks! On 4/18/19 5:42 PM, Ali Tamur via cfe-commits wrote: Author: tamur Date: Thu Apr 18 17:42:54 2019 New Revision: 358724 URL: http://llvm.org/viewvc/llvm-project?rev=358724&view=rev Log: Add header guard to Reusables.h [NFC] Modified: cfe/trunk/unittests/StaticAnalyzer/Reusa

[PATCH] D60930: [codeview] Fix symbol names for dynamic initializers and atexit stubs

rnk created this revision. rnk added reviewers: rsmith, rjmccall, jyu2. Herald added a subscriber: aprantl. Herald added a project: clang. Add a new variant to GlobalDecl for these so that we can detect them more easily during debug info emission and handle them appropriately. Repository: rG L

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. In D59712#1473223 , @jdenny wrote: > In D59712#1469392 , @lebedev.ri > wrote: > > > Does this pass `check-al

[PATCH] D60900: [ObjC][ARC] Check the basic block size before calling DominatorTree::dominate

ahatanak updated this revision to Diff 195951. ahatanak added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix the comment on why we have to check the size of the basic block before calling DominatorTree::dominate to compute the dominance relation between two

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyknight added a comment. There shouldn't be an empty string ("") in the asm output -- that should be a reference to the "l_yes" label, not the empty string. That seems very weird... Even odder: running clang -S on the above without -fno-integrated-as emits a ".quad .Ltmp00" (note the extra "0"

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

liutianle added a comment. hi ymandel, When I run "check-all", there are some warning/error in TransformerTest.cpp as follow. My version is llvm:0ee120077 and clang:d87ee8e678. Could you please have a fix or guild me how to fix it? ---

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

lebedev.ri added a comment. The `APSInt.h` itself looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59712/new/ https://reviews.llvm.org/D59712 ___ cfe-commits mailing list cfe-commits@lis