rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land.
LGTM, with a possible optimization. Thank you! I know this bug was incredibly hard to track down. =) ================ Comment at: lib/Sema/SemaLookup.cpp:1551 + TemplateParameterList *TPL = TD->getTemplateParameters(); + SearchDefinitions = llvm::find(*TPL, D) == TPL->end(); + } ---------------- You can avoid the linear search with: ``` SearchDefinitions = D->getIndex() >= TPL->size() || TPL->getParam(D->getIndex()) != D; ``` Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60892/new/ https://reviews.llvm.org/D60892 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
