[libclc] r356011 - mad: Convert to standard ternary header

Author: jvesely Date: Wed Mar 13 00:05:53 2019 New Revision: 356011 URL: http://llvm.org/viewvc/llvm-project?rev=356011&view=rev Log: mad: Convert to standard ternary header Reviewer: Aaron Watry Signed-off-by: Jan Vesely Removed: libclc/trunk/generic/include/clc/math/mad.inc Modified:

[libclc] r356013 - ceil: Remove llvm intrinsic from the header.

Author: jvesely Date: Wed Mar 13 00:05:58 2019 New Revision: 356013 URL: http://llvm.org/viewvc/llvm-project?rev=356013&view=rev Log: ceil: Remove llvm intrinsic from the header. Reviewer: Aaron Watry Signed-off-by: Jan Vesely Added: libclc/trunk/generic/lib/math/ceil.cl Modified: libcl

[libclc] r356012 - sqrt: Split function generation to a shared inc file.

Author: jvesely Date: Wed Mar 13 00:05:56 2019 New Revision: 356012 URL: http://llvm.org/viewvc/llvm-project?rev=356012&view=rev Log: sqrt: Split function generation to a shared inc file. This will be reused by other unary functions. Reviewer: Aaron Watry Signed-off-by: Jan Vesely Added: li

[libclc] r356017 - round: Remove llvm intrinsic from the header

Author: jvesely Date: Wed Mar 13 00:06:08 2019 New Revision: 356017 URL: http://llvm.org/viewvc/llvm-project?rev=356017&view=rev Log: round: Remove llvm intrinsic from the header Reviewer: Aaron Watry Signed-off-by: Jan Vesely Added: libclc/trunk/generic/lib/math/round.cl - copied, ch

[libclc] r356014 - fabs: Remove llvm intrinsic from the header.

Author: jvesely Date: Wed Mar 13 00:06:00 2019 New Revision: 356014 URL: http://llvm.org/viewvc/llvm-project?rev=356014&view=rev Log: fabs: Remove llvm intrinsic from the header. Reviewer: Aaron Watry Signed-off-by: Jan Vesely Added: libclc/trunk/generic/lib/math/fabs.cl Modified: libcl

[libclc] r356019 - Move ternary_intrinsic.h to private headers.

Author: jvesely Date: Wed Mar 13 00:06:13 2019 New Revision: 356019 URL: http://llvm.org/viewvc/llvm-project?rev=356019&view=rev Log: Move ternary_intrinsic.h to private headers. Reviewer: Aaron Watry Signed-off-by: Jan Vesely Added: libclc/trunk/generic/include/math/ternary_intrin.inc

[libclc] r356015 - floor: Remove llvm isntrinsic from the header.

Author: jvesely Date: Wed Mar 13 00:06:03 2019 New Revision: 356015 URL: http://llvm.org/viewvc/llvm-project?rev=356015&view=rev Log: floor: Remove llvm isntrinsic from the header. Reviewer: Aaron Watry Signed-off-by: Jan Vesely Added: libclc/trunk/generic/lib/math/floor.cl Modified: li

[libclc] r356016 - rint: Remove llvm intrinsic from the header.

Author: jvesely Date: Wed Mar 13 00:06:06 2019 New Revision: 356016 URL: http://llvm.org/viewvc/llvm-project?rev=356016&view=rev Log: rint: Remove llvm intrinsic from the header. Reviewer: Aaron Watry Signed-off-by: Jan Vesely Added: libclc/trunk/generic/lib/math/rint.cl Modified: libcl

[libclc] r356018 - trunc: Remove llvm intrinsic from the header.

Author: jvesely Date: Wed Mar 13 00:06:10 2019 New Revision: 356018 URL: http://llvm.org/viewvc/llvm-project?rev=356018&view=rev Log: trunc: Remove llvm intrinsic from the header. Reviewer: Aaron Watry Signed-off-by: Jan Vesely Added: libclc/trunk/generic/lib/math/trunc.cl - copied, c

[libclc] r356021 - Move unary_instrinsic.inc to private headers.

Author: jvesely Date: Wed Mar 13 00:06:19 2019 New Revision: 356021 URL: http://llvm.org/viewvc/llvm-project?rev=356021&view=rev Log: Move unary_instrinsic.inc to private headers. Reviewer: Aaron Watry Signed-off-by: Jan Vesely Added: libclc/trunk/generic/include/math/unary_intrin.inc

[libclc] r356020 - Move binary_intrinsic.h to private headers.

Author: jvesely Date: Wed Mar 13 00:06:15 2019 New Revision: 356020 URL: http://llvm.org/viewvc/llvm-project?rev=356020&view=rev Log: Move binary_intrinsic.h to private headers. Reviewer: Aaron Watry Signed-off-by: Jan Vesely Added: libclc/trunk/generic/include/math/binary_intrin.inc

[libclc] r356022 - hypot: Use binary_decl_tt.inc instead of custom inc file

Author: jvesely Date: Wed Mar 13 00:13:22 2019 New Revision: 356022 URL: http://llvm.org/viewvc/llvm-project?rev=356022&view=rev Log: hypot: Use binary_decl_tt.inc instead of custom inc file Reviewer: Aaron Watry Signed-off-by: Jan Vesely Removed: libclc/trunk/generic/include/clc/math/hypot

[libclc] r356026 - nextafter: Use binary_decl_tt.inc instead of custom inc file.

Author: jvesely Date: Wed Mar 13 00:13:30 2019 New Revision: 356026 URL: http://llvm.org/viewvc/llvm-project?rev=356026&view=rev Log: nextafter: Use binary_decl_tt.inc instead of custom inc file. Reviewer: Aaron Watry Signed-off-by: Jan Vesely Removed: libclc/trunk/generic/include/clc/math/

[libclc] r356025 - copysign: Use binary_decl_tt.inc instead of custom inc file.

Author: jvesely Date: Wed Mar 13 00:13:28 2019 New Revision: 356025 URL: http://llvm.org/viewvc/llvm-project?rev=356025&view=rev Log: copysign: Use binary_decl_tt.inc instead of custom inc file. Reviewer: Aaron Watry Signed-off-by: Jan Vesely Removed: libclc/trunk/generic/include/clc/math/c

[libclc] r356027 - fdim: Use binary_decl_tt.inc instead of custom inc file.

Author: jvesely Date: Wed Mar 13 00:13:32 2019 New Revision: 356027 URL: http://llvm.org/viewvc/llvm-project?rev=356027&view=rev Log: fdim: Use binary_decl_tt.inc instead of custom inc file. Reviewer: Aaron Watry Signed-off-by: Jan Vesely Removed: libclc/trunk/generic/include/clc/math/fdim.

[libclc] r356023 - atan2: Use binary_decl_tt.inc instead of custom inc file.

Author: jvesely Date: Wed Mar 13 00:13:24 2019 New Revision: 356023 URL: http://llvm.org/viewvc/llvm-project?rev=356023&view=rev Log: atan2: Use binary_decl_tt.inc instead of custom inc file. Reviewer: Aaron Watry Signed-off-by: Jan Vesely Removed: libclc/trunk/generic/include/clc/math/atan

[libclc] r356024 - atan2pi: Use binary_decl_tt.inc instead of custom inc file.

Author: jvesely Date: Wed Mar 13 00:13:26 2019 New Revision: 356024 URL: http://llvm.org/viewvc/llvm-project?rev=356024&view=rev Log: atan2pi: Use binary_decl_tt.inc instead of custom inc file. Reviewer: Aaron Watry Signed-off-by: Jan Vesely Removed: libclc/trunk/generic/include/clc/math/at

[libclc] r356028 - sincos: Simplify declaration headers.

Author: jvesely Date: Wed Mar 13 00:13:34 2019 New Revision: 356028 URL: http://llvm.org/viewvc/llvm-project?rev=356028&view=rev Log: sincos: Simplify declaration headers. This follows the same pattern as modf and fract. Reviewer: Aaron Watry Signed-off-by: Jan Vesely Modified: libclc/trunk

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

phosek marked an inline comment as done. phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:563 + crtend = Args.hasArg(options::OPT_shared) || IsPIE || IsStaticPIE ? + "crtend_shared" : "crtend"; + CmdArgs.push_back(ToolCh

[PATCH] D33841: [clang-tidy] redundant keyword check

koldaniel updated this revision to Diff 190377. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33841/new/ https://reviews.llvm.org/D33841 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/RedundantExternCheck.cpp c

[clang-tools-extra] r356029 - [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

Author: paulhoad Date: Wed Mar 13 01:07:46 2019 New Revision: 356029 URL: http://llvm.org/viewvc/llvm-project?rev=356029&view=rev Log: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present Summary: Addressing: PR25010 - https://bugs.llvm.org/s

r356029 - [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

Author: paulhoad Date: Wed Mar 13 01:07:46 2019 New Revision: 356029 URL: http://llvm.org/viewvc/llvm-project?rev=356029&view=rev Log: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present Summary: Addressing: PR25010 - https://bugs.llvm.org/s

[PATCH] D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

This revision was automatically updated to reflect the committed changes. Closed by commit rL356029: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an… (authored by paulhoad, committed by ). Herald added a reviewer: serge-sans-paille. Herald added a project: LLVM. Her

r356030 - Revert "[clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present"

Author: paulhoad Date: Wed Mar 13 01:15:03 2019 New Revision: 356030 URL: http://llvm.org/viewvc/llvm-project?rev=356030&view=rev Log: Revert "[clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present" This reverts commit b358cbb9b78389e20f7be36e1

[clang-tools-extra] r356030 - Revert "[clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present"

Author: paulhoad Date: Wed Mar 13 01:15:03 2019 New Revision: 356030 URL: http://llvm.org/viewvc/llvm-project?rev=356030&view=rev Log: Revert "[clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present" This reverts commit b358cbb9b78389e20f7be36e1

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

kadircet added a comment. In D56370#1427075 , @nridge wrote: > Ok, I filed a Theia issue > about it for now. Thanks! In D56370#1427076 , @nridge wrote: > Are the

r356031 - [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

Author: paulhoad Date: Wed Mar 13 01:26:39 2019 New Revision: 356031 URL: http://llvm.org/viewvc/llvm-project?rev=356031&view=rev Log: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present Summary: Addressing: PR25010 - https://bugs.llvm.org/s

[PATCH] D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

This revision was automatically updated to reflect the committed changes. Closed by commit rL356031: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an… (authored by paulhoad, committed by ). Changed prior to commit: https://reviews.llvm.org/D59087?vs=190378&id=1903

[clang-tools-extra] r356032 - [clangd] Default initialize SymInfo

Author: kadircet Date: Wed Mar 13 01:42:15 2019 New Revision: 356032 URL: http://llvm.org/viewvc/llvm-project?rev=356032&view=rev Log: [clangd] Default initialize SymInfo Modified: clang-tools-extra/trunk/clangd/index/Symbol.h Modified: clang-tools-extra/trunk/clangd/index/Symbol.h URL: htt

Re: r356031 - [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

This was reviewed by someone already familiar with, and active with the code in question? On Wed, Mar 13, 2019 at 11:25 AM Paul Hoad via cfe-commits wrote: > > Author: paulhoad > Date: Wed Mar 13 01:26:39 2019 > New Revision: 356031 > > URL: http://llvm.org/viewvc/llvm-project?rev=356031&view=rev

[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

kadircet updated this revision to Diff 190382. kadircet marked an inline comment as done. kadircet added a comment. - Agree on ilya-biryukov@'s suggestion, changing fuzzyfind to skip template (partial) specializations for now. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION ht

[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

kadircet added a comment. In D59083#1426105 , @ilya-biryukov wrote: > To split this into multiple independent changes, we could start with storing > the symbols for template specializations, but only showing the primary > template in the results of work

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

ioeric added a comment. just a few drive-by comments ;) Comment at: clang-tools-extra/clangd/FindSymbols.h:28 +// https://github.com/Microsoft/language-server-protocol/issues/344 +SymbolKind indexSymbolKindToSymbolKind(index::SymbolKind Kind); + This could prob

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

ilya-biryukov added a comment. A few small NITs Comment at: clang-tools-extra/clangd/ClangdServer.h:188 + /// Get information about type hierarchy for a given position. + void findTypeHierarchy(PathRef File, Position Pos, int Resolve, + TypeHierarchyDi

[PATCH] D59292: [clang-format] messes up indentation when using JavaScript private fields and methods

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: djasper, klimek, JonasToth, reuk, krasimir. MyDeveloperDay added a project: clang-tools-extra. Addresses PR40999 https://bugs.llvm.org/show_bug.cgi?id=40999 Private fields and methods in javasceipt would get incorrectly indent

[PATCH] D59283: Fixed global constant/variable naming check on C++ class for ObjC++ files.

hokein added inline comments. Comment at: clang-tidy/google/GlobalVariableDeclarationCheck.cpp:82 if (const auto *Decl = Result.Nodes.getNodeAs("global_var")) { +if (Decl->isStaticDataMember()) { + return; nit: removing the `{}`, the same below. ===

[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

Szelethus requested changes to this revision. Szelethus added a reviewer: baloghadamsoftware. Szelethus added a comment. This revision now requires changes to proceed. Code is great, idea's great, so green light on my part, but maybe we should allow some folks who are more knowledgeable on AST ma

[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

Szelethus added a comment. In D59279#1427017 , @mgrang wrote: > 3. Currently, we also do not check for what happens inside the for loop. > Not all iterations may causes non-determinism. For example, counting or > summing up the elements should not be n

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

E5ten added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:563 + crtend = Args.hasArg(options::OPT_shared) || IsPIE || IsStaticPIE ? + "crtend_shared" : "crtend"; + CmdArgs.push_back(ToolChain.getCompilerRTArgString( --

r356047 - [AST] Improve support of external layouts in `MicrosoftRecordLayoutBuilder`

Author: aleksandr.urakov Date: Wed Mar 13 06:38:12 2019 New Revision: 356047 URL: http://llvm.org/viewvc/llvm-project?rev=356047&view=rev Log: [AST] Improve support of external layouts in `MicrosoftRecordLayoutBuilder` Summary: This patch fixes several small problems with external layouts support

[PATCH] D58544: [AST] Improve support of external layouts in `MicrosoftRecordLayoutBuilder`

This revision was automatically updated to reflect the committed changes. Closed by commit rL356047: [AST] Improve support of external layouts in `MicrosoftRecordLayoutBuilder` (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Ch

[PATCH] D58544: [AST] Improve support of external layouts in `MicrosoftRecordLayoutBuilder`

aleksandr.urakov added a comment. Thank you! I've added a slightly reworked test too. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58544/new/ https://reviews.llvm.org/D58544 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name.

thakis abandoned this revision. thakis added a comment. We went with https://reviews.llvm.org/D36413 instead. (Upstream issue was https://crbug.com/751225) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36238/new/ https://reviews.llvm.org/D36238 __

[PATCH] D36413: Use "foo-12345.o.tmp" instead of "foo.o-12345" as temporary file name.

thakis added a comment. Note to self, this was for https://crbug.com/751225 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36413/new/ https://reviews.llvm.org/D36413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:453 + + StringRef FileName(Loc.printToString(Loc.getManager())); + if(getHeaderFilter

[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

MaskRay created this revision. MaskRay added reviewers: juliehockett, aaron.ballman, alexfh. Herald added subscribers: cfe-commits, jsji, kbarton, nemanjai. Herald added a project: clang. -ignore specifies a list of PP callbacks to ignore. It cannot express a whitelist, which may be more useful th

r356049 - [Analyzer] Skip symbolic regions based on conjured symbols in comparison of the containers of iterators

Author: baloghadamsoftware Date: Wed Mar 13 06:55:11 2019 New Revision: 356049 URL: http://llvm.org/viewvc/llvm-project?rev=356049&view=rev Log: [Analyzer] Skip symbolic regions based on conjured symbols in comparison of the containers of iterators Checking whether two regions are the same is a

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein updated this revision to Diff 190406. hokein marked 3 inline comments as done. hokein added a comment. Rename the tool. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58345/new/ https://reviews.llvm.org/D58345 Files: clangd/StdSymbolMap.inc

[PATCH] D53754: [Analyzer] Skip symbolic regions based on conjured symbols in comparison of the containers of iterators

This revision was automatically updated to reflect the committed changes. Closed by commit rC356049: [Analyzer] Skip symbolic regions based on conjured symbols in comparison of the… (authored by baloghadamsoftware, committed by ). Changed prior to commit: https://reviews.llvm.org/D53754?vs=1712

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein added inline comments. Comment at: clangd/StdGen/StdGen.py:2 +#!/usr/bin/env python +#===- StdGen.py - ---*- python -*--===# +# ioeric wrote: > hokein wrote: > > ioeric wrote: > > > I'd avoid abbreviation in the fi

[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:454 + StringRef FileName(Loc.printToString(Loc.getManager())); + if(getHeaderFilter()->match(FileName)) + { aaron.ballman wrote: > Formatting is incorrect he

[PATCH] D59298: [RISCV] Pass -target-abi to -cc1as

rogfer01 created this revision. rogfer01 added a reviewer: asb. Herald added subscribers: cfe-commits, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar. Herald added a project: clang

[PATCH] D48357: [RISCV] Remove duplicated logic when determining the target ABI

rogfer01 added a comment. Herald added subscribers: jocewei, PkmX, rkruppe. @asb in D59298 I call `riscv::getRISCVABI` for `ClangAs`, does it make sense to make the same change for `Clang` here? Thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D59254: [RFC] Implementation of Clang randstruct

connorkuehl added a comment. In D59254#1426809 , @pcc wrote: > This needs a test under `test/CodeGen` at least. Will do, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59254/new/ https://reviews

[PATCH] D59254: [RFC] Implementation of Clang randstruct

connorkuehl added inline comments. Comment at: clang/include/clang/AST/RecordFieldReorganizer.h:54 + std::seed_seq Seq; + std::default_random_engine rng; +}; pcc wrote: > I don't think we can use `default_random_engine` for this because the > behaviour would n

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

lebedev.ri added inline comments. Comment at: include/clang/AST/StmtOpenMP.h:335 + llvm::Optional getStructuredBlockImpl() const { +return const_cast(getInnermostCapturedStmt()->getCapturedStmt()); lebedev.ri wrote: > ABataev wrote: > > lebedev.ri wrote: >

[PATCH] D59299: [libclang] Expose aligned() attribute.

emilio created this revision. emilio added reviewers: Anastasia, arphaman. Herald added a reviewer: serge-sans-paille. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is useful because otherwise there's no easy way to distinguish #pragma packed(N) from attribute(packed,

[PATCH] D59300: [clangd] Tune the fuzzy-matching algorithm

ilya-biryukov created this revision. ilya-biryukov added a reviewer: ioeric. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. It now gives less preference to prefix matches and does not penalize skipping segments. The motivation is producing better sc

[PATCH] D59300: [clangd] Tune the fuzzy-matching algorithm

ilya-biryukov added a comment. I'll collect the metrics and post them here too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59300/new/ https://reviews.llvm.org/D59300 ___ cfe-commits mailing list cfe-

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

ABataev added inline comments. Comment at: include/clang/AST/StmtOpenMP.h:335 + llvm::Optional getStructuredBlockImpl() const { +return const_cast(getInnermostCapturedStmt()->getCapturedStmt()); lebedev.ri wrote: > lebedev.ri wrote: > > ABataev wrote: > >

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis updated this revision to Diff 190418. thakis edited the summary of this revision. thakis added a comment. two features CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59223/new/ https://reviews.llvm.org/D59223 Files: clang/include/clang/Basic/Features.def clang/lib/Parse/Parse

[PATCH] D59223: Objective-C++11: Support static_assert() in @interface/@implementation ivar lists and method declarations

thakis added a comment. Seems like this wasn't convincing, so now with two separate feature flags. I went with the shorter name, since adding "interface_" isn't just longer but also misleading, since this also works in @implementation ivar blocks now. CHANGES SINCE LAST ACTION https://review

[PATCH] D59287: [X86] Only define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 in 64-bit mode.

jfb added a comment. I don't think this is quite right: CX16 is literally "I have cmpxchg16b". In clang/lib/Basic/Targets/X86.h we do: void setMaxAtomicWidth() override { if (hasFeature("cx16")) MaxAtomicInlineWidth = 128; } Your change makes it inc

[clang-tools-extra] r356055 - [clangd] Fix a typo in doc.

Author: hokein Date: Wed Mar 13 08:22:31 2019 New Revision: 356055 URL: http://llvm.org/viewvc/llvm-project?rev=356055&view=rev Log: [clangd] Fix a typo in doc. Modified: clang-tools-extra/trunk/docs/clangd/Installation.rst Modified: clang-tools-extra/trunk/docs/clangd/Installation.rst URL:

[PATCH] D59299: [libclang] Expose aligned() attribute.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59299/new/ https://reviews.llvm.org/D59299

[PATCH] D59287: [X86] Only define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 in 64-bit mode.

craig.topper added a comment. Isn’t that setMaxAtomicWidth in the x86-64 derived class? As far as preventing “cx16” from being set in 32-bit mode, we’ll need to check the behavior of CPUID in 32-bit mode or -march=native might still end up setting it. Repository: rC Clang CHANGES SINCE LAS

[PATCH] D58556: [LibTooling] Add "smart" retrieval of AST-node source to FixIt library

ilya-biryukov added a comment. Ah, had some comments and forgot to send them out before I went on vacation :-( Comment at: clang/include/clang/Tooling/FixIt.h:60 +// future to include more associated text (like comments). +CharSourceRange getSourceRangeAuto(const Stmt &S, ASTCo

[PATCH] D58556: [LibTooling] Add "smart" retrieval of AST-node source to FixIt library

ilya-biryukov added a comment. Ignore my previous comment, I'll take another look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58556/new/ https://reviews.llvm.org/D58556 ___ cfe-commits mailing list c

[PATCH] D59287: [X86] Only define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 in 64-bit mode.

jfb added a comment. In D59287#1427485 , @craig.topper wrote: > Isn’t that setMaxAtomicWidth in the x86-64 derived class? Right you are! > As far as preventing “cx16” from being set in 32-bit mode, we’ll need to > check the behavior of CPUID in 32-bit

[PATCH] D58556: [LibTooling] Add "smart" retrieval of AST-node source to FixIt library

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. `getExtendedRange` is a really good choice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58556/new/ https://reviews.llvm.or

r356060 - Add AIX Target Info

Author: jasonliu Date: Wed Mar 13 09:02:26 2019 New Revision: 356060 URL: http://llvm.org/viewvc/llvm-project?rev=356060&view=rev Log: Add AIX Target Info Summary: A first pass over platform-specific properties of the C API/ABI on AIX for both 32-bit and 64-bit modes. This is a continuation of D1

[PATCH] D59300: [clangd] Tune the fuzzy-matching algorithm

ilya-biryukov added a comment. Here are some initial measurements with the current metrics that we have. We seem to regress significantly in some cases. This is expected, since we only check the prefix matches there. @ioeric is working on including the non-prefix (more concretely, initialism ma

[PATCH] D59048: Add AIX Target Info

This revision was automatically updated to reflect the committed changes. Closed by commit rC356060: Add AIX Target Info (authored by jasonliu, committed by ). Changed prior to commit: https://reviews.llvm.org/D59048?vs=190133&id=190425#toc Repository: rC Clang CHANGES SINCE LAST ACTION h

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet created this revision. kadircet added reviewers: ioeric, ilya-biryukov. Herald added subscribers: cfe-commits, jdoerfert, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D59302 Files: clangd/ClangdServer.cpp cl

[PATCH] D59299: [libclang] Expose aligned() attribute.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356062: [libclang] Expose aligned() attribute. (authored by emilio, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

r356062 - [libclang] Expose aligned() attribute.

Author: emilio Date: Wed Mar 13 09:16:54 2019 New Revision: 356062 URL: http://llvm.org/viewvc/llvm-project?rev=356062&view=rev Log: [libclang] Expose aligned() attribute. Summary: This is useful because otherwise there's no easy way to distinguish #pragma packed(N) from attribute(packed, aligned

[PATCH] D59299: [libclang] Expose aligned() attribute.

emilio added a comment. Thank you for the review! :) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59299/new/ https://reviews.llvm.org/D59299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D59304: Fix invocation of Gold plugin with LTO after r355331

nemanjai created this revision. nemanjai added reviewers: xur, tejohnson, davidxl. Herald added subscribers: dexonsmith, steven_wu, inglorion, mehdi_amini. Herald added a project: clang. The above commit tries to access the parameter to the `-fprofile-use` option without checking whether the opti

[PATCH] D59304: Fix invocation of Gold plugin with LTO after r355331

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59304/new/ https://reviews.llvm.org/D59304 ___ cfe-comm

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

Rakete updated this revision to Diff 190435. Rakete added a comment. Rebase + friendly ping :). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36357/new/ https://reviews.llvm.org/D36357 Files: clang/include/clang/Basic/DiagnosticParseKind

[PATCH] D59304: Fix invocation of Gold plugin with LTO after r355331

nemanjai added a comment. Thanks Teresa, I'll commit this soon. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59304/new/ https://reviews.llvm.org/D59304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D59306: [NFC][clang][astdump] Some baseline tests for OpenMP

lebedev.ri created this revision. lebedev.ri added reviewers: ABataev, aaron.ballman, stephenkelly. lebedev.ri added projects: clang, OpenMP. Herald added subscribers: jdoerfert, jfb, guansong. lebedev.ri added a child revision: D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

[PATCH] D59307: Patch llvm bug 41033 concerning atomicity of statement expressions

mibintc created this revision. mibintc added reviewers: cfe-commits, erichkeane, rsmith. Herald added subscribers: jdoerfert, jfb. Herald added a project: clang. Clang considers the type of a statement expression that returns the value of an _Atomic(ty) to be atomic, and this makes the statement

[PATCH] D59307: Patch llvm bug 41033 concerning atomicity of statement expressions

jfb requested changes to this revision. jfb added a comment. This revision now requires changes to proceed. I think you also want to test C++ `std::atomic` as well as regular `volatile`. Comment at: test/Sema/atomic-expr-stmt.c:7 + //CHECK: %atomic-load = load atomic i32, i32*

[PATCH] D59287: [X86] Only define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 in 64-bit mode.

craig.topper added a comment. Most if not all of the test cases in test/CodeGen/X86/atomic128.ll fail with a fatal error if you run it in 32-bit mode with -mattr=+cx16 Looks like the backend is also bad at checking 64 bit mode. Repository: rC Clang CHANGES SINCE LAST ACTION https://revie

[PATCH] D59287: [X86] Only define __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 in 64-bit mode.

jfb added a comment. In D59287#1427654 , @craig.topper wrote: > Most if not all of the test cases in test/CodeGen/X86/atomic128.ll fail with > a fatal error if you run it in 32-bit mode with -mattr=+cx16 Looks like the > backend is also bad at checking

[PATCH] D59307: Patch llvm bug 41033 concerning atomicity of statement expressions

jfb added a comment. Thinking some more, this is really a silly gotcha in code. We should probably follow what we're about to do with wg21.link/P1152 and ban chaining. Statement expressions should therefore not be allowed to return `_Atomic`, `std::atomic`, nor

[PATCH] D59307: Patch llvm bug 41033 concerning atomicity of statement expressions

jfb added a subscriber: jwakely. jfb added a comment. From an offline discussion, I'm told that @jwakely uses this in GCC headers and expects some semantics from it? Jonathan, why?!?! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59307/new/ https://reviews.llvm.

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: djasper, klimek, JonasToth, krasimir, reuk. MyDeveloperDay added a project: clang-tools-extra. Addresses PR40696 - https://bugs.llvm.org/show_bug.cgi?id=40696 The BreakAfterReturnType didn't work if it had a single arguments wh

[PATCH] D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it

sylvestre.ledru added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. @ddunbar ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56803/new/ https://reviews.llvm.org/D56803 ___ cfe-co

[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

mgrang updated this revision to Diff 190453. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59279/new/ https://reviews.llvm.org/D59279 Files: docs/analyzer/checkers.rst include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/

r356070 - Revert "Add AIX Target Info"

Author: jasonliu Date: Wed Mar 13 10:57:23 2019 New Revision: 356070 URL: http://llvm.org/viewvc/llvm-project?rev=356070&view=rev Log: Revert "Add AIX Target Info" This reverts commit 4e192d0e1e72ce32fabf1bccc06ac31ab5385e78. The newly added test case max_align.c do not work on all platforms. or

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

jdenny accepted this revision. jdenny added a comment. In D59168#1423587 , @phosek wrote: > I'm not super enthusiastic about the duplicated triple, but the only way to > eliminate it would be to move the Clang resource directory inside of > `lib/clang/x8

[PATCH] D59048: Add AIX Target Info

jasonliu added a comment. I'm seeing some build bot failures because of the newly added test case: max_align.c. So I reverted the previous committed change. Please fix the test case and let me know so that I can help you commit again. Repository: rC Clang CHANGES SINCE LAST ACTION https:/

RE: [PATCH] D59307: Patch llvm bug 41033 concerning atomicity of statement expressions

Yes the IR looks a bit odd. I should use a simpler case with a global _Atomic int a instead of the parameter. The store is the parameter value a, if I move that to a global then it won't be as confusing. > -Original Message- > From: JF Bastien via Phabricator [mailto:revi...@reviews.llv

[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

mgrang added a comment. Also, what is the difference between these two: https://clang.llvm.org/docs/analyzer/checkers.html, https://clang-analyzer.llvm.org/available_checks.html. It seems they document similar stuff. Should we add the doc for each new checker in both of these? CHANGES SINCE L

[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

mgrang added a comment. > The obvious question, why not implement this in clang-tidy? Going forward I would like to make these non-determinism checks more precise by reasoning about what happens inside the loop, for example. I am not sure if clang-tidy has support for such deeper reasoning. I t

RE: [PATCH] D59307: Patch llvm bug 41033 concerning atomicity of statement expressions

Sorry I formatted my reply badly, there are responses inline in the previous message > -Original Message- > From: Blower, Melanie > Sent: Wednesday, March 13, 2019 2:06 PM > To: 'reviews+d59307+public+153a08d52e63c...@reviews.llvm.org' > ; cfe- > comm...@lists.llvm.org; Keane, Erich ; > r

[PATCH] D59183: [clang-tidy] Expand cases covered by the abseil-duration-unnecessary-conversion check

hwright updated this revision to Diff 190456. hwright marked 4 inline comments as done. hwright added a comment. Addressed reviewer comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59183/new/ https://reviews.llvm.org/D59183 Files: clang-tidy/abseil/DurationUnnecessaryConversion

[PATCH] D59183: [clang-tidy] Expand cases covered by the abseil-duration-unnecessary-conversion check

hwright added inline comments. Comment at: test/clang-tidy/abseil-duration-unnecessary-conversion.cpp:48 + d2 = absl::Hours(d1 / absl::Hours(1)); + // CHECK-MESSAGES: [[@LINE-1]]:8: warning: remove unnecessary absl::Duration conversions [abseil-duration-unnecessary-conversio

  1   2   3   >