jfb added a comment.

I don't think this is quite right: CX16 is literally "I have cmpxchg16b".

In clang/lib/Basic/Targets/X86.h we do:

          void setMaxAtomicWidth() override {
            if (hasFeature("cx16"))
              MaxAtomicInlineWidth = 128;
          }

Your change makes it inconsistent.

We also have `HasCX16` which should be kept consistent.

The problem seems to be that cx16 can be set for 32-bit targets.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59287/new/

https://reviews.llvm.org/D59287



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to