[PATCH] D58544: [AST] Improve support of external layouts in `MicrosoftRecordLayoutBuilder`

aleksandr.urakov added a comment. Ping! Can you take a look, please? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58544/new/ https://reviews.llvm.org/D58544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

phosek marked an inline comment as done. phosek added a comment. In D59168#1424968 , @smeenai wrote: > I don't think the duplicated triple is too huge of a deal. I think the layout > where the resource directory is moved inside the triple directory is a b

[PATCH] D56990: Bugfix for Replacement of tied operand of inline asm

xiangzhangllvm added a comment. We found may tests failed about this issue. I hope It can be committed. Thank you very much! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56990/new/ https://reviews.llvm.org/D56990 __

[PATCH] D58324: Enable esan for the cache frag support

devnexen abandoned this revision. devnexen added a comment. Esan removed Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58324/new/ https://reviews.llvm.org/D58324 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

Re: r355743 - [8.0 Regression] Fix handling of `__builtin_constant_p` inside template arguments, enumerators, case statements, and the enable_if attribute.

Merged to release_80 in r355898. On Fri, Mar 8, 2019 at 11:05 PM Eric Fiselier via cfe-commits wrote: > > Author: ericwf > Date: Fri Mar 8 14:06:48 2019 > New Revision: 355743 > > URL: http://llvm.org/viewvc/llvm-project?rev=355743&view=rev > Log: > [8.0 Regression] Fix handling of `__builtin_co

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein updated this revision to Diff 190218. hokein marked 4 inline comments as done. hokein added a comment. Herald added a reviewer: serge-sans-paille. Address review comments, rewrite the tool with python. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein added a comment. add @ioeric as a reviewer, since @sammccall is OOO. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58345/new/ https://reviews.llvm.org/D58345 ___ cfe-commits mailing list cfe-comm

[PATCH] D59183: [clang-tidy] Expand cases covered by the abseil-duration-unnecessary-conversion check

hokein added inline comments. Comment at: clang-tidy/abseil/DurationUnnecessaryConversionCheck.cpp:31 +auto factory_matcher = cxxConstructExpr(hasArgument( +0, could you add a few comment briefly describing these matchers? Comment

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

gribozavr added inline comments. Comment at: include/clang/AST/StmtOpenMP.h:266 + + /// Returns the AST statement representing OpenMP structured-block of this + /// OpenMP executable directive, "the AST node" Comment at: include/clang/AST/Stm

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

gribozavr added inline comments. Comment at: include/clang/AST/StmtOpenMP.h:269 + /// or if this is an OpenMP stand-alone directive returns `None`. + llvm::Optional getStructuredBlock() const; }; Why not `Stmt *` as a return value? Repository: rC Clang CH

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus updated this revision to Diff 190223. Szelethus marked 13 inline comments as done. Szelethus added a comment. Fixes according to reviewer comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57855/new/ https://reviews.llvm.org/D57855 Files: include/clang/Basic/Diagnostic

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus added inline comments. Comment at: include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h:156 + return FullName == Rhs.FullName; +} + baloghadamsoftware wrote: > Are we able now to distinguish checkers of the same short names but in > differe

[PATCH] D57893: [analyzer] Fix function macro crash

bruntib added a comment. I rebased the patch on the current master. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://reviews.llvm.org/D57893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D57893: [analyzer] Fix function macro crash

bruntib updated this revision to Diff 190225. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://reviews.llvm.org/D57893 Files: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plis

r355903 - [analyzer] Fix function macro crash

Author: szelethus Date: Tue Mar 12 03:03:32 2019 New Revision: 355903 URL: http://llvm.org/viewvc/llvm-project?rev=355903&view=rev Log: [analyzer] Fix function macro crash When there is a functor-like macro which is passed as parameter to another "function" macro then its parameters are not liste

[PATCH] D57893: [analyzer] Fix function macro crash

This revision was automatically updated to reflect the committed changes. Closed by commit rC355903: [analyzer] Fix function macro crash (authored by Szelethus, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://reviews.llvm.org/D5789

[PATCH] D57890: [analyzer] Fix in self assignment checker

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. Herald added subscribers: Charusso, jdoerfert, whisperity. Yup, I agree. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57890/new/ https://revie

[PATCH] D57855: [analyzer] Reimplement checker options

whisperity added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:49 + "NoDiagnoseCallsToSystemHeaders", + "", + "false"> Let's put at least a FIXME here that the documentation for t

[PATCH] D58065: [analyzer] Document the frontend library

whisperity added inline comments. Comment at: docs/analyzer/developer-docs/FrontendLibrary.rst:85 +-fuse-ld=lld \ +../llvm + george.karpenkov wrote: > Information on compiling LLVM IMO should not be here. > Also, why Sphinx? Why X86? Why LLD and not gold?

[PATCH] D57860: [analyzer] Validate checker option names and values

whisperity added inline comments. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:329 + + // Insertation was successful -- CmdLineOption's constructor will validate + // whether values received from plugins or TableGen files are correct. Insertion

[PATCH] D58573: [analyzer] Move UninitializedObject out of alpha

whisperity added a comment. In case no bug reports //against// the checker are reported on the mailing list or Bugzilla, I wholeheartedly agree with kicking the ball here. As for the package, perhaps we could go into `optin.bugprone` or `optin.conventions`? (These are new package names...) Re

[libunwind] r355910 - Creating release candidate rc5 from release_800 branch

Author: hans Date: Tue Mar 12 04:16:25 2019 New Revision: 355910 URL: http://llvm.org/viewvc/llvm-project?rev=355910&view=rev Log: Creating release candidate rc5 from release_800 branch Added: libunwind/tags/RELEASE_800/rc5/ - copied from r355909, libunwind/branches/release_80/ ___

[libclc] r355910 - Creating release candidate rc5 from release_800 branch

Author: hans Date: Tue Mar 12 04:16:25 2019 New Revision: 355910 URL: http://llvm.org/viewvc/llvm-project?rev=355910&view=rev Log: Creating release candidate rc5 from release_800 branch Added: libclc/tags/RELEASE_800/rc5/ - copied from r355909, libclc/branches/release_80/ _

r355911 - Revert "[analyzer] Fix function macro crash"

Author: szelethus Date: Tue Mar 12 04:22:30 2019 New Revision: 355911 URL: http://llvm.org/viewvc/llvm-project?rev=355911&view=rev Log: Revert "[analyzer] Fix function macro crash" Buildbot breaks when LLVm is compiled with memory sanitizer. WARNING: MemorySanitizer: use-of-uninitialized-value

[PATCH] D57464: Generalize method overloading on addr spaces to C++

Anastasia added a comment. In D57464#1421493 , @ebevhan wrote: > Any more input on this? I think not. :( But I am wondering if we could proceed for now in some general direction and then make any improvements later. Probably the biggest part of this pa

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus marked 2 inline comments as done. Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:340 + if (OptionType == "bool") { +if (SuppliedValue != "true" && SuppliedValue != "false") { + if (AnOpts.ShouldEmitErrorsOnInvalidC

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

Szelethus added a comment. Would `NoteTag`s be displayed in a dumped exploded graph? In D58367#1405185 , @NoQ wrote: > In D58367#1404722 , @Charusso wrote: > > > So with that, I would out-chain this patch from the

r355915 - [PR41007][OpenCL] Allow printf in C++ mode.

Author: stulova Date: Tue Mar 12 05:46:56 2019 New Revision: 355915 URL: http://llvm.org/viewvc/llvm-project?rev=355915&view=rev Log: [PR41007][OpenCL] Allow printf in C++ mode. As for OpenCL C, we need to allow using printf and toolchain variadic functions (prefixed by "__") in C++ mode. Differ

[PATCH] D59219: [PR41007][OpenCL] Allow printf and toolchain reserved variadic functions in C++

This revision was automatically updated to reflect the committed changes. Closed by commit rL355915: [PR41007][OpenCL] Allow printf in C++ mode. (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[PATCH] D57860: [analyzer] Validate checker option names and values

baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:325 + std::string FullOption = + (llvm::Twine() + FullName + ":" + OptionName).str(); + Is this the most efficient way to concatenate `StringRef`s? =

[PATCH] D57893: [analyzer] Fix function macro crash

Szelethus reopened this revision. Szelethus added a comment. This revision is now accepted and ready to land. Ugh. Reverted the patch. FAIL: Clang :: Analysis/plist-macros-with-expansion.cpp (720 of 14281) TEST 'Clang :: Analysis/plist-macros-with-expansion.cpp' FAILED *

[PATCH] D57893: [analyzer] Fix function macro crash

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. Let's investigate what's behind this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://reviews.llvm.org/D57893 _

[PATCH] D57860: [analyzer] Validate checker option names and values

whisperity added inline comments. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:325 + std::string FullOption = + (llvm::Twine() + FullName + ":" + OptionName).str(); + baloghadamsoftware wrote: > Is this the most efficient way to concatenate `

[PATCH] D57893: [analyzer] Fix function macro crash

Szelethus added a comment. Some bots also break but emit a different message: TEST 'Clang :: Analysis/plist-macros-with-expansion.cpp' FAILED Script: -- : 'RUN: at line 1'; /b/sanitizer-x86_64-linux-bootstrap/build/llvm_build_asan/bin/clang -c

[PATCH] D59195: [analyzer] Remove the default value arg from getChecker*Option

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. This is straightforward. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59195/new/ https://reviews.llvm.org/D59195 ___ cfe-commits mailing

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

xingxue created this revision. xingxue added reviewers: hubert.reinterpretcast, jasonliu, mclow.lists. xingxue added a project: LLVM. Herald added a reviewer: EricWF. Herald added subscribers: libcxx-commits, cfe-commits, christof. Herald added projects: clang, libc++. AIX system headers need stdi

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:332 + AnOpts.Config.insert({(Twine() + CheckerFullName + ":" + OptionName).str(), +DefaultValStr}); } `Twine(CheckerFullName) + ":" + O

[PATCH] D57860: [analyzer] Validate checker option names and values

baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:325 + std::string FullOption = + (llvm::Twine() + FullName + ":" + OptionName).str(); + whisperity wrote: > baloghadamsoftware wrote: > > Is this the most

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

ioeric added inline comments. Comment at: clangd/StdGen/StdGen.py:2 +#!/usr/bin/env python +#===- StdGen.py - ---*- python -*--===# +# I'd avoid abbreviation in the file name and the new directory name. `StdGen` sounds a

[PATCH] D59083: [clangd] Store explicit template specializations in index for code navigation purposes

ilya-biryukov added a comment. To split this into multiple independent changes, we could start with storing the symbols for template specializations, but only showing the primary template in the results of workspaceSymbols. This would enable other features (xrefs, etc), and we could re-add spec

[PATCH] D59254: [RFC] Implementation of Clang randstruct

connorkuehl created this revision. Herald added subscribers: cfe-commits, jdoerfert, mgorny. Herald added a project: clang. This patch set introduces structure field layout randomization into the Clang compiler. The Randstruct feature is a compile-time hardening technique that randomizes the fiel

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

mclow.lists requested changes to this revision. mclow.lists added a comment. This revision now requires changes to proceed. I see no tests here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59253/new/ https://reviews.llvm.org/D59253 ___

[PATCH] D59255: NOLINT support for "clang-diagnostic-*".

hokein created this revision. hokein added reviewers: alexfh, aaron.ballman. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D59255 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h test/clang-tidy/nolint

[PATCH] D59255: [clang-tidy] NOLINT support for "clang-diagnostic-*".

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59255/new/ https://reviews.llvm.org/D59255 ___ cf

[PATCH] D59254: [RFC] Implementation of Clang randstruct

connorkuehl added inline comments. Comment at: clang/lib/AST/DeclBase.cpp:1262 + // The last one in the chain should have a null next! + PrevDecl->NextInContextAndBits.setPointer(nullptr); + Apologies that this is included. I've left a comment on `clang/lib/AS

Re: [RFC 00/12] Introduce struct layout randomization feature

Thank you for the heads up! I put the patchset on Phabricator and sent the RFC out to the cfe-dev mailing list. On 3/9/19 1:59 AM, Roman Lebedev wrote: You probably want to submit this patchset to phabricator. It will get lost in mailing list. On Sat, Mar 9, 2019 at 1:38 AM Connor Kuehl via cf

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev added a comment. Ping! Should I add more FE guys to review this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58675/new/ https://reviews.llvm.org/D58675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

r355927 - [CMake] Tell libc++ that we're using compiler-rt on Apple platforms

Author: ldionne Date: Tue Mar 12 08:32:00 2019 New Revision: 355927 URL: http://llvm.org/viewvc/llvm-project?rev=355927&view=rev Log: [CMake] Tell libc++ that we're using compiler-rt on Apple platforms Reviewers: beanz, arphaman, EricWF Subscribers: dberris, mgorny, jkorous, dexonsmith, jdoerfer

[PATCH] D58921: [CMake] Tell libc++ that we're using compiler-rt on Apple platforms

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC355927: [CMake] Tell libc++ that we're using compiler-rt on Apple platforms (authored by ldionne, committed by ). Changed

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

kadircet marked an inline comment as done. kadircet added a comment. In D56370#1424177 , @nridge wrote: > Fix a (somewhat amusing) typo where I wrote '0' instead of 'O' in a > fromJSON() implementation > > (Does the fact that this didn't cause any test fa

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D58749: [index-while-building] IndexRecordHasher

gribozavr added a comment. I left some comments, but it is difficult for me to review without understanding what the requirements for this hasher are, why some information is hashed in, and some is left out, could you clarify? See detailed comments. > This implementation is covered by lit test

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

kadircet added inline comments. Comment at: clang-tools-extra/unittests/clangd/XRefsTests.cpp:1496 +TEST(FindRecordTypeAt, TypeOrVariable) { + Annotations Source(R"cpp( Sorry for not pointing this out before, but it would be great if you could move related te

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein added inline comments. Comment at: clangd/StdGen/StdGen.py:2 +#!/usr/bin/env python +#===- StdGen.py - ---*- python -*--===# +# ioeric wrote: > I'd avoid abbreviation in the file name and the new directory name. `S

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein updated this revision to Diff 190275. hokein marked 13 inline comments as done. hokein added a comment. Address review comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58345/new/ https://reviews.llvm.org/D58345 Files: clangd/StdGen/

[clang-tools-extra] r355934 - [clang-tidy] NOLINT support for "clang-diagnostic-*".

Author: hokein Date: Tue Mar 12 09:11:46 2019 New Revision: 355934 URL: http://llvm.org/viewvc/llvm-project?rev=355934&view=rev Log: [clang-tidy] NOLINT support for "clang-diagnostic-*". Reviewers: alexfh, aaron.ballman Reviewed By: alexfh Subscribers: xazax.hun, cfe-commits Tags: #clang Diff

[PATCH] D59255: [clang-tidy] NOLINT support for "clang-diagnostic-*".

This revision was automatically updated to reflect the committed changes. Closed by commit rL355934: [clang-tidy] NOLINT support for "clang-diagnostic-*". (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SIN

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

ioeric added inline comments. Comment at: clangd/StdGen/StdGen.py:2 +#!/usr/bin/env python +#===- StdGen.py - ---*- python -*--===# +# hokein wrote: > ioeric wrote: > > I'd avoid abbreviation in the file name and the new

[PATCH] D58544: [AST] Improve support of external layouts in `MicrosoftRecordLayoutBuilder`

zturner added a comment. Probably @rnk needs to look at this, i'll ping him today. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58544/new/ https://reviews.llvm.org/D58544 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

phosek created this revision. phosek added a reviewer: echristo. Herald added subscribers: cfe-commits, jdoerfert, fedor.sergeev, dberris, srhines. Herald added a project: clang. phosek edited the summary of this revision. When compiler-rt is selected as the runtime library for Linux use its crtb

[PATCH] D59118: creduce script for clang crashes

akhuang updated this revision to Diff 190285. akhuang marked 6 inline comments as done. akhuang added a comment. style edits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59118/new/ https://reviews.llvm.org/D59118 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-

[PATCH] D59219: [PR41007][OpenCL] Allow printf and toolchain reserved variadic functions in C++

bader added inline comments. Comment at: cfe/trunk/test/SemaOpenCL/extensions.cl:31 // RUN: %clang_cc1 %s -triple amdgcn-unknown-unknown -verify -pedantic -fsyntax-only -cl-std=CL2.0 -finclude-default-header -// RUN: %clang_cc1 %s -triple spir-unknown-unknown -verify -pedantic

[PATCH] D59118: creduce script for clang crashes

george.burgess.iv accepted this revision. george.burgess.iv added a comment. This revision is now accepted and ready to land. I think that addresses all of the concerns people have put forward; given rnk's comment about one more round of fixes, this LGTM. Will check this in for you shortly. Tha

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

lebedev.ri added subscribers: steveire, aaron.ballman. lebedev.ri added a comment. Thanks for taking a look, some replies. Comment at: include/clang/AST/StmtOpenMP.h:269 + /// or if this is an OpenMP stand-alone directive returns `None`. + llvm::Optional getStructuredBlock()

r355944 - Add a creduce script for clang crashes

Author: gbiv Date: Tue Mar 12 10:48:53 2019 New Revision: 355944 URL: http://llvm.org/viewvc/llvm-project?rev=355944&view=rev Log: Add a creduce script for clang crashes This CL adds a script that calls C-Reduce on an input file and given the clang crash script, which is used to generate an inter

[PATCH] D59118: creduce script for clang crashes

This revision was automatically updated to reflect the committed changes. Closed by commit rC355944: Add a creduce script for clang crashes (authored by gbiv, committed by ). Changed prior to commit: https://reviews.llvm.org/D59118?vs=190285&id=190294#toc Repository: rC Clang CHANGES SINCE

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

ABataev added inline comments. Comment at: include/clang/AST/StmtOpenMP.h:335 + llvm::Optional getStructuredBlockImpl() const { +return const_cast(getInnermostCapturedStmt()->getCapturedStmt()); lebedev.ri wrote: > ABataev wrote: > > No need to insert it i

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

gribozavr added inline comments. Comment at: include/clang/AST/StmtOpenMP.h:269 + /// or if this is an OpenMP stand-alone directive returns `None`. + llvm::Optional getStructuredBlock() const; }; lebedev.ri wrote: > gribozavr wrote: > > Why not `Stmt *` as a r

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

lebedev.ri added inline comments. Comment at: include/clang/AST/StmtOpenMP.h:335 + llvm::Optional getStructuredBlockImpl() const { +return const_cast(getInnermostCapturedStmt()->getCapturedStmt()); ABataev wrote: > lebedev.ri wrote: > > ABataev wrote: > >

r355950 - Modules: Add LangOptions::CacheGeneratedPCH

Author: dexonsmith Date: Tue Mar 12 11:38:04 2019 New Revision: 355950 URL: http://llvm.org/viewvc/llvm-project?rev=355950&view=rev Log: Modules: Add LangOptions::CacheGeneratedPCH Add an option to cache the generated PCH in the ModuleCache when emitting it. This protects clients that build PCHs

[PATCH] D59176: Modules: Add LangOptions::CacheGeneratedPCH

dexonsmith closed this revision. dexonsmith added a comment. Committed in r355950. Thanks for the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59176/new/ https://reviews.llvm.org/D59176 ___ cfe-commits mailing list cfe-commits@lis

r355952 - [OPENMP 5.0]Initial support for 'allocator' clause.

Author: abataev Date: Tue Mar 12 11:52:33 2019 New Revision: 355952 URL: http://llvm.org/viewvc/llvm-project?rev=355952&view=rev Log: [OPENMP 5.0]Initial support for 'allocator' clause. Added parsing/sema analysis/serialization/deserialization for the 'allocator' clause of the 'allocate' directiv

[PATCH] D59118: creduce script for clang crashes

arichardson added a comment. In case anyone is interested, for the CHERI fork of LLVM/Clang I added a similar script that contains additional features such as inferring the crash message (so that you get the minimal reproducer for the issue that you are trying to reduce and not some obscure par

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

lebedev.ri added inline comments. Comment at: test/AST/ast-dump-openmp-atomic.c:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fopenmp -ast-dump %s | FileCheck -strict-whitespace -implicit-check-not=openmp_structured_block %s + gribozavr wrote: > lebedev.

r355960 - [OPENMP]Allow to redefine entry for the variables definitions.

Author: abataev Date: Tue Mar 12 13:05:17 2019 New Revision: 355960 URL: http://llvm.org/viewvc/llvm-project?rev=355960&view=rev Log: [OPENMP]Allow to redefine entry for the variables definitions. If the variable was declared and marked as declare target, a new offload entry with size 0 is create

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

lebedev.ri added inline comments. Comment at: include/clang/AST/StmtOpenMP.h:335 + llvm::Optional getStructuredBlockImpl() const { +return const_cast(getInnermostCapturedStmt()->getCapturedStmt()); lebedev.ri wrote: > ABataev wrote: > > lebedev.ri wrote: >

[PATCH] D59234: [CodeGen][ObjC] Remove the leading 'l' from symbols for protocol metadata and protocol list

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Using internal linkage instead of private makes sense to me. Even if we wanted to use private linkage, it never made sense to be doing this with `\01l` instead of just setting the linkage

[PATCH] D58749: [index-while-building] IndexRecordHasher

jkorous updated this revision to Diff 190317. jkorous added a comment. Herald added a subscriber: jfb. Based on Kadir comment I refactored the code. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58749/new/ https://reviews.llvm.org/D58749 Files: clang/lib/Index

r355964 - [Remarks] Add -foptimization-record-passes to filter remark emission

Author: thegameg Date: Tue Mar 12 13:28:50 2019 New Revision: 355964 URL: http://llvm.org/viewvc/llvm-project?rev=355964&view=rev Log: [Remarks] Add -foptimization-record-passes to filter remark emission Currently we have -Rpass for filtering the remarks that are displayed as diagnostics, but whe

[PATCH] D58749: [index-while-building] IndexRecordHasher

jkorous added a comment. In D58749#1426270 , @gribozavr wrote: > I left some comments, but it is difficult for me to review without > understanding what the requirements for this hasher are, why some information > is hashed in, and some is left out, coul

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

ABataev added inline comments. Comment at: include/clang/AST/StmtOpenMP.h:335 + llvm::Optional getStructuredBlockImpl() const { +return const_cast(getInnermostCapturedStmt()->getCapturedStmt()); lebedev.ri wrote: > lebedev.ri wrote: > > ABataev wrote: > >

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

lebedev.ri added inline comments. Comment at: include/clang/AST/StmtOpenMP.h:335 + llvm::Optional getStructuredBlockImpl() const { +return const_cast(getInnermostCapturedStmt()->getCapturedStmt()); ABataev wrote: > lebedev.ri wrote: > > lebedev.ri wrote: >

[PATCH] D58749: [index-while-building] IndexRecordHasher

kadircet added a comment. > I basically didn't really like the idea of testing against hard-coded hash > values in unittests as I consider it to be an implementation detail. I was > thinking about integration tests that would work around this by both writing > index and reading index and writin

[PATCH] D58749: [index-while-building] IndexRecordHasher

gribozavr added a comment. > I basically didn't really like the idea of testing against hard-coded hash > values in unittests as I consider it to be an implementation detail. Sorry, that's not what I was suggesting. There are better ways to test hashing. For example, write a piece of source c

r355976 - Revert "[Remarks] Add -foptimization-record-passes to filter remark emission"

Author: thegameg Date: Tue Mar 12 13:54:18 2019 New Revision: 355976 URL: http://llvm.org/viewvc/llvm-project?rev=355976&view=rev Log: Revert "[Remarks] Add -foptimization-record-passes to filter remark emission" This reverts commit 20fff32b7d1f1a1bd417b22aa9f26ededd97a3e5. Modified: cfe/tru

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

gribozavr added inline comments. Comment at: test/AST/ast-dump-openmp-atomic.c:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fopenmp -ast-dump %s | FileCheck -strict-whitespace -implicit-check-not=openmp_structured_block %s + lebedev.ri wrote: > gribozav

[PATCH] D59254: [RFC] Implementation of Clang randstruct

pcc added a comment. This needs a test under `test/CodeGen` at least. Comment at: clang/include/clang/AST/RecordFieldReorganizer.h:54 + std::seed_seq Seq; + std::default_random_engine rng; +}; I don't think we can use `default_random_engine` for this because

[PATCH] D58544: [AST] Improve support of external layouts in `MicrosoftRecordLayoutBuilder`

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/AST/RecordLayoutBuilder.cpp:2750-2753 +// It is possible that there were no fields or bases located after vbptr, +// so the size was not adjusted befor

[PATCH] D58749: [index-while-building] IndexRecordHasher

jkorous updated this revision to Diff 190342. jkorous marked 2 inline comments as done. jkorous added a comment. Addressed some of Dmitri's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58749/new/ https://reviews.llvm.org/D58749 Files: clang/lib/Index/CMakeLists.txt clang

[PATCH] D58749: [index-while-building] IndexRecordHasher

jkorous marked 8 inline comments as done. jkorous added a comment. Addressed some comments, going to update the diff. Comment at: clang/lib/Index/IndexRecordHasher.cpp:291 + +hash_code IndexRecordHasher::hashImpl(const Decl *D) { + return DeclHashVisitor(*this).Visit(D); -

[PATCH] D58749: [index-while-building] IndexRecordHasher

jkorous added a comment. In D58749#1426769 , @kadircet > In D58749#1426778 , @gribozavr > I see what you mean now. That's a good idea. I'll add some unit tests. CHANGES SINCE LAST ACTION https://reviews.l

r355984 - Reland "[Remarks] Add -foptimization-record-passes to filter remark emission"

Author: thegameg Date: Tue Mar 12 14:22:27 2019 New Revision: 355984 URL: http://llvm.org/viewvc/llvm-project?rev=355984&view=rev Log: Reland "[Remarks] Add -foptimization-record-passes to filter remark emission" Currently we have -Rpass for filtering the remarks that are displayed as diagnostics

r355987 - [NFC][clang][PCH][ObjC] Add some missing `VisitStmt(S);`

Author: lebedevri Date: Tue Mar 12 14:31:00 2019 New Revision: 355987 URL: http://llvm.org/viewvc/llvm-project?rev=355987&view=rev Log: [NFC][clang][PCH][ObjC] Add some missing `VisitStmt(S);` Summary: These ObjC AST classes inherit from Stmt, but don't call `VisitStmt(S);`. Some were founded wit

[PATCH] D59197: [NFC][clang][PCH][ObjC] Add some missing `VisitStmt(S);`

This revision was automatically updated to reflect the committed changes. Closed by commit rC355987: [NFC][clang][PCH][ObjC] Add some missing `VisitStmt(S);` (authored by lebedevri, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59197/new/ https://r

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

gribozavr added a comment. Sorry for the delay. I will finish reviewing tomorrow. Comment at: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h:9 +/// \file +/// \brief Utility class for listening for file system changes in a directory. +//===

[PATCH] D36836: [clang-tidy] Implement sonarsource-function-cognitive-complexity check

lebedev.ri added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. In D36836#1021863 , @chandlerc wrote: > In D36836#931995 , @lebedev.ri wrote: > > > - Rebased > > - As advised by @aaro

r355989 - Add XCOFF triple object format type for AIX

Author: jasonliu Date: Tue Mar 12 15:01:10 2019 New Revision: 355989 URL: http://llvm.org/viewvc/llvm-project?rev=355989&view=rev Log: Add XCOFF triple object format type for AIX This patch adds an XCOFF triple object format type into LLVM. This XCOFF triple object file type will be used later by

[PATCH] D58930: Add XCOFF triple object format type for AIX

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL355989: Add XCOFF triple object format type for AIX (authored by jasonliu, committed by ). Herald added a subscriber: kris

[PATCH] D59087: [clang-format] [PR25010] AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

MyDeveloperDay updated this revision to Diff 190351. MyDeveloperDay added a comment. run git clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59087/new/ https://reviews.llvm.org/D59087 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h cla

  1   2   >