rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

Using internal linkage instead of private makes sense to me.  Even if we wanted 
to use private linkage, it never made sense to be doing this with `\01l` 
instead of just setting the linkage properly.  Maybe this was implemented 
before LLVM directly supported private linkage, but that hasn't been a 
constraint in 10+ years.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59234/new/

https://reviews.llvm.org/D59234



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to