[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

craig.topper added a comment. @rsmith, @efriedma, @chandlerc, is this in good enough shape that we can commit and move to incremental fixes/improvement? Jennifer has had to rebase this a couple times which is making things hard for the folks testing this with the Linux kernel and needing to app

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. I'm fine merging in this state... but please wait for rsmith to respond before you merge. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added a subscriber: rsmith. hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:626 + +// FIXME: Define AIX OS-Version Macros +Builder.defineMacro("_AIX"); Comments should be full senten

[PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

hubert.reinterpretcast added a comment. D59048 has been posted with some initial `OSTargetInfo` changes. Noticeable differences include not defining `_ALL_SOURCE` and focus on 64-bit long double. This is consistent with the invocation provided with the recent v

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

nickdesaulniers added a comment. > which is making things hard for the folks testing this with the Linux kernel > and needing to apply this patch themselves. If we can get inlining of callbr working first before landing this, then all of our CI won't go immediately red (as it would from landing

[PATCH] D58320: [Darwin] Introduce a new flag, -fapple-link-rtlib that forces linking of the builtins library.

ab added a comment. Please check the embedded thing (the other comments are minor). Otherwise, LGTM; if you have found this flag to be necessary, this looks like a reasonable way to implement it Comment at: clang/include/clang/Driver/Options.td:1252 +def fapple_link_rtlib :

[PATCH] D58154: Add support for -fpermissive.

rsmith abandoned this revision. rsmith added a comment. In D58154#1420565 , @aaron.ballman wrote: > If we go with a different name for the flag, then the user has to update > their build scripts to get code to compile with Clang, which means it > should

[PATCH] D58530: Add PragmaHandler for MSVC pragma execution_character_set

sigatrev updated this revision to Diff 189629. sigatrev added a comment. Added tests, and slightly improved associated messaging. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58530/new/ https://reviews.llvm.org/D58530 Files: clang-tools-extra/pp-trace/PPCallbacksTracker.cpp clang-

[PATCH] D58121: [analyzer][WIP] Attempt to fix traversing bindings of non-base regions in ClusterAnalysis

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Herald added a subscriber: Charusso. Ugh, it takes forever to debug, because it gets reduced to a true positive now, and the original unprunned report is ~1300 pieces long (the normal report being c

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

ahatanak updated this revision to Diff 189630. ahatanak added a comment. Diagnose invalid UTF-8 strings in boxed expressions. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58729/new/ https://reviews.llvm.org/D58729 Files: include/clang/AST/ExprObjC.h include

[PATCH] D53754: [Analyzer] Skip symbolic regions based on conjured symbols in comparison of the containers of iterators

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Herald added a subscriber: Charusso. In D53754#1401162 , @baloghadamsoftware wrote: > I think that here the main difference is that if we analyze this functi

[PATCH] D59048: Add AIX Target Info

apaprocki added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:626 + +// FIXME: Define AIX OS-Version Macros +Builder.defineMacro("_AIX"); hubert.reinterpretcast wrote: > Comments should be full sentences (with periods). Please updat

[PATCH] D58665: [analyzer] Handle comparison between non-default AS symbol and constant

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks again! Please commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58665/new/ https://reviews.llvm.org/D58665 ___ cfe-commits mailing

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

rjmccall added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:322 def InvalidSourceEncoding : DiagGroup<"invalid-source-encoding">; +def InvalidUTF8String : DiagGroup<"invalid-utf8-string">; def KNRPromotedParameter : DiagGroup<"knr-promoted-parameter">; -

[PATCH] D58719: [PR40778][Sema] Adjust address space of operands in builtin operators

rjmccall added a comment. Looks great, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58719/new/ https://reviews.llvm.org/D58719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

phosek updated this revision to Diff 189643. phosek marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59013/new/ https://reviews.llvm.org/D59013 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test/Driver/linux-per-t

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

smeenai added inline comments. Comment at: clang/test/Driver/linux-per-target-runtime-dir.c:13 // CHECK-PER-TARGET-RUNTIME: "-isysroot" "[[SYSROOT:[^"]+]]" // CHECK-PER-TARGET-RUNTIME: "-internal-isystem" "[[RESDIR]]/include/c++/v1" // CHECK-PER-TARGET-RUNTIME: "-internal-isys

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:626 + +// FIXME: Define AIX OS-Version Macros +Builder.defineMacro("_AIX"); apaprocki wrote: > hubert.reinterpretcast wrote: > > Comments should be full sent

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

modocache created this revision. modocache added reviewers: GorNishanov, tks2103, rsmith. Herald added subscribers: jdoerfert, EricWF. Herald added a project: clang. As reported in https://bugs.llvm.org/show_bug.cgi?id=40978, it's an error to use the `co_yield` or `co_await` keywords outside of a

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

phosek updated this revision to Diff 189654. phosek marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59013/new/ https://reviews.llvm.org/D59013 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/L

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

EricWF added inline comments. Comment at: lib/Sema/SemaCoroutine.cpp:675 + // Second emphasis of [expr.await]p2: must be outside of an exception handler. + if (S.getCurScope()->getFlags() & Scope::CatchScope) { +S.Diag(Loc, diag::err_coroutine_within_handler) << Keyword; -

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

modocache added inline comments. Comment at: lib/Sema/SemaCoroutine.cpp:675 + // Second emphasis of [expr.await]p2: must be outside of an exception handler. + if (S.getCurScope()->getFlags() & Scope::CatchScope) { +S.Diag(Loc, diag::err_coroutine_within_handler) << Keyword

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

phosek updated this revision to Diff 189656. phosek marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59013/new/ https://reviews.llvm.org/D59013 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/L

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

ahatanak updated this revision to Diff 189657. ahatanak marked 2 inline comments as done. ahatanak added a comment. Improve diagnostic message. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58729/new/ https://reviews.llvm.org/D58729 Files: include/clang/AST/Ex

<    1   2