rsmith abandoned this revision.
rsmith added a comment.

In D58154#1420565 <https://reviews.llvm.org/D58154#1420565>, @aaron.ballman 
wrote:

> If we go with a different name for the flag, then the user has to update 
> their build scripts to get code to compile with Clang, which means it 
> shouldn't be too onerous for them to spell out the specific diagnostics they 
> need disabled (and it sort of forces them into somewhat better code hygiene 
> by not disabling all diagnostics). I'm kind of leaning towards not providing 
> a flag at all.


I would certainly prefer that people explicitly list the `-Wno-whatever` flags 
they're relying on when porting to Clang. There might still be some benefit in 
`-Wno-error=everything`, but it seems questionable (as James points out, users 
who don't enjoy build spam would likely reach for `-Wno-everything` instead).

In any case, I think we have consensus that this patch is the wrong direction. 
Abandoning.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58154/new/

https://reviews.llvm.org/D58154



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to