[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous added reviewers: kadircet, gribozavr. jkorous added a comment. Adding clangd folks in case they want to take a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 ___ cfe-commits mailing li

[PATCH] D58924: Replace clang::FileData with llvm::vfs::Status

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. LGTM, although I made a small suggestion for clarity. FYI `InPCH` was used by PTH, which was removed a couple of months ago. Comment at: clang/lib/Basic/FileManag

[PATCH] D58924: Replace clang::FileData with llvm::vfs::Status

harlanhaskins marked an inline comment as done. harlanhaskins added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:305 +UFE = &UniqueRealFiles[Status.getUniqueID()]; +Status = llvm::vfs::Status( + Status.getName(), Status.getUniqueID(),

[PATCH] D58924: Replace clang::FileData with llvm::vfs::Status

benlangmuir added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:305 +UFE = &UniqueRealFiles[Status.getUniqueID()]; +Status = llvm::vfs::Status( + Status.getName(), Status.getUniqueID(), harlanhaskins wrote: > benlangmuir wrote: > > Why

[PATCH] D58924: Replace clang::FileData with llvm::vfs::Status

This revision was automatically updated to reflect the committed changes. Closed by commit rL355368: Replace clang::FileData with llvm::vfs::Status (authored by harlanhaskins, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58094/new/ https://reviews.llvm.org/D58094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute.

vsapsai added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:266 +auto *NewAttrTy = cast(T.getTypePtr()); +for (TypeAttrPair &A : AttrsForTypes) { + if (A.first == AttrTy) jkorous wrote: > Do you think it would make sense to ter

[PATCH] D58811: [clang] Fix misuses of char width to char align

amalykh added a comment. Thank you for your comments, Roman. Despite the fact, that there are no official LLVM targets that will be influenced by this patch, there are architectures which support only word addressing mode, for which the assumption of char align equals to 8 is not true. The patch

[PATCH] D58880: [WIP] [Looking for API feedback] [clangd] Type hierarchy subtypes

nridge updated this revision to Diff 189275. nridge added a comment. Add tests involving templates and template specializations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58880/new/ https://reviews.llvm.org/D58880 Files: clang-tools-extra/cla

[PATCH] D58880: [WIP] [Looking for API feedback] [clangd] Type hierarchy subtypes

nridge added a comment. In D58880#1416754 , @kadircet wrote: > Sorry I didn't notice the mailing thread beforehand, looks like Sam had a > good point regarding performing operations on types rather than > symbols(http://lists.llvm.org/pipermail/clangd-de

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

rjmccall added inline comments. Comment at: test/SemaObjC/boxing-illegal.m:70 + s = @(L"abc"); // expected-error {{illegal type 'int *' used in a boxed expression}} + s = @("\pabc"); // expected-error {{illegal type 'unsigned char *' used in a boxed expression}} +} --

[PATCH] D58878: [Diagnostics] Warn for assignments in bool contexts

rjmccall added a comment. This seems eminently reasonable to warn about. I think people might legitimately complain about extending an existing warning to a new set of contexts without putting it under a new warning flag, though. How annoying would it be to clone the warnings and put them in

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

rjmccall added a comment. In the abstract, it would be nice to warn about casts that always have UB because the address spaces don't overlap; however, I'm worried about how people might be using address spaces in strange ways today, knowing that they *do* overlap, only in ways that the compiler

[PATCH] D58811: [clang] Fix misuses of char width to char align

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. In D58811#1417959 , @amalykh wrote: > Thank you for your comments, Roman. > Despite the fact, that there are no official LLVM targets

[PATCH] D58922: [clang-format] broken after lambda with return type template with boolean literal

MyDeveloperDay added a comment. In D58922#1417605 , @jkorous wrote: > BTW I suggest you also add the original test case since the test cases you > added fail the expectation at FormatTest.cpp:74 and the message is a bit > unclear whether the testcase or

[PATCH] D58934: [clang-format] Fix lambdas returning template specialization that contains operator in parameter

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I'm not sure I personally would ever write code like that ;-) , but if its legal C++ and it compiles we should handle it the same as foo<1>,foo,foo As there are a number of re

<    1   2