lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed.
In D58811#1417959 <https://reviews.llvm.org/D58811#1417959>, @amalykh wrote: > Thank you for your comments, Roman. > Despite the fact, that there are no official LLVM targets that will be > influenced by this patch, there are architectures which support only word > addressing mode, for which the assumption of char align equals to 8 is not > true. > The patch have been tested for a proprietary architecture, where there is a > difference between align and width of char. As for the official targets, it's > more like a style improvement. Thank you for working on this! So in other words this will sadly indeed not have any test coverage in LLVM proper, correct? If so, i think you want to submit an RFC (mentioning this fact) to cfe-dev (maybe CC llvm-dev). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58811/new/ https://reviews.llvm.org/D58811 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
