[PATCH] D57878: [clangd] Use Dex for dynamic index by default.

ioeric created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Memory usage for a sample TU: Without Dex: 17.9M WithDex: 24.4M The memory increase is considerable but seems tolerable. Repository:

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

ioeric updated this revision to Diff 185718. ioeric marked 2 inline comments as done. ioeric added a comment. - Merge remote-tracking branch 'origin/master' into typo - address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57021/new/

[clang-tools-extra] r353380 - [clangd] Suggest adding missing includes for typos (like include-fixer).

Author: ioeric Date: Thu Feb 7 01:23:22 2019 New Revision: 353380 URL: http://llvm.org/viewvc/llvm-project?rev=353380&view=rev Log: [clangd] Suggest adding missing includes for typos (like include-fixer). Summary: This adds include-fixer feature into clangd based on D56903. Clangd now captures d

[PATCH] D57021: [clangd] Suggest adding missing includes for typos (like include-fixer).

This revision was automatically updated to reflect the committed changes. Closed by commit rL353380: [clangd] Suggest adding missing includes for typos (like include-fixer). (authored by ioeric, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: r

[PATCH] D57879: [clangd] Fix an assertion failure in Selection.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, kristof.beyls, javed.absar. Herald added a project: clang. The assertion is triggered when the Decl is null. I didn't have a small reproduce tes

[PATCH] D57553: [Fixed Point Arithmetic] Avoid resizing for types with the same width

ebevhan added a comment. In D57553#1381920 , @leonardchan wrote: > In regards to solving the problem of resizing for int conversions, I'm > starting to think that we will need that initial resize since if we want to > retain the min-max pattern for all c

[PATCH] D57739: [clangd] Format tweak's replacements.

hokein closed this revision. hokein added a comment. Committed in rL353306 . Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57739/new/ https://reviews.llvm.org/D57739 _

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

hokein added a comment. You'd need to rebase this patch, D57739 had some changes to the Tweak API. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56610/new/ https://reviews.llvm.org/D56610 ___

[PATCH] D57230: [analyzer] Toning down invalidation a bit

xazax.hun added a comment. In D57230#1387834 , @NoQ wrote: > There seem to be a few regressions - weird memory leaks of inner objects in > C++ destructors. Trying to investigate/reproduce. Oh, that is unfortunate. Feel free to share a repro as soon as y

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

ebevhan added inline comments. Comment at: clang/test/Frontend/fixed_point_conversions.c:437 + // DEFAULT-NEXT: [[RES:%[a-z0-9]+]] = trunc i39 [[SATMIN]] to i16 + // DEFAULT-NEXT: store i16 [[RES]], i16* %sat_sa, align 2 + leonardchan wrote: > leonardchan wrote

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

ebevhan added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3444 case BO_NE: +return Builder.CreateICmpNE(FullLHS, FullRHS); + case BO_Mul: rjmccall wrote: > leonardchan wrote: > > rjmccall wrote: > > > Are padding bits guaranteed zero o

[clang-tools-extra] r353382 - [clang-tidy] Expand and clarify the NOLINT documentation a bit.

Author: alexfh Date: Thu Feb 7 02:34:43 2019 New Revision: 353382 URL: http://llvm.org/viewvc/llvm-project?rev=353382&view=rev Log: [clang-tidy] Expand and clarify the NOLINT documentation a bit. Modified: clang-tools-extra/trunk/docs/clang-tidy/index.rst Modified: clang-tools-extra/trunk/d

[PATCH] D57852: [clang-tidy] Don't use assignment for value-initialized enums

JonasToth added a comment. How are the semantics for `enum class` in this case? Comment at: clang-tools-extra/test/clang-tidy/modernize-use-default-member-init-assignment.cpp:172 + // CHECK-FIXES: PositiveValueEnum() {} + Enum e; + // CHECK-MESSAGES: :[[@LINE-1]]:8: warnin

[PATCH] D57824: [OpenCL][PR40603] Align the use of extensions in C++ to be backwards compatible with OpenCL C v2.0

svenvh added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:1063 +auto OpenCLVersion = +LangOpts.OpenCLCPlusPlus ? 200 : LangOpts.OpenCLVersion; +#define OPENCLEXT(Ext) \ Why not

[clang-tools-extra] r353389 - [clang-tidy] Fixed a std::bind() transformation

Author: jonastoth Date: Thu Feb 7 03:00:59 2019 New Revision: 353389 URL: http://llvm.org/viewvc/llvm-project?rev=353389&view=rev Log: [clang-tidy] Fixed a std::bind() transformation There was an extra semicolon that was somehow working in some contexts. Patch by oleg.smolsky. Modified: cl

Re: [clang-tools-extra] r353327 - [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

Merged in r353391. On Wed, Feb 6, 2019 at 8:17 PM Roman Lebedev via cfe-commits wrote: > > Author: lebedevri > Date: Wed Feb 6 11:17:30 2019 > New Revision: 353327 > > URL: http://llvm.org/viewvc/llvm-project?rev=353327&view=rev > Log: > [clang-tidy] modernize-avoid-c-arrays: avoid main function

Re: [clang-tools-extra] r353327 - [clang-tidy] modernize-avoid-c-arrays: avoid main function (PR40604)

Thank you. On Thu, Feb 7, 2019 at 2:03 PM Hans Wennborg wrote: > > Merged in r353391. > > On Wed, Feb 6, 2019 at 8:17 PM Roman Lebedev via cfe-commits > wrote: > > > > Author: lebedevri > > Date: Wed Feb 6 11:17:30 2019 > > New Revision: 353327 > > > > URL: http://llvm.org/viewvc/llvm-project?r

r353393 - Typo: s/follwing/following

Author: hans Date: Thu Feb 7 03:13:28 2019 New Revision: 353393 URL: http://llvm.org/viewvc/llvm-project?rev=353393&view=rev Log: Typo: s/follwing/following Modified: cfe/trunk/include/clang/Driver/Options.td Modified: cfe/trunk/include/clang/Driver/Options.td URL: http://llvm.org/viewvc/l

[PATCH] D57824: [OpenCL][PR40603] Align the use of extensions in C++ to be backwards compatible with OpenCL C v2.0

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:1063 +auto OpenCLVersion = +LangOpts.OpenCLCPlusPlus ? 200 : LangOpts.OpenCLVersion; +#define OPENCLEXT(Ext)

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

JonasToth created this revision. JonasToth added reviewers: lebedev.ri, aaron.ballman, baloghadamsoftware, alexfh. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, a.sidorin, rnkovacs, xazax.hun. Herald added a project: clang. The analsis on the throwing behvaiour on functio

[PATCH] D57884: [clangd] Don't restart clangd in vscode extension.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. This would make the life of tracking/reporting crashes easier, and restarting clangd doesn't help as file state is usually br

[PATCH] D57884: [clangd] Don't restart clangd in vscode extension.

hokein updated this revision to Diff 185736. hokein added a comment. Fix space. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57884/new/ https://reviews.llvm.org/D57884 Files: clangd/clients/clangd-vscode/src/extension.ts Index: clangd/clients/

[PATCH] D57884: [clangd] Don't restart clangd in vscode extension.

hokein updated this revision to Diff 185737. hokein added a comment. update Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57884/new/ https://reviews.llvm.org/D57884 Files: clangd/clients/clangd-vscode/src/extension.ts Index: clangd/clients/clan

[PATCH] D57838: [clang-cl] support /Oy- on aarch64

froydnj added a comment. Thanks for the review, @mstorsjo. Would you please land this for me? I don't have commit access. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57838/new/ https://reviews.llvm.org/D57838 __

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

ebevhan added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3444 case BO_NE: +return Builder.CreateICmpNE(FullLHS, FullRHS); + case BO_Mul: ebevhan wrote: > rjmccall wrote: > > leonardchan wrote: > > > ebevhan wrote: > > > > rjmccall wro

r353402 - [clang-cl] support /Oy- on aarch64

Author: mstorsjo Date: Thu Feb 7 04:46:49 2019 New Revision: 353402 URL: http://llvm.org/viewvc/llvm-project?rev=353402&view=rev Log: [clang-cl] support /Oy- on aarch64 MSVC supports /Oy- on aarch64, so clang-cl should too. Patch by Nathan Froyd! Differential Revision: https://reviews.llvm.org

[PATCH] D57838: [clang-cl] support /Oy- on aarch64

This revision was automatically updated to reflect the committed changes. Closed by commit rC353402: [clang-cl] support /Oy- on aarch64 (authored by mstorsjo, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57838/new/ https://reviews.llvm.org/D57838

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

lebedev.ri added a comment. Exciting! Comment at: clang-tidy/utils/ExceptionAnalyzer.h:31-192 +enum class ExceptionState : std::int8_t { + Throwing,///< The function can definitly throw given an AST. + NotThrowing, ///< This function can not throw, given an AST. + Unknow

[PATCH] D57890: [analyzer] Fix in self assignment checker

bruntib created this revision. bruntib added reviewers: NoQ, george.karpenkov, Szelethus, xazax.hun, baloghadamsoftware. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet. Herald added a project: clang. For self assignment checker it was nece

[PATCH] D57852: [clang-tidy] Don't use assignment for value-initialized enums

malcolm.parsons marked an inline comment as done. malcolm.parsons added a comment. In D57852#1388526 , @JonasToth wrote: > How are the semantics for `enum class` in this case? No enumerators are present in the initialisation or the fixit, so there is no

[PATCH] D57879: [clangd] Fix an assertion failure in Selection.

ilya-biryukov added a comment. Repro: template struct Foo {}; template class /*cursor here*/U> struct Foo*> {}; I'm not sure how easy is that, but this should probably be fixed in the `RecursiveASTVisitor<>`. There's really no point in calling `TraverseDecl(null)` Repository: r

[PATCH] D57891: [analyzer] Fix infinite recursion in printing macros

bruntib created this revision. bruntib added reviewers: NoQ, george.karpenkov, Szelethus, xazax.hun. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. #define f(y) x #define x f(x) int main()

r353411 - Fix r350643 to limit COFF emission to <= 32 BYTES instead of BITS.

Author: erichkeane Date: Thu Feb 7 07:14:11 2019 New Revision: 353411 URL: http://llvm.org/viewvc/llvm-project?rev=353411&view=rev Log: Fix r350643 to limit COFF emission to <= 32 BYTES instead of BITS. The patch in r350643 incorrectly sets the COFF emission based on bits instead of bytes. This

[PATCH] D57892: [analyzer] Fix macro printer crash when macro comes from another translation unit

bruntib created this revision. bruntib added reviewers: NoQ, george.karpenkov, Szelethus, xazax.hun. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. Repository: rC Clang https://reviews.

[PATCH] D57879: [clangd] Fix an assertion failure in Selection.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. In D57879#1388789 , @ilya-biryukov wrote: > Repro: > > template > struct Foo {}; > > template class /*cursor here*/U> > struct Foo*>

[PATCH] D57878: [clangd] Use Dex for dynamic index by default.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (Just flipping the flag seems fine too) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57878/new/ https://reviews.llvm.org/D57878 ___

[PATCH] D57392: [clangd] Mention indexing in docs.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Herald added a project: clang. Sorry about delaying this. Comment at: docs/clangd.rst:156 +- Passing experimental `-background-index` commandline argument, which will

[PATCH] D57893: [analyzer] Fix function macro crash

bruntib created this revision. bruntib added reviewers: NoQ, george.karpenkov, Szelethus, xazax.hun. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. When there is a functor-like macro which

[PATCH] D57819: [clangd] Reduce number of threads used by BackgroundIndex to number of physical cores.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. NIT about a description: we can't be 100% certain that it's related to hyper-threading, so I'd avoid putting that to the description, maybe simply mention that this avoids

[clang-tools-extra] r353413 - [clangd] Use Dex for dynamic index by default.

Author: ioeric Date: Thu Feb 7 07:34:37 2019 New Revision: 353413 URL: http://llvm.org/viewvc/llvm-project?rev=353413&view=rev Log: [clangd] Use Dex for dynamic index by default. Summary: Memory usage for a sample TU: Without Dex: 17.9M WithDex: 24.4M The memory increase is considerable

[PATCH] D57878: [clangd] Use Dex for dynamic index by default.

ioeric updated this revision to Diff 185762. ioeric added a comment. - Keep the option for now. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57878/new/ https://reviews.llvm.org/D57878 Files: clangd/tool/ClangdMain.cpp Index: clangd/tool/Clangd

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

JonasToth marked 2 inline comments as done. JonasToth added inline comments. Comment at: clang-tidy/utils/ExceptionAnalyzer.h:31-192 +enum class ExceptionState : std::int8_t { + Throwing,///< The function can definitly throw given an AST. + NotThrowing, ///< This function c

[PATCH] D57878: [clangd] Use Dex for dynamic index by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE353413: [clangd] Use Dex for dynamic index by default. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D57878?vs=185762&id=185763#toc Repository: rCTE Clang T

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth added a comment. Herald added a project: clang. ping Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54395/new/ https://reviews.llvm.org/D54395 ___ cfe-commits mailing list cfe-commits@lists.llv

[libunwind] r353414 - Creating release candidate rc2 from release_800 branch

Author: hans Date: Thu Feb 7 07:36:17 2019 New Revision: 353414 URL: http://llvm.org/viewvc/llvm-project?rev=353414&view=rev Log: Creating release candidate rc2 from release_800 branch Added: libunwind/tags/RELEASE_800/rc2/ - copied from r353413, libunwind/branches/release_80/ ___

[libclc] r353414 - Creating release candidate rc2 from release_800 branch

Author: hans Date: Thu Feb 7 07:36:17 2019 New Revision: 353414 URL: http://llvm.org/viewvc/llvm-project?rev=353414&view=rev Log: Creating release candidate rc2 from release_800 branch Added: libclc/tags/RELEASE_800/rc2/ - copied from r353413, libclc/branches/release_80/ _

[clang-tools-extra] r353415 - [ELF] Format lines inadvertently indented by rCTE353380

Author: maskray Date: Thu Feb 7 07:38:14 2019 New Revision: 353415 URL: http://llvm.org/viewvc/llvm-project?rev=353415&view=rev Log: [ELF] Format lines inadvertently indented by rCTE353380 Modified: clang-tools-extra/trunk/clangd/SourceCode.h Modified: clang-tools-extra/trunk/clangd/SourceC

[PATCH] D57896: Variable names rule

michaelplatings created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Following discussion and general agreement that the current naming rule for variables is not ideal, this patch switc

[PATCH] D57879: [clangd] Fix an assertion failure in Selection.

hokein updated this revision to Diff 185770. hokein added a comment. Add reproduce testcase. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57879/new/ https://reviews.llvm.org/D57879 Files: clangd/Selection.cpp unittests/clangd/SelectionTests.cp

[PATCH] D57879: [clangd] Fix an assertion failure in Selection.

hokein updated this revision to Diff 185771. hokein added a comment. Remove an unexpected change. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57879/new/ https://reviews.llvm.org/D57879 Files: clangd/Selection.cpp unittests/clangd/SelectionTes

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

ilya-biryukov updated this revision to Diff 185772. ilya-biryukov added a comment. - Move the string to CIndexer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57532/new/ https://reviews.llvm.org/D57532 Files: clang/test/Index/record-completion-

[clang-tools-extra] r353421 - [clangd] Fix an assertion failure in Selection.

Author: hokein Date: Thu Feb 7 08:00:44 2019 New Revision: 353421 URL: http://llvm.org/viewvc/llvm-project?rev=353421&view=rev Log: [clangd] Fix an assertion failure in Selection. Summary: The assertion is triggered when the Decl is null. Details for the assertion: F0207 09:55:09.069385 4730

[PATCH] D57879: [clangd] Fix an assertion failure in Selection.

This revision was automatically updated to reflect the committed changes. Closed by commit rL353421: [clangd] Fix an assertion failure in Selection. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAS

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

ilya-biryukov updated this revision to Diff 185775. ilya-biryukov added a comment. - Simplify code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57532/new/ https://reviews.llvm.org/D57532 Files: clang/test/Index/record-completion-invocation.c

[clang-tools-extra] r353422 - [clangd] Reduce number of threads used by BackgroundIndex to number of physical cores.

Author: kadircet Date: Thu Feb 7 08:04:30 2019 New Revision: 353422 URL: http://llvm.org/viewvc/llvm-project?rev=353422&view=rev Log: [clangd] Reduce number of threads used by BackgroundIndex to number of physical cores. Summary: clangd is using as many threads as logical cores for BackgroundIn

[PATCH] D57819: [clangd] Reduce number of threads used by BackgroundIndex to number of physical cores.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE353422: [clangd] Reduce number of threads used by BackgroundIndex to number of physical… (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D57819?vs=185549&id=18

[PATCH] D57824: [OpenCL][PR40603] In C++ preserve backwards compatibility with OpenCL C v2.0

Anastasia updated this revision to Diff 185774. Anastasia retitled this revision from "[OpenCL][PR40603] Align the use of extensions in C++ to be backwards compatible with OpenCL C v2.0" to "[OpenCL][PR40603] In C++ preserve backwards compatibility with OpenCL C v2.0". Anastasia edited the summar

[PATCH] D57893: [analyzer] Fix function macro crash

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Cheers! Let's wait for a couple days for feedback, and I'll commit on your behalf after that. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ h

[PATCH] D57891: [analyzer] Fix infinite recursion in printing macros

Szelethus added a comment. Is there a chance of obtaining a testcase for this? I would very strongly prefer one. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57891/new/ https://reviews.llvm.org/D57891 ___ cfe-commi

[PATCH] D57392: [clangd] Mention indexing in docs.

kadircet updated this revision to Diff 185777. kadircet marked 2 inline comments as done. kadircet added a comment. Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57392/new/ https://reviews.llvm.org/D57392 Files: docs/clangd.rst

[PATCH] D57892: [analyzer] Fix macro printer crash when macro comes from another translation unit

Szelethus accepted this revision. Szelethus added a reviewer: martong. Szelethus added a comment. This revision is now accepted and ready to land. Yup, cheers! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57892/new/ https://reviews.llvm.org/D57892 ___

[PATCH] D57893: [analyzer] Fix function macro crash

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. Actually, reproducing this with a testcase would be much preferred here too. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57893/new/ https://r

[clang-tools-extra] r353423 - [clangd] Mention indexing in docs.

Author: kadircet Date: Thu Feb 7 08:10:39 2019 New Revision: 353423 URL: http://llvm.org/viewvc/llvm-project?rev=353423&view=rev Log: [clangd] Mention indexing in docs. Reviewers: sammccall Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, cfe-commits Differential Revision: https

[PATCH] D57392: [clangd] Mention indexing in docs.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE353423: [clangd] Mention indexing in docs. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D57392?vs=185777&id=185781#toc Repository: rCTE Clang Tools Extra

[PATCH] D57824: [OpenCL][PR40603] In C++ preserve backwards compatibility with OpenCL C v2.0

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. Even nicer to have it only inside the extension logic indeed. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57824/new/ https://reviews.llvm.org/D57824 __

[PATCH] D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language

rupprecht added a comment. In D56943#1388314 , @kristina wrote: > The patch itself looks sound. However given that you have a specific use case > in mind (TableGen files) could you provide supplementary coverage for that > specific use case (unit tests f

[PATCH] D57322: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way

This revision was automatically updated to reflect the committed changes. Closed by commit rC353425: [ASTImporter] Refactor unittests to be able to parameterize them in a more… (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D57322?vs=184694&id=185786#toc

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3444 case BO_NE: +return Builder.CreateICmpNE(FullLHS, FullRHS); + case BO_Mul: ebevhan wrote: > ebevhan wrote: > > rjmccall wrote: > > > leonardchan wrote: > > > > ebevhan wro

r353425 - [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way

Author: martong Date: Thu Feb 7 08:52:48 2019 New Revision: 353425 URL: http://llvm.org/viewvc/llvm-project?rev=353425&view=rev Log: [ASTImporter] Refactor unittests to be able to parameterize them in a more flexible way Summary: Currently `TestImportBase` is derived from `ParameterizedTestsFix

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

rupprecht updated this revision to Diff 185787. rupprecht added a comment. Herald added a subscriber: arphaman. Herald added a project: clang. - Rebased w/ D56943 patched in so we can override just TableGen in getLLVMStyle() Repository: rG LLVM Github Monorep

[PATCH] D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language

rupprecht added a comment. In D56943#1388985 , @rupprecht wrote: > In D56943#1388314 , @kristina wrote: > > > The patch itself looks sound. However given that you have a specific use > > case in mind (TableGen file

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

rjmccall added a comment. In D57768#1386862 , @Anastasia wrote: > - SYCL seem to require adding tight dependencies from the standard libraries > into the compiler because many language features are hidden behind library > classes. This is not common for

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

lebedev.ri added inline comments. Comment at: clang-tidy/utils/ExceptionAnalyzer.h:31-192 +enum class ExceptionState : std::int8_t { + Throwing,///< The function can definitly throw given an AST. + NotThrowing, ///< This function can not throw, given an AST. + Unknown,

[PATCH] D57901: [ASTImporter] Add test RedeclChainShouldBeCorrectAmongstNamespaces

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. We add a new test to show that redecl chains are not handled properly amongst

[PATCH] D57896: Variable names rule

lebedev.ri added a comment. Pretty sure this patch should have gone to llvm-commits, not cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57896/new/ https://reviews.llvm.org/D57896 ___ cfe-co

[PATCH] D57896: Variable names rule

michaelplatings added a comment. In D57896#1389042 , @lebedev.ri wrote: > Pretty sure this patch should have gone to llvm-commits, not cfe-commits. I just set the repository, Phabricator did the rest - apparently the magic isn't working so well. Repos

[PATCH] D57902: [AST] Fix structural inequivalence of operators

martong created this revision. martong added reviewers: shafik, a_sidorin, aaron.ballman. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a project: clang. Operators kind was not checked, so we reported e.g. op- to be equal with op+ Repository: rC Cl

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 marked an inline comment as done. jyu2 added inline comments. Comment at: lib/AST/Stmt.cpp:628 + DiagOffs = CurPtr-StrStart-1; + return diag::err_asm_invalid_operand_for_goto_labels; +} rsmith wrote: > jyu2 wrote: > > rsmith wrote:

r353431 - [OpenCL][PR40603] In C++ preserve compatibility with OpenCL C v2.0

Author: stulova Date: Thu Feb 7 09:32:37 2019 New Revision: 353431 URL: http://llvm.org/viewvc/llvm-project?rev=353431&view=rev Log: [OpenCL][PR40603] In C++ preserve compatibility with OpenCL C v2.0 Valid OpenCL C code should still compile in C++ mode. This change enables extensions and OpenCL

[PATCH] D57824: [OpenCL][PR40603] In C++ preserve backwards compatibility with OpenCL C v2.0

This revision was automatically updated to reflect the committed changes. Closed by commit rL353431: [OpenCL][PR40603] In C++ preserve compatibility with OpenCL C v2.0 (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D57896: Variable names rule

lebedev.ri added a comment. In D57896#1389046 , @michaelplatings wrote: > In D57896#1389042 , @lebedev.ri > wrote: > > > Pretty sure this patch should have gone to llvm-commits, not cfe-commits. > > > I just set t

[PATCH] D57905: [ASTImporter][ASTImporterSpecificLookup] Add test for different operators

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. This is to check that operators are handled properly in `ASTImporterSpecificL

[PATCH] D54978: Move the SMT API to LLVM

brzycki added a comment. This commit is causing a build-break for our nightly cross compilers of arm and aarch64. The immediately preceding commit of D54977 does not break with the exact same invocation. The problem is our build machine (Ubuntu 18.04 LTS) insta

[PATCH] D57906: [CTU] Do not allow different CPP dialects in CTU

martong created this revision. martong added reviewers: xazax.hun, a_sidorin, r.stahl. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a project: clang. If CPP dialects are different then return with error. Consider this STL code: template struct

[PATCH] D57896: Variable names rule

probinson added a comment. Herald added a project: LLVM. In D57896#1389067 , @lebedev.ri wrote: > 2. It might be best to give this more visibility, by submitting a mail to > llvm-dev, with a **noticeable** subject, like "RFC: changing variable naming > r

[PATCH] D57908: [SEMA]Generalize deferred diagnostic interface, NFC.

ABataev created this revision. ABataev added reviewers: rjmccall, tra. Herald added a project: clang. Deferred diagnostic interface is going to be used for OpenMP device compilation. Generalized previously existed deferred diagnostic interface for CUDA to be used with OpenMP and, possibly, other m

[PATCH] D57910: [ASTImporter] Find previous friend function template

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D57910 Files: lib/AST/AST

[PATCH] D54978: Move the SMT API to LLVM

shakeel.mahate added a comment. The ninja build also fails ninja -C out/gn ninja: Entering directory `out/gn' [1/3182] ACTION //clang/test:lit_site_cfg(//llvm/utils/gn/build/toolchain:unix) FAILED: gen/clang/test/lit.site.cfg.py python ../../llvm/utils/gn/build/write_cmake_config.py -o gen/clan

[PATCH] D55659: [Sema][ObjC] Disallow non-trivial C struct fields in unions

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Two minor tweaks, but otherwise LGTM. Comment at: lib/AST/Type.cpp:2273 +const RecordDecl *RD = QT->castAs()->getDecl(); +// C++ classes are ignored. +if (isa

[PATCH] D57874: [WebAssembly] Set '-matomics' when '-pthread' is set

dschuff added a comment. So this CL has the effect that setting `-pthreads` will also set `-matomics`. Currently as you mentioned we have the problem that we can't make our current logic of "do we lower away the atomics" be controlled by the target features because it's done at pass config time

[PATCH] D57874: [WebAssembly] Set '-matomics' when '-pthread' is set

dschuff added a comment. Oh I guess another option would just be to pin all 3 flags together here, but since `-pthread` sets a preprocessor define and may also affect linker behavior, I think it's fine to allow atomic codegen without setting `-pthread`. Repository: rC Clang CHANGES SINCE LA

[PATCH] D54978: Move the SMT API to LLVM

george.karpenkov added a comment. @mikhail.ramalho could you revert then? In general, we should not use Z3 unless it's explicitly requested. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54978/new/ https://reviews.llvm.org/D54978 __

[PATCH] D57908: [SEMA]Generalize deferred diagnostic interface, NFC.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. I've added jlebar@ as he's originally written the code. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57908/new/ https://reviews.llvm.org/D57908 ___

[PATCH] D57829: [HIP] Disable emitting llvm.linker.options in device compilation

rjmccall added a comment. Also, why is this HIP-specific? I thought the toolchain was largely shared with CUDA and there were just a few runtime differences. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57829/new/ https://reviews.llvm.org/D57829 ___

[PATCH] D57915: [COFF, ARM64] Remove definitions for _byteswap library functions

TomTan created this revision. TomTan added reviewers: mgrang, efriedma, mstorsjo. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. _byteswap_* functions are are implemented in below file as normal function from libucrt.lib and declared in stdlib.h.

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau created this revision. pgousseau added reviewers: rsmith, probinson, gbedwell, filcab, lebedev.ri, wristow. Herald added subscribers: cfe-commits, cryptoad. Herald added a project: clang. enum SanitizerOrdinal has reached maximum capacity, this change extends the capacity to 128 saniti

[PATCH] D57874: [WebAssembly] Set '-matomics' when '-pthread' is set

sbc100 added a comment. Yes it makes sense to me to set `-mthread-model=posix` when `-pthread` is passed on the commandline. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874 _

[PATCH] D57874: [WebAssembly] Set '-matomics' when '-pthread' is set

sunfish added a comment. That sounds reasonable to me too. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D43737: Improve -Winfinite-recursion

steven_wu added a comment. Herald added a project: LLVM. Sorry for following up late on the patch. Removing the reachability testing for the exit block causes false positive for infinite loop cases like this: void l() { static int count = 5; if (count >0) { count--; l();

[PATCH] D57918: Add an attribute that causes clang to emit fortified calls to C stdlib functions

erik.pilkington created this revision. erik.pilkington added reviewers: aaron.ballman, rjmccall, eli.friedman. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. This attribute applies to declarations of C stdlib functions (sprintf, memcpy...) that have known fortified

  1   2   >