[PATCH] D53541: [COFF, ARM64] Do not emit x86_seh_recoverfp intrinsic

mgrang abandoned this revision. mgrang added a comment. I have added a default lowering for llvm.eh.recoverfp in D53540 . So this patch is no longer needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53541/new/ https://reviews.llvm.org/D53541

r351371 - [Fixed Point Arithmetic] Fixed Point Subtraction

Author: leonardchan Date: Wed Jan 16 11:53:50 2019 New Revision: 351371 URL: http://llvm.org/viewvc/llvm-project?rev=351371&view=rev Log: [Fixed Point Arithmetic] Fixed Point Subtraction This patch covers subtraction between fixed point types and other fixed point types or integers, using the con

[PATCH] D55844: [Fixed Point Arithmetic] Fixed Point Subtraction

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL351371: [Fixed Point Arithmetic] Fixed Point Subtraction (authored by leonardchan, committed by ). Herald added a subscrib

[PATCH] D56733: [OPENMP] update release note for implemented OMP 5.0 features

gtbercea added a comment. Could we add the changes in D56790 to this diff? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56733/new/ https://reviews.llvm.org/D56733 ___ cfe-commits mailing list cfe-commits@

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm updated this revision to Diff 182121. dankm added a comment. Move trailing path separator stripping back to Clang. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 Files: include/clang/Basic/DiagnosticDriverKinds.t

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

rjmccall added inline comments. Comment at: lib/Parse/ParseDecl.cpp:6170 + } +} + } Does this not need to diagnose redundant qualifiers? Why is this path required in addition to the path in SemaType, anyway? Comment at:

[PATCH] D56802: [CodeGenObjC] Treat ivar offsets variables as constant if they refer to ivars of a direct subclass of NSObject with an @implementation

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, pete, ahatanak. Herald added subscribers: dexonsmith, jkorous. This patch was originally written by Pete Cooper. This is possible because the size of NSObject is effectively ABI, and will not change in the future.

[PATCH] D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: ddunbar. It has been introduced in 2011 for gcc compat: https://github.com/llvm-mirror/clang/commit/95a907fc0f2f717dca38a379c1d2353bfea06d4f it is probably time to remove it to remove the confusion. Repository: rC Clang

[PATCH] D56802: [CodeGenObjC] Treat ivar offsets variables as constant if they refer to ivars of a direct subclass of NSObject with an @implementation

rjmccall added a comment. We've tossed around the idea of doing things like this before, but I was hoping that it wouldn't have to be specific to `NSObject` and that we'd e.g. have an attribute that guarantees that the `@interface` declares all the ivars for a class. Are we still thinking that

[PATCH] D56802: [CodeGenObjC] Treat ivar offsets variables as constant if they refer to ivars of a direct subclass of NSObject with an @implementation

rjmccall added a comment. Also, we should just go ahead and skip using the offset variable when emitting the ivar access in the frontend. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56802/new/ https://reviews.llvm.org/D56802

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

MyDeveloperDay added a comment. In D56424#1359227 , @karepker wrote: > In D56424#1357484 , @MyDeveloperDay > wrote: > > > In D56424#1357481 , @lebedev.ri > > wrote: > > > >

[PATCH] D56530: [X86] Add versions of the avx512 gather intrinsics that take the mask as a vXi1 vector instead of a scalar (clang side)

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56530/new/ https://reviews.llvm.org/D56530 ___ cfe-commits mailing list cfe-commits

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker added a comment. In D56424#1360318 , @MyDeveloperDay wrote: > In D56424#1359227 , @karepker wrote: > > > In D56424#1357484 , > > @MyDeveloperDay wrote: > > > > > I

[PATCH] D56632: [analyzer] Track region liveness only through base regions.

NoQ added a comment. In D56632#1359576 , @xazax.hun wrote: > If you find out the reason why we need `markElementIndicesLive`, documenting > that would also be useful. But it is also independent of this change. > Maybe something like we could learn new i

r351382 - PR40329: [adl] Fix determination of associated classes when searching a

Author: rsmith Date: Wed Jan 16 14:01:39 2019 New Revision: 351382 URL: http://llvm.org/viewvc/llvm-project?rev=351382&view=rev Log: PR40329: [adl] Fix determination of associated classes when searching a member enum and then its enclosing class. There are situations where ADL will collect a clas

r351383 - Fix libc++ mac driver test to pass on Windows

Author: rnk Date: Wed Jan 16 14:05:34 2019 New Revision: 351383 URL: http://llvm.org/viewvc/llvm-project?rev=351383&view=rev Log: Fix libc++ mac driver test to pass on Windows There is a substitution for 'clang-check' to absolutize it, so the '$(which clang-check)' is unnecessary. Modified:

[PATCH] D56811: [Mem2Reg] Enable promotion for bitcastable load/store values

sdmitriev created this revision. sdmitriev added a reviewer: andrew.w.kaylor. Herald added subscribers: cfe-commits, javed.absar. This patch enables Mem2Reg to handle loads/stores from/to bitcasted alloca values as long as the loaded/stored value is bitcastable to the allocated type (see example b

[PATCH] D56811: [Mem2Reg] Enable promotion for bitcastable load/store values

lebedev.ri added a comment. The diff does not seem to match the subject. (also, probably should go do llvm-commits) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56811/new/ https://reviews.llvm.org/D56811 ___ cfe-com

[PATCH] D56811: [Mem2Reg] Enable promotion for bitcastable load/store values

sdmitriev added a comment. This patch is a clang's part of this review https://reviews.llvm.org/D56810 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56811/new/ https://reviews.llvm.org/D56811 ___ cfe-commits mailing

Re: r350768 - [ObjC] Allow the use of implemented unavailable methods from within

Hi, We are planning to fix this issue by not checking if the method is defined. I will post a patch this week. Cheers, Alex On Fri, 11 Jan 2019 at 10:26, Alex L wrote: > Thanks, we might have similar cases in our code base as well. We'll see if > we can fix that too. > > On Fri, 11 Jan 2019 at

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

rupprecht planned changes to this revision. rupprecht added a comment. I'll refactor `getLLVMStyle()` to `getLLVMStyle(FormatStyle::LanguageKind Language)` to support this change first. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55964/new/ https://reviews.llv

[PATCH] D56766: [Frontend] Make WrapperFrontendAction call WrappedAction.PrepareToExecuteAction.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. That LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56766/new/ https://reviews.llvm.org/D56766 ___ cfe-commits mailing list cfe

r351390 - [X86] Add versions of the avx512 gather intrinsics that take the mask as a vXi1 vector instead of a scalar

Author: ctopper Date: Wed Jan 16 14:34:33 2019 New Revision: 351390 URL: http://llvm.org/viewvc/llvm-project?rev=351390&view=rev Log: [X86] Add versions of the avx512 gather intrinsics that take the mask as a vXi1 vector instead of a scalar We need to custom handle these so we can turn the scala

[PATCH] D56530: [X86] Add versions of the avx512 gather intrinsics that take the mask as a vXi1 vector instead of a scalar (clang side)

This revision was automatically updated to reflect the committed changes. Closed by commit rC351390: [X86] Add versions of the avx512 gather intrinsics that take the mask as a vXi1… (authored by ctopper, committed by ). Changed prior to commit: https://reviews.llvm.org/D56530?vs=180978&id=18215

[PATCH] D56802: [CodeGenObjC] Treat ivar offsets variables as constant if they refer to ivars of a direct subclass of NSObject with an @implementation

dexonsmith added a comment. In D56802#1360316 , @rjmccall wrote: > We've tossed around the idea of doing things like this before, but I was > hoping that it wouldn't have to be specific to `NSObject` and that we'd e.g. > have an attribute that guarantees

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

sberg added a comment. One problem I found with the macro `__cpp_impl_destroying_delete` not being conditional on language version is the following: Recent GCC trunk (since https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=76b94d4ba654e9af1882865933343d11f5c3b18b "Implement P0722R3, destroying oper

r351391 - Recommit r351160 "[X86] Make _xgetbv/_xsetbv on non-windows platforms"

Author: ctopper Date: Wed Jan 16 14:56:25 2019 New Revision: 351391 URL: http://llvm.org/viewvc/llvm-project?rev=351391&view=rev Log: Recommit r351160 "[X86] Make _xgetbv/_xsetbv on non-windows platforms" V8 has been fixed now. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def cfe/

[PATCH] D56006: [AST] Fix a -Wimplicit-fallthrough warning in ScanfFormatString.cpp

riccibruno abandoned this revision. riccibruno added a comment. Nice, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56006/new/ https://reviews.llvm.org/D56006 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D56816: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context

arphaman created this revision. arphaman added a reviewer: erik.pilkington. Herald added subscribers: cfe-commits, dexonsmith, jkorous. This patch extends r350768 and allows the use of methods marked as `unavailable` that are declared in a parent class/category from within the `@implementation`

r351393 - [analyzer] [NFC] Yet another minor cleanup of RetainCountChecker

Author: george.karpenkov Date: Wed Jan 16 15:21:15 2019 New Revision: 351393 URL: http://llvm.org/viewvc/llvm-project?rev=351393&view=rev Log: [analyzer] [NFC] Yet another minor cleanup of RetainCountChecker Differential Revision: https://reviews.llvm.org/D56744 Modified: cfe/trunk/lib/Stat

r351394 - [analyzer] Another RetainCountChecker cleanup

Author: george.karpenkov Date: Wed Jan 16 15:21:38 2019 New Revision: 351394 URL: http://llvm.org/viewvc/llvm-project?rev=351394&view=rev Log: [analyzer] Another RetainCountChecker cleanup This is not NFC strictly speaking, since it unifies CleanupAttr handling, so that out parameters now also un

[PATCH] D56759: [analyzer] Another RetainCountChecker cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit rC351394: [analyzer] Another RetainCountChecker cleanup (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D56759?vs=1

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

rsmith added a comment. @jwakely, we should come to a common understanding of the right behavior here :) (and then probably report back to SG-10). Clang unconditionally makes sized delete work if you have a suitable library type, and expects the library to decide whether it wants to provide the

[PATCH] D56786: [ASTMatchers] Changes to `CXXMemberExpr` matchers.

steveire added a comment. It seems that you update docs for existing matchers without changing those matchers. You could put all of that in one patch. Then, you seem to add some tests for existing matches. You could put that in the second patch. Then your third patch would add the new matcher

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

On Wed, 16 Jan 2019 at 09:10, John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 16 Jan 2019, at 9:13, Aaron Ballman wrote: > > > On Wed, Jan 16, 2019 at 1:57 AM Akira Hatanaka > > wrote: > >> > >> Yes, the behavior of the compiler doesn’t match what’s explained > >> in the doc

[PATCH] D54604: Automatic variable initialization

pcc added inline comments. Comment at: cfe/trunk/include/clang/Driver/Options.td:1657 + " | pattern">, Values<"uninitialized,pattern">; +def enable_trivial_var_init_zero : Joined<["-"], "enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang">, + Flags<[CC1Opt

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2129 +def warn_class_template_argument_deduction_no_user_defined_guides : Warning< + "using class template argumen

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

jwakely added a comment. The simplest solution would be to change libstdc++'s `` to: #if __cplusplus >= 201703L && __cpp_impl_destroying_delete #define __cpp_lib_destroying_delete 201806L Or we could be fancier and do: #if __cplusplus >= 201103L && __cpp_impl_destroying_delete namespace

[PATCH] D56802: [CodeGenObjC] Treat ivar offsets variables as constant if they refer to ivars of a direct subclass of NSObject with an @implementation

erik.pilkington updated this revision to Diff 182182. erik.pilkington added a comment. Address review comments: move the check to a function, and call it when emitting the ivar offset instead of when we emit the global. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56802/new/ h

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

On 16 Jan 2019, at 18:32, Richard Smith wrote: > On Wed, 16 Jan 2019 at 09:10, John McCall via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On 16 Jan 2019, at 9:13, Aaron Ballman wrote: >> >>> On Wed, Jan 16, 2019 at 1:57 AM Akira Hatanaka >>> wrote: Yes, the behavior of th

r351402 - [Frontend] Make WrapperFrontendAction call WrappedAction.PrepareToExecuteAction.

Author: vsapsai Date: Wed Jan 16 16:20:43 2019 New Revision: 351402 URL: http://llvm.org/viewvc/llvm-project?rev=351402&view=rev Log: [Frontend] Make WrapperFrontendAction call WrappedAction.PrepareToExecuteAction. Fixes `-emit-header-module` when GenerateHeaderModuleAction is wrapped by another

[PATCH] D56816: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context

erik.pilkington added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:7374-7378 + (MD->isDefined() || + (MD->getClassInterface() && +MD->getClassInterface()->getSuperClass() && +MD->getClassInterface()->getSuperCla

[PATCH] D56766: [Frontend] Make WrapperFrontendAction call WrappedAction.PrepareToExecuteAction.

This revision was automatically updated to reflect the committed changes. Closed by commit rC351402: [Frontend] Make WrapperFrontendAction call WrappedAction.PrepareToExecuteAction. (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D56766?vs=181946&id=18218

[PATCH] D56766: [Frontend] Make WrapperFrontendAction call WrappedAction.PrepareToExecuteAction.

vsapsai added a comment. Thanks for the review. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56766/new/ https://reviews.llvm.org/D56766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

r351408 - [X86] Add custom emission for the avx512 scatter builtins to convert from scalar integer to vXi1 for the mask arguments to the intrinsics.

Author: ctopper Date: Wed Jan 16 16:34:19 2019 New Revision: 351408 URL: http://llvm.org/viewvc/llvm-project?rev=351408&view=rev Log: [X86] Add custom emission for the avx512 scatter builtins to convert from scalar integer to vXi1 for the mask arguments to the intrinsics. Modified: cfe/trunk

[PATCH] D54604: Automatic variable initialization

jfb marked an inline comment as done. jfb added inline comments. Comment at: cfe/trunk/include/clang/Driver/Options.td:1657 + " | pattern">, Values<"uninitialized,pattern">; +def enable_trivial_var_init_zero : Joined<["-"], "enable-trivial-auto-var-init-zero-knowing-it-will-be-

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

> On Jan 16, 2019, at 4:20 PM, John McCall via cfe-commits > wrote: > > > > On 16 Jan 2019, at 18:32, Richard Smith wrote: > >> On Wed, 16 Jan 2019 at 09:10, John McCall via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> On 16 Jan 2019, at 9:13, Aaron Ballman wrote: >>> O

[PATCH] D54604: Automatic variable initialization

pcc added inline comments. Comment at: cfe/trunk/include/clang/Driver/Options.td:1657 + " | pattern">, Values<"uninitialized,pattern">; +def enable_trivial_var_init_zero : Joined<["-"], "enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang">, + Flags<[CC1Opt

[PATCH] D56816: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context

arphaman updated this revision to Diff 182191. arphaman added a comment. Follow Erik's suggestion and don't check for definition/declaration in parent class. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56816/new/ https://reviews.llvm.org/D56816 Files: lib/S

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

On Wed, 16 Jan 2019 at 16:20, John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 16 Jan 2019, at 18:32, Richard Smith wrote: > > > On Wed, 16 Jan 2019 at 09:10, John McCall via cfe-commits < > > cfe-commits@lists.llvm.org> wrote: > > > >> On 16 Jan 2019, at 9:13, Aaron Ballman w

[PATCH] D56816: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context

smeenai added a comment. My understanding is that rL349841 accidentally started producing some spurious warnings/errors, rL350768 fixed some instances, and this change fixes more instances. Given that the first two changes

[PATCH] D56816: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context

dexonsmith added a comment. In D56816#1360824 , @smeenai wrote: > My understanding is that rL349841 > accidentally started producing some spurious warnings/errors, rL350768 > fixed s

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

ckennelly added a comment. Conditioning off of C++17 (or part C++11 and part C++17) seems reasonable, although we may want consistency with libc++ (discussion on https://reviews.llvm.org/D55840). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55741/new/ https://

[PATCH] D56821: [CodeGen] Always use string computed in Sema for PredefinedExpr

efriedma created this revision. efriedma added reviewers: rjmccall, rsmith. We can't use any other string, anyway, because its type wouldn't match the type of the PredefinedExpr. With this change, we don't compute a "nice" name for the __func__ global when it's used in the initializer for a con

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

EricWF updated this revision to Diff 182206. EricWF marked 3 inline comments as done. EricWF added a comment. address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56731/new/ https://reviews.llvm.org/D56731 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basi

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

EricWF added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2129 +def warn_class_template_argument_deduction_no_user_defined_guides : Warning< + "using class template argument deduction for %0 that has no user-defined deduction guides" >, + InGroup, De

[PATCH] D56823: [analyzer] Do not try to body-farm bodies for Objective-C properties with custom accessors.

NoQ created this revision. NoQ added reviewers: dcoughlin, george.karpenkov. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, kristof.beyls, xazax.hun, javed.absar. If a property is defined with a custom getter, we shou

[PATCH] D56824: [analyzer] MoveChecker: add ".assign" to the list of common reinitializing methods.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, george.karpenkov, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet. Eg., `std::vector::assign(std::initializer_list)`. I wonder h

[PATCH] D56825: [CMake][Fuchsia] Disable modules for the second stage build

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich, juliehockett. Herald added subscribers: cfe-commits, mgorny. This made the toolchain build 50% slower. Repository: rC Clang https://reviews.llvm.org/D56825 Files: clang/cmake/caches/Fuchsia-stage2.cmake Index:

[PATCH] D56825: [CMake][Fuchsia] Disable modules for the second stage build

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56825/new/ https://reviews.llvm.org/D56825 ___ cf

r351415 - [CMake][Fuchsia] Disable modules for the second stage build

Author: phosek Date: Wed Jan 16 20:12:30 2019 New Revision: 351415 URL: http://llvm.org/viewvc/llvm-project?rev=351415&view=rev Log: [CMake][Fuchsia] Disable modules for the second stage build This made the toolchain build 50% slower. Differential Revision: https://reviews.llvm.org/D56825 Modif

[PATCH] D56825: [CMake][Fuchsia] Disable modules for the second stage build

This revision was automatically updated to reflect the committed changes. Closed by commit rL351415: [CMake][Fuchsia] Disable modules for the second stage build (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56825

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

On 16 Jan 2019, at 20:03, Richard Smith wrote: > On Wed, 16 Jan 2019 at 16:20, John McCall via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On 16 Jan 2019, at 18:32, Richard Smith wrote: >> >>> On Wed, 16 Jan 2019 at 09:10, John McCall via cfe-commits < >>> cfe-commits@lists.llvm.org> w

[PATCH] D56816: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56816/new/ https://reviews.llvm.org/D56816 ___

[PATCH] D56802: [CodeGenObjC] Treat ivar offsets variables as constant if they refer to ivars of a direct subclass of NSObject with an @implementation

rjmccall added a comment. Emitting the global as `const` is probably still a good idea; if the global actually gets mapped as a constant, we'll end up making a dynamic assertion that we got the offset right. It's possible that the section will inhibit that, though. CHANGES SINCE LAST ACTION

[PATCH] D56821: [CodeGen] Always use string computed in Sema for PredefinedExpr

rjmccall added a comment. I agree that this is the right thing to do. If we want to make those improvements, they're doable within Sema. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56821/new/ https://reviews.llvm.org/D56821

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='

tabloid.adroit updated this revision to Diff 182213. tabloid.adroit marked an inline comment as done. tabloid.adroit added a comment. Thanks for the review! - address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56353/new/ https://reviews.llvm.org/D563

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='

tabloid.adroit marked 2 inline comments as done. tabloid.adroit added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:576-579 + Arg *FP = Args.getLastArg(options::OPT_fno_omit_frame_pointer, +options::OPT_fomit_frame_pointer); + Arg *Lea

[PATCH] D56802: [CodeGenObjC] Treat ivar offsets variables as constant if they refer to ivars of a direct subclass of NSObject with an @implementation

erik.pilkington updated this revision to Diff 182214. erik.pilkington added a comment. Sure, that makes sense. The new patch makes the global constant again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56802/new/ https://reviews.llvm.org/D56802 Files: clang/lib/CodeGen/CGObjCMac.cp

[PATCH] D56824: [analyzer] MoveChecker: add ".assign" to the list of common reinitializing methods.

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. This revision is now accepted and ready to land. I think it is straightforward. Thank you for noticing this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56824/new/ https://reviews.ll

<    1   2