pcc added inline comments.

================
Comment at: cfe/trunk/include/clang/Driver/Options.td:1657
+  " | pattern">, Values<"uninitialized,pattern">;
+def enable_trivial_var_init_zero : Joined<["-"], 
"enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang">,
+  Flags<[CC1Option]>,
----------------
I noticed that this introduces a parsing ambiguity on the command line: the 
flag `-enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang` 
can be interpreted either as this flag or as `-e 
nable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang`, 
meaning "tell the linker to use that long symbol name as the program's entry 
point". Worth fixing (e.g. by renaming to `--enable-...`)? It's probably a good 
idea to rename it every so often just to keep people on their toes anyway.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54604/new/

https://reviews.llvm.org/D54604



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to