[PATCH] D56555: Add Attribute to define nonlazy objc classes

aaron.ballman added a comment. It's still missing the tests in SemaObjC -- you can use clang\test\SemaObjC\attr-root-class.m as an example of what I'm talking about. Comment at: clang/include/clang/Basic/Attr.td:1697 + let LangOpts = [ObjC] + let Documentation = [Undocumente

[PATCH] D56241: expose a control flag for interger to pointer ext warning

kristina added a comment. Going to test and land it as requested by @lebedev.ri on IRC. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56241/new/ https://reviews.llvm.org/D56241 ___ cfe-commits mailing list cfe-commit

[PATCH] D56592: [clangd] Fix updated file detection logic in indexing

ilya-biryukov added a comment. This looks neat, thanks for the change! Just a few NITs from my side Comment at: clangd/index/Background.cpp:264 +/// Given index results from a TU, only update symbols coming from files with +/// different digests than \p DigestsSnapshot. Also st

[PATCH] D56592: [clangd] Fix updated file detection logic in indexing

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM after the NITs are fixed. Unless there are other significant changes planned that I need to look at. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https

[PATCH] D47819: [compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing

Lekensteyn added a comment. The direction of this patch looks reasonable to me. Is it worth mentioning the issue (https://github.com/google/sanitizers/issues/974) in the commit message? What environment have you tested this in, could you verify that the tests are indeed skipped on a system with

[PATCH] D53763: [libc++] [test] Fix logic error in tests; enable for MSVC previews

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. I'm a bit concerned about the `TEST_HAS_NO_SPACESHIP_OPERATOR` and how it tracks with `_LIBCPP_HAS_NO_SPACESHIP_OPERATOR`, but I'm not going to hold this up for that. CHANGES SINCE

[PATCH] D56597: [clangd] Add Limit parameter for xref.

hokein updated this revision to Diff 181575. hokein marked an inline comment as done. hokein added a comment. Remove scopes. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56597/new/ https://reviews.llvm.org/D56597 Files: clangd/ClangdLSPServer.cp

[PATCH] D47819: [compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing

mgorny marked 2 inline comments as done. mgorny added a comment. In D47819#1356347 , @Lekensteyn wrote: > The direction of this patch looks reasonable to me. Is it worth mentioning > the issue (https://github.com/google/sanitizers/issues/974) in the commi

[PATCH] D51762: First part of the calendar stuff

mclow.lists marked 2 inline comments as done. mclow.lists added inline comments. Comment at: include/chrono:2667 +#if _LIBCPP_STD_VER > 17 +constexpr chrono::day operator ""d(unsigned long long __d) noexcept +{ EricWF wrote: > Including this file with Cla

[PATCH] D53329: Generate DIFile with main program if source is not available

yonghong-song added a comment. @dblaikie @scott.linder Have you got time to look at this issue? Looks like a trivial test case will be able to reproduce the problem. I have the simple example in the previous comments. Practically, `-gdwarf-5 -gembed-source` is broken now. Repository: rC Cla

[PATCH] D56620: [COFF, ARM64] Declare intrinsics: __nop, _byteswap_[ushort/ulong/uint64]

mgrang added a comment. I have implemented __nop intrinsics in https://reviews.llvm.org/D56620 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56620/new/ https://reviews.llvm.org/D56620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56671: [COFF, ARM64] Add __nop intrinsic

mgrang created this revision. mgrang added reviewers: rnk, efriedma, TomTan, haripul, ssijaric. Herald added subscribers: kristof.beyls, javed.absar. Repository: rC Clang https://reviews.llvm.org/D56671 Files: lib/Headers/intrin.h test/Headers/ms-arm64-intrin.cpp Index: test/Headers/ms-a

[clang-tools-extra] r351081 - [clangd] Add Limit parameter for xref.

Author: hokein Date: Mon Jan 14 10:11:09 2019 New Revision: 351081 URL: http://llvm.org/viewvc/llvm-project?rev=351081&view=rev Log: [clangd] Add Limit parameter for xref. Reviewers: sammccall Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, kadircet, cfe-commits Differential Re

[PATCH] D56597: [clangd] Add Limit parameter for xref.

This revision was automatically updated to reflect the committed changes. Closed by commit rL351081: [clangd] Add Limit parameter for xref. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

Eugene.Zelenko added a comment. In D54945#1355920 , @MarinaKalashina wrote: > @Eugene.Zelenko > > > I would suggest to rename contribution to Contributing (see LLVM > > documentation) and integrations to Integrations. > > Sure, done. > > > Will be also g

r351082 - [Sema] Expose a control flag for integer to pointer ext warning

Author: kristina Date: Mon Jan 14 10:16:51 2019 New Revision: 351082 URL: http://llvm.org/viewvc/llvm-project?rev=351082&view=rev Log: [Sema] Expose a control flag for integer to pointer ext warning While building openJDK11u, it seems that some of the code in the native core libraries make libera

[PATCH] D56241: [Sema] expose a control flag for integer to pointer ext warning

This revision was automatically updated to reflect the committed changes. Closed by commit rC351082: [Sema] Expose a control flag for integer to pointer ext warning (authored by kristina, committed by ). Changed prior to commit: https://reviews.llvm.org/D56241?vs=180143&id=181585#toc Repositor

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

ruiu accepted this revision. ruiu added a comment. This revision is now accepted and ready to land. Let me make it clear again that I'm *not* okay with this approach. Please explicitly pass command line arguments from the compiler driver to the linker. CHANGES SINCE LAST ACTION https://review

[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

xur updated this revision to Diff 181587. xur added a comment. Update the patch to sync with https://reviews.llvm.org/D54175 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54176/new/ https://reviews.llvm.org/D54176 Files: include/clang/Basic/CodeGenOptions.h include/clang/Driver/Op

[PATCH] D53763: [libc++] [test] Fix logic error in tests; enable for MSVC previews

CaseyCarter added a comment. In D53763#1356356 , @mclow.lists wrote: > I'm a bit concerned about the `TEST_HAS_NO_SPACESHIP_OPERATOR` and how it > tracks with `_LIBCPP_HAS_NO_SPACESHIP_OPERATOR`, but I'm not going to hold > this up for that. Same. I tr

r351089 - [WebAssembly] Remove old builtins

Author: djg Date: Mon Jan 14 10:28:10 2019 New Revision: 351089 URL: http://llvm.org/viewvc/llvm-project?rev=351089&view=rev Log: [WebAssembly] Remove old builtins This removes the old grow_memory and mem.grow-style builtins, leaving just the memory.grow-style builtins. Differential Revision: ht

[PATCH] D47819: [compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing

mgorny added a comment. PASS: MemorySanitizer-X86_64 :: Linux/sunrpc_bytes.cc (2932 of 6195) PASS: MemorySanitizer-X86_64 :: Linux/sunrpc_string.cc (2935 of 6195) PASS: MemorySanitizer-X86_64 :: Linux/sunrpc.cc (2974 of 6195) PASS: ThreadSanitizer-x86_64 :: sunrpc.cc (5110 of 6195) So yep

[PATCH] D47819: [compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing

Lekensteyn accepted this revision. Lekensteyn added a comment. This revision is now accepted and ready to land. In D47819#1356498 , @mgorny wrote: > PASS: MemorySanitizer-X86_64 :: Linux/sunrpc_bytes.cc (2932 of 6195) > PASS: MemorySanitizer-X86_64 ::

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

Pierre-vh added a comment. Hello! I'm trying one last ping since it's been a month and it hasn't been commited (I think). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55226/new/ https://reviews.llvm.org/D55226 ___ cfe-commits mailing lis

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

george.karpenkov added a comment. Whoops, sorry. There were holidays, and then I did forget about this patch. I'll commit this now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55226/new/ https://reviews.llvm.org/D55226 ___ cfe-commits ma

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 marked an inline comment as done. jyu2 added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:470 +if (NS->isGCCAsmGoto() && +Exprs[ConstraintIdx]->getStmtClass() == Stmt::AddrLabelExprClass) + break; efriedma wrote: > jyu2 wrote: > > j

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

george.karpenkov added a comment. @Pierre-vh The patch does not compile due to unmatched braces. Please do test and compile before submitting! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55226/new/ https://reviews.llvm.org/D55226 ___ cfe

r351096 - [analyzer] [NFC] Remove unused undefined method.

Author: george.karpenkov Date: Mon Jan 14 10:54:35 2019 New Revision: 351096 URL: http://llvm.org/viewvc/llvm-project?rev=351096&view=rev Log: [analyzer] [NFC] Remove unused undefined method. Wow, at no point the linker or compiler complaints about that! Modified: cfe/trunk/lib/StaticAnalyz

r351097 - [analyzer] [PR39792] false positive on strcpy targeting struct members

Author: george.karpenkov Date: Mon Jan 14 10:54:48 2019 New Revision: 351097 URL: http://llvm.org/viewvc/llvm-project?rev=351097&view=rev Log: [analyzer] [PR39792] false positive on strcpy targeting struct members Patch by Pierre van Houtryve. Differential Revision: https://reviews.llvm.org/D552

[PATCH] D55226: [Fix][StaticAnalyzer] Bug 39792 - False positive on strcpy targeting struct member

This revision was automatically updated to reflect the committed changes. Closed by commit rL351097: [analyzer] [PR39792] false positive on strcpy targeting struct members (authored by george.karpenkov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D56523: Improve a -Wunguarded-availability note

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56523/new/ https://reviews.llvm.org/D56523 ___ cfe-commits mailing list cfe-commi

[clang-tools-extra] r351100 - Revert r351051 "[clangd] Unlink VFS working dir from OS working dir."

Author: aemerson Date: Mon Jan 14 10:59:17 2019 New Revision: 351100 URL: http://llvm.org/viewvc/llvm-project?rev=351100&view=rev Log: Revert r351051 "[clangd] Unlink VFS working dir from OS working dir." The llvm commit r351050 broke some bots and was reverted. Modified: clang-tools-extra/t

r351105 - [clang][UBSan] Sanitization for alignment assumptions.

Author: lebedevri Date: Mon Jan 14 11:09:27 2019 New Revision: 351105 URL: http://llvm.org/viewvc/llvm-project?rev=351105&view=rev Log: [clang][UBSan] Sanitization for alignment assumptions. Summary: UB isn't nice. It's cool and powerful, but not nice. Having a way to detect it is nice though. [[

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

lebedev.ri updated this revision to Diff 181608. lebedev.ri added a comment. Rebased before commit, NFC. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54589/new/ https://reviews.llvm.org/D54589 Files: docs/ReleaseNotes.rst docs/UndefinedBehaviorSanitizer.rst

[PATCH] D56523: Improve a -Wunguarded-availability note

This revision was automatically updated to reflect the committed changes. Closed by commit rC351108: Improve a -Wunguarded-availability note (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D56523?vs=181130&id=181616#toc Repository: rC Clang CHANGES SINC

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

This revision was automatically updated to reflect the committed changes. Closed by commit rC351105: [clang][UBSan] Sanitization for alignment assumptions. (authored by lebedevri, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54589/new/ https://rev

r351108 - Improve a -Wunguarded-availability note

Author: epilk Date: Mon Jan 14 11:17:31 2019 New Revision: 351108 URL: http://llvm.org/viewvc/llvm-project?rev=351108&view=rev Log: Improve a -Wunguarded-availability note Mention the deployment target, and don't say "partial" which doesn't really mean anything to users. rdar://problem/33601513

[PATCH] D47819: [compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing

This revision was automatically updated to reflect the committed changes. Closed by commit rCRT351109: [test] Disable sunrpc tests when rpc/xdr.h is missing (authored by mgorny, committed by ). Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47819/new/

Re: r350856 - Split -Wdelete-non-virtual-dtor into two groups

Sure, for posterity: this was originally committed in r350585 and reverted in r350639. The original commit added -Wdelete-abstract-non-virtual-dtor as a group including -Wdelete-non-virtual-dtor, which led to strange cli behaviour. Thanks! On 1/13/19 5:28 PM, David Blaikie wrote: Might be han

[PATCH] D53153: [OpenCL] Mark kernel functions with default visibility

scott.linder added a comment. In D53153#1355718 , @rjmccall wrote: > In D53153#1353256 , @scott.linder > wrote: > > > In D53153#1317977 , @rjmccall > > wrote: > > > > > I t

r351112 - NFC: Fix nits I missed before

Author: steveire Date: Mon Jan 14 11:50:34 2019 New Revision: 351112 URL: http://llvm.org/viewvc/llvm-project?rev=351112&view=rev Log: NFC: Fix nits I missed before Modified: cfe/trunk/lib/AST/ASTDumper.cpp cfe/trunk/lib/AST/TextNodeDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp UR

[PATCH] D56671: [COFF, ARM64] Add __nop intrinsic

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM I'm assuming this isn't on the list of intrinsics that we must not implement as an inline function in intrin.h... if it is, we'll have to reimplement it at some point. But this is c

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

jdoerfert updated this revision to Diff 181622. jdoerfert marked 2 inline comments as done. jdoerfert added a comment. Small fixes, allow "this" inside "callbacks" Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55483/new/ https://reviews.llvm.org/D55483 Files:

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

efriedma added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:470 +if (NS->isGCCAsmGoto() && +Exprs[ConstraintIdx]->getStmtClass() == Stmt::AddrLabelExprClass) + break; jyu2 wrote: > efriedma wrote: > > jyu2 wrote: > > > jyu2 wrote: > > >

r351114 - [ASTDump] NFC: Move Type Visit implementation to TextNodeDumper

Author: steveire Date: Mon Jan 14 12:11:02 2019 New Revision: 351114 URL: http://llvm.org/viewvc/llvm-project?rev=351114&view=rev Log: [ASTDump] NFC: Move Type Visit implementation to TextNodeDumper Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.or

[PATCH] D56639: NFC: Move Type Visit implementation to TextNodeDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rC351114: [ASTDump] NFC: Move Type Visit implementation to TextNodeDumper (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56639?vs=181448&id=181625#toc Repositor

r351115 - [ASTDump] NFC: Canonicalize handling of TypeLocInfo

Author: steveire Date: Mon Jan 14 12:13:09 2019 New Revision: 351115 URL: http://llvm.org/viewvc/llvm-project?rev=351115&view=rev Log: [ASTDump] NFC: Canonicalize handling of TypeLocInfo Summary: No need to avoid the Visit method. Reviewers: aaron.ballman Subscribers: cfe-commits Differential

[PATCH] D56640: NFC: Canonicalize handling of TypeLocInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rC351115: [ASTDump] NFC: Canonicalize handling of TypeLocInfo (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56640?vs=181449&id=181626#toc Repository: rC Clan

[PATCH] D56641: NFC: Move dumping of QualType node to TextNodeDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rL351116: [ASTDump] NFC: Move dumping of QualType node to TextNodeDumper (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION ht

r351116 - [ASTDump] NFC: Move dumping of QualType node to TextNodeDumper

Author: steveire Date: Mon Jan 14 12:15:29 2019 New Revision: 351116 URL: http://llvm.org/viewvc/llvm-project?rev=351116&view=rev Log: [ASTDump] NFC: Move dumping of QualType node to TextNodeDumper Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org

[PATCH] D56671: [COFF, ARM64] Add __nop intrinsic

rnk accepted this revision. rnk added a comment. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56671/new/ https://reviews.llvm.org/D56671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D56652: [CMake][Fuchsia] Synchronize first and second stage builds

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56652/new/ https://reviews.llvm.org/D56652 ___ cfe-commit

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

jdoerfert updated this revision to Diff 181631. jdoerfert added a comment. Generalize the treatment of "kw_this" as "kw_ident" Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55483/new/ https://reviews.llvm.org/D55483 Files: include/clang/AST/ASTContext.h incl

[PATCH] D56642: NFC: Move dump of type nodes to NodeDumper

steveire updated this revision to Diff 181632. steveire added a comment. Nits Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56642/new/ https://reviews.llvm.org/D56642 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cp

[PATCH] D56647: [WIP] [ELF] Implement --copy-dt-needed-entries

joerg added a comment. As first step, it goes into the right direction. I would explicitly set --as-needed for all those indirectly loaded objects. If people want to retain the questionable behavior of newer GNU tools, it could be a separate flag so that a final round can warn if an indirectly

[PATCH] D56463: [SEH] Pass the frame pointer from SEH finally to finally functions

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Thanks! I'm surprised we passed as much of the Microsoft exception tests as we did with this bug. Maybe it regressed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D56632: [analyzer] Track region liveness only through base regions.

a_sidorin added a comment. Hi Artem, This looks perfect, just some stylish issues. Comment at: test/Analysis/symbol-reaper.cpp:13 + void foo() { +// Ugh, maybe just let clang_analyzer_eval() work within callees already? +// The glob variable shouldn't keep our symbol a

[PATCH] D56680: [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added a reviewer: EricWF. This is a regression of r348365. When clang-tools run on a file without a complation database (`clang-check /tmp/t.cc`), we will use fixed compilation database as a fallback. However the actual

[PATCH] D53153: [OpenCL] Mark kernel functions with default visibility

rjmccall added a comment. Mostly, we don't really want the abstract visibility calculation to change whenever we see a definition. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53153/new/ https://reviews.llvm.org/D53153 ___ cfe-commits mai

[PATCH] D55394: Re-order type param children of ObjC nodes

rjmccall added a comment. I don't really have an opinion about this, sorry. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55394/new/ https://reviews.llvm.org/D55394 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D53329: Generate DIFile with main program if source is not available

scott.linder added a comment. In D53329#1356381 , @yonghong-song wrote: > @dblaikie @scott.linder Have you got time to look at this issue? Looks like a > trivial test case will be able to reproduce the problem. I have the simple > example in the previou

[PATCH] D53329: Generate DIFile with main program if source is not available

yonghong-song added a comment. @scott.linder Thanks! It would be good if you could give at least an initial, even rough, analysis. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53329/new/ https://reviews.llvm.org/D53329 ___

[PATCH] D53541: [COFF, ARM64] Do not emit x86_seh_recoverfp intrinsic

rnk added a comment. In D53541#1353251 , @mgrang wrote: > > What about the three stack pointer case of stack realignment plus a dynamic > > alloca? Typically this is the case where recoverfp is necessary. > > @rnk Sorry, I missed your comment earlier. I a

[PATCH] D55394: Re-order type param children of ObjC nodes

aaron.ballman added a comment. In D55394#1356837 , @rjmccall wrote: > I don't really have an opinion about this, sorry. Do you think ObjC users will find the new output to be harder to read or less understandable than the old output? Repository: rC

[PATCH] D56642: NFC: Move dump of type nodes to NodeDumper

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from `auto` nits. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56642/new/ https://reviews.llvm.org/D56642

[PATCH] D55394: Re-order type param children of ObjC nodes

rjmccall added a comment. This is the AST dumper. This is not a user feature. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55394/new/ https://reviews.llvm.org/D55394 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D55394: Re-order type param children of ObjC nodes

rjmccall added a comment. If I'm debugging a clang bug and calling `D->dump()`, I think it'll be just as clear as it used to be what the `ObjCTypeParamDecl` lines mean. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55394/new/ https://reviews.llvm.org/D55394 _

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

karepker added a comment. Hi all, ping on this patch. I've addressed all comments to the best of my ability. Is there anything outstanding that needs to be changed? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56424/new/ https://reviews.llvm.org/D

[PATCH] D56685: [COFF, ARM64] Declare __byteswap intrinsics

mgrang created this revision. mgrang added reviewers: rnk, efriedma, ssijaric, TomTan, haripul. Herald added subscribers: kristof.beyls, javed.absar. Repository: rC Clang https://reviews.llvm.org/D56685 Files: lib/Headers/arm64intr.h test/Headers/ms-arm64-intrin.cpp Index: test/Headers/m

[PATCH] D56620: [COFF, ARM64] Declare intrinsics: __nop, _byteswap_[ushort/ulong/uint64]

mgrang abandoned this revision. mgrang added a comment. _bytswap intrinsics are added in D56685 . Abandoning this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56620/new/ https://reviews.llvm.org/D56620

r351135 - [COFF, ARM64] Add __nop intrinsic

Author: mgrang Date: Mon Jan 14 15:26:01 2019 New Revision: 351135 URL: http://llvm.org/viewvc/llvm-project?rev=351135&view=rev Log: [COFF, ARM64] Add __nop intrinsic Reviewers: rnk, efriedma, TomTan, haripul, ssijaric Reviewed By: rnk, efriedma Subscribers: javed.absar, kristof.beyls, cfe-comm

[PATCH] D56671: [COFF, ARM64] Add __nop intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rL351135: [COFF, ARM64] Add __nop intrinsic (authored by mgrang, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56671?vs=181578&id=181659#toc

[PATCH] D56685: [COFF, ARM64] Declare __byteswap intrinsics

efriedma added inline comments. Comment at: lib/Headers/arm64intr.h:50 +#define _byteswap_ulong __builtin_bswap32 +#define _byteswap_uint64 __builtin_bswap64 + These should be available for all Microsoft targets, I think. Please define these as inline functions

r351137 - [Sema] Change std::sort to llvm::sort

Author: mgrang Date: Mon Jan 14 15:45:58 2019 New Revision: 351137 URL: http://llvm.org/viewvc/llvm-project?rev=351137&view=rev Log: [Sema] Change std::sort to llvm::sort Modified: cfe/trunk/lib/Sema/SemaChecking.cpp Modified: cfe/trunk/lib/Sema/SemaChecking.cpp URL: http://llvm.org/viewvc/

[PATCH] D56686: [X86] Make _xgetbv/_xsetbv on non-windows platforms

craig.topper created this revision. craig.topper added reviewers: rnk, RKSimon, spatel. This patch attempts to redo what was tried in r278783, but was reverted. These intrinsics should be available on non-windows platforms with "xsave" feature check. But on Windows platforms they shouldn't have

[PATCH] D56686: [X86] Make _xgetbv/_xsetbv on non-windows platforms

rnk added inline comments. Comment at: lib/Headers/immintrin.h:381-394 +#ifdef _MSC_VER +#ifdef __cplusplus +extern "C" { +#endif +unsigned __int64 __cdecl _xgetbv(unsigned int); +void __cdecl _xsetbv(unsigned int, unsigned __int64); +#ifdef __cplusplus I think w

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

jkorous added a comment. Hi Ilya, this seems really useful for people learning how to implement their custom actions! Comment at: clangd/refactor/actions/SwapIfBranches.cpp:36 + + bool VisitIfStmt(IfStmt *If) { +auto R = toHalfOpenFileRange(Ctx.getSourceManager(), Ctx.get

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

jkorous added a comment. Hi Ilya, I got here from reading your other patch (https://reviews.llvm.org/D56611). I'm wondering if we could make those range utility functions more understandable. Comment at: clangd/SourceCode.h:64 +/// Turns a token range into a half-open range

[PATCH] D56685: [COFF, ARM64] Add __byteswap intrinsics

mgrang updated this revision to Diff 181671. mgrang retitled this revision from "[COFF, ARM64] Declare __byteswap intrinsics" to "[COFF, ARM64] Add __byteswap intrinsics". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56685/new/ https://reviews.llvm.org/D56685 Files: lib/Headers/intri

[PATCH] D56686: [X86] Make _xgetbv/_xsetbv on non-windows platforms

craig.topper updated this revision to Diff 181672. craig.topper added a comment. Remove guard from include of xsaveintrin.h. We can't have any check because we need it to always include on non-windows platforms due to target attribute. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56686

[PATCH] D56685: [COFF, ARM64] Add __byteswap intrinsics

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: test/Headers/ms-arm64-intrin.cpp:19 __nop(); } + While you're here, please fix all four tests to just check the IR. CHANGES SINCE

[PATCH] D56686: [X86] Make _xgetbv/_xsetbv on non-windows platforms

craig.topper marked an inline comment as done. craig.topper added inline comments. Comment at: test/Headers/ms-intrin.cpp:37 void f() { __movsb(0, 0, 0); __movsd(0, 0, 0); rnk wrote: > Surely `__movsb` and `__readmsr` should all be x86-only as well, at lea

[PATCH] D56685: [COFF, ARM64] Add __byteswap intrinsics

efriedma added a comment. Before you commit, please verify this actually compiles if you include both this intrin.h and stdlib.h from the Microsoft SDK, in either order. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56685/new/ https://reviews.llvm.org/D56685

r351145 - [CMake][Fuchsia] Synchronize first and second stage builds

Author: phosek Date: Mon Jan 14 17:15:00 2019 New Revision: 351145 URL: http://llvm.org/viewvc/llvm-project?rev=351145&view=rev Log: [CMake][Fuchsia] Synchronize first and second stage builds This reorders options between the first and second stage builds to make them better lined up. The change

[PATCH] D56652: [CMake][Fuchsia] Synchronize first and second stage builds

This revision was automatically updated to reflect the committed changes. Closed by commit rL351145: [CMake][Fuchsia] Synchronize first and second stage builds (authored by phosek, committed by ). Herald added a reviewer: alexshap. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D56690: [Nios2] Remove Nios2 backend

craig.topper created this revision. craig.topper added reviewers: chandlerc, hans, efriedma. Herald added subscribers: jfb, mgorny. As mentioned here. This backend is incomplete and has not been maintained in several months. http://lists.llvm.org/pipermail/llvm-dev/2019-January/129121.html htt

[PATCH] D56685: [COFF, ARM64] Add __byteswap intrinsics

mgrang marked an inline comment as done. mgrang added a comment. Verified that this compiles when both intrin.h and stdlib.h from the Microsoft SDK are included, in either order. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56685/new/ https://reviews.llvm.org/D56685 ___

[PATCH] D56685: [COFF, ARM64] Add __byteswap intrinsics

mgrang updated this revision to Diff 181679. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56685/new/ https://reviews.llvm.org/D56685 Files: lib/Headers/intrin.h test/Headers/ms-arm64-intrin.cpp Index: test/Headers/ms-arm64-intrin.cpp ===

r351147 - [COFF, ARM64] Add __byteswap intrinsics

Author: mgrang Date: Mon Jan 14 17:26:26 2019 New Revision: 351147 URL: http://llvm.org/viewvc/llvm-project?rev=351147&view=rev Log: [COFF, ARM64] Add __byteswap intrinsics Reviewers: rnk, efriedma, ssijaric, TomTan, haripul Reviewed By: efriedma Subscribers: javed.absar, cfe-commits, kristof.b

[PATCH] D56685: [COFF, ARM64] Add __byteswap intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rC351147: [COFF, ARM64] Add __byteswap intrinsics (authored by mgrang, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56685/new/ https://reviews.llvm.org/D566

[PATCH] D56686: [X86] Make _xgetbv/_xsetbv on non-windows platforms

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56686/new/ https://reviews.llvm.org/D56686 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D56690: [Nios2] Remove Nios2 backend

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM as a patch, but same as the other wait to land until the -dev thread settles. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56690/new/ https://reviews.llvm.org/D56690 _

[PATCH] D53763: [libc++] [test] Fix logic error in tests; enable for MSVC previews

CaseyCarter closed this revision. CaseyCarter added a comment. I merged this as r351148. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53763/new/ https://reviews.llvm.org/D53763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D55781: Make CC mangling conditional on the ABI version

rnk abandoned this revision. rnk added a comment. In D55781#1351541 , @rjmccall wrote: > Okay. In my opinion, then, we should just do this unconditionally. Sounds good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55781/new/ https://re

[PATCH] D56555: Add Attribute to define nonlazy objc classes

joedaniels29 updated this revision to Diff 181692. joedaniels29 marked 2 inline comments as done. joedaniels29 added a comment. Hopefully addressed Aaron's comments. Thanks again Aaron. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56555/new/ https://reviews.llvm

[PATCH] D56555: Add Attribute to define nonlazy objc classes

joedaniels29 added a comment. never mind, I didnt address > It's still missing the tests in SemaObjC -- you can use > clang\test\SemaObjC\attr-root-class.m as an example of what I'm talking about. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56555/new/ https:/

[PATCH] D56555: Add Attribute to define nonlazy objc classes

joedaniels29 added a comment. On second thought, I have addressed everything, I think. > clang/test/SemaObjC/attr-objc-non-lazy.m Aaron, would you mind taking another look? Thanks a bunch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56555/new/ https://reviews

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 updated this revision to Diff 181702. jyu2 added a comment. Add code to diagnostic error for use of the "l" modifier that does not point to a label in the label list. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/A

[PATCH] D56429: fix python3 compability issue

roxma marked an inline comment as done. roxma added inline comments. Comment at: bindings/python/clang/cindex.py:2998 +for i,(name,contents) in enumerate(unsaved_files): +if hasattr(contents, "read"): +contents = contents.read() ---

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

jyu2 marked an inline comment as done. jyu2 added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:470 +if (NS->isGCCAsmGoto() && +Exprs[ConstraintIdx]->getStmtClass() == Stmt::AddrLabelExprClass) + break; efriedma wrote: > jyu2 wrote: > > e

<    1   2   3   >