roxma marked an inline comment as done. roxma added inline comments.
================ Comment at: bindings/python/clang/cindex.py:2998 + for i,(name,contents) in enumerate(unsaved_files): + if hasattr(contents, "read"): + contents = contents.read() ---------------- serge-sans-paille wrote: > serge-sans-paille wrote: > > Why did you remove the FIXME comment? > @roxma LGTM except this FIXME removal. @serge-sans-paille the `contents.read()` looks almost the same as line 2817. It is better to keep the code consistent. The FIXME doesn't seem to be helpful. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56429/new/ https://reviews.llvm.org/D56429 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
