[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

sammccall updated this revision to Diff 180796. sammccall added a comment. Ignore lambdas in FunctionSizeCheck (functionDecl() now matches their operator()). I think they should probably be included, but don't want to change the check semantics in this patch. Repository: rC Clang CHANGES SI

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

sammccall added a subscriber: klimek. sammccall added a comment. In D56444#1350252 , @JonasToth wrote: > I still see the unit-test crashing for `ExprMutAnalyzer` (just apply the last > two tests > https://github.com/JonasToth/clang/blob/fix_crash/unittes

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

MyDeveloperDay added inline comments. Comment at: clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp:27 +static bool isGoogletestTestMacro(StringRef MacroName) { + static const llvm::StringSet<> MacroNames = {"TEST", "TEST_F", "TEST_P", +

[PATCH] D56483: [clangd] Add a test for SignatureHelp on dynamic index.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. This would catch regressions caused by future changes of the index. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56483 Files: unitte

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

MyDeveloperDay added inline comments. Comment at: clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp:64 + Check->diag(TestCaseNameToken->getLocation(), + "avoid using \"_\" in test case name \"%0\" according to " + "Googletest FAQ")

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

JonasToth added a comment. In D56444#1350746 , @sammccall wrote: > In D56444#1350252 , @JonasToth wrote: > > > I still see the unit-test crashing for `ExprMutAnalyzer` (just apply the > > last two tests > > https:

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

ilya-biryukov added inline comments. Comment at: clangd/index/Background.cpp:259 + // if this thread sees the older version but finishes later. This should + // be rare in practice. + DigestIt.first->second = Hash; kadircet wrote: > ilya-biryukov w

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

ilya-biryukov added inline comments. Comment at: clangd/SourceCode.h:107 +// "/tmp/build/foo.h" +std::string makeCanonicalPath(llvm::StringRef AbsolutePath, + const SourceManager &SM); This changes should go away after the rebase, rig

[PATCH] D51641: [VFS] Cache the current working directory for the real FS.

sammccall added a comment. In D51641#1338004 , @labath wrote: > Might I ask what was the motivation for this change? Performance > optimalization? Yes, this was for performance. IIRC the problem was something like calling `VFS->makeAbsolute(P)` for ever

[PATCH] D56314: [clangd] Don't store completion info if the symbol is not used for code completion.

hokein updated this revision to Diff 180808. hokein marked 2 inline comments as done. hokein added a comment. Address comments, store docs. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56314/new/ https://reviews.llvm.org/D56314 Files: clangd/ind

[PATCH] D56314: [clangd] Don't store completion info if the symbol is not used for code completion.

hokein added inline comments. Comment at: clangd/index/SymbolCollector.cpp:543 + + if (!(S.Flags & Symbol::IndexedForCodeCompletion)) +return Insert(S); ilya-biryukov wrote: > hokein wrote: > > ilya-biryukov wrote: > > > Most of the fields updated at the bot

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

klimek added a comment. In D56444#1350746 , @sammccall wrote: > In D56444#1350252 , @JonasToth wrote: > > > I still see the unit-test crashing for `ExprMutAnalyzer` (just apply the > > last two tests > > https://g

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

jkorous added a comment. @arphaman or @sammccall, could you please take the final look? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54428/new/ https://reviews.llvm.org/D54428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

jkorous updated this revision to Diff 180809. jkorous edited the summary of this revision. jkorous added a comment. Fixed the synchronous handling of events. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54428/new/ https://reviews.llvm.org/D54428 Files: CMakeLists.txt clangd/CMakeL

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

ilya-biryukov added inline comments. Comment at: clangd/index/Background.cpp:197 +Cmd.CommandLine.push_back("-resource-dir=" + ResourceDir); +const std::string FileName = Cmd.Filename; +if (auto Error = index(std::move(Cmd), Storage)) use

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

steveire added a comment. The timing of this is unfortunate because the change will not be needed soon. Refactoring is underway to extract a generic traverser from ASTDumper. Then the parent/child traversal of ASTMatchFinder can be implemented in terms of it without any of these kinds of proble

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

hokein added inline comments. Comment at: clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp:27 +static bool isGoogletestTestMacro(StringRef MacroName) { + static const llvm::StringSet<> MacroNames = {"TEST", "TEST_F", "TEST_P", +

r350703 - Use DeclSpec for quals in DeclaratorChunk::FunctionTypeInfo.

Author: stulova Date: Wed Jan 9 03:25:09 2019 New Revision: 350703 URL: http://llvm.org/viewvc/llvm-project?rev=350703&view=rev Log: Use DeclSpec for quals in DeclaratorChunk::FunctionTypeInfo. Rather than duplicating data fields, use DeclSpec directly to store the qualifiers for the functions/m

[PATCH] D55948: Modify DeclaratorChuck::getFunction to use DeclSpec for qualifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rC350703: Use DeclSpec for quals in DeclaratorChunk::FunctionTypeInfo. (authored by stulova, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55948/new/ https:/

[libunwind] r350705 - [Sparc] Add Sparc V8 support

Author: dcederman Date: Wed Jan 9 04:06:05 2019 New Revision: 350705 URL: http://llvm.org/viewvc/llvm-project?rev=350705&view=rev Log: [Sparc] Add Sparc V8 support Summary: Adds the register class implementation for Sparc. Adds support for DW_CFA_GNU_window_save. Adds save and restore context fu

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

sammccall added a comment. In D56444#1350897 , @steveire wrote: > The timing of this is unfortunate because the change will not be needed soon. RecursiveASTVisitor should be fixed (even if it won't be used for the parent map) unless it's going away enti

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

steveire added a comment. In D56444#1350935 , @sammccall wrote: > In D56444#1350897 , @steveire wrote: > > > > > > I'm not inclined to hold off fixing this bug though, because: > > - it's blocking other patches, and

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

JonasToth added a comment. In D56444#1350897 , @steveire wrote: > The timing of this is unfortunate because the change will not be needed soon. > Refactoring is underway to extract a generic traverser from ASTDumper. Then > the parent/child traversal of

[PATCH] D56446: [Driver] Fix libcxx detection on Darwin with clang run as ./clang

thakis added a comment. …can you land this? :-) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56446/new/ https://reviews.llvm.org/D56446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

steveire added a comment. In D56444#1350946 , @JonasToth wrote: > Should still be fixed for 8.0 (probably with this patch). The refactoring is > more realistic to land in 9.0 i guess? That's why I said timing is unfortunate :). Repository: rC Clang

r350714 - [Driver] Fix libcxx detection on Darwin with clang run as ./clang

Author: ibiryukov Date: Wed Jan 9 05:08:11 2019 New Revision: 350714 URL: http://llvm.org/viewvc/llvm-project?rev=350714&view=rev Log: [Driver] Fix libcxx detection on Darwin with clang run as ./clang Summary: By using '..' instead of fs::parent_path. The intention of the code was to go from 'p

[PATCH] D56446: [Driver] Fix libcxx detection on Darwin with clang run as ./clang

This revision was automatically updated to reflect the committed changes. Closed by commit rC350714: [Driver] Fix libcxx detection on Darwin with clang run as ./clang (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D56446?vs=180691&id=180822#toc Reposi

[clang-tools-extra] r350715 - Fix clang-tidy test after r350714. NFC

Author: ibiryukov Date: Wed Jan 9 05:08:31 2019 New Revision: 350715 URL: http://llvm.org/viewvc/llvm-project?rev=350715&view=rev Log: Fix clang-tidy test after r350714. NFC Added: clang-tools-extra/trunk/test/clang-tidy/Inputs/mock-libcxx/bin/ clang-tools-extra/trunk/test/clang-tidy/Inp

Re: r346652 - Make clang-based tools find libc++ on MacOS

Glad to help. The fix has landed. Let me know if the problem persists after it's integrated. On Tue, Jan 8, 2019 at 7:36 PM Nico Weber wrote: > That looks like it should help. Thanks for the quick fix! > > On Tue, Jan 8, 2019 at 1:11 PM Ilya Biryukov wrote: > >> Hi Nico, >> >> This is clearly a

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

kadircet updated this revision to Diff 180823. kadircet marked 8 inline comments as done. kadircet added a comment. Address comments && rebase Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55224/new/ https://reviews.llvm.org/D55224 Files: clangd/

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

kadircet added a comment. There seems to be no unexpected changes after rebase Comment at: clangd/index/Background.cpp:259 + // if this thread sees the older version but finishes later. This should + // be rare in practice. + DigestIt.first->second = Hash; --

[PATCH] D56483: [clangd] Add a test for SignatureHelp on dynamic index.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Many thanks! Should've been there from the start, sorry about the inconvenience Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56483/

[PATCH] D56062: [compiler-rt] [test] Detect glibc-2.27+ and XFAIL appropriate tests

This revision was automatically updated to reflect the committed changes. Closed by commit rCRT350717: [test] Detect glibc-2.27+ and XFAIL appropriate tests (authored by mgorny, committed by ). Changed prior to commit: https://reviews.llvm.org/D56062?vs=179456&id=180824#toc Repository: rCRT

r350718 - Revert r350648: "Fix clang for r350647: Missed a function rename"

Author: fhahn Date: Wed Jan 9 05:30:47 2019 New Revision: 350718 URL: http://llvm.org/viewvc/llvm-project?rev=350718&view=rev Log: Revert r350648: "Fix clang for r350647: Missed a function rename" The related commit r350647 breaks thread sanitizer on some macOS builders, e.g. http://green.lab.ll

[PATCH] D56314: [clangd] Don't store completion info if the symbol is not used for code completion.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clangd/index/Index.h:188 /// candidate list. For example, "(X x, Y y) const" is a function signature. + /// This field is only meaningful w

[PATCH] D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr

JonasToth added a comment. @LegalizeAdulthood your stuck on the commit right things right? If you want I can commit for you (maybe even later) as you said you are limited on time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56323/new/ https://reviews.llvm.org/D56323 __

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

JonasToth accepted this revision. JonasToth added a comment. LGTM! You verified that your fixes, fix the issues in LLVM? But it looks good to go. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55433/new/ https://reviews.llvm.org/D55433 ___ c

[clang-tools-extra] r350720 - [clangd] Add a test for SignatureHelp on dynamic index.

Author: hokein Date: Wed Jan 9 05:42:03 2019 New Revision: 350720 URL: http://llvm.org/viewvc/llvm-project?rev=350720&view=rev Log: [clangd] Add a test for SignatureHelp on dynamic index. Summary: This would catch regressions caused by future changes of the index. Reviewers: ilya-biryukov Subs

[PATCH] D56483: [clangd] Add a test for SignatureHelp on dynamic index.

This revision was automatically updated to reflect the committed changes. Closed by commit rL350720: [clangd] Add a test for SignatureHelp on dynamic index. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://rev

[PATCH] D56314: [clangd] Don't store completion info if the symbol is not used for code completion.

hokein updated this revision to Diff 180827. hokein marked an inline comment as done. hokein added a comment. address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56314/new/ https://reviews.llvm.org/D56314 Files: clangd/index/Ind

RE: r350643 - Limit COFF 'common' emission to <=32 alignment types.

Thank you for that! From: Shoaib Meenai [mailto:smee...@fb.com] Sent: Tuesday, January 8, 2019 4:48 PM To: David Majnemer Cc: Keane, Erich ; cfe-commits@lists.llvm.org; Martin Storsjo Subject: Re: r350643 - Limit COFF 'common' emission to <=32 alignment types. I sent out https://reviews.llvm.o

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. In D56430#1350706 , @smateo wrote: > Renaming the `isParallelRegion` function to `isImplicitTaskingRegion`. > > Shall we rename the `isParallelOrTaskR

[PATCH] D56446: [Driver] Fix libcxx detection on Darwin with clang run as ./clang

ilya-biryukov added a comment. Sorry about the delay. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56446/new/ https://reviews.llvm.org/D56446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

r350724 - Fix typo in comment

Author: nico Date: Wed Jan 9 06:19:16 2019 New Revision: 350724 URL: http://llvm.org/viewvc/llvm-project?rev=350724&view=rev Log: Fix typo in comment Modified: cfe/trunk/include/clang/Sema/Sema.h Modified: cfe/trunk/include/clang/Sema/Sema.h URL: http://llvm.org/viewvc/llvm-project/cfe/tru

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

aaron.ballman added a comment. In D56444#1350849 , @JonasToth wrote: > In D56444#1350746 , @sammccall wrote: > > > @klimek: would it be better to preserve the odd behavior of the > > `functionDecl()` matcher, and a

[PATCH] D56488: clang-cl: Align help texts for /O1 and O2

thakis created this revision. thakis added a reviewer: hans. Makes it a bit easier to see what exactly the difference is. Also use "same as" instead of "equivalent to", because that's faster to read. https://reviews.llvm.org/D56488 Files: clang/include/clang/Driver/CLCompatOptions.td Index

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

klimek added a comment. In D56444#1351056 , @aaron.ballman wrote: > In D56444#1350849 , @JonasToth wrote: > > > In D56444#1350746 , @sammccall > > wrote: > > > > > @klimek:

[PATCH] D56489: clang-cl: Fix help text for /O: '/O2y-' means '/O2 /Oy-', not '/O2 /y-'

thakis created this revision. thakis added a reviewer: hans. https://reviews.llvm.org/D56489 Files: clang/include/clang/Driver/CLCompatOptions.td Index: clang/include/clang/Driver/CLCompatOptions.td === --- clang/include/clang/Dr

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

ilya-biryukov added inline comments. Comment at: clangd/SourceCode.h:21 #include "clang/Tooling/Core/Replacement.h" +#include "llvm/Support/Path.h" #include "llvm/Support/SHA1.h" Looks redundant. Remove? Comment at: clangd/index/Background.cp

[PATCH] D56314: [clangd] Don't store completion info if the symbol is not used for code completion.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. LGTM again :-) I bet the savings are less now that we're always storing the comments in the static index, so the numbers in the description might be outdated. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

sammccall added a comment. In D56444#1351056 , @aaron.ballman wrote: > Given that, I kind of think we should have functionDecl() match only > functions, and give users some other way to match the semantic declarations > in a consistent manner. Alternati

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay added a comment. In D55433#1350999 , @JonasToth wrote: > LGTM! > You verified that your fixes, fix the issues in LLVM? But it looks good to > go. They look good, you asked before... > P.S. did you request commit rights already? I do no

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

ABataev added inline comments. Comment at: lib/AST/DeclOpenMP.cpp:164 + if (NumClauses) { +Clauses = (OMPClause **)C.Allocate(sizeof(OMPClause *) * NumClauses); +setClauses(CL); No, bad idea. Use tail allocation for the clauses. Check the implementation

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

aaron.ballman added a comment. In D56444#1351067 , @klimek wrote: > In D56444#1351056 , @aaron.ballman > wrote: > > > In D56444#1350849 , @JonasToth > > wrote: > > > > > In

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

aaron.ballman added a comment. In D56444#1351096 , @sammccall wrote: > In D56444#1351056 , @aaron.ballman > wrote: > > > Given that, I kind of think we should have functionDecl() match only > > functions, and give

r350727 - Remove dependency-related arguments in clang-check.

Author: alexfh Date: Wed Jan 9 07:00:06 2019 New Revision: 350727 URL: http://llvm.org/viewvc/llvm-project?rev=350727&view=rev Log: Remove dependency-related arguments in clang-check. This is the default behavior of clang tools, but clang-check overrides default argument adjusters for some reaso

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

steveire added a comment. In D56444#1351096 , @sammccall wrote: > In D56444#1351056 , @aaron.ballman > wrote: > > > Given that, I kind of think we should have functionDecl() match only > > functions, and give user

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

aaron.ballman added a comment. In D56444#1351127 , @steveire wrote: > I suggest not trying to make any such drastic changes for 8.0, try to fix the > bug in a minimal way if possible, and have a more considered approach to the > future of AST Matchers fo

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

steveire added a comment. In D56444#1351125 , @aaron.ballman wrote: > if the location isn't somewhere in user code, then don't consider the node or > its children for traversal. However, that may be insufficient and equally as > mysterious behavior. T

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

steveire added a comment. In D56444#1351130 , @steveire wrote: > In D56444#1351125 , @aaron.ballman > wrote: > > > if the location isn't somewhere in user code, then don't consider the node > > or its children for

[PATCH] D55781: Make CC mangling conditional on the ABI version

probinson added a comment. Herald added a subscriber: mstorsjo. Sorry for not noticing this sooner. The TL;DR is, the current patch does not affect PS4, so go ahead; but see the long version for other considerations. First, the general point: The PS4 ABI does not fit neatly into the sequential

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

sammccall added a comment. In D56444#1351128 , @aaron.ballman wrote: > In D56444#1351127 , @steveire wrote: > > > I suggest not trying to make any such drastic changes for 8.0, try to fix > > the bug in a minimal

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

sammccall added a comment. In D56444#1351130 , @steveire wrote: > In D56444#1351125 , @aaron.ballman > wrote: > > > if the location isn't somewhere in user code, then don't consider the node > > or its children fo

[PATCH] D55488: Add utility for dumping a label with child nodes

aaron.ballman added a comment. @rsmith -- do you have opinions on the new format for how we display the child node? I think this is a more clear approach, but a second opinion would be nice. Comment at: include/clang/AST/TextNodeDumper.h:43 + /// Add a child of the current no

[PATCH] D56492: [clangd] Add Documentations for member completions.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. We are missing docs for class member completion -- we don't store comments in the preamble, so Sema doesn't return any docs. To get docs for class members,

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

steveire added a comment. In D56444#1351145 , @sammccall wrote: > In D56444#1351128 , @aaron.ballman > wrote: > > > In D56444#1351127 , @steveire > > wrote: > > > > > I sug

[PATCH] D56492: [clangd] Add Documentations for member completions.

hokein updated this revision to Diff 180843. hokein added a comment. Add a comment. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56492/new/ https://reviews.llvm.org/D56492 Files: clangd/CodeComplete.cpp unittests/clangd/CodeCompleteTests.cpp

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

steveire added a comment. In D56444#1351150 , @sammccall wrote: > In D56444#1351130 , @steveire wrote: > > > In D56444#1351125 , @aaron.ballman > > wrote: > > > > > if the l

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

JonasToth added a comment. >> Is the suggestion to make that change, but then modify the semantics of the >> `functionDecl()` etc matchers to hide it? Or something else? > > My suggestion is to extract the traverser from ASTDumper first, then fix this > issue. I understand that you are working

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

steveire added a comment. In D56444#1351182 , @steveire wrote: > In D56444#1351150 , @sammccall wrote: > > > In D56444#1351130 , @steveire > > wrote: > > > > > In D56444#135

[PATCH] D53891: [LTO] Add option to enable LTOUnit splitting, and disable unless needed

tejohnson added a comment. ping - @pcc do you have any more comments or can this be committed along with D53890 ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53891/new/ https://reviews.llvm.org/D53891 ___

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

smateo updated this revision to Diff 180844. smateo added a comment. Done! Thanks, Sergi Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56430/new/ https://reviews.llvm.org/D56430 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/task_messages.cpp Index: test/OpenM

r350732 - [AST] Store the results in OverloadExpr in a trailing array

Author: brunoricci Date: Wed Jan 9 07:43:19 2019 New Revision: 350732 URL: http://llvm.org/viewvc/llvm-project?rev=350732&view=rev Log: [AST] Store the results in OverloadExpr in a trailing array Use the newly available space in the bit-fields of Stmt to pack OverloadExpr, UnresolvedLookupExpr a

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

steveire added a comment. In D56444#1351194 , @JonasToth wrote: > >> Is the suggestion to make that change, but then modify the semantics of > >> the `functionDecl()` etc matchers to hide it? Or something else? > > > > My suggestion is to extract the tra

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

ABataev added a comment. Will you commit this patch? Or I should do it? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56430/new/ https://reviews.llvm.org/D56430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56368: [AST] Store the results in OverloadExpr in a trailing array

This revision was automatically updated to reflect the committed changes. Closed by commit rL350732: [AST] Store the results in OverloadExpr in a trailing array (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D5

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

aaron.ballman added a comment. Can you add a test that checks that a lambda declared within another lambda also traverses as expected? In D56444#1351145 , @sammccall wrote: > In D56444#1351128 , @aaron.ballman >

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

smateo added a comment. I don't have commit access yet. Would you mind to commit it for me? Thanks!, Sergi Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56430/new/ https://reviews.llvm.org/D56430 ___ cfe-commits mai

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

ABataev added a comment. In D56430#1351212 , @smateo wrote: > I don't have commit access yet. Would you mind to commit it for me? Thanks!, > > Sergi Sure, no problems. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56430/

[PATCH] D56314: [clangd] Don't store completion info if the symbol is not used for code completion.

hokein added a comment. In D56314#1351091 , @ilya-biryukov wrote: > LGTM again :-) I bet the savings are less now that we're always storing the > comments in the static index, so the numbers in the description might be > outdated. Yes, fixed. Reposi

[PATCH] D56492: [clangd] Add Documentations for member completions.

ilya-biryukov added inline comments. Comment at: clangd/CodeComplete.cpp:1373 // Convert the results to final form, assembling the expensive strings. -for (auto &C : Top) { - Output.Completions.push_back(toCodeCompletion(C.first)); - Output.Completions.back().S

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl added a comment. In D56411#1350233 , @jlebar wrote: > __host__ void bar() {} > __device__ int bar() { return 0; } > __host__ __device__ void foo() { int x = bar(); } > template __global__ void kernel() { devF();} > > kernel(); > > > > >

r350734 - Incorrect implicit data-sharing for nested tasks

Author: abataev Date: Wed Jan 9 07:58:05 2019 New Revision: 350734 URL: http://llvm.org/viewvc/llvm-project?rev=350734&view=rev Log: Incorrect implicit data-sharing for nested tasks Summary: There is a minor issue in how the implicit data-sharings for nested tasks are computed. For the followi

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

This revision was automatically updated to reflect the committed changes. Closed by commit rL350734: Incorrect implicit data-sharing for nested tasks (authored by ABataev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56430?vs=180844

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

sammccall added a comment. In D56444#1351174 , @steveire wrote: > In D56444#1351145 , @sammccall wrote: > > > This manifests as assertion failures (or with assertions off, incorrect > > results) for some matchers,

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

steveire added a comment. In D56444#1351247 , @sammccall wrote: > In D56444#1351174 , @steveire wrote: > > > Yes - don't use RAV to traverse parents when AST-matching. > > > OK, this is certainly a much more invasiv

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl updated this revision to Diff 180848. yaxunl added a comment. Add test for `__host__ __device__`. Removing the flag IsParsingTemplateArgument in Sema. Instead, check ExprEvalContexts for disabling checking device/host consistency. I did not use ExprEvalContext Unevaluated to condition the

r350741 - [AST] Move back BasePathSize to the bit-fields of CastExpr

Author: brunoricci Date: Wed Jan 9 08:41:33 2019 New Revision: 350741 URL: http://llvm.org/viewvc/llvm-project?rev=350741&view=rev Log: [AST] Move back BasePathSize to the bit-fields of CastExpr The number of trailing CXXBaseSpecifiers in CastExpr was moved from CastExprBitfields to a trailing o

[PATCH] D56358: [AST] Move back BasePathSize to the bit-fields of CastExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rC350741: [AST] Move back BasePathSize to the bit-fields of CastExpr (authored by brunoricci, committed by ). Changed prior to commit: https://reviews.llvm.org/D56358?vs=180377&id=180854#toc Repository:

[PATCH] D51641: [VFS] Cache the current working directory for the real FS.

labath added a comment. I wholeheartedly support an openat(2) based VFS, as the current one falls short of the expectations you have of it and is pretty broken right now. As for your assumption #2, I think that depends on what does one want to get out of the VFS. I can certainly see a use for h

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

rupprecht added a comment. Post-holiday ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55964/new/ https://reviews.llvm.org/D55964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

kadircet updated this revision to Diff 180859. kadircet marked 12 inline comments as done. kadircet added a comment. Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55224/new/ https://reviews.llvm.org/D55224 Files: clangd/URI.cpp

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

kadircet added inline comments. Comment at: clangd/index/Background.cpp:259 + // if this thread sees the older version but finishes later. This should + // be rare in practice. + DigestIt.first->second = Hash; ilya-biryukov wrote: > kadircet wrote:

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

djasper added a comment. This seem to conceptually be a list of things rather than an array subscript, though, right? Could we alternatively set SpacesInContainerLiterals to false for LK_TableGen? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55964/new/ https:

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

rupprecht added a comment. In D55964#1351348 , @djasper wrote: > This seem to conceptually be a list of things rather than an array subscript, > though, right? Could we alternatively set SpacesInContainerLiterals to false > for LK_TableGen? That seems

[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/SemaInit.cpp:4539 + if (InitCategory.isPRValue() || InitCategory.isXValue()) +T1Quals.removeAddressSpace(); + rjmccall wrote: > ebevhan wrote: > > rjmccall wrot

[PATCH] D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context

erik.pilkington added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:7290 + // when it's actually defined and is referenced from within the + // @implementation itself. + if (const auto *MD = dyn_cast(OffendingDecl)) { Maybe add a sentence:

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google, sbc100. Depends on D56501 . Also adds a macro define __wasm_unimplemented_simd128__ for feature detection of unimp

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

djasper added a comment. Look at getGoogleStyle(). It has a bunch of language-specific configs at the bottom. You can do the same for TableGen in getLLVMStyle(). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55964/new/ https://reviews.llvm.org/D55964

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

rupprecht added a comment. Right, but `getGoogleStyle()` has the inferred language passed in (i.e. `getGoogleStyle(FormatStyle::LanguageKind Language)`. Whereas `getLLVMStyle()` takes no args and assumes C++. Would it be worthwhile to refactor getLLVMStyle to take in an optional language arg?

  1   2   >