sammccall added a comment. In D56444#1350897 <https://reviews.llvm.org/D56444#1350897>, @steveire wrote:
> The timing of this is unfortunate because the change will not be needed soon. RecursiveASTVisitor should be fixed (even if it won't be used for the parent map) unless it's going away entirely - it's supposed to traverse the whole AST. > Refactoring is underway to extract a generic traverser from ASTDumper. Then > the parent/child traversal of ASTMatchFinder can be implemented in terms of > it without any of these kinds of problems. That sounds interesting (though it's not obvious to me why ASTDumper's traversal is inherently less prone to these issues than RecursiveASTVisitor). I'm not inclined to hold off fixing this bug though, because: - it's blocking other patches, and the changes you're talking about seem likely to be quite involved and need some details worked out - if we are going to switch from the RAV parent map to an ASTDumper-traverser-derived map, then the closer that switch is to a no-op, the easier it will be to land. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56444/new/ https://reviews.llvm.org/D56444 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
