[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

mikael marked 3 inline comments as done. mikael added inline comments. Comment at: lib/AST/Type.cpp:2950 + FunctionTypeBits.HasExtQuals = 0; + } } rjmccall wrote: > The indentation here is messed up. > > You seem to be mixing up "fast qualifiers" with "CVR q

[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

kristina added a comment. Personally I'm against this type of warning as it's likely anyone using `-mllvm` is actually intending to adjust certain behaviors across one or more passes with a lot of switches supported by it being intentionally hidden from ` --help` output requiring explicitly spe

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

romanovvlad added a comment. I'm getting the same IR for both examples you provided. And for both load of X value is aligned on 4 bytes wo patch and on 1 byte with. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55262/new/ https://reviews.llvm.org/D55262 _

[clang-tools-extra] r348467 - [clangd] Fix a typo in TUSchedulerTests

Author: hokein Date: Thu Dec 6 00:55:24 2018 New Revision: 348467 URL: http://llvm.org/viewvc/llvm-project?rev=348467&view=rev Log: [clangd] Fix a typo in TUSchedulerTests Reviewers: ilya-biryukov Reviewed By: ilya-biryukov Subscribers: javed.absar, ioeric, MaskRay, jkorous, arphaman, kadircet

[PATCH] D55312: [clangd] Fix a typo in TUSchedulerTests

This revision was automatically updated to reflect the committed changes. Closed by commit rL348467: [clangd] Fix a typo in TUSchedulerTests (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

r348469 - Make test resistant to line numbers changing

Author: steveire Date: Thu Dec 6 01:22:12 2018 New Revision: 348469 URL: http://llvm.org/viewvc/llvm-project?rev=348469&view=rev Log: Make test resistant to line numbers changing Modified: cfe/trunk/test/AST/dump.cpp Modified: cfe/trunk/test/AST/dump.cpp URL: http://llvm.org/viewvc/llvm-pr

[PATCH] D54796: [clangd] C++ API for emitting file status

hokein updated this revision to Diff 176936. hokein marked 8 inline comments as done. hokein added a comment. Address comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54796/new/ https://reviews.llvm.org/D54796 Files: clangd/ClangdServer.cp

r348471 - Add test for ObjC generics

Author: steveire Date: Thu Dec 6 01:23:59 2018 New Revision: 348471 URL: http://llvm.org/viewvc/llvm-project?rev=348471&view=rev Log: Add test for ObjC generics Modified: cfe/trunk/test/AST/ast-dump-decl.m Modified: cfe/trunk/test/AST/ast-dump-decl.m URL: http://llvm.org/viewvc/llvm-projec

r348470 - Extend OMP test

Author: steveire Date: Thu Dec 6 01:23:53 2018 New Revision: 348470 URL: http://llvm.org/viewvc/llvm-project?rev=348470&view=rev Log: Extend OMP test Modified: cfe/trunk/test/AST/dump.cpp Modified: cfe/trunk/test/AST/dump.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/AST/dump

[PATCH] D54796: [clangd] C++ API for emitting file status

hokein added inline comments. Comment at: clangd/TUScheduler.cpp:268 + /// Status of the TU. + TUStatus Status; /* GUARDED_BY(DiagMu) */ }; ilya-biryukov wrote: > hokein wrote: > > ilya-biryukov wrote: > > > hokein wrote: > > > > ilya-biryukov wrote: > > > > >

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

glaubitz added a comment. I have applied this patch to the llvm-toolchain-7 package in Debian and did not see any regressions on x86_64 or 32-Bit PowerPC. Additionally, I have included the patches from https://reviews.llvm.org/D54409 and https://reviews.llvm.org/D54583 saw no regressions on x86

Re: r348471 - Add test for ObjC generics

Can you please write better commit messages, especially the first subject line? E.g. this should have been "[AST][NFC] Add dump test for ObjC generics" On Thu, Dec 6, 2018 at 12:26 PM Stephen Kelly via cfe-commits wrote: > > Author: steveire > Date: Thu Dec 6 01:23:59 2018 > New Revision: 348471

r348473 - Diagnose friend function template redefinitions.

Author: sepavloff Date: Thu Dec 6 01:35:04 2018 New Revision: 348473 URL: http://llvm.org/viewvc/llvm-project?rev=348473&view=rev Log: Diagnose friend function template redefinitions. Friend function template defined in a class template becomes available if the enclosing class template is instan

[PATCH] D21508: Diagnose friend function template redefinitions

This revision was automatically updated to reflect the committed changes. Closed by commit rL348473: Diagnose friend function template redefinitions. (authored by sepavloff, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D21508?vs=1767

[clang-tools-extra] r348475 - [clangd] C++ API for emitting file status.

Author: hokein Date: Thu Dec 6 01:41:04 2018 New Revision: 348475 URL: http://llvm.org/viewvc/llvm-project?rev=348475&view=rev Log: [clangd] C++ API for emitting file status. Introduce clangd C++ API to emit the current status of file. Modified: clang-tools-extra/trunk/clangd/ClangdServer.c

[PATCH] D55358: [ASTImporter] Fix import of NestedNameSpecifierLoc.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, martong, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Import type location in case of TypeSpec and TypeSpecWithTemplate. Without this fix the imported NespedNameSpecifierLoc

[PATCH] D55331: [CodeComplete] Fix assertion failure

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55331/new/ https://reviews.llvm.org/D55331 ___ cfe-commit

[PATCH] D54796: [clangd] C++ API for emitting file status

hokein added a comment. Forgot to associate this patch to the actual commit, committed in rL348475 . Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54796/new/ https://reviews.llvm.org/D54796

[clang-tools-extra] r348478 - [clangd] Update the test code

Author: hokein Date: Thu Dec 6 02:22:48 2018 New Revision: 348478 URL: http://llvm.org/viewvc/llvm-project?rev=348478&view=rev Log: [clangd] Update the test code I forgot to update it in the last round of code review. Modified: clang-tools-extra/trunk/unittests/clangd/TUSchedulerTests.cpp

[PATCH] D53866: [Preamble] Stop generating preamble for circular #includes

nik marked 2 inline comments as done and an inline comment as not done. nik added inline comments. Comment at: include/clang/Lex/Preprocessor.h:391 } PreambleConditionalStack; + bool PreambleGenerationFailed = false; ilya-biryukov wrote: > nik wrote: > > il

[PATCH] D53866: [Preamble] Stop generating preamble for circular #includes

nik updated this revision to Diff 176941. nik added a comment. Added a dedicated diagnostic. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53866/new/ https://reviews.llvm.org/D53866 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Lex/Preproces

[PATCH] D55359: [clangd] Avoid emitting Queued status when we are able to acquire the Barrier.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, javed.absar. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D55359 Files: clangd/TUScheduler.cpp clangd/Threading.cpp clangd/Threadi

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

mikael updated this revision to Diff 176943. mikael added a comment. - Added FIXME's. - Fixed the latest comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54862/new/ https://reviews.llvm.org/D54862 Files: include/clang/AST/CanonicalType.h include/clang/AST/DeclCXX.h include

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

mikael marked an inline comment as done and an inline comment as not done. mikael added inline comments. Comment at: lib/AST/Type.cpp:2950 + FunctionTypeBits.HasExtQuals = 0; + } } mikael wrote: > rjmccall wrote: > > The indentation here is messed up. > > >

[PATCH] D55363: [clangd] Expose FileStatus in LSP.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, javed.absar. Add an LSP extension "textDocument/fileStatus" to emit file-status information. Repository: rCTE Clang Tools Extra https://reviews.llvm.o

Re: r348469 - Make test resistant to line numbers changing

On Thu, Dec 6, 2018 at 4:25 AM Stephen Kelly via cfe-commits wrote: > > Author: steveire > Date: Thu Dec 6 01:22:12 2018 > New Revision: 348469 > > URL: http://llvm.org/viewvc/llvm-project?rev=348469&view=rev > Log: > Make test resistant to line numbers changing I would prefer to see the line nu

Re: r348471 - Add test for ObjC generics

On Thu, Dec 6, 2018 at 4:26 AM Stephen Kelly via cfe-commits wrote: > > Author: steveire > Date: Thu Dec 6 01:23:59 2018 > New Revision: 348471 > > URL: http://llvm.org/viewvc/llvm-project?rev=348471&view=rev > Log: > Add test for ObjC generics > > Modified: > cfe/trunk/test/AST/ast-dump-decl

[PATCH] D54565: Introduce `-Wc++14-compat-ctad` as a subgroup of `-Wc++14-compat`

Quuxplusone updated this revision to Diff 176955. Quuxplusone added a comment. Rename `-Wc++14-compat-ctad` to just `-Wctad`, per @rsmith's comment to "move this out of `-Wc++14-compat`." @rsmith ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54565/new/ ht

[PATCH] D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields

Szelethus planned changes to this revision. Szelethus added a comment. Let's try that again then! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51866/new/ https://reviews.llvm.org/D51866 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

aaron.ballman added inline comments. Comment at: include/clang/AST/TextNodeDumper.h:28 const comments::FullComment *> { + TextTreeStructure &TreeStructure; raw_ostream &OS; This makes me a bit wary because you creat

[PATCH] D55212: Handle alloc_size attribute on function pointers

arichardson marked an inline comment as done. arichardson added inline comments. Comment at: include/clang/Basic/Attr.td:1072 def AllocSize : InheritableAttr { let Spellings = [GCC<"alloc_size">]; + let Subjects = SubjectList<[HasFunctionProto]>; aaron.ballm

[PATCH] D55338: NFC: Move VisitStmt code to dumpStmt

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55338/new/ https://reviews.llvm.org/D55338 ___

[PATCH] D55190: Move dump of individual comment nodes to NodeDumper

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55190/new/ https://reviews.llvm.org/D55190 ___

[PATCH] D55339: NFC: Move VisitExpr code to dumpStmt

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a small nit. Comment at: lib/AST/ASTDumper.cpp:1698 +if (auto *E = dyn_cast(S)) { + NodeDumper.dumpType(E->getType()); --

[PATCH] D55346: [clang-tidy] check for using declaration scope and qualification

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Could you send each check in a separate patch, please? This makes the review much more straightforward and I'm sure it will be faster too. Repository: rCTE Clang Tools Extra CHAN

[PATCH] D55346: [clang-tidy] check for using declaration scope and qualification

alexfh added inline comments. Comment at: clang-tidy/abseil/AbseilTidyModule.cpp:25 #include "StrCatAppendCheck.h" Please upload the patch with full context. See https://llvm.org/docs/Phabricator.html Repository: rCTE Clang Tools Extra CHANGES SINCE LAST

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

alexfh added a comment. In D54945#1318343 , @MarinaKalashina wrote: > @alexfh Thanks a lot for your patience and help. I've made another revision, > now with the diff made by 'git show HEAD -U99' to have the full context > availlable. I don't know

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

alexfh added a comment. In D54945#1321301 , @alexfh wrote: > In D54945#1318343 , @MarinaKalashina > wrote: > > > @alexfh Thanks a lot for your patience and help. I've made another > > revision, now with the diff m

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik updated this revision to Diff 176962. nik marked an inline comment as done. nik added a comment. Addressed comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005 Files: include/clang/Frontend/ASTUnit.h lib/Fron

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik marked 4 inline comments as done. nik added inline comments. Comment at: include/clang/Frontend/ASTUnit.h:581 + unsigned getPreambleCounter() const { return PreambleCounter; } + ilya-biryukov wrote: > NIT: `getPreambleCounterForTests()`? This is clearly an

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

ilya-biryukov added a comment. Maybe try to use Arcanist for uploading diffs? The web interface can be confusing at times, Arcanist is more reliable (LLVM docs have pointers to the Arcanist documentation to get st

[PATCH] D55340: NFC: Move dump of individual Stmts to TextNodeDumper

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some small nits. Comment at: lib/AST/TextNodeDumper.cpp:685 +void TextNodeDumper::VisitObjCSelectorExpr(const ObjCSelectorExpr *Node) { + + OS

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. In D54401#1320772 , @Szelethus wrote: > In D54401#1318282 , @alexfh wrote: > > > In D54401#1315354

[clang-tools-extra] r348490 - [clangd] Remove the test that sometimes deadlocks

Author: ibiryukov Date: Thu Dec 6 07:14:11 2018 New Revision: 348490 URL: http://llvm.org/viewvc/llvm-project?rev=348490&view=rev Log: [clangd] Remove the test that sometimes deadlocks Will figure out how to properly rewrite it and recommit. Modified: clang-tools-extra/trunk/unittests/clang

[PATCH] D55371: Fix thunks returning memptrs via sret by emitting also scalar return values directly in sret slot (PR39901)

hans edited subscribers, added: cfe-commits; removed: llvm-commits. hans added a comment. -llvm-commits +cfe-commits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55371/new/ https://reviews.llvm.org/D55371 ___ cfe-commits mailing list cfe-c

r348492 - [OPENMP][NVPTX] Fix globalization of the mapped array sections.

Author: abataev Date: Thu Dec 6 07:35:13 2018 New Revision: 348492 URL: http://llvm.org/viewvc/llvm-project?rev=348492&view=rev Log: [OPENMP][NVPTX] Fix globalization of the mapped array sections. If the array section is based on pointer and this sections is mapped in target region + then it is

[PATCH] D55280: [CTU] Make loadExternalAST return with non nullptr on success

martong added a comment. Hi Aleksey, The first version was indeed not correct. But, I think we handle that case with the latest update (https://reviews.llvm.org/differential/diff/176779/). In `loadExternalAST()` we have this right before the return: if (!Unit) return llvm::make_error(

[PATCH] D55212: Handle alloc_size attribute on function pointers

aaron.ballman added a comment. I think all that's missing are some C++ tests and some nits. Comment at: include/clang/Basic/Attr.td:1072 def AllocSize : InheritableAttr { let Spellings = [GCC<"alloc_size">]; + let Subjects = SubjectList<[HasFunctionProto]>; ---

[PATCH] D49890: Clang-Tidy Export Problem

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. In D49890#1200061 , @TheAhmad wrote: > In D49890#1182556 , @alexfh wrote: > > > Could you describe th

[PATCH] D55374: [clangd] Show FileStatus in vscode-clangd.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. The file status will be shown in the status bar. Depends on D55363 . Repository: rCTE Clang Tools Extra https://review

[PATCH] D55363: [clangd] Expose FileStatus in LSP.

hokein updated this revision to Diff 176983. hokein added a comment. Update. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55363/new/ https://reviews.llvm.org/D55363 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/Protocol.c

[PATCH] D48116: [libclang] Allow skipping warnings from all included files

nik added a comment. Herald added a subscriber: arphaman. In D48116#1144732 , @ilya-biryukov wrote: > Have you considered doing the same filtering in ASTUnit's > `StoredDiagnosticConsumer`? It should not be more difficult and allows to > avoid changing

[PATCH] D55289: [analyzer] MoveChecker Pt.5: Improve invalidation policies.

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:528 ArrayRef ExplicitRegions, ArrayRef Regions, const LocationContext *LCtx, const CallEvent *Call) const { NoQ wro

[PATCH] D51554: [CUDA][OPENMP][NVPTX]Improve logic of the debug info support.

ABataev marked 4 inline comments as done. ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:282-285 enum DebugInfoKind { - NoDebug, /// No debug info. - LineTableOnly, /// Line tables only. - FullDebug /// Full debug info. + NoDebug,

[PATCH] D51554: [CUDA][OPENMP][NVPTX]Improve logic of the debug info support.

ABataev updated this revision to Diff 176993. ABataev marked an inline comment as done. ABataev added a comment. Reworked according to the latest comments from Eric. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51554/new/ https://reviews.llvm.org/D51554 Files:

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

aaron.ballman added inline comments. Comment at: test/PCH/cxx-static_assert.cpp:17 -// expected-error@12 {{static_assert failed "N is not 2!"}} +// expected-error@12 {{static_assert failed due to requirement '1 == 2' "N is not 2!"}} T<1> t1; // expected-note {{in instantiatio

[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

jyknight added a comment. In D55150#1321046 , @kristina wrote: > Personally I'm against this type of warning as it's likely anyone using > `-mllvm` is actually intending to adjust certain behaviors across one or more > passes with a lot of switches suppo

[PATCH] D55269: [CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55269/new/ https://reviews.llvm.org/D55269 ___ cfe-commits mailing list cfe-commits@lists.

r348504 - [CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu

Author: jdenny Date: Thu Dec 6 09:46:17 2018 New Revision: 348504 URL: http://llvm.org/viewvc/llvm-project?rev=348504&view=rev Log: [CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu This just extends D40453 (r319317) to Ubuntu. Reviewed By: Hahnfeld, tra Differential Revision: https://reviews

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/TextNodeDumper.h:28 const comments::FullComment *> { + TextTreeStructure &TreeStructure; raw_ostream &OS; aaro

[PATCH] D55269: [CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu

This revision was automatically updated to reflect the committed changes. Closed by commit rL348504: [CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu (authored by jdenny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55269?vs=17691

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong added a comment. Hey Alexey, Here is what I found so far: The new assertion is this: Assertion failed: (ToRD == ToD->getDeclContext() && ToRD->containsDecl(ToD)), function ImportDeclContext ToRD looks like this in code: typedef struct __sFILE { // several fields here ... }

[PATCH] D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions

Szelethus updated this revision to Diff 177002. Szelethus marked 32 inline comments as done. Szelethus added a reviewer: MTC. Szelethus added a comment. Addressing inline comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54823/new/ https://reviews.llvm.org/D54823 Files: lib/Sta

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

rjmccall added a comment. In D55262#1321048 , @romanovvlad wrote: > I'm getting the same IR for both examples you provided. And for both load of > X value is aligned on 4 bytes wo patch and on 1 byte with. That's odd, because the natural type alignment

[PATCH] D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1087 if (FD->getKind() == Decl::Function) { -initIdentifierInfo(C.getASTContext()); +MemFunctionInfo.initIdentifierInfo(C.getASTContext()); IdentifierInfo *FunI = FD->getIde

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

romanovvlad added a comment. Yes it's 1, but after addrspacecast alignment becomes not struct A but alignment of the pointer CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55262/new/ https://reviews.llvm.org/D55262 ___ cfe-commits mailing l

[PATCH] D55269: [CUDA] Fix nvidia-cuda-toolkit detection on Ubuntu

jdenny added a comment. In D55269#1320382 , @tra wrote: > >> Let's start with fixing OpenMP's cmake files. Once it no longer insists on > >> specifying --cuda-path=/usr, and isUbuntu is in place, what is the > >> remaining failure that you see? > > > >

[PATCH] D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:1087 if (FD->getKind() == Decl::Function) { -initIdentifierInfo(C.getASTContext()); +MemFunctionInfo.initIdentifierInfo(C.getASTContex

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, but you can probably undo one of my requests. :) Comment at: lib/AST/Type.cpp:2950 + FunctionTypeBits.HasExtQuals = 0; + } } mikael wrote: > mi

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

rjmccall added a comment. In D55262#1321641 , @romanovvlad wrote: > Yes it's 1, but after addrspacecast alignment becomes not struct A but > alignment of the pointer Oh! Yes, that's even more broken than I thought. Comment at: lib/C

[PATCH] D55371: Fix thunks returning memptrs via sret by emitting also scalar return values directly in sret slot (PR39901)

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. That seems reasonable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55371/new/ https://reviews.llvm.org/D55371 ___ cfe-commits mail

[PATCH] D42682: [clang-tidy] Add io-functions-misused checker

aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/IoFunctionsCheck.cpp:32 +has(cxxMemberCallExpr( +on(hasType(namedDecl(hasAnyName("istream", +callee(cxxMethodDecl(hasName("get")).bind("DeclOfGet")

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

romanovvlad added a comment. Backtrace: F7656050: stack CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55262/new/ https://reviews.llvm.org/D55262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

rjmccall added a comment. Sorry. Can you post the result of passing `-ast-dump` instead of `-emit-llvm` to the compiler? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55262/new/ https://reviews.llvm.org/D55262 ___ cfe-commits mailing list

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

kadircet updated this revision to Diff 177005. kadircet added a comment. - Fix a few problems that come up in the field test. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55224/new/ https://reviews.llvm.org/D55224 Files: clangd/SourceCode.cpp

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

rjmccall added a comment. In D55262#1321682 , @rjmccall wrote: > Sorry. Can you post the result of passing `-ast-dump` instead of > `-emit-llvm` to the compiler? Actually, nevermind, I don't need that. If you can fix the address-space issue I pointed

[PATCH] D55377: Allow forwarding -fdebug-compilation-dir to cc1as

thakis created this revision. thakis added a reviewer: rnk. The flag -fdebug-compilation-dir is useful to make generated .o files independent of the path of the build directory, without making the compile command-line dependent on the path of the build directory, like -fdebug-prefix-map require

[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

kristina added a comment. > There is a cost to having people encode these flags into their build systems > -- it can then cause issues if we ever change these internal flags. I do not > think any Clang maintainer intends to support these as stable APIs, unlike > most of the driver command-line.

[PATCH] D55315: [clangd] Only reduce priority of a thread for indexing.

kadircet updated this revision to Diff 177007. kadircet marked 2 inline comments as done. kadircet added a comment. - Delete redundant comment Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55315/new/ https://reviews.llvm.org/D55315 Files: clangd/

[PATCH] D55315: [clangd] Only reduce priority of a thread for indexing.

kadircet added inline comments. Comment at: clangd/index/Background.cpp:202 std::lock_guard Lock(QueueMu); -Queue.push_back(std::move(T)); +if (Priority == ThreadPriority::Low) { + Queue.push_back(Bind( ilya-biryukov wrote: > Since we might be i

r348513 - Reapply "Avoid emitting redundant or unusable directories in DIFile metadata entries.""

Author: adrian Date: Thu Dec 6 10:44:50 2018 New Revision: 348513 URL: http://llvm.org/viewvc/llvm-project?rev=348513&view=rev Log: Reapply "Avoid emitting redundant or unusable directories in DIFile metadata entries."" This reverts commit r348280 and reapplies D55085 without modifications. Or

[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

jyknight added a comment. In D55150#1321705 , @kristina wrote: > > There is a cost to having people encode these flags into their build > > systems -- it can then cause issues if we ever change these internal flags. > > I do not think any Clang maintaine

[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

aaron.ballman added inline comments. Comment at: clang/docs/UsersManual.rst:3137 -W Enable the specified warning - -XclangPass to the clang compiler + -XclangPass to the clang cc1 frontend. For experimental use only. -

[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

thakis added a comment. I don't have an opinion on this patch (if you force me to have one, I'm weakly in favor), but I agree with the general sentiment. When I told people to not use mllvm and Xclang before, they told me "but if I'm not supposed to use them, why are they advertised in --help"?

[PATCH] D55377: Allow forwarding -fdebug-compilation-dir to cc1as

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55377/new/ https://reviews.llvm.org/D55377 ___ cfe-commits mailing list cfe-commits@lists

r348515 - Allow forwarding -fdebug-compilation-dir to cc1as

Author: nico Date: Thu Dec 6 10:50:39 2018 New Revision: 348515 URL: http://llvm.org/viewvc/llvm-project?rev=348515&view=rev Log: Allow forwarding -fdebug-compilation-dir to cc1as The flag -fdebug-compilation-dir is useful to make generated .o files independent of the path of the build directory

[PATCH] D55262: [OpenCL] Fix for TBAA information of pointer after addresspacecast

romanovvlad updated this revision to Diff 177012. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55262/new/ https://reviews.llvm.org/D55262 Files: lib/CodeGen/CGExpr.cpp test/CodeGenOpenCLCXX/address-space-deduction2.cl Index: test/CodeGenOpenCLCXX/address-space-deduction2.cl ==

[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

thakis added a comment. Oh hey, the patch does that already! Ignore me, then :-) That part is probably less controversial, maybe you want to land that while the warning part is being discussed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55150/new/ https://reviews.llvm.org/D55150

[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

arsenm added a comment. I don't really see the point of this and think it will just be an inconvenience to llvm developers. Another use case we have for using these in a build system is for the builtin library shipped with the compiler CHANGES SINCE LAST ACTION https://reviews.llvm.org/D551

[PATCH] D55377: Allow forwarding -fdebug-compilation-dir to cc1as

This revision was automatically updated to reflect the committed changes. Closed by commit rL348515: Allow forwarding -fdebug-compilation-dir to cc1as (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55377?vs=177004&i

[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

erichkeane added a comment. I'm in favor of at least the documentation changes, though I'd like to see them use stronger language. I'm fairly in favor of the warning itself since its easy enough to disable (with the -Wno flag), so I don't terribly understand those against it. CHANGES SINCE L

[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

george.karpenkov added reviewers: dcoughlin, NoQ. george.karpenkov requested changes to this revision. george.karpenkov added a comment. Using `-Xclang` is the only way to pass options to the static analyzer, I don't think we should warn on it. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus added a comment. Thanks! I'll commit in a couple days to give some breathing room for anyone who'd object. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54401/new/ https://reviews.llvm.org/D54401 ___ cfe-commits mailing list cfe-

[PATCH] D52956: Support `-fno-visibility-inlines-hidden`

rsmith added a comment. Is this change blocked on something? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52956/new/ https://reviews.llvm.org/D52956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

arphaman requested changes to this revision. arphaman added a comment. Swift uses `-Xclang` to pass in build settings to its own build and to pass in custom options through its Clang importer that we intentionally don't want to expose to Clang's users. We don't want to warn for those uses for su

[PATCH] D55378: [compiler-rt] [test] Add missing cmake include for building libFuzzer alone

mgorny created this revision. mgorny added reviewers: phosek, george.karpenkov. Herald added subscribers: Sanitizers, llvm-commits, dberris. Include CompilerRTCompile in fuzzer tests explicitly. Otherwise, when building only libFuzzer, CMake fails due to: CMake Error at cmake/Modules/AddCompil

[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

kristina added a comment. In D55150#1321734 , @thakis wrote: > I don't have an opinion on this patch (if you force me to have one, I'm > weakly in favor), but I agree with the general sentiment. When I told people > to not use mllvm and Xclang before, th

[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

jyknight added a comment. In D55150#1321759 , @george.karpenkov wrote: > Using `-Xclang` is the only way to pass options to the static analyzer, I > don't think we should warn on it. Well,, that seems unfortunate if we have the only supported interface

[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

efriedma added a comment. I'm not sure that putting a warning that can be disabled really helps here; anyone who needs the option will just disable the warning anyway, and then users adding additional options somewhere else in the build system will miss the warning. Instead, it would probably

[PATCH] D55150: Emit warnings from the driver for use of -mllvm or -Xclang options.

george.karpenkov added a comment. > Well,, that seems unfortunate if we have the only supported interface for the > static analyzer be an internal interface. Perhaps it can be given a different > option? Even discounting this change, I that seems like it would be > appropriate. Officially ther

  1   2   >