nik marked 4 inline comments as done. nik added inline comments.
================ Comment at: include/clang/Frontend/ASTUnit.h:581 + unsigned getPreambleCounter() const { return PreambleCounter; } + ---------------- ilya-biryukov wrote: > NIT: `getPreambleCounterForTests()`? This is clearly an internal detail, > would try giving it a name that discourages using it outside the testing code. Done. Side note: I hardly see something like this used in clang, but I agree that it's good. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41005/new/ https://reviews.llvm.org/D41005 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits