[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

yvvan added a comment. According to https://msdn.microsoft.com/en-us/2e9c3174-af48-4fa3-9f6a-fb62b23ed994 - "Unmapping a mapped view of a file invalidates the range occupied by the view in the address space of the process and makes the range available for other allocations". Also as far as i u

Re: r347720 - [RISCV] Mark unit tests as "requires: riscv-registered-target"

On Tue, 27 Nov 2018 at 22:56, Mandeep Singh Grang via cfe-commits wrote: > > Author: mgrang > Date: Tue Nov 27 14:53:57 2018 > New Revision: 347720 > > URL: http://llvm.org/viewvc/llvm-project?rev=347720&view=rev > Log: > [RISCV] Mark unit tests as "requires: riscv-registered-target" > > Some of t

[PATCH] D55051: [Analyzer] [HOTFIX!] SValBuilder crash when `aggressive-binary-operation-simplification` enabled

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, xazax.hun. baloghadamsoftware added a project: clang. Herald added subscribers: donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a reviewer: george.karpenkov. During the review of D41938

[PATCH] D55021: Mark __builtin_shufflevector as using custom type checking

Anastasia accepted this revision. Anastasia added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55021/new/ https://reviews.llvm.org/D55021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

peter.smith added a comment. Yes this is fine. The effects are entirely within the Android target. The change in LLD to a 64k page size was made in D25079 . The main reason given was that a sufficient number of linux distributions including Redhat had chosen a 6

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

kadircet updated this revision to Diff 175831. kadircet marked 17 inline comments as done. kadircet added a comment. - Address comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54999/new/ https://reviews.llvm.org/D54999 Files: clangd/Header

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

kadircet added inline comments. Comment at: unittests/clangd/IndexActionTests.cpp:28 +std::string PathToURI(llvm::StringRef Path) { + return URI::create(Path).toString(); +} ilya-biryukov wrote: > Maybe inline this? This looks simple enough. yeah but repeating a

[PATCH] D55022: OpenCL: Extend argument promotion rules to vector types

Anastasia added a comment. > The spec is ambiguous on whether vector types are allowed to be > implicitly converted. The only legal context I think this can > be used for OpenCL is printf, where it seems necessary. s6.2.1, seems to say "Implicit conversions between built-in vector data types a

[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

lebedev.ri added a comment. Passing-by thought, feel free to ignore: this seems to so far only affect windows only? So the fix shouldn't probably pessimize all other arches? (and maybe even non-clangd) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54995/new/ https://reviews.llvm.org/D

[PATCH] D55006: [clang] - Simplify tools::SplitDebugName

grimar updated this revision to Diff 175843. grimar added a comment. - Added the test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55006/new/ https://reviews.llvm.org/D55006 Files: lib/Driver/ToolChains/Clang.cpp lib/Driver/ToolChains/CommonArgs.cpp lib/Driver/ToolChains/C

[PATCH] D55023: OpenCL: Improve vector printf warnings

Anastasia added inline comments. Comment at: test/SemaOpenCL/format-strings-fixit.cl:13 +void vector_fixits() { +// printf("%f", (int) 123); + printf("%v4f", (int4) 123); Does this not work yet? Comment at: test/SemaOpenCL/printf-format-strin

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

hwright marked 4 inline comments as done. hwright added inline comments. Comment at: clang-tidy/abseil/DurationFactoryFloatCheck.cpp:61 + + if (SimpleArg) { diag(MatchedCall->getBeginLoc(), JonasToth wrote: > hwright wrote: > > JonasToth wrote: > > > hwrigh

[PATCH] D55051: [Analyzer] [HOTFIX!] SValBuilder crash when `aggressive-binary-operation-simplification` enabled

Szelethus added a comment. Have you seen a crash resulting from this? Is supplying a test case feasable? I know that some of these errors are extremely hard to reproduce. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55051/new/ https://reviews.llvm.org/D55051

[PATCH] D55051: [Analyzer] [HOTFIX!] SValBuilder crash when `aggressive-binary-operation-simplification` enabled

baloghadamsoftware added a comment. In D55051#1312660 , @Szelethus wrote: > Have you seen a crash resulting from this? Is supplying a test case feasable? > I know that some of these errors are extremely hard to reproduce. > > Edit: Nevertheless, looks goo

[clang-tools-extra] r347860 - Adding a FIXME test to document an area for improvement with the cert-err58-cpp check; NFC.

Author: aaronballman Date: Thu Nov 29 04:45:50 2018 New Revision: 347860 URL: http://llvm.org/viewvc/llvm-project?rev=347860&view=rev Log: Adding a FIXME test to document an area for improvement with the cert-err58-cpp check; NFC. Modified: clang-tools-extra/trunk/test/clang-tidy/cert-static

[PATCH] D55051: [Analyzer] [HOTFIX!] SValBuilder crash when `aggressive-binary-operation-simplification` enabled

Szelethus added a comment. In D55051#1312666 , @baloghadamsoftware wrote: > In D55051#1312660 , @Szelethus wrote: > > > Have you seen a crash resulting from this? Is supplying a test case > > feasable? I know that

[PATCH] D52835: [Diagnostics] Check integer to floating point number implicit conversions

aaron.ballman added inline comments. Comment at: test/CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp:136 Agg f8 = {EnumVal}; // OK + // expected-warning@+1 {{implicit conversion from 'int' to 'float' changes value from 123456789 to 1.2345679E+8}} Agg f9 = {123456789}; //

[PATCH] D53764: [OpenCL] Enable address spaces for references in C++

romanovvlad added inline comments. Comment at: cfe/trunk/lib/CodeGen/CGExpr.cpp:4268 +DestTy.getAddressSpace(), ConvertType(DestTy)); +return MakeNaturalAlignPointeeAddrLValue(V, DestTy); + } Hi, It seems this code doesn't work correctly(repro at th

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet updated this revision to Diff 175855. courbet marked 5 inline comments as done. courbet added a comment. - add more tests - handle c++17 constructs - add c++17 tests in static-assert-cxx17.cpp Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet added a comment. Thanks Comment at: lib/Sema/SemaTemplate.cpp:3064 +// If this is a qualified name, expand the template arguments in nested +// qualifiers. +DR->getQualifier()->print(OS, PrintPolicy, true); Quuxplusone wrote: > I don't under

[PATCH] D54796: [clangd] C++ API for emitting file status

hokein updated this revision to Diff 175859. hokein marked 10 inline comments as done. hokein added a comment. - address review comments - drop the LSP change, only focus on TUScheduler in this patch Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5479

[PATCH] D55052: Fix junk output in clangd vscode plugin

jfindley created this revision. jfindley added a reviewer: ioeric. jfindley added a project: clang-tools-extra. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. When using the vscode clangd plugin, lots and lots of junk output is printed to the output w

[PATCH] D54796: [clangd] C++ API for emitting file status

hokein added a comment. @ilya-biryukov, I hope the current patch is not too big for you to review, happy to chat offline if you want (sam and I had a lot of discussions before he is OOO). Comment at: clangd/ClangdLSPServer.cpp:787 +void ClangdLSPServer::onFileUpdated(const Fi

r347863 - Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger

Author: teemperor Date: Thu Nov 29 05:50:30 2018 New Revision: 347863 URL: http://llvm.org/viewvc/llvm-project?rev=347863&view=rev Log: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger Summary: `MustBuildLookupTable` must always be called on a primary context as we otherwise trigg

[PATCH] D54898: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger

This revision was automatically updated to reflect the committed changes. Closed by commit rL347863: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

aaron.ballman added inline comments. Comment at: clang-tidy/utils/FixItHintUtils.cpp:35 +static bool isValueType(QualType QT) { return isValueType(QT.getTypePtr()); } +static bool isArrayType(QualType QT) { return isa(QT.getTypePtr()); } +static bool isReferenceType(QualType QT)

[PATCH] Add myself as code owner for OpenBSD driver

Add myself as code owner for OpenBSD driver. Index: CODE_OWNERS.TXT === --- CODE_OWNERS.TXT (revision 347715) +++ CODE_OWNERS.TXT (working copy) @@ -49,6 +49,10 @@ E: rjmcc...@apple.com D: Clang LLVM IR generation +N: Bra

[PATCH] D55052: Fix junk output in clangd vscode plugin

ioeric added a comment. Thanks for the patch James! Adding folks who are currently using vscode+clangd to get more opinions. Comment at: clangd/clients/clangd-vscode/src/extension.ts:59 +// Avoid lots of junk in output +revealOutputChannelOn: vscodelc.RevealOut

[PATCH] D54918: Apply clang-format to GenericTaintChecker.cpp

boga95 added a comment. If you find it ok, can you please commit it? @xazax.hun Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54918/new/ https://reviews.llvm.org/D54918 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D55052: Fix junk output in clangd vscode plugin

jfindley marked an inline comment as done. jfindley added inline comments. Comment at: clangd/clients/clangd-vscode/src/extension.ts:59 +// Avoid lots of junk in output +revealOutputChannelOn: vscodelc.RevealOutputChannelOn.Never }; ioeric wr

r347865 - [OpenCL] Improve diags for addr spaces in templates

Author: stulova Date: Thu Nov 29 06:11:15 2018 New Revision: 347865 URL: http://llvm.org/viewvc/llvm-project?rev=347865&view=rev Log: [OpenCL] Improve diags for addr spaces in templates Fix ICEs on template instantiations that were leading to the creation of invalid code patterns with address spa

[PATCH] D54858: [OpenCL] Improve diagnostics for address spaces in template instantiation

This revision was automatically updated to reflect the committed changes. Closed by commit rL347865: [OpenCL] Improve diags for addr spaces in templates (authored by stulova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54858?vs=175

[PATCH] D55052: Fix junk output in clangd vscode plugin

hokein added a comment. @jfindley I'd like to understand how do these log messages noise you? Does the window prompt up to you automatically (this only happens when there is an error in clangd)? These messages only get print to the `clangd-vscode` output panel which is used for debugging purpo

[PATCH] D55052: Fix junk output in clangd vscode plugin

ilya-biryukov added a comment. +1 to the change, this is annoying for me too. In D55052#1312753 , @hokein wrote: > @jfindley I'd like to understand how do these log messages noise you? Does > the window prompt up to you automatically (this only happens w

[PATCH] D54952: [clangd] DO NOT SUBMIT. Draft interfaces for build system integration.

klimek added inline comments. Comment at: clangd/BuildSystem.h:29 +/// Default compilation database used by clangd, based on the build system. +class Integration : public GlobalCompilationDatabase { +public: ilya-biryukov wrote: > klimek wrote: > > 'Integration'

[PATCH] D55052: Fix junk output in clangd vscode plugin

ilya-biryukov added inline comments. Comment at: clangd/clients/clangd-vscode/src/extension.ts:58 +}, +// Avoid lots of junk in output +revealOutputChannelOn: vscodelc.RevealOutputChannelOn.Never Could we rephrase this? Something like `//

[PATCH] D55052: Fix junk output in clangd vscode plugin

ilya-biryukov added inline comments. Comment at: clangd/clients/clangd-vscode/src/extension.ts:58 +}, +// Avoid lots of junk in output +revealOutputChannelOn: vscodelc.RevealOutputChannelOn.Never ilya-biryukov wrote: > Could we rephrase th

[PATCH] D55052: Fix junk output in clangd vscode plugin

hokein added a comment. In D55052#1312760 , @ilya-biryukov wrote: > +1 to the change, this is annoying for me too. > > In D55052#1312753 , @hokein wrote: > > > @jfindley I'd like to understand how do these log mess

[PATCH] D53818: [ASTImporter] Changed use of Import to Import_New in ASTImporter.

balazske reopened this revision. balazske added a comment. This revision is now accepted and ready to land. Reopening to fix failing lldb tests. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53818/new/ https://reviews.llvm.org/D53818 ___

[PATCH] D55049: Changed every use of ASTImporter::Import to Import_New

balazske updated this revision to Diff 175864. balazske added a comment. - Changed some missing Import calls. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55049/new/ https://reviews.llvm.org/D55049 Files: lib/AST/ASTImporter.cpp lib/AST/ExternalASTMerger.cp

[PATCH] D55052: Fix junk output in clangd vscode plugin

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. In D55052#1312766 , @hokein wrote: > In D55052#1312760 , @ilya-biryukov > wrote: > > > +1 to the change, this

r347870 - inhereit LLVM_ENABLE_LIBXML2

Author: david2050 Date: Thu Nov 29 06:57:14 2018 New Revision: 347870 URL: http://llvm.org/viewvc/llvm-project?rev=347870&view=rev Log: inhereit LLVM_ENABLE_LIBXML2 Summary: When building in an LLVM context, we should respect its LLVM_ENABLE_LIBXML2 option. Reviewers: vitalybuka, mspertus, modo

[PATCH] D53212: inhereit LLVM_ENABLE_LIBXML2

This revision was automatically updated to reflect the committed changes. Closed by commit rL347870: inhereit LLVM_ENABLE_LIBXML2 (authored by david2050, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53212/new

Re: [PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

If this is to go in (which I think is still not clear), it definitely should be limited to clangd. Not using mapped files is an order of magnitude performance regression for many use cases. On Thu, Nov 29, 2018 at 3:15 AM Roman Lebedev via Phabricator < revi...@reviews.llvm.org> wrote: > lebedev.r

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

ebevhan added a comment. In D53738#1310212 , @leonardchan wrote: > In D53738#1309171 , @ebevhan wrote: > > > In D53738#1308314 , @leonardchan > > wrote: > > > > > > Generall

[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

yvvan added a comment. I'm currently trying out another suggestion - which unmaps memory buffer caches after ASTUnit's Parse or Reparse and is limited to Windows only. And my aim currently is not only clangd but any other client as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D549

[PATCH] D55048: [ThinLTO] Allow importing of multiple symbols with same GUID

evgeny777 accepted this revision. evgeny777 added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55048/new/ https://reviews.llvm.org/D55048 ___ cfe-comm

[PATCH] D55052: Fix junk output in clangd vscode plugin

ilya-biryukov added a comment. In D55052#1312766 , @hokein wrote: > For cancellation errors, it might be reasonable, but what if other > unrecoverable errors in clangd (e.g. clangd crashes), in these cases, users > don't know what happens, and would stil

[PATCH] D55054: [clang] Fill RealPathName for virtual files.

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added a subscriber: cfe-commits. Absolute path information for virtual files were missing even if we have already stat'd the files. This patch puts that information for virtual files that can succesffully be stat'd.

[PATCH] D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules

manmanren added a comment. I am not sure if this is the best approach, but the implementation looks okay to me. @bruno @rsmith What do you think? Manman Comment at: include/clang/Serialization/ASTReader.h:2241 SkipString(Record, Idx); +Idx++; // Relative } --

r347873 - Mark __builtin_shufflevector as using custom type checking

Author: arsenm Date: Thu Nov 29 07:45:05 2018 New Revision: 347873 URL: http://llvm.org/viewvc/llvm-project?rev=347873&view=rev Log: Mark __builtin_shufflevector as using custom type checking The custom handling seems to all be implemented already. This avoids regressions in a future patch when f

[PATCH] D55021: Mark __builtin_shufflevector as using custom type checking

arsenm closed this revision. arsenm added a comment. r347873 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55021/new/ https://reviews.llvm.org/D55021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D55022: OpenCL: Extend argument promotion rules to vector types

arsenm updated this revision to Diff 175873. arsenm added a comment. Add codegen test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55022/new/ https://reviews.llvm.org/D55022 Files: lib/Sema/SemaExpr.cpp test/CodeGenOpenCL/printf.cl Index: test/CodeGenOpenCL/printf.cl ===

[PATCH] D55023: OpenCL: Improve vector printf warnings

arsenm marked 2 inline comments as done. arsenm added inline comments. Comment at: test/SemaOpenCL/format-strings-fixit.cl:13 +void vector_fixits() { +// printf("%f", (int) 123); + printf("%v4f", (int4) 123); Anastasia wrote: > Does this not work yet? It does.

[PATCH] D55023: OpenCL: Improve vector printf warnings

arsenm marked an inline comment as done and an inline comment as not done. arsenm added inline comments. Comment at: test/SemaOpenCL/printf-format-strings.cl:65 +{ +printf("%v4f\n", arg); // expected-warning {{format specifies type 'double __attribute__((ext_vector_type(4)))

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

ilya-biryukov added inline comments. Comment at: clangd/index/IndexAction.cpp:31 + // Populates the following fields of the corresponding node for a new include: + // - Digest -> SHA1 hash of the file. + // - IsTU -> true if the file is the main file the indexing action has b

[PATCH] D55023: OpenCL: Improve vector printf warnings

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: test/SemaOpenCL/printf-format-strings.cl:65 +{ +printf("%v4f\n", arg); // expected-warning {{format specifies type 'double __attribute__((ext_vector_type(4)))' but the argument has type 'float

[PATCH] D54905: [AddressSanitizer] Add flag to disable linking with CXX runtime

kcc added a comment. In D54905#1312386 , @evgeny777 wrote: > Unfortunately, this is not an option. I have very custom heap implementation > (in fact multiple heap types sharing contiguous memory block), so ASAN heap > can't be a drop-in replacement. I'm

[PATCH] D55057: [Headers] Make max_align_t match GCC's implementation.

EricWF created this revision. EricWF added reviewers: rsmith, jyknight. GCC also considers the `__float128` type when constructing `max_align_t`. Clang's definition is intended to exactly match GCC's, so this patch make Clang do the same. NOTE: This breaks the ABI of `max_align_t` by changing i

[PATCH] D55022: OpenCL: Extend argument promotion rules to vector types

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Apart from the test can be changed. Comment at: test/CodeGenOpenCL/printf.cl:2 +// REQUIRES: amdgpu-registered-target +// RUN: %clang_cc1 -cl-std=CL1.2 -triple am

[PATCH] D55023: OpenCL: Improve vector printf warnings

Anastasia added inline comments. Comment at: test/SemaOpenCL/printf-format-strings.cl:65 +{ +printf("%v4f\n", arg); // expected-warning {{format specifies type 'double __attribute__((ext_vector_type(4)))' but the argument has type 'float2' (vector of 2 'float' values)}} }

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

kadircet updated this revision to Diff 175878. kadircet marked 8 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54999/new/ https://reviews.llvm.org/D54999 Files: clangd/Headers.

[PATCH] D54947: [OpenCL][CodeGen] Fix replacing memcpy with addrspacecast

Anastasia added inline comments. Comment at: lib/CodeGen/CGCall.cpp:3972 + // we don't want to perform address space cast for it, since that + // leads to casting __private * (default addr space in OpenCL) to + // __global * which is not valid. Create m

[PATCH] D54253: [OpenCL] Launch opencl-types.cl test only on x86

Anastasia added a comment. In D54253#1307752 , @asavonic wrote: > >> FWIW, I'd vote for the first revision of this patch. From my > >> > >> understanding, the test verifies that libclang is able to parse OpenCL > >> code correctly. It doesn't do anyth

[PATCH] D55048: [ThinLTO] Allow importing of multiple symbols with same GUID

This revision was automatically updated to reflect the committed changes. Closed by commit rC347887: [ThinLTO] Allow importing of multiple symbols with same GUID (authored by tejohnson, committed by ). Changed prior to commit: https://reviews.llvm.org/D55048?vs=175814&id=175881#toc Repository:

r347887 - [ThinLTO] Allow importing of multiple symbols with same GUID

Author: tejohnson Date: Thu Nov 29 09:02:59 2018 New Revision: 347887 URL: http://llvm.org/viewvc/llvm-project?rev=347887&view=rev Log: [ThinLTO] Allow importing of multiple symbols with same GUID Summary: The is the clang side of the fix in D55047, to handle the case where two different modules

r347888 - [analyzer][PlistMacroExpansion] Part 4.: Support for __VA_ARGS__

Author: szelethus Date: Thu Nov 29 09:09:41 2018 New Revision: 347888 URL: http://llvm.org/viewvc/llvm-project?rev=347888&view=rev Log: [analyzer][PlistMacroExpansion] Part 4.: Support for __VA_ARGS__ Differential Revision: https://reviews.llvm.org/D52986 Modified: cfe/trunk/lib/StaticAnalyz

[PATCH] D52986: [analyzer][PlistMacroExpansion] Part 4.: Support for __VA_ARGS__

This revision was automatically updated to reflect the committed changes. Closed by commit rC347888: [analyzer][PlistMacroExpansion] Part 4.: Support for __VA_ARGS__ (authored by Szelethus, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52986/new/ h

[PATCH] D54970: [OpenMP] Add a new version of the SPMD deinit kernel function

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54970/new/ https://reviews.llvm.org/D54970 ___ cfe-commits ma

[PATCH] D54428: [clangd][WIP] XPC transport layer, framework, test-client

jkorous updated this revision to Diff 175884. jkorous marked 19 inline comments as done. jkorous retitled this revision from "[clangd] XPC transport layer, framework, test-client" to "[clangd][WIP] XPC transport layer, framework, test-client". jkorous edited the summary of this revision. jkorous a

[PATCH] D54428: [clangd][WIP] XPC transport layer, framework, test-client

jkorous added reviewers: ilya-biryukov, ioeric. jkorous added a comment. Since AFAIK Sam is off until the end of the year I am adding more reviewers. Comment at: tool/ClangdMain.cpp:329 +if (getenv("CLANGD_AS_XPC_SERVICE")) + return newXPCransport(); +#endif --

[PATCH] D54905: [AddressSanitizer] Add flag to disable linking with CXX runtime

eugenis added a comment. Would turning asan operator new/delete into weak symbols help? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54905/new/ https://reviews.llvm.org/D54905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D55061: [clangd] Penalize destructor and overloaded operators in code completion.

ioeric created this revision. ioeric added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D55061 Files: clangd/Quality.cpp clangd/Quality.h unittests/clangd/Quali

[PATCH] D55062: [clangd] Partition include graph on auto-index.

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. Partitions include graphs in auto-index so that each shards contains only part of the include graph related to itself. Repository: rCTE Clang Too

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

ilya-biryukov added inline comments. Comment at: clangd/Headers.h:64 +// Important: The graph generated by those callbacks might contain cycles and +// self edges. using IncludeGraph = llvm::StringMap; And multi-edges too, right? Even though they're not useful.

[PATCH] D55023: OpenCL: Improve vector printf warnings

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: test/SemaOpenCL/printf-format-strings.cl:65 +{ +printf("%v4f\n", arg); // expected-warning {{format specifies type 'double __attribute__((ext_vector_type(4)))' but the argument has type 'float

[PATCH] D55065: [clangd] Drop injected class name when class scope is not explicitly specified.

ioeric created this revision. ioeric added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. E.g. allow injected "A::A" in `using A::A^` but not in "A^". Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D55065 Files: clangd/

r347892 - Add missing REQUIRES to new test

Author: tejohnson Date: Thu Nov 29 10:02:31 2018 New Revision: 347892 URL: http://llvm.org/viewvc/llvm-project?rev=347892&view=rev Log: Add missing REQUIRES to new test Test added in r347887 requires an x86 target. Modified: cfe/trunk/test/CodeGen/thinlto_backend_local_name_conflict.ll Modi

[PATCH] D55052: Fix junk output in clangd vscode plugin

jfindley updated this revision to Diff 175897. jfindley added a comment. Changed the comment to be a little more helpful. I used 'output' rather than errors because depending on verbosity level it can be more than just errors printed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5505

[PATCH] D55052: Fix junk output in clangd vscode plugin

ioeric added a comment. James, do you have commit access to llvm? If not, I'm happy to land the patch for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55052/new/ https://reviews.llvm.org/D55052 ___ cfe-commits mailing list cfe-commit

[PATCH] D53764: [OpenCL] Enable address spaces for references in C++

rjmccall added inline comments. Comment at: cfe/trunk/lib/CodeGen/CGExpr.cpp:4268 +DestTy.getAddressSpace(), ConvertType(DestTy)); +return MakeNaturalAlignPointeeAddrLValue(V, DestTy); + } romanovvlad wrote: > Hi, > > It seems this code doesn't work

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added a comment. > It's certainly interesting to degenerate integer-with-fixedpoint to just a > mul (since the scaling factor is 2^-n * 2^0, which is just 2^-n), but in the > general case you can't avoid doing the scale alignment. Unless I'm missing > something. No you're right. So

[PATCH] D55054: [clang] Fill RealPathName for virtual files.

kadircet updated this revision to Diff 175898. kadircet added a comment. - Update tests Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55054/new/ https://reviews.llvm.org/D55054 Files: include/clang/Basic/FileManager.h lib/Basic/FileManager.cpp unittests/Ba

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

kadircet updated this revision to Diff 175899. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54999/new/ https://reviews.llvm.org/D54999 Files: clangd/Headers

[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

dcoughlin added a comment. Looks good! Some suggested minor tweaks to diagnostic text inline. Comment at: test/Analysis/use-after-move.cpp:146 +A b = std::move(a); // expected-note {{Object 'a' is moved}} +b = a; // expected-warning {{Moved-from object is c

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:70 +- New :doc:`abseil-make-unique + ` check. Please use alphabetical order for new checks. Comment at: docs/clang-tidy/checks/abseil-make-unique.rst:6 + +Replaces uniqu

[PATCH] D54999: [clangd] Populate include graph during static indexing action.

kadircet added inline comments. Comment at: unittests/clangd/IndexActionTests.cpp:168 + std::string MainFilePath = testPath("main.cpp"); + std::pair CommonHeader = {testPath("common.h"), + R"cpp( ilya-biryuko

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

rjmccall added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2638 + // type. + QualType getCorrespondingSignedFixedPointType(QualType Ty) const; + Please include in the comment here that, unlike `getCorrespondingUnsignedType`, this has to b

r347895 - Simplify the __builtin_constant_p test that was used to catch rC347417 failure

Author: maskray Date: Thu Nov 29 10:26:39 2018 New Revision: 347895 URL: http://llvm.org/viewvc/llvm-project?rev=347895&view=rev Log: Simplify the __builtin_constant_p test that was used to catch rC347417 failure Reviewers: rsmith, void, shafik Reviewed By: void Subscribers: kristina, cfe-commi

[PATCH] D54964: Add test about __builtin_constant_p

This revision was automatically updated to reflect the committed changes. Closed by commit rC347895: Simplify the __builtin_constant_p test that was used to catch rC347417 failure (authored by MaskRay, committed by ). Changed prior to commit: https://reviews.llvm.org/D54964?vs=175543&id=175902#

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

zhizhouy added a comment. Thanks for the review and comments! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55029/new/ https://reviews.llvm.org/D55029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D54905: [AddressSanitizer] Add flag to disable linking with CXX runtime

kcc added a comment. weak new/delete may solve this particular problem, but may cause confusion to lots of other users, e.g. in cases when a user has overridden new/delete for non-essential reasons (e.g. debuging) and can disable the overrides in asan mode. With weak symbols such a user will n

[PATCH] D55066: [ASan] Minor documentation fix: remove static linking limitation.

Dor1s created this revision. Dor1s added reviewers: eugenis, kcc. Herald added a subscriber: cfe-commits. Looks like the documentation is out of date, given that static linking is not only supported these days, but is actually a default mode. Repository: rC Clang https://reviews.llvm.org/D550

[PATCH] D55052: Fix junk output in clangd vscode plugin

jfindley marked an inline comment as done. jfindley added a comment. In D55052#1313048 , @ioeric wrote: > James, do you have commit access to llvm? If not, I'm happy to land the patch > for you. I do not have commit access - if you could land it that wo

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

ruiu accepted this revision. ruiu added a comment. LGTM. Please commit. Peter, I wonder if you are fine with the default 64KiB page size with lld, especially given that lld always round up the text segment size to the maximum page size on disk and fill the padding with trap instructions. On ave

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

This revision was automatically updated to reflect the committed changes. Closed by commit rC347897: set default max-page-size to 4KB in lld for Android Aarch64 (authored by zhizhouy, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55029/new/ https:/

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

JonasToth added a comment. In D54757#1311516 , @Szelethus wrote: > In D54757#1311468 , @donat.nagy > wrote: > > > **Macros:** > > > > The current implementation of the check only looks at the preprocessed > > code

r347897 - set default max-page-size to 4KB in lld for Android Aarch64

Author: zhizhouy Date: Thu Nov 29 10:52:22 2018 New Revision: 347897 URL: http://llvm.org/viewvc/llvm-project?rev=347897&view=rev Log: set default max-page-size to 4KB in lld for Android Aarch64 Summary: This patch passes an option '-z max-page-size=4096' to lld through clang driver. This is for

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

JonasToth added inline comments. Comment at: clang-tidy/bugprone/BranchCloneCheck.cpp:31 +/// an if/else if/else chain is one statement (which may be a CompoundStmt). +using SwitchBranch = llvm::SmallVector; +} // anonymous namespace donat.nagy wrote: > JonasToth

[PATCH] D54986: Make CodeGen choose when to emit vtables.

rjmccall added inline comments. Comment at: lib/AST/ASTContext.cpp:9801 + RD->getTemplateSpecializationKind() == + TSK_ExplicitInstantiationDefinition; else Does it matter if it's not this particular declaration that's the explicit ins

  1   2   3   >