Anastasia added a comment. In D54253#1307752 <https://reviews.llvm.org/D54253#1307752>, @asavonic wrote:
> >> FWIW, I'd vote for the first revision of this patch. From my > >> > >> understanding, the test verifies that libclang is able to parse OpenCL > >> code correctly. It doesn't do anything specific to x86: target for x86 > >> just > >> happens to support a set of OpenCL extensions. > > > > I am trying to understand what exactly does it bring into testing if the > > code doesn't have anything target specific in there? > > It brings the architecture that does not support any OpenCL extension, > thus we check that types are "invalid". Ok, let's test one invalid configuration if you think it's valuable. I assume we can't test all? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54253/new/ https://reviews.llvm.org/D54253 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
