sammccall added a comment.
OK, sounds like we have something to move forward with. I'd suggest we start
with an operation returning {SymbolID, scope qualifiers, unqualified name, USR}
and ignoring location for now, unless you have an immediate need. Reason being
this sidesteps the index questio
balazske marked 3 inline comments as done.
balazske added a comment.
If we change signature of `Import` now, other parts of the code (in clang and
LLDB) would not compile (without changing to use the new kind of Import). If
there is a `Import_New` the old code can still compile and can be change
theraven added inline comments.
Comment at: lib/CodeGen/CGObjCRuntime.h:288
+ /// descriptor's symbol name.
+ virtual std::string getObjCEncodingForBlock(const BlockExpr *BE) const;
+
I'm not sure that this actually belongs in CGObjCRuntime. The runtime doesn'
ebevhan added a comment.
I'd be interested in seeing tests for two saturating unsigned _Fract with and
without padding.
If the padding case emits a uadd_sat, that seems wrong; uadd_sat doesn't
saturate on the padding bit, but will saturate the whole number, which can
result in invalid represen
balazske updated this revision to Diff 174168.
balazske added a comment.
- Small style corrections.
Repository:
rC Clang
https://reviews.llvm.org/D53818
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
Index: lib/AST/ASTImporter.cpp
ioeric added inline comments.
Comment at: clangd/index/dex/dexp/Dexp.cpp:64
+// add the global scope to the request.
+Request.Scopes = {""};
I think the old behavior used `AnyScope` for a unqualified name. Do we want to
keep that?
Repository:
rCTE
balazske added inline comments.
Comment at: include/clang/AST/ASTImporter.h:192
///
-/// \returns the equivalent declaration in the "to" context, or a NULL type
-/// if an error occurred.
+/// \returns The equivalent declaration in the "to" context, or the import
ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/index/dex/dexp/Dexp.cpp:64
+// add the global scope to the request.
+Request.Scopes = {""};
ioeric wrote:
> I think the old
aheejin created this revision.
aheejin added a reviewer: dschuff.
Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, sbc100.
We discussed this at the Nov 12th CG meeting, and decided to use the
unsigned semantics for the wake count.
Corresponding spec change:
https://github.com
Author: kadircet
Date: Thu Nov 15 02:31:10 2018
New Revision: 346938
URL: http://llvm.org/viewvc/llvm-project?rev=346938&view=rev
Log:
Introduce shard storage to auto-index.
Reviewers: sammccall, ioeric
Subscribers: ilya-biryukov, jkorous, arphaman, cfe-commits
Differential Revision: https://re
Author: kadircet
Date: Thu Nov 15 02:31:19 2018
New Revision: 346940
URL: http://llvm.org/viewvc/llvm-project?rev=346940&view=rev
Log:
Address comments
Modified:
clang-tools-extra/trunk/clangd/index/Background.cpp
clang-tools-extra/trunk/clangd/index/Background.h
clang-tools-extra/tru
Author: kadircet
Date: Thu Nov 15 02:31:15 2018
New Revision: 346939
URL: http://llvm.org/viewvc/llvm-project?rev=346939&view=rev
Log:
clang-format
Modified:
clang-tools-extra/trunk/clangd/index/Background.cpp
clang-tools-extra/trunk/unittests/clangd/BackgroundIndexTests.cpp
Modified: cl
Author: kadircet
Date: Thu Nov 15 02:31:23 2018
New Revision: 346941
URL: http://llvm.org/viewvc/llvm-project?rev=346941&view=rev
Log:
Address comments.
Modified:
clang-tools-extra/trunk/clangd/index/Background.cpp
clang-tools-extra/trunk/clangd/index/Background.h
clang-tools-extra/tr
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346938: Introduce shard storage to auto-index. (authored by
kadircet, committed by ).
Herald added a subscriber: llvm-comm
Author: kadircet
Date: Thu Nov 15 02:34:47 2018
New Revision: 346945
URL: http://llvm.org/viewvc/llvm-project?rev=346945&view=rev
Log:
Revert "Introduce shard storage to auto-index."
This reverts commit 6dd1f24aead10a8d375d0311001987198d26e900.
Modified:
clang-tools-extra/trunk/clangd/index/
Author: kadircet
Date: Thu Nov 15 02:34:43 2018
New Revision: 346944
URL: http://llvm.org/viewvc/llvm-project?rev=346944&view=rev
Log:
Revert "clang-format"
This reverts commit 0a37e9c3d88a2e21863657df2f7735fb7e5f746e.
Modified:
clang-tools-extra/trunk/clangd/index/Background.cpp
clang-t
Author: kadircet
Date: Thu Nov 15 02:34:35 2018
New Revision: 346942
URL: http://llvm.org/viewvc/llvm-project?rev=346942&view=rev
Log:
Revert "Address comments."
This reverts commit b43c4d1c731e07172a382567f3146b3c461c5b69.
Modified:
clang-tools-extra/trunk/clangd/index/Background.cpp
cl
Author: kadircet
Date: Thu Nov 15 02:34:39 2018
New Revision: 346943
URL: http://llvm.org/viewvc/llvm-project?rev=346943&view=rev
Log:
Revert "Address comments"
This reverts commit 19a39b14eab2b5339325e276262b177357d6b412.
Modified:
clang-tools-extra/trunk/clangd/index/Background.cpp
cla
Anastasia marked 4 inline comments as done.
Anastasia added a comment.
Do you think there is anything else to do for this patch?
Comment at: lib/Sema/SemaExprCXX.cpp:4289
+ /*BasePath=*/nullptr, CCK)
+ .get();
rjmccal
sammccall added a comment.
As mentioned offline - sounds like someone from Apple might take a look.
If not, ping me again to land!
(Sorry for the delay)
Repository:
rC Clang
https://reviews.llvm.org/D53900
___
cfe-commits mailing list
cfe-commit
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clangd/Function.h:147
+private:
+ static_assert(std::is_same::type, T>::value,
+"use a plain type: event values are always pas
ilya-biryukov added a reviewer: ilya-biryukov.
ilya-biryukov added a comment.
This seems ready, so putting myself in as a reviewer.
Let me know if there's more work to do and I you don't want the review yet.
Thanks for the fix, just a single NIT comment.
Comment at: clangd/XRe
jkorous added reviewers: arphaman, benlangmuir.
jkorous added a comment.
This looks reasonable to me but asked people with more context to take a look.
Repository:
rC Clang
https://reviews.llvm.org/D53900
___
cfe-commits mailing list
cfe-commits@
Author: hokein
Date: Thu Nov 15 04:17:41 2018
New Revision: 346947
URL: http://llvm.org/viewvc/llvm-project?rev=346947&view=rev
Log:
[clangd] Fix no results returned for global symbols in dexp
Summary:
For symbols in global namespace (without any scope), we need to
add global scope "" to the fuzz
kadircet updated this revision to Diff 174187.
kadircet added a comment.
- Change factory design to use llvm::unique_function.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54269
Files:
clangd/CMakeLists.txt
clangd/index/Background.cpp
clangd/index/Background.h
clangd/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346947: [clangd] Fix no results returned for global symbols
in dexp (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D54519
Fi
aaron.ballman added a comment.
In https://reviews.llvm.org/D54547#1299105, @chandlerc wrote:
> Should likely add release notes about this.
>
> Also might be worth sending a note to cfe-dev as a heads up and give folks
> some time to say "wait wait".
+1 to both of these points, but if doesn't c
aaron.ballman added a comment.
Missing sema tests that demonstrate the attribute can only appertain to
functions and types, accepts no arguments, has the expected semantic behavior
for typecasts to function pointers, etc.
Comment at: include/clang/Basic/Attr.td:1792
+ let Sp
riccibruno added a comment.
I don't think I can comment more broadly on this, but
there is some PTH-related code in `Basic/IdentifierTable`,
in `IdentifierInfo::getNameStart` and `IdentifierInfo::getLength`.
Maybe this should be removed too ?
Repository:
rC Clang
https://reviews.llvm.org/D545
baloghadamsoftware updated this revision to Diff 174189.
baloghadamsoftware added a comment.
Herald added a subscriber: gamesh411.
Tests updated to the now default `eagerly assume` mode. Range scaling fixed.
https://reviews.llvm.org/D50256
Files:
include/clang/StaticAnalyzer/Core/PathSensitiv
baloghadamsoftware updated this revision to Diff 174190.
baloghadamsoftware added a comment.
Herald added a subscriber: gamesh411.
Rebased on the previous part. Tests updated for the now default `eagerly
assume` mode.
https://reviews.llvm.org/D49074
Files:
include/clang/StaticAnalyzer/Core/P
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
Looks good. Do we plan to detect problems other than use after move? Maybe it
would be worth to synchronize with the tidy checker name use-after-move or is
it going to cause more confusi
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
It would be great to have a way to extend the list of (possibly non-stl) types
to check. But I do understand that the analyzer does not have a great way to
set such configuration options
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks! Looks good, rest of the nits are obvious or up to you.(
Comment at: clangd/index/Background.cpp:37
-BackgroundIndex::BackgroundIndex(Context BackgroundContext
baloghadamsoftware added a comment.
Here is the proof of the algorithm for `signed char` and `unsigned char` types.
The dumper which tests every `n` for the `n*k m` relation
and creates ranges from values satisfying the expression for every `k` and `m`
produces exactly the same output as the g
Author: uabelho
Date: Thu Nov 15 05:01:54 2018
New Revision: 346950
URL: http://llvm.org/viewvc/llvm-project?rev=346950&view=rev
Log:
Fix warning about unused variable [NFC]
Modified:
cfe/trunk/lib/CodeGen/CGDecl.cpp
Modified: cfe/trunk/lib/CodeGen/CGDecl.cpp
URL:
http://llvm.org/viewvc/llv
grimar added a comment.
`SplitDebugName` is called from the following 4 places:
1. void Clang::ConstructJob()
(https://github.com/llvm-mirror/clang/blob/master/lib/Driver/ToolChains/Clang.cpp#L3933)
We can get here when clang construct jobs for regular case (cpp files):
EX: main.cpp -g -gsplit-
grimar created this revision.
grimar added a reviewer: dblaikie.
grimar added a comment.
`SplitDebugName` is called from the following 4 places:
1. void Clang::ConstructJob()
(https://github.com/llvm-mirror/clang/blob/master/lib/Driver/ToolChains/Clang.cpp#L3933)
We can get here when clang cons
ArnaudBienner added a comment.
@rsmith do you have any thoughts about this change?
Repository:
rC Clang
https://reviews.llvm.org/D53807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: brunoricci
Date: Thu Nov 15 05:30:38 2018
New Revision: 346951
URL: http://llvm.org/viewvc/llvm-project?rev=346951&view=rev
Log:
[AST] Pack UnaryOperator
Use the newly available space in the bit-fields of Stmt
to store some data from UnaryOperator.
This saves 8 bytes per UnaryOperator.
D
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346951: [AST] Pack UnaryOperator (authored by brunoricci,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D54524?vs=174024&id=174195#toc
Repos
riccibruno marked 6 inline comments as done.
riccibruno added a comment.
Marked the inline comments as done since I believe I
answered each of them. If not I can fix it in a subsequent commit.
Repository:
rC Clang
https://reviews.llvm.org/D54526
Author: brunoricci
Date: Thu Nov 15 05:49:32 2018
New Revision: 346952
URL: http://llvm.org/viewvc/llvm-project?rev=346952&view=rev
Log:
[AST][NFC] Move the friend decls to the top of MemberExpr
The norm is to have them at the top, and having them
at the bottom is painful for the reader.
Modifi
Author: brunoricci
Date: Thu Nov 15 05:56:22 2018
New Revision: 346953
URL: http://llvm.org/viewvc/llvm-project?rev=346953&view=rev
Log:
[AST] Pack MemberExpr
Use the newly available space in the bit-fields of Stmt
to store some data from MemberExpr. This saves
one pointer per MemberExpr.
Differ
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346953: [AST] Pack MemberExpr (authored by brunoricci,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54525?vs=174026&id=174196#toc
Repository:
rC Clang
https://reviews.llvm.org/
Author: brunoricci
Date: Thu Nov 15 06:12:51 2018
New Revision: 346954
URL: http://llvm.org/viewvc/llvm-project?rev=346954&view=rev
Log:
[AST] Pack BinaryOperator
Use the newly available space in the bit-fields of Stmt.
This saves 8 bytes per BinaryOperator.
Differential Revision: https://review
This revision was automatically updated to reflect the committed changes.
Closed by commit rC346954: [AST] Pack BinaryOperator (authored by brunoricci,
committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D54526
Files:
include/clang/AST/Expr.h
include/clang/AST/Stmt.h
Index: inc
Author: hokein
Date: Thu Nov 15 06:15:19 2018
New Revision: 346955
URL: http://llvm.org/viewvc/llvm-project?rev=346955&view=rev
Log:
[clangd] global-symbol-builder => clangd-indexer
Modified:
clang-tools-extra/trunk/clangd/index/dex/dexp/Dexp.cpp
Modified: clang-tools-extra/trunk/clangd/inde
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, xazax.hun.
(See https://reviews.llvm.org/D54204 for original review)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54579
Files:
clang-tidy/misc/UnusedParametersCheck.c
malaperle updated this revision to Diff 174202.
malaperle added a comment.
Address comment.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54553
Files:
clangd/XRefs.cpp
unittests/clangd/XRefsTests.cpp
Index: unittests/clangd/XRefsTests.cpp
sammccall updated this revision to Diff 174203.
sammccall added a comment.
Address comments from the last round of review in
https://reviews.llvm.org/D54204.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54579
Files:
clang-tidy/misc/UnusedParametersCheck.cpp
clang-tidy/mo
sammccall added a comment.
Moved the clang-tidy changes to https://reviews.llvm.org/D54579.
Sorry for mixing everything up!
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:518
void SimplifyBooleanExprCheck::registerMatchers(MatchFinder *Finder) {
- Finder->add
sammccall updated this revision to Diff 174204.
sammccall added a comment.
Remove clang-tidy changes, add FIXME comment.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54204
Files:
clangd/CMakeLists.txt
clangd/ClangdUnit.cpp
clangd/XRefs.cpp
unittests/clangd/ClangdUnitT
Author: brunoricci
Date: Thu Nov 15 06:30:18 2018
New Revision: 346957
URL: http://llvm.org/viewvc/llvm-project?rev=346957&view=rev
Log:
[AST][NFC] Re-add comment in BinaryOperator which was removed by r346954
Modified:
cfe/trunk/include/clang/AST/Stmt.h
Modified: cfe/trunk/include/clang/AS
scott.linder added inline comments.
Comment at: docs/ClangCommandLineReference.rst:797
+
+Generate a section .LLVM.command.line containing the clang driver command line.
+
rjmccall wrote:
> 1. Is this section always called `.LLVM.command.line`, or does it differ
HsiangKai added a comment.
In https://reviews.llvm.org/D45045#1299507, @tyb0807 wrote:
> Hello all,
>
> This commit has been reverted by https://reviews.llvm.org/rC345026. It was
> reported that this broke the Chromium build (again). Have you had a look to
> fix this, @HsiangKai?
I have fixed
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:567
replaceCompoundReturnWithCondition(Result, Compound, true);
- else if (const auto TU = Result.N
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
looks good!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54204
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
Author: sammccall
Date: Thu Nov 15 07:06:11 2018
New Revision: 346961
URL: http://llvm.org/viewvc/llvm-project?rev=346961&view=rev
Log:
[clang-tidy] Update checks to play nicely with limited traversal scope added in
r346847
Summary: (See D54204 for original review)
Reviewers: hokein
Subscriber
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346961: [clang-tidy] Update checks to play nicely with
limited traversal scope added in… (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https:/
Szelethus accepted this revision.
Szelethus added a comment.
LGTM, both the concept and the patch! I have read your followup patches up to
part 4, I'll leave some thoughts there.
Repository:
rC Clang
https://reviews.llvm.org/D54556
___
cfe-commi
kadircet updated this revision to Diff 174215.
kadircet marked 13 inline comments as done.
kadircet added a comment.
- Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54269
Files:
clangd/CMakeLists.txt
clangd/index/Background.cpp
clangd/index/Background.h
Szelethus added a comment.
I think we should either remove the non-default functionality (which wouldn't
be ideal), or emphasise somewhere (open projects?) that there is still work to
be done, but leaving it to be forgotten and essentially making it an extra
maintenance work would be, in my opt
Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.
Awesome! :D
Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:385-386
+ }
+ // Provide the caller with the classification of the object
+ // we've obtained her
Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.
How about `std::list::splice`?
Repository:
rC Clang
https://reviews.llvm.org/D54563
___
cfe-commits mailing list
cfe-commits@lists.llvm.
riccibruno added a comment.
In https://reviews.llvm.org/D54547#1299883, @erichkeane wrote:
> Added to the release notes. Also, an email was sent out to cfe-dev.
>
> @riccibruno and I are separately looking into IdentifierInfo, because it
> seems that there are some pretty massive optimization o
Szelethus added a comment.
Alpha checkers, at least to developers, are clearly stating "Please finish
me!", but a non-alpha, enabled-by-default checker with a flag that you'd never
know about unless you looked at the source code (at least up until I fix these)
sounds like it'll be forgotten lik
ilya-biryukov updated this revision to Diff 174217.
ilya-biryukov marked 10 inline comments as done.
ilya-biryukov added a comment.
- Address comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52273
Files:
clangd/CMakeLists.txt
clangd/ExpectedTypes.cpp
clangd/Expecte
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added inline comments.
Comment at: clangd/ExpectedTypes.cpp:12
+
+static llvm::Optional toEquivClass(ASTContext &Ctx, QualType T) {
+ if (T.isNull() || T->isDependentType())
sammccall wrote:
> returni
jhibbits added a comment.
Hi Vit,
The register spilling bug is being addressed in https://reviews.llvm.org/D54409
now.
Repository:
rC Clang
https://reviews.llvm.org/D49754
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Author: brunoricci
Date: Thu Nov 15 08:42:14 2018
New Revision: 346967
URL: http://llvm.org/viewvc/llvm-project?rev=346967&view=rev
Log:
[AST][NFC] Various NFCs in StringLiteral
Factored out of D54166
([AST] Store the string data in StringLiteral in a trailing array of chars):
* For-range loops
scott.linder added a comment.
Looking a bit further, it seems some other object-file formats have conventions
for naming (e.g. Mach-O sections are `_snake_case`) and so `.LLVM.command.line`
may not end up being what we want universally.
Additionally it seems things like `.ident` are not support
astrelni updated this revision to Diff 174218.
astrelni marked an inline comment as done.
astrelni added a comment.
Fix to use `hasAnyName` everywhere
https://reviews.llvm.org/D53830
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/UpgradeDu
astrelni updated this revision to Diff 174226.
astrelni added a comment.
Fix incorrect uploaded diff.
https://reviews.llvm.org/D53830
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp
clang-tidy/abseil/Up
Author: brunoricci
Date: Thu Nov 15 09:31:16 2018
New Revision: 346969
URL: http://llvm.org/viewvc/llvm-project?rev=346969&view=rev
Log:
[AST] Store the string data in StringLiteral in a trailing array of chars
Use the newly available space in the bit-fields of Stmt and store the
string data in a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346969: [AST] Store the string data in StringLiteral in a
trailing array of chars (authored by brunoricci, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revie
Szelethus added a comment.
Herald added a subscriber: gamesh411.
In https://reviews.llvm.org/D54438#1297602, @NoQ wrote:
> Hmm, makes sense. Maybe `static bool BlahBlahChecker::isApplicable(const
> LangOpts &LO)` or something like that.
>
> Btw, maybe instead of default constructor and `->setup(
jkorous planned changes to this revision.
jkorous added a comment.
In https://reviews.llvm.org/D54428#1297147, @sammccall wrote:
> A question about the high-level build target setup (I don't know much about
> XPC services/frameworks, bear with me...):
>
> This is set up so that the clangd binary
leonardchan added a comment.
In https://reviews.llvm.org/D53738#1299557, @ebevhan wrote:
> I'd be interested in seeing tests for two saturating unsigned _Fract with and
> without padding.
>
> If the padding case emits a uadd_sat, that seems wrong; uadd_sat doesn't
> saturate on the padding bit,
leonardchan updated this revision to Diff 174235.
leonardchan marked 13 inline comments as done.
Repository:
rC Clang
https://reviews.llvm.org/D53738
Files:
clang/include/clang/AST/ASTContext.h
clang/include/clang/AST/Type.h
clang/include/clang/Basic/FixedPoint.h
clang/lib/AST/ASTConte
russellmcc added a comment.
bump! Thanks for your consideration.
https://reviews.llvm.org/D40988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shafik added inline comments.
Comment at: include/clang/AST/Expr.h:1407
public:
- enum CharacterKind {
-Ascii,
-Wide,
-UTF8,
-UTF16,
-UTF32
- };
+ enum CharacterKind { Ascii, Wide, UTF8, UTF16, UTF32 };
riccibruno wrote:
> shafik wrote:
shafik added a comment.
Did you ever resolve the issue of libcxx tests not running
https://reviews.llvm.org/D53697
Repository:
rC Clang
https://reviews.llvm.org/D53702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
lebedev.ri created this revision.
lebedev.ri added reviewers: ABataev, craig.topper, vsk, rsmith, rnk,
Sanitizers, erichkeane, filcab, rjmccall.
lebedev.ri added a project: Sanitizers.
lebedev.ri added a dependency: D54588: [llvm][IRBuilder] Introspection for
CreateAlignmentAssumption*() function
scott.linder accepted this revision.
scott.linder added a comment.
This revision is now accepted and ready to land.
r346884
https://reviews.llvm.org/D51223
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
scott.linder closed this revision.
scott.linder added a comment.
r346884
https://reviews.llvm.org/D51223
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Agreed - looks like this went in untested in r175813 & has never been used.
https://reviews.llvm.org/D54576
___
cfe-commits mailing list
cfe-
devnexen created this revision.
devnexen added reviewers: george.karpenkov, dergachev.a.
devnexen created this object with visibility "All Users".
Herald added a subscriber: cfe-commits.
- explicit_bzero has limited scope/usage only for security/crypto purposes but
is non-optimisable version of m
delesley added inline comments.
Comment at: lib/Analysis/ThreadSafety.cpp:951
+}
} else {
+// We're removing the underlying mutex. Warn on double unlocking.
aaronpuchert wrote:
> aaronpuchert wrote:
> > delesley wrote:
> > > aaronpuchert wr
kkwli0 added a comment.
Please do a rebase. The test case teams_distribute_simd_loop_messages.cpp
needs to update too.
Comment at: clang/lib/Sema/SemaOpenMP.cpp:3707
/// UB >= Var
- bool TestIsLessOp = false;
+ /// This will has no value when the condition is !=
+ ll
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
https://reviews.llvm.org/D53764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
rjmccall added inline comments.
Comment at: docs/ClangCommandLineReference.rst:797
+
+Generate a section .LLVM.command.line containing the clang driver command line.
+
scott.linder wrote:
> rjmccall wrote:
> > 1. Is this section always called `.LLVM.command.line`
phosek created this revision.
phosek added reviewers: mcgrathr, jakehehrlich, juliehockett.
Herald added subscribers: cfe-commits, mgorny.
Not all Linux targets use the ${arch}-linux-gnu spelling, so
specify the list of Linux explicitly.
Repository:
rC Clang
https://reviews.llvm.org/D54598
F
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: jkorous.
LGTM
https://reviews.llvm.org/D54245
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
Author: erichkeane
Date: Thu Nov 15 13:35:35 2018
New Revision: 346996
URL: http://llvm.org/viewvc/llvm-project?rev=346996&view=rev
Log:
Fix parens warning in assert in ASTMatchFinder
Change-Id: Ie34f9c6846b98fba87449e73299519fc2346bac1
Modified:
cfe/trunk/lib/ASTMatchers/ASTMatchFinder.cpp
smeenai planned changes to this revision.
smeenai added a comment.
In https://reviews.llvm.org/D52674#1298115, @rjmccall wrote:
> In https://reviews.llvm.org/D52674#1297893, @smeenai wrote:
>
> > In https://reviews.llvm.org/D52674#1297879, @rjmccall wrote:
> >
> > > I'm not worried about the mang
leonardchan updated this revision to Diff 174279.
Repository:
rC Clang
https://reviews.llvm.org/D53738
Files:
clang/include/clang/AST/ASTContext.h
clang/include/clang/AST/Type.h
clang/include/clang/Basic/FixedPoint.h
clang/lib/AST/ASTContext.cpp
clang/lib/Basic/FixedPoint.cpp
clang
dblaikie added a subscriber: scott.linder.
dblaikie added a comment.
Thanks!
So I can see where/how this fails now - the LLVM backend seems to require that
if any file has embedded source, they all do. Would you be able to/would you
mind adding a debug info verifier check for this? That'd help
leonardchan added a comment.
> Good case to bring up. For addition, I think we just need to add an extra
> condition that checks for unsigned padding in the result. Added this test
> also.
Actually this was wrong. Updated and instead dictate how the appropriate number
of bits to `getCommonSema
Author: phosek
Date: Thu Nov 15 13:55:59 2018
New Revision: 346997
URL: http://llvm.org/viewvc/llvm-project?rev=346997&view=rev
Log:
[CMake] Explicitly list Linux targets for Fuchsia toolchain
Not all Linux targets use the ${arch}-linux-gnu spelling, so instead
specify the list of Linux explicitl
1 - 100 of 143 matches
Mail list logo
