aaron.ballman added a comment. Missing sema tests that demonstrate the attribute can only appertain to functions and types, accepts no arguments, has the expected semantic behavior for typecasts to function pointers, etc.
================ Comment at: include/clang/Basic/Attr.td:1792 + let Spellings = [Clang<"aarch64_vector_pcs">]; + let Documentation = [ AArch64VectorPcsDocs ]; +} ---------------- Spurious whitespace around the square brackets. ================ Comment at: include/clang/Basic/AttrDocs.td:1749-1750 +On 64-bit ARM targets, this argument causes the function to obey the vector +procedural call standard (VPCS) rules as described in the Vector ABI for +AArch64. In particular, the register caller/callee saves ratio is set to 16/16. + }]; ---------------- If you can add a link to the vector ABI here, or to something that gives more detail about the ABI, that'd be great. https://reviews.llvm.org/D54425 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
