Rakete added inline comments.
Comment at: test/SemaCXX/unknown-type-name.cpp:50
template
-void f(T::type) { } // expected-error{{missing 'typename'}}
+void f(T::type) { } // expected-warning {{implicit 'typename' is a C++2a
extension}}
rsmith wrote:
> Rak
rnk added subscribers: aaron.ballman, rsmith.
rnk added a comment.
In https://reviews.llvm.org/D53985#1284196, @ldionne wrote:
> Would it make sense to add the GNU spelling to the attribute in Clang?
I'll redirect that question to @rsmith and @aaron.ballman. I have a vague
recollection that it
rjmccall added inline comments.
Comment at: docs/ClangCommandLineReference.rst:805
-Enable poisoning array cookies when using class member operator new\[\] in
AddressSanitizer
+Enable poisoning array cookies when using custom operator new\[\] in
AddressSanitizer
---
rjmccall added a comment.
In https://reviews.llvm.org/D53705#1284203, @keryell wrote:
> I was really meaning "run on the CPU" and not "run on the GPU", it was not a
> typo from me. :-)
> If there are no visible language extensions besides C++ classes, it is
> easier to run the kernel code on a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345870: Use C++11 fallthrough attribute syntax when
available and add a break (authored by rnk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org
aaron.ballman added a comment.
In https://reviews.llvm.org/D53985#1284246, @rnk wrote:
> In https://reviews.llvm.org/D53985#1284196, @ldionne wrote:
>
> > Would it make sense to add the GNU spelling to the attribute in Clang?
>
>
> I'll redirect that question to @rsmith and @aaron.ballman. I have
Hi,
this patch seems to cause a build failure:
/usr/bin/ld: CMakeFiles/clangAST.dir/OSLog.cpp.o: in function `(anonymous
namespace)::OSLogFormatStringHandler::~OSLogFormatStringHandler()':
/home/jvesely/llvm/tools/clang/lib/AST/OSLog.cpp:18: undefined reference to
`clang::analyze_format_string::F
JonasToth added a comment.
But that reasoning would apply to `if` and `while` loops, as it might be
an "always true". But you are right, this case is not generally problematic.
long size = 30;
short index = 100;
// Opposite comparison
if(index > size) {
//
}
Repository:
Author: tnorthover
Date: Thu Nov 1 11:37:42 2018
New Revision: 345871
URL: http://llvm.org/viewvc/llvm-project?rev=345871&view=rev
Log:
Revert "Reapply Logging: make os_log buffer size an integer constant
expression."
Still more dependency hell.
Added:
cfe/trunk/include/clang/Analysis/Anal
Author: mgrang
Date: Thu Nov 1 11:38:26 2018
New Revision: 345872
URL: http://llvm.org/viewvc/llvm-project?rev=345872&view=rev
Log:
Revert "[COFF, ARM64] Change setjmp for AArch64 Windows to use
Intrinsic.sponentry"
This reverts commit 619111f5ccf349b635e4987ec02d15777c571495.
Modified:
cf
On 1 Nov 2018, at 18:36, Jan Vesely wrote:
> this patch seems to cause a build failure:
Ugh. Reverted as r345871.
Do you know what linker and other options you’re using? The only failure I’ve
been able to reproduce locally is when I introduced a circular dependency.
Cheers.
Tim.
aaron.ballman updated this revision to Diff 172191.
aaron.ballman added a comment.
Updated based on review feedback.
https://reviews.llvm.org/D53982
Files:
lib/StaticAnalyzer/Core/SarifDiagnostics.cpp
test/Analysis/diagnostics/Inputs/expected-sarif/sarif-diagnostics-taint-test.c.sarif
t
aaron.ballman marked an inline comment as done.
aaron.ballman added inline comments.
Comment at: test/Analysis/diagnostics/sarif-multi-diagnostic-test.c:1
+// RUN: %clang_analyze_cc1
-analyzer-checker=core,alpha.security.taint,debug.TaintTest %s -verify
-analyzer-output=sarif -
void updated this revision to Diff 172194.
Repository:
rC Clang
https://reviews.llvm.org/D53921
Files:
lib/ARCMigrate/ObjCMT.cpp
lib/AST/ASTImporter.cpp
lib/AST/ExprConstant.cpp
lib/Analysis/CFG.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGExprAgg.cpp
lib/CodeGen/CGExprComplex.cpp
On Thu, 2018-11-01 at 18:40 +, Tim Northover via cfe-commits wrote:
> On 1 Nov 2018, at 18:36, Jan Vesely wrote:
> > this patch seems to cause a build failure:
>
> Ugh. Reverted as r345871.
>
> Do you know what linker and other options you’re using? The only
> failure I’ve been able to repr
george.karpenkov accepted this revision.
george.karpenkov added inline comments.
This revision is now accepted and ready to land.
Comment at:
test/Analysis/diagnostics/Inputs/expected-sarif/sarif-diagnostics-taint-test.c.sarif:10
},
- "length": 510,
+
Author: rnk
Date: Thu Nov 1 11:53:02 2018
New Revision: 345873
URL: http://llvm.org/viewvc/llvm-project?rev=345873&view=rev
Log:
Add LLVM_FALLTHROUGH annotation after switch
This silences a -Wimplicit-fallthrough warning from clang. GCC does not
appear to warn when the case body ends in a switch
eandrews added a comment.
> Upstreaming it first might be better, especially since the change seems to be
> trivial. Is this line addition the only change proposed for the benchmark
> library?
Yes this line is the only change.
> Do you want me to submit the patch to the benchmark library? It s
Author: aaronballman
Date: Thu Nov 1 11:57:38 2018
New Revision: 345874
URL: http://llvm.org/viewvc/llvm-project?rev=345874&view=rev
Log:
Output "rule" information in SARIF exports.
SARIF allows you to export descriptions about rules that are present in the
SARIF log. Expose the help text table
aaron.ballman closed this revision.
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Thank you for the quick review and feedback -- I've commit in r345874.
Comment at:
test/Analysis/diagnostics/Inputs/expected-sarif/sarif-diagnostics-taint-test.c.
rsmith added a comment.
In https://reviews.llvm.org/D53985#1284282, @aaron.ballman wrote:
> In https://reviews.llvm.org/D53985#1284246, @rnk wrote:
>
> > In https://reviews.llvm.org/D53985#1284196, @ldionne wrote:
> >
> > > Would it make sense to add the GNU spelling to the attribute in Clang?
>
mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D53970
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Author: rnk
Date: Thu Nov 1 12:54:45 2018
New Revision: 345882
URL: http://llvm.org/viewvc/llvm-project?rev=345882&view=rev
Log:
Fix clang -Wimplicit-fallthrough warnings across llvm, NFC
This patch should not introduce any behavior changes. It consists of
mostly one of two changes:
1. Replacing
Author: rnk
Date: Thu Nov 1 12:54:45 2018
New Revision: 345882
URL: http://llvm.org/viewvc/llvm-project?rev=345882&view=rev
Log:
Fix clang -Wimplicit-fallthrough warnings across llvm, NFC
This patch should not introduce any behavior changes. It consists of
mostly one of two changes:
1. Replacing
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345882: Fix clang -Wimplicit-fallthrough warnings across
llvm, NFC (authored by rnk, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D53950?vs=1
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345882: Fix clang -Wimplicit-fallthrough warnings across
llvm, NFC (authored by rnk, committed by ).
Herald added a subscriber: jrtc27.
Changed prior to commit:
https://reviews.llvm.org/D53950?vs=172208
Rakete updated this revision to Diff 172218.
Rakete added a comment.
I'm pretty sure I implemented the rules correctly now :)
Repository:
rC Clang
https://reviews.llvm.org/D53847
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Parse/Parser.h
include/clang/Sema/S
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345889: [CMake][Fuchsia] Don't restrict Linux runtimes
to UNIX (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53970?vs=1
Author: phosek
Date: Thu Nov 1 13:36:33 2018
New Revision: 345889
URL: http://llvm.org/viewvc/llvm-project?rev=345889&view=rev
Log:
[CMake][Fuchsia] Don't restrict Linux runtimes to UNIX
This allows building Linux runtimes on any platform if the correct
sysroot is provided via CMake option.
Dif
ztamas updated this revision to Diff 172226.
ztamas added a comment.
Run clang-formats on files, remove unneeded empty lines, fix up documentation.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53974
Files:
clang-tidy/bugprone/BugproneTidyModule.cpp
clang-tidy/bugprone/CMa
ztamas marked 30 inline comments as done.
ztamas added a comment.
I fixed up formatting and the docs based on comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53974
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, MTC.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, jfb,
mikhail.ramalho, a.sidorin, rnkovacs, szepet, whisperity.
TL;DR: Interestingly, only about the quarter of the emitter file is used, th
Szelethus requested changes to this revision.
Szelethus added a comment.
This revision now requires changes to proceed.
I think @NoQ's list would be great to add! @dkrupp, as far as I'm aware, has
some works in progress to avoid the usage of HTML, so let's put this on hold
for a bit.
Repositor
aaron.ballman added inline comments.
Comment at: www/analyzer/checker_dev_manual.html:720
+Are Checkers.td and the CMakeLists entry alphabetically ordered?
+
+
Do we want to add an item for "Is the help text for the checker a useful
description of what the check
yinma created this revision.
Herald added subscribers: cfe-commits, chrib, kristof.beyls, javed.absar.
ARM64 setjmp expects sp on entry instead of framepointer.
Repository:
rC Clang
https://reviews.llvm.org/D53998
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/ms-setjmp.c
Index: test/Co
efriedma added a comment.
This is exactly the same as https://reviews.llvm.org/D53684, right? You don't
need another review.
Repository:
rC Clang
https://reviews.llvm.org/D53998
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
yinma added a comment.
re-upload due to the depended llvm patch need rework.
Repository:
rC Clang
https://reviews.llvm.org/D53998
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Szelethus added inline comments.
Comment at: www/analyzer/checker_dev_manual.html:720
+Are Checkers.td and the CMakeLists entry alphabetically ordered?
+
+
aaron.ballman wrote:
> Do we want to add an item for "Is the help text for the checker a useful
> descript
Author: vsapsai
Date: Thu Nov 1 14:57:05 2018
New Revision: 345897
URL: http://llvm.org/viewvc/llvm-project?rev=345897&view=rev
Log:
[CodeGen] Move `emitConstant` from ScalarExprEmitter to CodeGenFunction. NFC.
The goal is to use `emitConstant` in more places. Didn't move
`ComplexExprEmitter::em
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345897: [CodeGen] Move `emitConstant` from ScalarExprEmitter
to CodeGenFunction. NFC. (authored by vsapsai, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revi
vsapsai added a comment.
Thanks for the review, John. I'll update the comment with TODO and commit.
https://reviews.llvm.org/D53674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
keryell added a comment.
In https://reviews.llvm.org/D53705#1284268, @rjmccall wrote:
>
> Okay. So the purpose of OpenCL C++ is to provide a non-unified model that
> allows you to easily run C++ code on the CPU.
It is just the second-order purpose.
A C++-based kernel language to program ac
Szelethus updated this revision to Diff 172253.
Szelethus added a comment.
- Moved `std::string` implementation from `InnerPointerChecker`'s testfile to
the system header simulator header file.
https://reviews.llvm.org/D53856
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/Sta
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX345900: Fix test assumption that Linux implies glibc.
(authored by danalbert, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53956?vs=172038&id=172255#toc
Repository:
rCXX libc+
Szelethus added a comment.
A polite ping :)
https://reviews.llvm.org/D53483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Szelethus added a comment.
Polite ping. :)
https://reviews.llvm.org/D53692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yinma added a comment.
exactly the same
Repository:
rC Clang
https://reviews.llvm.org/D53998
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vsapsai
Date: Thu Nov 1 15:50:08 2018
New Revision: 345903
URL: http://llvm.org/viewvc/llvm-project?rev=345903&view=rev
Log:
[CodeGen] Fix assertion on referencing constexpr Obj-C object with ARC.
Failed assertion is
> Assertion failed: ((ND->isUsed(false) || !isa(ND) ||
> !E->getLocati
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345903: [CodeGen] Fix assertion on referencing constexpr
Obj-C object with ARC. (authored by vsapsai, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.ll
azharudd added a comment.
In https://reviews.llvm.org/D53912#1281584, @rnk wrote:
> This sounds like it would defeat what I'm assuming is the intended purpose of
> intrin0.h, which is to reduce compile time. intrin.h is kind of enormous, and
> the compile time problems are well-documented. We s
erik.pilkington created this revision.
erik.pilkington added reviewers: rjmccall, ahatanak.
Herald added a subscriber: dexonsmith.
LLVM IR, in it's infinite wisdom, doesn't relate `ConstantAggregate` and
`ConstantAggregateZero` through inheritance, so make sure we handle both cases
here. Fixes a
NoQ updated this revision to Diff 172263.
NoQ added a comment.
Ha! Apart from Zombie symbols that are neither dead nor alive and therefore not
buried properly, there are also Schrödinger symbols that are dead and alive at
the same time. Moreover, asking whether a Schrödinger symbol is `isLive()`
NoQ added a comment.
Just to be clear - this newly found problem is also automatically fixed by that
patch.
https://reviews.llvm.org/D18860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov,
rnkovacs.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus,
mikhail.ramalho, szepet, baloghadamsoftware.
In its `checkDeadSymbols` callback, when no pointers are tracked and the
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:4462-4463
+ DefaultIgnore;
+def ext_implicit_typename : ExtWarn<"implicit 'typename' is a C++2a
extension">,
+ InGroup;
Please make the start of this diagnostic match the no
tlively updated this revision to Diff 172280.
tlively added a comment.
- Wrap comment to 80 chars.
Repository:
rL LLVM
https://reviews.llvm.org/D53675
Files:
lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
test/CodeGen/WebAssembly/simd-
void updated this revision to Diff 172279.
void retitled this revision from "Compound literals, global array decls, and
enums require constant inits" to "Compound literals, enums, et al require const
expr".
void edited the summary of this revision.
void added a comment.
I believe this patch shou
leonardchan created this revision.
leonardchan added reviewers: rsmith, aaron.ballman.
leonardchan added a project: clang.
leonardchan added a dependent revision: D49511: [Sema/Attribute] Check for
noderef attribute.
leonardchan removed a dependent revision: D49511: [Sema/Attribute] Check for
nod
Author: rsmith
Date: Thu Nov 1 17:24:40 2018
New Revision: 345915
URL: http://llvm.org/viewvc/llvm-project?rev=345915&view=rev
Log:
When building a header module, treat inputs as headers rather than
source files.
This suppresses certain warnings (eg, '#include_next in main source
file').
Modifi
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, george.karpenkov.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus,
mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware.
This false negative bug was exposed by https://reviews.llvm.org/D18860. T
NoQ added a comment.
It also seems that we still have a false negative under ARC, but i didn't
bother investigating it. Just in case, i added `-fobjc-arc` run-lines to older
tests to see if there's any difference, and it turned out that there's no
difference.
Repository:
rC Clang
https://r
stephanemoore updated this revision to Diff 172285.
stephanemoore marked an inline comment as done.
stephanemoore added a comment.
Updated comments, release notes, and documentation to be consistent with the
implemented changes.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51
stephanemoore added a comment.
I believe that it should be safe to remove the `Acronyms` and
`IncludeDefaultAcronyms` options but if it's alright with you, I would prefer
to separate that into a followup change.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:28-31
NoQ accepted this revision.
NoQ added a comment.
The new addition makes perfect sense, please feel free to commit :) Eventually
i guess we'll need to declare where is this checker going and what specific
lint rule is this checker designed to check, document this rule, and move it to
`optin` onc
NoQ accepted this revision.
NoQ added a comment.
Looks great, let's land? Not sure if i already asked - am i understanding
correctly that this is a "poor-man's" support for macro expansions for tools
that read plists but do not support those new plist macro dictionaries yet?
Also i wanted to ha
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Because i don't know much about macros, i shouldn't be blocking this review on
waiting for myself to understand the code :) I guess we'll eventually figure
out if something is wrong with it.
https
stephanemoore marked an inline comment as done.
stephanemoore added a comment.
https://reviews.llvm.org/D51832 is in review to update the
objc-property-declaration check to allow arbitrary acronyms and initialisms.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51575
___
stephanemoore updated this revision to Diff 172296.
stephanemoore added a comment.
Updated diff after pulling and merging.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51575
Files:
clang-tidy/google/CMakeLists.txt
clang-tidy/google/FunctionNamingCheck.cpp
clang-tidy/goo
NoQ accepted this revision.
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:677
+/// need to expanded further when it is nested inside another macro.
+class MacroArgMap : public std::map {
+public:
Szelethus wrote:
> Szelethus
NoQ added a comment.
Ok, so where do we put it? :)
I think we should put the everyday checklist into the checker developer manual
under a title like "Making Your Checker Better" and put the out-of-alpha
checklist somewhere into docs/analyzer as plain text (because that's not a sort
of info you
NoQ accepted this revision.
NoQ added a comment.
> haha!
:D
https://reviews.llvm.org/D52986
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Yay.
https://reviews.llvm.org/D52988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
void updated this revision to Diff 172297.
Repository:
rC Clang
https://reviews.llvm.org/D53921
Files:
include/clang/AST/Expr.h
include/clang/ASTMatchers/ASTMatchers.h
lib/AST/ASTImporter.cpp
lib/AST/Expr.cpp
lib/AST/ExprConstant.cpp
lib/ASTMatchers/ASTMatchersInternal.cpp
lib/AS
Author: tstellar
Date: Thu Nov 1 20:02:31 2018
New Revision: 345947
URL: http://llvm.org/viewvc/llvm-project?rev=345947&view=rev
Log:
Creating release candidate rc1 from release_701 branch
Added:
libunwind/tags/RELEASE_701/rc1/ (props changed)
- copied from r345946, libunwind/branche
Author: tstellar
Date: Thu Nov 1 20:02:29 2018
New Revision: 345946
URL: http://llvm.org/viewvc/llvm-project?rev=345946&view=rev
Log:
Creating release directory for release_701.
Added:
libunwind/tags/RELEASE_701/
___
cfe-commits mailing list
cfe-c
This is triggering an assertion failure in our build, I've filed
PR39528 which also has a reproducer.
On Mon, Oct 29, 2018 at 7:04 PM Richard Smith via cfe-commits
wrote:
>
> Author: rsmith
> Date: Mon Oct 29 19:02:49 2018
> New Revision: 345562
>
> URL: http://llvm.org/viewvc/llvm-project?rev=34
NoQ added a comment.
@Charusso, i believe you have some misconception about what constraints mean
and how they work. Not sure what this misconception is, so i'll make a blind
guess and annoy you a little bit with a narcissistic rant and you'll have to
bear me, sry!
The most important thing to
NoQ accepted this revision.
NoQ added a comment.
Yup, seems fine, please feel free to land! The `AggressiveReport` option looks
unused, we should probably remove it. Sry it took so long><
https://reviews.llvm.org/D53276
___
cfe-commits mailing list
NoQ accepted this revision.
NoQ added a comment.
In https://reviews.llvm.org/D53277#1270141, @Szelethus wrote:
> In https://reviews.llvm.org/D53277#1269960, @NoQ wrote:
>
> > I think this is awesome o_o
>
>
> I'm glad you like it ^-^
I mean, do i have a choice? Like, seriously, it's... beautifu
NoQ added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:146-149
+/// If you'd like to add a new -cc1 flag, add it to
+/// include/clang/Driver/CC1Options.td, add a new field to store the value of
+/// that flag in this class, and initialize it i
Author: maskray
Date: Thu Nov 1 21:09:08 2018
New Revision: 345950
URL: http://llvm.org/viewvc/llvm-project?rev=345950&view=rev
Log:
Fix -Wimplicit-fallthrough warning in LLVM_ENABLE_ASSERTIONS=Off builds
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/BasicValueFactory.cpp
Modified: cfe/trunk/
NoQ added a comment.
I guess i'm running out of steam for today :)
> `Opts.shouldDoThat()` -> `Opts.ShouldDoThat.getValue()`
Is this really unavoidable? Like, what makes them optional when they're always
non-optional? Maybe just somehow prevent un-eagerly-initialized AnalyzerConfig
from appear
Author: maskray
Date: Thu Nov 1 21:17:17 2018
New Revision: 345951
URL: http://llvm.org/viewvc/llvm-project?rev=345951&view=rev
Log:
Fix -Wimplicit-fallthrough warning in LLVM_ENABLE_ASSERTIONS=Off builds
Modified:
clang-tools-extra/trunk/clang-tidy/cert/StrToNumCheck.cpp
Modified: clang-to
Author: maskray
Date: Thu Nov 1 21:23:50 2018
New Revision: 345952
URL: http://llvm.org/viewvc/llvm-project?rev=345952&view=rev
Log:
[clangd] Fix clang -Wimplicit-fallthrough
Modified:
clang-tools-extra/trunk/clangd/CodeComplete.cpp
Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp
rjmccall added a comment.
In https://reviews.llvm.org/D53705#1284734, @keryell wrote:
> In https://reviews.llvm.org/D53705#1284268, @rjmccall wrote:
>
> >
>
>
>
>
> > Okay. So the purpose of OpenCL C++ is to provide a non-unified model that
> > allows you to easily run C++ code on the CPU.
>
>
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1142
+ llvm_unreachable("Unexpected Base constant type!");
+}
Is `getAggregateElement` not good enough here?
Repository:
rC Clang
https://reviews.llvm.org/D54010
_
takuto.ikuta updated this revision to Diff 172304.
takuto.ikuta marked 17 inline comments as done.
takuto.ikuta added a comment.
Simplify test and fix some behavior.
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/LangOptions.def
clang/in
takuto.ikuta added a comment.
Hans, thank you for review! I addressed all your comment and fixed small
behavior.
Comment at: clang/test/CodeGenCXX/dllexport-no-dllexport-inlines.cpp:76
+ // DEFAULT-NOT: InlineOutclassDefFunc@NoTemplateExportedClass@@
+ __forceinline void Inl
erik.pilkington updated this revision to Diff 172306.
erik.pilkington marked an inline comment as done.
erik.pilkington added a comment.
Use `getAggregateElement`. Thanks!
https://reviews.llvm.org/D54010
Files:
clang/lib/CodeGen/CGExprConstant.cpp
clang/test/CodeGen/designated-initializers.
erik.pilkington added inline comments.
Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1142
+ llvm_unreachable("Unexpected Base constant type!");
+}
rjmccall wrote:
> Is `getAggregateElement` not good enough here?
No, `getAggregateElement` is perfect,
Author: maskray
Date: Thu Nov 1 22:59:29 2018
New Revision: 345953
URL: http://llvm.org/viewvc/llvm-project?rev=345953&view=rev
Log:
[clangd] Really fix clang -Wimplicit-fallthrough
The intention was to fall through to Function case in
LLVM_ENABLE_ASSERTIONS=Off builds.
Use #ifndef NDEBUG to f
lebedev.ri added a comment.
In https://reviews.llvm.org/D53949#1283872, @regehr wrote:
> Regarding ++ and --, I think for now it's fine to just document that these
> aren't instrumented.
Indeed, that is a different issue, i don't want to solve it in this
differential.
Though, there currently
101 - 192 of 192 matches
Mail list logo
