kbobyrev created this revision.
kbobyrev added reviewers: sammccall, ioeric.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous.
https://reviews.llvm.org/D51527
Files:
clang-tools-extra/clangd/FileDistance.cpp
clang-tools-extra/clangd/FileDistan
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/FileDistance.cpp:56
-constexpr const unsigned FileDistance::kUnreachable;
-
I think this is required - are y
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM, note that this change will break our next internal integration.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51504
___
c
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, sammccall.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous.
- Use consistent assertion messages in iterators implementations
- Silence a bunch of clang-tidy warnings: use `emplace_b
kbobyrev updated this revision to Diff 163474.
https://reviews.llvm.org/D51527
Files:
clang-tools-extra/clangd/FileDistance.cpp
clang-tools-extra/clangd/FileDistance.h
Index: clang-tools-extra/clangd/FileDistance.h
===
--- clan
Author: omtcyfz
Date: Fri Aug 31 01:19:50 2018
New Revision: 341182
URL: http://llvm.org/viewvc/llvm-project?rev=341182&view=rev
Log:
[NFC] Use LLVM naming conventions within FileDistance
Reviewed by: sammccall
Differential Revision: https://reviews.llvm.org/D51527
Modified:
clang-tools-ext
kbobyrev added a comment.
The next step would be to move Dex to index/ and slightly simplify file
structure, but I guess I should consider doing that after
https://reviews.llvm.org/D51422 lands, otherwise it's a lot of effort to keep
rebasing everything on top of different patches.
https://re
hokein closed this revision.
hokein added a comment.
Thanks @aaron.ballman. I'm closing it now as it is committed in
https://reviews.llvm.org/rL340915.
https://reviews.llvm.org/D51061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE341182: [NFC] Use LLVM naming conventions within
FileDistance (authored by omtcyfz, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51527?vs=163474&id=163476#toc
Repository:
rCTE
Author: omtcyfz
Date: Fri Aug 31 01:29:48 2018
New Revision: 341184
URL: http://llvm.org/viewvc/llvm-project?rev=341184&view=rev
Log:
NFC: Fix build failure after rL341182
Didn't rename another variable reference.
Modified:
clang-tools-extra/trunk/clangd/FileDistance.cpp
Modified: clang-too
ioeric accepted this revision.
ioeric added a comment.
lg
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/index/dex/DexIndex.cpp:33
std::vector Result = generateIdentifierTrigrams(Sym.Name);
- Result.push_back(Token(Token::Kind::Scope,
Szelethus updated this revision to Diff 163479.
Szelethus added a comment.
Fixed a crash, where the super region was symbolic.
In https://reviews.llvm.org/D50892#1218060, @NoQ wrote:
> Let's commit then?
I'd be much more comfortable landing https://reviews.llvm.org/D51057 before
modifying der
stryku marked 2 inline comments as done.
stryku added a comment.
@Rakete or anyone else, any more comments? (:
Comment at: test/SemaCXX/warn-unsequenced-cxx17.cpp:7
+ // expected-no-diagnostics
+ p[(long long unsigned)(p = 0)] // ok
+}
Rakete wrote:
>
kbobyrev updated this revision to Diff 163485.
kbobyrev marked 2 inline comments as done.
https://reviews.llvm.org/D51528
Files:
clang-tools-extra/clangd/index/dex/DexIndex.cpp
clang-tools-extra/clangd/index/dex/DexIndex.h
clang-tools-extra/clangd/index/dex/Iterator.cpp
clang-tools-extra/
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet,
whisperity.
Especially with pointees, it a lot of meaningless reports came from
uninitialized regions that were alrea
mstorsjo created this revision.
mstorsjo added reviewers: cdavis5x, rnk.
Herald added a reviewer: javed.absar.
Herald added subscribers: chrib, kristof.beyls.
Even though SEH for ARM is incomplete, make what code already exists at least
compile correctly.
The _LIBUNWIND_CURSOR_SIZE wasn't correc
Szelethus added a comment.
Would you be comfortable me commiting this without that assert, or should I
come up with a more risk-free solution?
Repository:
rC Clang
https://reviews.llvm.org/D51300
___
cfe-commits mailing list
cfe-commits@lists.ll
Author: omtcyfz
Date: Fri Aug 31 02:17:02 2018
New Revision: 341190
URL: http://llvm.org/viewvc/llvm-project?rev=341190&view=rev
Log:
[NFC] Cleanup Dex
* Use consistent assertion messages in iterators implementations
* Silence a bunch of clang-tidy warnings: use `emplace_back` instead of
`push_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341190: [NFC] Cleanup Dex (authored by omtcyfz, committed by
).
Herald added subscribers: llvm-commits, ilya-biryukov.
Changed prior to commit:
https://reviews.llvm.org/D51528?vs=163485&id=163489#toc
R
kbobyrev added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:48
+// loading.
+class AsyncLoadIndex : public SymbolIndex {
+public:
Also, do we want only static index to be built asynchronously? Do we want it to
be used only in our Clangd tool driver? L
martong created this revision.
martong added reviewers: a_sidorin, r.stahl, xazax.hun.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs.
Herald added a reviewer: a.sidorin.
Some `Expr` classes set up default values for the `ExprBits` of `Stmt`. These
default values are then overwritten by
kbobyrev added inline comments.
Comment at: clangd/index/Index.h:416
+ // until the call returns (even if reset() is called).
+ bool fuzzyFind(const FuzzyFindRequest &,
+ llvm::function_ref) const override;
Do we want these functions to be `fina
theraven added a comment.
This revision broke blocks on all ELF targets. The block descriptors' symbol
names can now include the @ character, which is reserved on ELF platforms as a
separator between symbol name and symbol version. As a result, nothing
containing a block that has an Objective
theraven added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:163
+ std::string TypeAtEncoding =
+ CGM.getContext().getObjCEncodingForBlock(BlockInfo.getBlockExpr());
+ Name += "e" + llvm::to_string(TypeAtEncoding.size()) + "_" + TypeAtEncoding;
Spe
kristina added a comment.
Giving it a second glance, just as an idea, maybe it's better to leave ObjC
pragmas out for now, for another more narrower-scope revision/review specific
to ObjC(/Swift)? Since they could cause incorrect code generation if combined
in odd ways (as well as making no sen
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
This basically looks good to go (some fixes needed but they're pretty clear I
think let me know if not!)
Comment at: clangd/index/FileIndex.cpp:63
+ auto Occurrences
Szelethus updated this revision to Diff 163499.
Szelethus added a comment.
Reuploaded with `-U9`. Oops.
https://reviews.llvm.org/D51057
Files:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341201: [docs][mips] Clang 7.0 Release notes (authored by
atanasyan, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51356?vs=162850&id=163501
atanasyan added a comment.
Thanks for review.
Repository:
rL LLVM
https://reviews.llvm.org/D51356
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kbobyrev updated this revision to Diff 163507.
kbobyrev added a comment.
Canonicalize URIs, slightly simplify code structure.
https://reviews.llvm.org/D51481
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/DexIndex.cpp
clang-tools-extra/clangd/index/dex/D
aaron.ballman added a comment.
In https://reviews.llvm.org/D51333#1219938, @rsmith wrote:
> Instead of guessing whether the corrected filename would be valid, why not
> strip off the leading and trailing non-alphanumeric characters, look up the
> resulting filename, and find out? If we did that
On Thu, Aug 30, 2018 at 4:12 PM, Richard Smith wrote:
> On Thu, 30 Aug 2018 at 12:27, Aaron Ballman via cfe-commits
> wrote:
>>
>> On Thu, Aug 30, 2018 at 3:21 PM, Richard Smith - zygoloid via
>> Phabricator wrote:
>> > rsmith marked an inline comment as done.
>> > rsmith added inline comments.
aaron.ballman added a comment.
I think the fix generally looks good, but can you please add some test coverage
for the change?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51192
___
cfe-commits mailing list
cfe-commits@lists.llvm
aaron.ballman added inline comments.
Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:50
// CHECK-NEXT: EnumExtensibility (SubjectMatchRule_enum)
+// CHECK-NEXT: ExtVectorType (SubjectMatchRule_type_alias)
// CHECK-NEXT: ExternalSourceSymbol ((SubjectMatchR
hokein updated this revision to Diff 163512.
hokein added a comment.
Address review comments in https://reviews.llvm.org/D51279.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50385
Files:
clangd/index/Index.cpp
clangd/index/Index.h
clangd/index/SymbolCollector.cpp
clan
hokein marked 3 inline comments as done.
hokein added a comment.
Sorry! Just realised I messed up this patch with
https://reviews.llvm.org/D50385 (mostly SymbolCollector changes), all the
comments about `SymbolCollector` are fixed in https://reviews.llvm.org/D50385.
Repository:
rCTE Clang To
aaron.ballman added inline comments.
Comment at: include/clang/AST/Type.h:4343
QualType getEquivalentType() const { return EquivalentType; }
+ IdentifierInfo *getAddressSpaceMacroII() const { return AddressSpaceMacroII;
}
+ bool hasAddressSpaceMacroII() const { return Addre
Author: hokein
Date: Fri Aug 31 05:54:13 2018
New Revision: 341208
URL: http://llvm.org/viewvc/llvm-project?rev=341208&view=rev
Log:
[clangd] Collect symbol occurrences in SymbolCollector.
SymbolCollector will be used for two cases:
- collect Symbol type only, used for indexing preamble AST.
-
hokein closed this revision.
hokein added a comment.
Committed in https://reviews.llvm.org/rL341208.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, sammccall.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
Currently, `SymbolIndex::estimateMemoryUsage()` returns the "overhead"
estimate, i.e. the estimate of the Index
baloghadamsoftware updated this revision to Diff 163517.
baloghadamsoftware removed a reviewer: george.karpenkov.
baloghadamsoftware added a comment.
Herald added a reviewer: george.karpenkov.
Since https://reviews.llvm.org/rL338263 fixed a bug in the cleanup phase the
tests for mismatched iterat
dexonsmith added inline comments.
Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:50
// CHECK-NEXT: EnumExtensibility (SubjectMatchRule_enum)
+// CHECK-NEXT: ExtVectorType (SubjectMatchRule_type_alias)
// CHECK-NEXT: ExternalSourceSymbol ((SubjectMatchRule
kbobyrev planned changes to this revision.
kbobyrev added a comment.
I should use `SymbolSlab.bytes()` instead of `SymbolSlab.size()`. Either way,
something seems to be wrong, because manually checking the `PairedSlabSize`
made me suspicious.
https://reviews.llvm.org/D51539
ioeric added inline comments.
Comment at: clangd/index/dex/DexIndex.h:42
+ // All symbols must outlive this index.
+ template DexIndex(Range &&Symbols) {
+for (auto &&Sym : Symbols)
Why is this constructor needed? I think this could restrict the flexibilit
On Fri, Aug 31, 2018 at 9:23 AM, Duncan P. N. Exon Smith via
Phabricator wrote:
> dexonsmith added inline comments.
>
>
>
> Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:50
> // CHECK-NEXT: EnumExtensibility (SubjectMatchRule_enum)
> +// CHECK-NEXT: ExtVec
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/CodeComplete.cpp:396
+// Prefer includes that do not need edits (i.e. already exist).
+std::stable_sort(Completion.Includes.begin(), Comp
Author: cdavis
Date: Fri Aug 31 06:41:05 2018
New Revision: 341210
URL: http://llvm.org/viewvc/llvm-project?rev=341210&view=rev
Log:
[AddressSpace] Use the macro to set hidden visibility on LocalAddressSpace.
Summary:
That attribute has no effect on Windows anyway--classes are hidden by
default.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341210: [AddressSpace] Use the macro to set hidden
visibility on LocalAddressSpace. (authored by cdavis, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llv
sammccall added inline comments.
Comment at: clangd/index/Index.h:416
+ // until the call returns (even if reset() is called).
+ bool fuzzyFind(const FuzzyFindRequest &,
+ llvm::function_ref) const override;
kbobyrev wrote:
> Do we want these fu
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/DexIndex.cpp:137
+ BoostingIterators.push_back(
+ createBoost(create(It->second), P.second + 10));
+ }
Could you comment on `P.second + 10` here? It sounds lik
kbobyrev updated this revision to Diff 163523.
kbobyrev added a comment.
Resolved the issues. Measurements show that static Dex index for LLVM takes
~140 MB, ~80 MB of which is the size of `SymbolSlab`.
https://reviews.llvm.org/D51539
Files:
clang-tools-extra/clangd/index/FileIndex.cpp
cl
sammccall added a comment.
This looks reasonable!
This is going to conflict with https://reviews.llvm.org/D51422, you might want
to rebase.
Comment at: clang-tools-extra/clangd/index/MemIndex.h:26
+ void build(std::shared_ptr> Symbols,
+ size_t SlabSize=0);
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341211: [clangd] Flatten out Symbol::Details. It was
ill-conceived, sorry. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/
Author: sammccall
Date: Fri Aug 31 06:55:01 2018
New Revision: 341211
URL: http://llvm.org/viewvc/llvm-project?rev=341211&view=rev
Log:
[clangd] Flatten out Symbol::Details. It was ill-conceived, sorry.
Reviewers: ioeric
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commi
cdavis5x added inline comments.
Comment at: src/assembly.h:76-78
+ .section .drectve,"yn" SEPARATOR\
+ .ascii "-export:", #name, "\0" SEPARATOR\
+ .text
rnk wrote:
> Maybe .pushsection / .popsection is better than assumi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341212: [DEBUGINFO] Add support for emission of the debug
directives only. (authored by ABataev, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D5
Author: abataev
Date: Fri Aug 31 06:56:14 2018
New Revision: 341212
URL: http://llvm.org/viewvc/llvm-project?rev=341212&view=rev
Log:
[DEBUGINFO] Add support for emission of the debug directives only.
Summary:
Added option -gline-directives-only to support emission of the debug directives
only. I
hokein updated this revision to Diff 163531.
hokein marked 4 inline comments as done.
hokein added a comment.
- rebase
- address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51279
Files:
clangd/index/FileIndex.cpp
clangd/index/FileIndex.h
clangd/index/In
hokein updated this revision to Diff 163532.
hokein added a comment.
Minor cleanup.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51279
Files:
clangd/index/FileIndex.cpp
clangd/index/FileIndex.h
clangd/index/Index.h
clangd/index/MemIndex.cpp
clangd/index/MemIndex.h
hokein added inline comments.
Comment at: clangd/index/MemIndex.cpp:35
std::unique_ptr MemIndex::build(SymbolSlab Slab) {
auto Idx = llvm::make_unique();
sammccall wrote:
> This is still implicitly creating an index with no occurrences. Did you mean
> to a
ioeric added inline comments.
Comment at: clangd/index/MemIndex.h:30
+ /// Builds an index from a slab. The shared_ptr manages the slab's lifetime.
+ static std::shared_ptr build(SymbolSlab Slab);
sammccall wrote:
> ioeric wrote:
> > (It's a bit unfortunate t
christylee marked 2 inline comments as done.
christylee added a comment.
In https://reviews.llvm.org/D51333#1219938, @rsmith wrote:
> Instead of guessing whether the corrected filename would be valid, why not
> strip off the leading and trailing non-alphanumeric characters, look up the
> result
sammccall added inline comments.
Comment at: unittests/clangd/TestTU.h:41
+ static TestTU withAllCode(llvm::StringRef HeaderCode, llvm::StringRef Code,
+llvm::StringRef Filename = "") {
hokein wrote:
> sammccall wrote:
> > We've avo
Author: mstorsjo
Date: Fri Aug 31 07:56:55 2018
New Revision: 341217
URL: http://llvm.org/viewvc/llvm-project?rev=341217&view=rev
Log:
Fix existing code for SEH on ARM to compile correctly
Even though SEH for ARM is incomplete, make what code already exists
at least compile correctly.
The _LIBUN
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341217: Fix existing code for SEH on ARM to compile
correctly (authored by mstorsjo, committed by ).
Herald added subscribers: llvm-commits, christof.
Changed prior to commit:
https://reviews.llvm.org/D
jkorous created this revision.
jkorous added reviewers: arphaman, vsapsai, dexonsmith, rsmith.
jkorous added a project: clang.
Herald added subscribers: cfe-commits, mgorny.
It's rather error-prone to leave that member variable uninitialized. The
DeclAccessPair seems to be intentionally POD and i
sammccall added inline comments.
Comment at: clangd/index/FileIndex.h:47
+ // The shared_ptr keeps the symbols alive.
+ std::shared_ptr buildMemIndex();
ioeric wrote:
> Maybe avoid hardcoding the index name, so that we could potentially switch to
> use a dif
kbobyrev updated this revision to Diff 163537.
kbobyrev marked 14 inline comments as done.
https://reviews.llvm.org/D51481
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/DexIndex.cpp
clang-tools-extra/clangd/index/dex/DexIndex.h
clang-tools-extra/clangd/
phosek added a comment.
In https://reviews.llvm.org/D51440#1218859, @mstorsjo wrote:
> I'll see if I can get to looking at that sometime soon. I had this patch
> lying around as an attempt to work around the libtool issue in
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27866 which doesn't se
kbobyrev updated this revision to Diff 163538.
kbobyrev marked an inline comment as not done.
kbobyrev added a comment.
Fix tests
https://reviews.llvm.org/D51481
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/DexIndex.cpp
clang-tools-extra/clangd/index/d
hokein updated this revision to Diff 163539.
hokein marked 3 inline comments as done.
hokein added a comment.
address review comments:
- build memindex with symbol slab and occurrence slab
- remove withAllCode in TestTU
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51279
File
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Token.h:54
Scope,
+/// Path to symbol declaration.
+///
ioeric wrote:
> As this is called `Path`, I'd try to decouple it from URIs, so that we don't
> need special handli
mstorsjo added a comment.
In https://reviews.llvm.org/D51440#1220925, @phosek wrote:
> In https://reviews.llvm.org/D51440#1218859, @mstorsjo wrote:
>
> > I'll see if I can get to looking at that sometime soon. I had this patch
> > lying around as an attempt to work around the libtool issue in
>
asavonic created this revision.
asavonic added reviewers: Anastasia, yaxunl, bader.
Herald added subscribers: cfe-commits, jfb, mgorny.
TL;DR
-
This patch splits huge opencl-c.h header into multiple headers to
support efficient use of Precompiled Headers (or Modules):
- opencl-c-defs.h conta
eandrews created this revision.
eandrews added reviewers: lebedev.ri, rsmith, rjmccall, rnk, mclow.lists,
erichkeane.
GCC enables -Wtype-limits under -Wextra. Warnings under GCC's -Wtype-limits is
covered in Clang by -Wtautological-type-limit-compare and
-Wtautological-unsigned-zero-compare.
S
kbobyrev planned changes to this revision.
kbobyrev added a comment.
I'll rebase it on top of https://reviews.llvm.org/D51422 and address the last
comment before proceeding to the review.
https://reviews.llvm.org/D51539
___
cfe-commits mailing list
Szelethus updated this revision to Diff 163542.
https://reviews.llvm.org/D51531
Files:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp
lib/StaticAnalyzer/Checkers/UninitializedObject/Uniniti
eandrews added a comment.
@lebedev.ri is there a specific reason -Wtautological-unsigned-zero-compare was
removed? All the issues I am aware of talks about comparisons with min/max.
https://reviews.llvm.org/D51545
___
cfe-commits mailing list
cfe-c
lebedev.ri added reviewers: thakis, vsk, phosek.
lebedev.ri added a comment.
In https://reviews.llvm.org/D51545#1220967, @eandrews wrote:
> @lebedev.ri is there a specific reason -Wtautological-unsigned-zero-compare
> was removed? All the issues I am aware of talks about comparisons with
> min/
usaxena95 updated this revision to Diff 163549.
usaxena95 marked 15 inline comments as done.
usaxena95 added a comment.
- Made suggested changes.
Repository:
rC Clang
https://reviews.llvm.org/D51359
Files:
include/clang/Basic/VirtualFileSystem.h
lib/Basic/VirtualFileSystem.cpp
unittest
srhines accepted this revision.
srhines added a comment.
This revision is now accepted and ready to land.
Thanks for cleaning this up and adding better checks for Android. :)
Repository:
rC Clang
https://reviews.llvm.org/D51521
___
cfe-commits ma
usaxena95 added a comment.
Made the suggested changes.
Comment at: include/clang/Basic/VirtualFileSystem.h:359
+ public:
+ /// Add a HardLink to a File.
+ /// The To path must be an existing file or a hardlink. The From file must
not
ilya-biryukov wrote:
>
Author: saugustine
Date: Fri Aug 31 10:59:03 2018
New Revision: 341231
URL: http://llvm.org/viewvc/llvm-project?rev=341231&view=rev
Log:
Refactor Addlibgcc to make the when and what logic more straightfoward.
Add Android tests.
Modified:
cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp
cf
saugustine closed this revision.
saugustine added a comment.
commited as r341231.
Repository:
rC Clang
https://reviews.llvm.org/D51521
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: src/assembly.h:76-78
+ .section .drectve,"yn" SEPARATOR\
+ .ascii "-export:", #name, "\0" SEPARATOR\
+ .text
---
Author: cdavis
Date: Fri Aug 31 11:11:48 2018
New Revision: 341232
URL: http://llvm.org/viewvc/llvm-project?rev=341232&view=rev
Log:
Export public functions implemented in assembly on Windows.
Summary:
By default, symbols aren't visible outside of the module that defines
them. To make them visibl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341232: Export public functions implemented in assembly on
Windows. (authored by cdavis, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D51508
Fi
Author: ctopper
Date: Fri Aug 31 11:22:52 2018
New Revision: 341234
URL: http://llvm.org/viewvc/llvm-project?rev=341234&view=rev
Log:
[X86] Add kshift intrinsics to match gcc and icc.
This adds the following intrinsics:
_kshiftli_mask8
_kshiftli_mask16
_kshiftli_mask32
_kshiftli_mask64
_kshiftri_
ahatanak added a comment.
The GNUstep documentation I found replaces '@' with '\1'. Would that fix the
problem?
https://github.com/gnustep/libobjc2/blob/master/ABIDoc/abi.tex
Repository:
rC Clang
https://reviews.llvm.org/D50783
___
cfe-commits
Hello Zachary,
It looks like this commit added broken tests on one of our builders:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/19508
. . .
Failing Tests (2):
LLVM-Unit :: ADT/./ADTTests.exe/HashingTest.HashCombineRangeGoldenTest
Clang :: Code
On Fri, 31 Aug 2018 at 06:35, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> My reasoning is because type attributes have more impact than variable
> attributes and types appear more frequently. Consider using
> address_space where the region includes function definitions. Sh
Author: tnorthover
Date: Fri Aug 31 12:24:37 2018
New Revision: 341240
URL: http://llvm.org/viewvc/llvm-project?rev=341240&view=rev
Log:
Tests: fix tests encoding specific hash values for 32-bit systems.
I changed the seed slightly, but forgot to run the tests on a 32-bit system, so
tests which h
jfb updated this revision to Diff 163577.
jfb added a comment.
- Don't diagnose initialization, only assignment.
Repository:
rC Clang
https://reviews.llvm.org/D51084
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/Sema/atomic-implicit-seq_cst.c
test/S
ABataev created this revision.
ABataev added reviewers: tra, echristo.
Herald added subscribers: JDevlieghere, guansong, aprantl.
Added support for the -gline-directives-only option + fixed logic of the
debug info for CUDA devices. If optimization level is O0, then options
--[no-]cuda-noopt-device
Author: hokein
Date: Fri Aug 31 12:53:37 2018
New Revision: 341242
URL: http://llvm.org/viewvc/llvm-project?rev=341242&view=rev
Log:
[clangd] Implement findOccurrences interface in dynamic index.
Summary:
Implement the interface in
- FileIndex
- MemIndex
- MergeIndex
Depends on https://rev
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE341242: [clangd] Implement findOccurrences interface in
dynamic index. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51279?vs=163539&id=163580#toc
Repository
Are we sure it was my commit? Because this seems like a very unusual
failure given the nature of the commit. I'll try to reproduce it locally
and report back.
On Fri, Aug 31, 2018 at 11:49 AM Galina Kistanova
wrote:
> Hello Zachary,
>
> It looks like this commit added broken tests on one of ou
It looks like tnorthover has fixed these in r341240
On Fri, Aug 31, 2018 at 1:08 PM Zachary Turner wrote:
> Are we sure it was my commit? Because this seems like a very unusual
> failure given the nature of the commit. I'll try to reproduce it locally
> and report back.
>
> On Fri, Aug 31, 201
The builder is just fixed, so I am wrong. Sorry to bother you.
Thanks
Galina
On Fri, Aug 31, 2018 at 1:08 PM Zachary Turner wrote:
> Are we sure it was my commit? Because this seems like a very unusual
> failure given the nature of the commit. I'll try to reproduce it locally
> and report ba
1 - 100 of 120 matches
Mail list logo
