ioeric added inline comments.
================
Comment at: clangd/index/dex/DexIndex.h:42
+ // All symbols must outlive this index.
+ template <typename Range> DexIndex(Range &&Symbols) {
+ for (auto &&Sym : Symbols)
----------------
Why is this constructor needed? I think this could restrict the flexibility of
DexIndex initialization, in case we need to pass in extra parameters here.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51422
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits