[PATCH] D50845: [CUDA/OpenMP] Define only some host macros during device compilation

Hahnfeld updated this revision to Diff 162328. Hahnfeld added a comment. Herald added a subscriber: krytarowski. Add required macros for compiling C++ code. https://reviews.llvm.org/D50845 Files: lib/Frontend/InitPreprocessor.cpp test/Preprocessor/aux-triple.c test/SemaCUDA/builtins.cu I

[PATCH] D51154: [clangd] Log memory usage of DexIndex and MemIndex

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:123 + size_t Bytes = Index.estimateMemoryUsage(); + for (const auto &Scheme : URISchemes) { +// std::

[PATCH] D51029: [clangd] Implement LIMIT iterator

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:109 + float consume() override { +if (reachedEnd()) return DEFAULT_BOOST_SCORE; this isn't possible, as the item being consumed is the value of peek(). You co

[PATCH] D51154: [clangd] Log memory usage of DexIndex and MemIndex

kbobyrev updated this revision to Diff 162334. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Address few concerns. https://reviews.llvm.org/D51154 Files: clang-tools-extra/clangd/index/FileIndex.cpp clang-tools-extra/clangd/index/FileIndex.h clang-tools-extra/clangd

[PATCH] D50962: [clangd] Speculative code completion index request before Sema is run.

ioeric updated this revision to Diff 162335. ioeric added a comment. - fix typos.. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50962 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/CodeComplete.cpp clangd/CodeComplete.h clangd/TUScheduler.h clangd/ind

[PATCH] D51154: [clangd] Log memory usage of DexIndex and MemIndex

kbobyrev added a comment. In https://reviews.llvm.org/D51154#1211376, @ioeric wrote: > Do we plan to expose an API in `ClangdServer` to allow C++ API users to track > index memory usages? I think we do, IIUC the conclusion of the offline discussion was that it might be useful for the clients.

[PATCH] D51061: [clang-tidy] abseil-str-cat-append

JonasToth added inline comments. Comment at: clang-tidy/abseil/StrCatAppendCheck.cpp:21 +namespace { + +// Skips any combination of temporary materialization, temporary binding and I think you can elide the empty line around the matcher. Commen

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

JonasToth added a comment. ping @alexfh what is your take on the issue? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D51159: [FileManager] Do not call 'real_path' in getFile().

ioeric added inline comments. Comment at: lib/Basic/FileManager.cpp:319 - SmallString<128> RealPathName; - if (!FS->getRealPath(InterndFileName, RealPathName)) -UFE.RealPathName = RealPathName.str(); + if (UFE.File) { +if (auto Path = UFE.File->getName()) { -

[PATCH] D51159: [FileManager] Do not call 'real_path' in getFile().

ioeric updated this revision to Diff 162337. ioeric added a comment. - Compute absolute paths even when file is not opened. Repository: rC Clang https://reviews.llvm.org/D51159 Files: lib/Basic/FileManager.cpp Index: lib/Basic/FileManager.cpp =

[PATCH] D51204: [COFF, ARM64] Add MS intrinsics: __getReg, _ReadStatusReg, _WriteStatusReg

mstorsjo added a comment. In MSVC, these ones seem to be declared in intrin.h, not in the arm64intr.h subheader, so to match closely perhaps we should declare them there as well? The test, arm64-microsoft-intrinsics.c, doesn't actually include intrin.h nor arm64intr.h, so this test doesn't actu

[PATCH] D51159: [FileManager] Do not call 'real_path' in getFile().

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM from my side. We need this to unbreak performance in code completion Repository: rC Clang https://reviews.llvm.org/D51159 _

[PATCH] D51036: clang-format: Fix formatting C++ namespaces with preceding 'inline' or 'export' specifier

sammccall accepted this revision. sammccall added a comment. Nice fix! Comment at: lib/Format/Format.cpp:1312 auto &Line = *AnnotatedLines[i]; if (Line.startsWith(tok::kw_namespace) || + Line.startsWith(tok::kw_inline, tok::kw_namespace) || --

[PATCH] D50502: [clangd] Initial cancellation mechanism for LSP requests.

ilya-biryukov added a comment. Mostly NITs, but please take a look at the potential data race Comment at: clangd/Cancellation.cpp:23 +const Task &getCurrentTask() { + return *Context::current().getExisting(TaskKey); +} Maybe add 'assert' that TaskKey is presen

[PATCH] D51036: clang-format: Fix formatting C++ namespaces with preceding 'inline' or 'export' specifier

sammccall added inline comments. Comment at: unittests/Format/FormatTest.cpp:7582 Style); + verifyFormat("export namespace Foo\n" + "{};", you may want to add tests for other modules TS syntax (e.g. non-namespace export decls). It

[PATCH] D51155: [clangd] Allow to merge symbols on-the-fly in global-symbol-builder

ilya-biryukov updated this revision to Diff 162338. ilya-biryukov added a comment. - Make the option hidden Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51155 Files: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp Index: clangd/global-symbol-builder/GlobalSymbolBu

[PATCH] D51029: [clangd] Implement LIMIT iterator

kbobyrev updated this revision to Diff 162341. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Address a round of comments & simplify code. https://reviews.llvm.org/D51029 Files: clang-tools-extra/clangd/index/dex/DexIndex.cpp clang-tools-extra/clangd/index/dex/Iterator

[PATCH] D50385: [clangd] Collect symbol occurrences from AST.

ioeric added inline comments. Comment at: clangd/index/SymbolCollector.h:74 +// If not null, SymbolCollector will collect symbols. +const CollectSymbolOptions *SymOpts; +// If not null, SymbolCollector will collect symbol occurrences. Use `llvm::Optio

[PATCH] D50502: [clangd] Initial cancellation mechanism for LSP requests.

kadircet updated this revision to Diff 162342. kadircet marked 3 inline comments as done. kadircet added a comment. - Change a few comments. - Add some assertions. - Fix a data race. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50502 Files: clangd/CMakeLists.txt clangd/Ca

[PATCH] D50502: [clangd] Initial cancellation mechanism for LSP requests.

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clangd/ClangdLSPServer.cpp:351 + [this](llvm::Expected List) { +auto _ = llvm::make_scope_exit([this]() { CleanupTaskHandle(); }); + ilya-biryukov wrote: > Cleanup

r340598 - [FileManager] Do not call 'real_path' in getFile().

Author: ioeric Date: Fri Aug 24 01:59:54 2018 New Revision: 340598 URL: http://llvm.org/viewvc/llvm-project?rev=340598&view=rev Log: [FileManager] Do not call 'real_path' in getFile(). Summary: This partially rolls back the change in D48903: https://github.com/llvm-mirror/clang/commit/89aa7f45a1f

[PATCH] D51159: [FileManager] Do not call 'real_path' in getFile().

This revision was automatically updated to reflect the committed changes. Closed by commit rC340598: [FileManager] Do not call 'real_path' in getFile(). (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D51159?vs=162337&id=162344#toc Repository: rC Clang

[PATCH] D50962: [clangd] Speculative code completion index request before Sema is run.

ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.cpp:159 + } + if (SpecFuzzyReq) { +if (auto Filter = speculateCompletionFilter(Content, Pos)) { ioeric wrote: > ilya-biryukov wrote: > > NIT: maybe invert condition to reduce nesting? > It

[PATCH] D51164: [Tooling] Add a isSingleProcess() helper to ToolExecutor

This revision was automatically updated to reflect the committed changes. Closed by commit rC340599: [Tooling] Add a isSingleProcess() helper to ToolExecutor (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D51164?vs=162182&id=162345#toc Repository: r

r340599 - [Tooling] Add a isSingleProcess() helper to ToolExecutor

Author: ibiryukov Date: Fri Aug 24 02:03:29 2018 New Revision: 340599 URL: http://llvm.org/viewvc/llvm-project?rev=340599&view=rev Log: [Tooling] Add a isSingleProcess() helper to ToolExecutor Summary: Used in clangd's symbol builder to optimize for the common shared-memory executor case. Review

[clang-tools-extra] r340600 - [clangd] Allow to merge symbols on-the-fly in global-symbol-builder

Author: ibiryukov Date: Fri Aug 24 02:03:54 2018 New Revision: 340600 URL: http://llvm.org/viewvc/llvm-project?rev=340600&view=rev Log: [clangd] Allow to merge symbols on-the-fly in global-symbol-builder Summary: The new mode avoids serializing and deserializing YAML. This results in better perfo

[PATCH] D51155: [clangd] Allow to merge symbols on-the-fly in global-symbol-builder

This revision was automatically updated to reflect the committed changes. Closed by commit rL340600: [clangd] Allow to merge symbols on-the-fly in global-symbol-builder (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

ilya-biryukov added a comment. @Dmitry.Kozhevnikov, do you need us to land the patch? Any last changes you'd like to make? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51154: [clangd] Log memory usage of DexIndex and MemIndex

This revision was automatically updated to reflect the committed changes. Closed by commit rL340601: [clangd] Log memory usage of DexIndex and MemIndex (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51154?vs=1623

[clang-tools-extra] r340601 - [clangd] Log memory usage of DexIndex and MemIndex

Author: omtcyfz Date: Fri Aug 24 02:12:54 2018 New Revision: 340601 URL: http://llvm.org/viewvc/llvm-project?rev=340601&view=rev Log: [clangd] Log memory usage of DexIndex and MemIndex This patch prints information about built index size estimation to verbose logs. This is useful for optimizing m

[PATCH] D50962: [clangd] Speculative code completion index request before Sema is run.

ioeric updated this revision to Diff 162348. ioeric marked 5 inline comments as done. ioeric added a comment. - Merge remote-tracking branch 'origin/master' into speculate-index - address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50962 Files: clangd/ClangdServe

[PATCH] D50962: [clangd] Speculative code completion index request before Sema is run.

ilya-biryukov added inline comments. Comment at: clangd/CodeComplete.h:187 +/// A speculative and asynchronous fuzzy find index request (based on cached +/// request) that can be before parsing sema. This would reduce completion +/// latency if the speculation succeeds. -

[PATCH] D50962: [clangd] Speculative code completion index request before Sema is run.

ilya-biryukov added inline comments. Comment at: clangd/CodeComplete.h:187 +/// A speculative and asynchronous fuzzy find index request (based on cached +/// request) that can be before parsing sema. This would reduce completion +/// latency if the speculation succeeds. -

[PATCH] D51209: AMDGPU: Default to hidden visibility

arsenm created this revision. arsenm added reviewers: t-tye, kzhuravl, yaxunl. Herald added subscribers: sunfish, aheejin, tpr, dstuttard, nhaehnle, wdng, jvesely, dschuff. Object linking isn't supported, so it's not useful to emit default visibility. Default visibility requires relocations we do

[PATCH] D50962: [clangd] Speculative code completion index request before Sema is run.

ioeric updated this revision to Diff 162351. ioeric added a comment. - fix doc Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50962 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/CodeComplete.cpp clangd/CodeComplete.h clangd/TUScheduler.h clangd/index/I

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

Dmitry.Kozhevnikov added a comment. In https://reviews.llvm.org/D50993#1212130, @ilya-biryukov wrote: > @Dmitry.Kozhevnikov, do you need us to land the patch? > Any last changes you'd like to make? It’s blocked by the llvm review, which has some valid comments I’ll address today. After that,

[PATCH] D50958: [clangd] WIP: xrefs for dynamic index.

sammccall added a comment. Mostly just reviewed the `references()` implementation. For the infrastructure I have some high level questions: - why are we combining SymbolSlab and occurrences? - what's the motivation for the separate preamble/main-file indexes - why put more functionality into Sym

[PATCH] D51036: clang-format: Fix formatting C++ namespaces with preceding 'inline' or 'export' specifier

owenpan added inline comments. Comment at: lib/Format/Format.cpp:1312 auto &Line = *AnnotatedLines[i]; if (Line.startsWith(tok::kw_namespace) || + Line.startsWith(tok::kw_inline, tok::kw_namespace) || sammccall wrote: > these 3 startswith c

[PATCH] D50958: [clangd] WIP: xrefs for dynamic index.

ilya-biryukov added a comment. Parts of the patch contain were landed as https://reviews.llvm.org/D50847 and https://reviews.llvm.org/D50889, happy to discuss the design decisions ("merged" dynamic index, two callbacks), but that's probably out of scope of this patch. Repository: rCTE Clang

[PATCH] D50502: [clangd] Initial cancellation mechanism for LSP requests.

kadircet added inline comments. Comment at: clangd/Protocol.h:883 +/// converts it into a string. +bool parseNumberOrString(const llvm::json::Value &Params, std::string &Parsed, + const std::string &Field); ilya-biryukov wrote: > Maybe sim

[PATCH] D50502: [clangd] Initial cancellation mechanism for LSP requests.

kadircet updated this revision to Diff 162354. kadircet marked 2 inline comments as done. kadircet added a comment. - Change helper for normalizing Number | String. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50502 Files: clangd/CMakeLists.txt clangd/Cancellation.cpp c

[PATCH] D51036: clang-format: Fix formatting C++ namespaces with preceding 'inline' or 'export' specifier

owenpan added inline comments. Comment at: lib/Format/UnwrappedLineFormatter.cpp:533-535 + !(Line.startsWith(tok::kw_namespace) || + Line.startsWith(tok::kw_inline, tok::kw_namespace) || + Line.startsWith(tok::kw_export, tok::kw

[PATCH] D50385: [clangd] Collect symbol occurrences from AST.

ioeric added inline comments. Comment at: clangd/index/SymbolCollector.cpp:241 -SymbolCollector::SymbolCollector(Options Opts) : Opts(std::move(Opts)) {} +class SymbolCollector::CollectOccurrence { +public: I don't see a strong reason for the separation of `Col

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

ilya-biryukov added a comment. In https://reviews.llvm.org/D50993#1212162, @Dmitry.Kozhevnikov wrote: > In https://reviews.llvm.org/D50993#1212130, @ilya-biryukov wrote: > > > @Dmitry.Kozhevnikov, do you need us to land the patch? > > Any last changes you'd like to make? > > > It’s blocked by th

r340602 - Fix build bot after r340598.

Author: ioeric Date: Fri Aug 24 02:53:44 2018 New Revision: 340602 URL: http://llvm.org/viewvc/llvm-project?rev=340602&view=rev Log: Fix build bot after r340598. Revert to the original behavior: only calculate real file path when file is opened and avoid using InterndPath for real path calculatio

[PATCH] D50962: [clangd] Speculative code completion index request before Sema is run.

ioeric updated this revision to Diff 162355. ioeric added a comment. - moved SpecReq into CodeComplete.cpp Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50962 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/CodeComplete.cpp clangd/CodeComplete.h clangd/TU

[PATCH] D50962: [clangd] Speculative code completion index request before Sema is run.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LG, thanks. And two small NITs. Comment at: clangd/CodeComplete.h:184 +llvm::Expected +speculateCompletionFilter(llvm::StringRef Content, Position Pos); + -

[PATCH] D50962: [clangd] Speculative code completion index request before Sema is run.

ioeric updated this revision to Diff 162356. ioeric added a comment. - add doc Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50962 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/CodeComplete.cpp clangd/CodeComplete.h clangd/TUScheduler.h clangd/index/I

[PATCH] D51029: [clangd] Implement LIMIT iterator

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/unittests/clangd/DexIndexTests.cpp:34 +consumeIDs(std::unique_ptr It, + size_t Limit = std::numeric_limits::max()) { + auto

[PATCH] D50958: [clangd] WIP: xrefs for dynamic index.

sammccall added a comment. In https://reviews.llvm.org/D50958#1212179, @ilya-biryukov wrote: > Parts of this patch were landed as https://reviews.llvm.org/D50847 and > https://reviews.llvm.org/D50889, happy to discuss the design decisions > ("merged" dynamic index, two callbacks), but that's pr

[clang-tools-extra] r340604 - [clangd] Speculative code completion index request before Sema is run.

Author: ioeric Date: Fri Aug 24 04:23:56 2018 New Revision: 340604 URL: http://llvm.org/viewvc/llvm-project?rev=340604&view=rev Log: [clangd] Speculative code completion index request before Sema is run. Summary: For index-based code completion, send an asynchronous speculative index request, bas

[PATCH] D50962: [clangd] Speculative code completion index request before Sema is run.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE340604: [clangd] Speculative code completion index request before Sema is run. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D50962?vs=162356&id=162358#toc Re

[clang-tools-extra] r340605 - [clangd] Implement LIMIT iterator

Author: omtcyfz Date: Fri Aug 24 04:25:43 2018 New Revision: 340605 URL: http://llvm.org/viewvc/llvm-project?rev=340605&view=rev Log: [clangd] Implement LIMIT iterator This patch introduces LIMIT iterator, which is very important for improving the quality of search query. LIMIT iterators can be a

[PATCH] D51029: [clangd] Implement LIMIT iterator

This revision was automatically updated to reflect the committed changes. Closed by commit rL340605: [clangd] Implement LIMIT iterator (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51029?vs=162341&id=162359#toc

[PATCH] D51211: [Sema] Emit -Wformat properly for bitfield promotions.

ebevhan created this revision. ebevhan added reviewers: krememek, rsmith. Herald added a subscriber: cfe-commits. The integer promotions apply to bitfields as well, but rather oddly. If you have a bitfield with a lower width than int, then the type of the member expression will be int regardless o

[PATCH] D51212: [OpenCL][Docs] Release notes for OpenCL in Clang

Anastasia created this revision. Anastasia added reviewers: hans, bader, yaxunl. https://reviews.llvm.org/D51212 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs/ReleaseNotes.rst +++ docs/ReleaseNotes.rst @@

r340595 - [RISCV] RISC-V using -fuse-init-array by default

Author: kito Date: Thu Aug 23 20:05:08 2018 New Revision: 340595 URL: http://llvm.org/viewvc/llvm-project?rev=340595&view=rev Log: [RISCV] RISC-V using -fuse-init-array by default Reviewers: asb, apazos, mgrang Reviewed By: asb Differential Revision: https://reviews.llvm.org/D50043 Modified:

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hokein added inline comments. Comment at: docs/clang-tidy/checks/abseil-no-internal-deps.rst:17 + + absl::strings_internal::foo(); + class foo { I think this line is also triggered the warning? Comment at: test/clang-tidy/abseil-no-internal-d

[PATCH] D50502: [clangd] Initial cancellation mechanism for LSP requests.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LG with a few small comments Comment at: clangd/Protocol.cpp:635 + if(const auto AsNumber = Params->getAsInteger()) +return utostr(AsNumber.getValue()); +

[PATCH] D50502: [clangd] Initial cancellation mechanism for LSP requests.

kadircet updated this revision to Diff 162365. kadircet marked 2 inline comments as done. kadircet added a comment. - Resolve comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50502 Files: clangd/CMakeLists.txt clangd/Cancellation.cpp clangd/Cancellation.h clangd

Re: r314872 - We allow implicit function declarations as an extension in all C dialects. Remove OpenCL special case.

Thanks! Will do! From: Richard Smith Sent: 23 August 2018 21:15 To: Anastasia Stulova Cc: nd; cfe-commits Subject: Re: r314872 - We allow implicit function declarations as an extension in all C dialects. Remove OpenCL special case. On Thu, 23 Aug 2018 at 02:52,

[clang-tools-extra] r340607 - [clangd] Initial cancellation mechanism for LSP requests.

Author: kadircet Date: Fri Aug 24 06:09:41 2018 New Revision: 340607 URL: http://llvm.org/viewvc/llvm-project?rev=340607&view=rev Log: [clangd] Initial cancellation mechanism for LSP requests. Reviewers: ilya-biryukov, ioeric, hokein Reviewed By: ilya-biryukov Subscribers: mgorny, ioeric, MaskR

[PATCH] D50502: [clangd] Initial cancellation mechanism for LSP requests.

This revision was automatically updated to reflect the committed changes. Closed by commit rL340607: [clangd] Initial cancellation mechanism for LSP requests. (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50502

[PATCH] D51214: [clangd] Add options to enable/disable fixits and function argument snippets.

kadircet created this revision. kadircet added reviewers: hokein, ioeric, ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. Currently LSP clients cannot directly change IncludeFixIts or EnableFunctionArgSnippets parameters. This patch is to provide them with a way t

[PATCH] D51170: [libc++] Remove race condition in std::async

ldionne added inline comments. Comment at: libcxx/include/future:556 bool __has_value() const {return (__state_ & __constructed) || (__exception_ != nullptr);} jfb wrote: > I'm not auditing everything, but it seems like code above can still access

[libcxx] r340608 - [libc++] Remove race condition in std::async

Author: ldionne Date: Fri Aug 24 07:00:59 2018 New Revision: 340608 URL: http://llvm.org/viewvc/llvm-project?rev=340608&view=rev Log: [libc++] Remove race condition in std::async Summary: The state associated to the future was set in one thread (with synchronization) but read in another thread wi

[PATCH] D51170: [libc++] Remove race condition in std::async

This revision was automatically updated to reflect the committed changes. Closed by commit rL340608: [libc++] Remove race condition in std::async (authored by ldionne, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51170?vs=162200&id=

[PATCH] D51214: [clangd] Add options to enable/disable fixits and function argument snippets.

ilya-biryukov added a subscriber: sammccall. ilya-biryukov added inline comments. Comment at: clangd/tool/ClangdMain.cpp:197 +static llvm::cl::opt IncludeFixIts( +"include-fixits", I wonder if we should make the `IncludeFixIts` option hidden? It currently o

[libcxx] r340609 - [libc++] Fix handling of negated character classes in regex

Author: ldionne Date: Fri Aug 24 07:10:28 2018 New Revision: 340609 URL: http://llvm.org/viewvc/llvm-project?rev=340609&view=rev Log: [libc++] Fix handling of negated character classes in regex Summary: This commit fixes a regression introduced in r316095, where we don't match inverted character

[PATCH] D50534: [libc++] Fix handling of negated character classes in regex

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX340609: [libc++] Fix handling of negated character classes in regex (authored by ldionne, committed by ). Changed prior to commit: https://reviews.llvm.org/D50534?vs=160169&id=162377#toc Repository:

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

aaron.ballman added inline comments. Comment at: clang-tidy/abseil/RedundantStrcatCallsCheck.cpp:28 + +void RedundantStrcatCallsCheck::registerMatchers(MatchFinder* Finder) { + if (!getLangOpts().CPlusPlus) The formatting here looks off -- you should run the pa

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

JonasToth added a comment. Owen, shall i commit for you? Repository: rC Clang https://reviews.llvm.org/D50699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg updated this revision to Diff 162379. hugoeg marked 2 inline comments as done. hugoeg added a comment. fixed comments https://reviews.llvm.org/D50542 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/NoInternalDepsCheck.cpp clang-tid

[PATCH] D50542: [clang-tidy] Add abseil-no-internal-deps check

hugoeg added inline comments. Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:8 +#include "absl/external-file.h" +// CHECK: absl/external-file.h:1:23: warning: do not reference any 'internal' namespaces; those implementation details are reserved to Abseil [abseil-no-int

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev updated this revision to Diff 162381. kbobyrev added a comment. Rebase on top of parent patch. https://reviews.llvm.org/D51090 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/benchmarks/CMakeLists.txt clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp

[PATCH] D50385: [clangd] Collect symbol occurrences from AST.

sammccall added inline comments. Comment at: clangd/index/Index.h:310 + + llvm::ArrayRef findOccurrences(const SymbolID &ID) const { +auto It = SymbolOccurrences.find(ID); As discussed offline: the merge of occurrences into SymbolSlab seems problematic to m

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg updated this revision to Diff 162382. hugoeg marked 7 inline comments as done. hugoeg added a comment. applied corrections form comments https://reviews.llvm.org/D51132 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/RedundantStrcatC

[PATCH] D51061: [clang-tidy] abseil-str-cat-append

aaron.ballman added inline comments. Comment at: clang-tidy/abseil/StrCatAppendCheck.cpp:82 + if (Call->getNumArgs() == 1) { +diag(Op->getBeginLoc(), "call to absl::StrCat does nothing"); +return; JonasToth wrote: > please use 'absl::StrCat' in the diagn

[PATCH] D51214: [clangd] Add options to enable/disable fixits and function argument snippets.

sammccall added a comment. The description says "LSP clients", i.e. editors. For editors (e.g. whether editor can handle snippets), LSP capability negotiation rather than flags is the right thing. I suspect this is true for including completion fixes. For users (e.g. I like behavior X), flags ar

[PATCH] D49851: [clang-tidy] run-clang-tidy add synchronisation to the output

Abpostelnicu added a comment. In https://reviews.llvm.org/D49851#1203676, @JonasToth wrote: > In https://reviews.llvm.org/D49851#1202764, @Abpostelnicu wrote: > > > Strangely I haven't had those kind of issues but since you propose those > > modifications I would do one more modification, let's

[PATCH] D51187: Thread safety analysis: Warn on double (un-)lock of scoped capability

aaron.ballman added a comment. I'm not certain how I feel about this as it seems to be removing functionality users may be relying on that I think is still technically correct. Can you describe more about why you think this should change? Repository: rC Clang https://reviews.llvm.org/D51187

[PATCH] D49851: [clang-tidy] run-clang-tidy add synchronisation to the output

Abpostelnicu updated this revision to Diff 162387. https://reviews.llvm.org/D49851 Files: clang-tidy/tool/run-clang-tidy.py Index: clang-tidy/tool/run-clang-tidy.py === --- clang-tidy/tool/run-clang-tidy.py +++ clang-tidy/tool/ru

[PATCH] D49851: [clang-tidy] run-clang-tidy add synchronisation to the output

JonasToth added a comment. Please dont work in this revision but create a new one (as this one is already committed)! Am 24.08.2018 um 17:34 schrieb Andi via Phabricator: > Abpostelnicu updated this revision to Diff 162387. > > https://reviews.llvm.org/D49851 > > Files: > > clang-tidy/tool/

[PATCH] D51212: [OpenCL][Docs] Release notes for OpenCL in Clang

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, thanks https://reviews.llvm.org/D51212 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg added inline comments. Comment at: clang-tidy/abseil/RedundantStrcatCallsCheck.cpp:37-38 + // Those are handled on the ancestor call. + const auto CallToEither = callExpr( + callee(functionDecl(hasAnyName("::absl::StrCat", "::absl::StrAppend"; + Finder->addMatc

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

JonasToth added a comment. Please create the patch with full context (https://www.llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51220 ___ cfe-commits mailin

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

owenpan added a comment. @JonasToth Yes, please. Also https://reviews.llvm.org/D50697 :) Thanks again for getting me started! Repository: rC Clang https://reviews.llvm.org/D50699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

JonasToth added a comment. I don't know a lot about how to write portable code! But wouldn't this be out usecase? http://python-future.org/compatible_idioms.html#file-io-with-open Using the `decode` is supposed to work in both pythons Repository: rCTE Clang Tools Extra https://reviews.llvm.

[PATCH] D51200: Introduce per-callsite inline intrinsics

kuhar added a comment. One extra question: do you think this deserves a separate RFC? Repository: rC Clang https://reviews.llvm.org/D51200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D51212: [OpenCL][Docs] Release notes for OpenCL in Clang

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. https://reviews.llvm.org/D51212 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51061: [clang-tidy] abseil-str-cat-append

hugoeg updated this revision to Diff 162390. hugoeg marked 9 inline comments as done. hugoeg added a comment. applied corrections from comments https://reviews.llvm.org/D51061 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/StrCatAppendChec

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

Abpostelnicu updated this revision to Diff 162391. https://reviews.llvm.org/D51220 Files: clang-tidy/tool/run-clang-tidy.py Index: clang-tidy/tool/run-clang-tidy.py === --- clang-tidy/tool/run-clang-tidy.py +++ clang-tidy/tool/ru

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

Abpostelnicu added a comment. In https://reviews.llvm.org/D51220#1212463, @JonasToth wrote: > I don't know a lot about how to write portable code! > > But wouldn't this be out usecase? > http://python-future.org/compatible_idioms.html#file-io-with-open > Using the `decode` is supposed to work i

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

JonasToth added a comment. Could you please verify it is actually working? Am 24.08.2018 um 18:05 schrieb Andi via Phabricator: > Abpostelnicu added a comment. > > In https://reviews.llvm.org/D51220#1212463, @JonasToth wrote: > >> I don't know a lot about how to write portable code! >> >> But

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

Abpostelnicu added a comment. I can confirm tested on: 2.7.15 3.7.0 On both it worked. - F7047650: signature.asc https://reviews.llvm.org/D51220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

yaxunl added a comment. Herald added a subscriber: jvesely. In https://reviews.llvm.org/D43783#1204353, @svenvh wrote: > Sorry for digging up an old commit... > > Apparently this broke block arguments, e.g. the following test case: > > int foo(int (^ bl)(void)) { > return bl(); > } > >

[PATCH] D51061: [clang-tidy] abseil-str-cat-append

hugoeg updated this revision to Diff 162395. hugoeg added a comment. ran svn update https://reviews.llvm.org/D51061 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/StrCatAppendCheck.cpp clang-tidy/abseil/StrCatAppendCheck.h docs/Release

[clang-tools-extra] r340620 - [clang-doc] Fix memory leaks

Author: juliehockett Date: Fri Aug 24 09:43:46 2018 New Revision: 340620 URL: http://llvm.org/viewvc/llvm-project?rev=340620&view=rev Log: [clang-doc] Fix memory leaks Adds a virtual destructor to the base Info class. Differential Revision: https://reviews.llvm.org/D51137 Modified: clang-to

[PATCH] D51137: [clang-doc] Fix memory leaks

This revision was automatically updated to reflect the committed changes. Closed by commit rL340620: [clang-doc] Fix memory leaks (authored by juliehockett, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51137?vs=162081&id=162399#toc

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

aaron.ballman added inline comments. Comment at: clang-tidy/abseil/RedundantStrcatCallsCheck.cpp:28 + +void RedundantStrcatCallsCheck::registerMatchers(MatchFinder* Finder) { + if (!getLangOpts().CPlusPlus) aaron.ballman wrote: > The formatting here looks off -

  1   2   >