ioeric added inline comments.
================
Comment at: clangd/index/SymbolCollector.cpp:241
-SymbolCollector::SymbolCollector(Options Opts) : Opts(std::move(Opts)) {}
+class SymbolCollector::CollectOccurrence {
+public:
----------------
I don't see a strong reason for the separation of `CollectOccurrence` and
`CollectSymbol`. There are some pieceis that are only used by one of them, but
they seem cheap enough to ignore? Intuitively, it seems to me reference
collection could just be a member function of `SymbolCollector`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50385
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
