This revision was automatically updated to reflect the committed changes.
Closed by commit rL339415: [clang-tidy] Omit cases where loop variable is not
used in loop body in (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.or
Author: hokein
Date: Fri Aug 10 01:25:51 2018
New Revision: 339415
URL: http://llvm.org/viewvc/llvm-project?rev=339415&view=rev
Log:
[clang-tidy] Omit cases where loop variable is not used in loop body in
performance-for-range-copy check.
Summary:
The upstream change r336737 make the check too sm
lebedev.ri added a comment.
It seems this ended up silently being a catch-all, with no option to control
this behavior, and i don't see any comments discussing this..
Repository:
rL LLVM
https://reviews.llvm.org/D50447
___
cfe-commits mailing li
Author: hokein
Date: Fri Aug 10 01:34:16 2018
New Revision: 339416
URL: http://llvm.org/viewvc/llvm-project?rev=339416&view=rev
Log:
[clangd] Fix a "-Wdangling-else" compiler warning in the test.
Modified:
clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp
Modified: clang-tools-e
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50555
Files:
clangd/CodeComplete.cpp
clangd/Quality.cpp
clangd/Quality.h
uni
kbobyrev updated this revision to Diff 160071.
kbobyrev added a comment.
Complete the tests, finish the implementation.
One thought about prefix match suggestion: we should either make it more
explicit for the index (e.g. introduce `prefixMatch` and dispatch `fuzzyMatch`
to prefix matching in c
ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/unittests/clangd/DexIndexTests.cpp:252
+ auto DocIterator = create(L0);
+ EXPECT_THAT(consume(*DocIterator, 42), ElementsAre(4, 7, 8, 20,
JonasToth added inline comments.
Comment at: clang-tidy/abseil/NoInternalDepsCheck.cpp:24
+
+ Finder->addMatcher(
+ nestedNameSpecifierLoc(loc(specifiesNamespace(namespaceDecl(
Actually that one is generally useful. Accessing the `foo::internal` from
outsi
JonasToth added a comment.
Do you think it is a bad idea? If the variable is not used it is ok to
ignore it in this particular circumstance. Other warnings/check should
deal with such a situation IMHO.
Am 10.08.2018 um 10:29 schrieb Roman Lebedev via Phabricator:
> lebedev.ri added a comment.
>
kadircet updated this revision to Diff 160073.
kadircet marked 5 inline comments as done.
kadircet added a comment.
Herald added a subscriber: mgrang.
- Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50449
Files:
clangd/CodeComplete.cpp
clangd/CodeCompl
JonasToth added inline comments.
Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:32
+ hasImplicitDestinationType(qualType(unless(isInteger(,
+ unless(hasParent(cxxStaticCastExpr(,
+ this);
deannagarcia wrote:
> JonasToth wro
kadircet added inline comments.
Comment at: clangd/CodeComplete.cpp:1310
+ // other.
+ for (const auto &FixIt : FixIts) {
+if (IsRangeConsecutive(FixIt.range, LSP.textEdit->range)) {
ilya-biryukov wrote:
> Maybe keep the `reserve` call? (we could reserve on
kbobyrev planned changes to this revision.
kbobyrev added a comment.
As discussed offline with @ilya-biryukov, the better approach would be to
prefix match first symbols of each distinct identifier piece instead of prefix
matching (just looking at the first letter of the identifier) the whole
i
ioeric added a comment.
Thanks for the patch!
In https://reviews.llvm.org/D50517#1194955, @kbobyrev wrote:
> Complete the tests, finish the implementation.
>
> One thought about prefix match suggestion: we should either make it more
> explicit for the index (e.g. introduce `prefixMatch` and dis
kbobyrev updated this revision to Diff 160074.
kbobyrev added a comment.
@ilya-biryukov I have changed the approach to the one we discussed before.
https://reviews.llvm.org/D50517
Files:
clang-tools-extra/clangd/index/dex/Trigram.cpp
clang-tools-extra/clangd/index/dex/Trigram.h
clang-tool
ioeric added a comment.
In https://reviews.llvm.org/D50517#1194976, @kbobyrev wrote:
> As discussed offline with @ilya-biryukov, the better approach would be to
> prefix match first symbols of each distinct identifier piece instead of
> prefix matching (just looking at the first letter of the i
ioeric added a comment.
In https://reviews.llvm.org/D50517#1194976, @kbobyrev wrote:
> As discussed offline with @ilya-biryukov, the better approach would be to
> prefix match first symbols of each distinct identifier piece instead of
> prefix matching (just looking at the first letter of the i
Author: hans
Date: Fri Aug 10 02:49:21 2018
New Revision: 339420
URL: http://llvm.org/viewvc/llvm-project?rev=339420&view=rev
Log:
clang-cl: Support /guard:cf,nochecks
This extension emits the guard cf table without inserting the
instrumentation. Currently that's what clang-cl does with /guard:cf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339420: clang-cl: Support /guard:cf,nochecks (authored by
hans, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50513?vs=159927&id=160076#toc
Hahnfeld removed a reviewer: Hahnfeld.
Hahnfeld added a comment.
I feel like there is no progress in the discussion (here and off-list), partly
because we might still not be talking about the same things. So I'm stepping
down from this revision to unblock review from somebody else.
Here's my cu
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/DexIndex.cpp:29
+ // might be more efficient.
+ std::sort(begin(*Syms), end(*Syms), [](const Symbol *LHS, const Symbol *RHS)
{
+return quality(*LHS) > quality(*RHS);
Calculating `
kbobyrev updated this revision to Diff 160081.
kbobyrev marked 5 inline comments as done.
kbobyrev added a comment.
Address a round of comments.
I have added few comments to get additional feedback before further changes are
made.
https://reviews.llvm.org/D50517
Files:
clang-tools-extra/cla
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Trigram.cpp:74
+// symbol of the identifier.
+if (!FoundFirstSymbol) {
+ FoundFirstSymbol = true;
ioeric wrote:
> Could this be pulled out of the loop? I think what we wan
kbobyrev added a comment.
In https://reviews.llvm.org/D50517#1194990, @ioeric wrote:
> In https://reviews.llvm.org/D50517#1194976, @kbobyrev wrote:
>
> > As discussed offline with @ilya-biryukov, the better approach would be to
> > prefix match first symbols of each distinct identifier piece ins
ilya-biryukov added a comment.
I have left a few comments, but wanted to start with a higher-level design
consideration.
I believe we should probably expose the cancellations in the ClangdServer API
directly.
The reasons for that are:
1. We have an internal client that would also benefit from
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/PointerSortingChecker.cpp:91-100
+ const QualType IterTy = CE->getArg(0)->getType();
+ const RecordDecl *RD =
+IterTy->getUnqualifiedDesugaredType()->getAsCXXRecordDecl();
+
+ if (RD->field_empty())
+
whisperity added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/PointerSortingChecker.cpp:88
+
+ if (!II->getName().equals("sort"))
+return;
Brrr... `equals`. StringRef has a `==` and `!=` operator which accepts string
literals on the other side,
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Trigram.cpp:74
+// symbol of the identifier.
+if (!FoundFirstSymbol) {
+ FoundFirstSymbol = true;
kbobyrev wrote:
> ioeric wrote:
> > Could this be pulled out of the loop? I
smaksimovic created this revision.
smaksimovic added a reviewer: atanasyan.
Herald added subscribers: arichardson, sdardis.
Set __mips_fpr to 0 if o32 ABI is used with either -mfpxx or none of -mfp32,
-mfpxx, -mfp64 being specified.
Introduce additional checks:
- -mfpxx is only to be used in co
Author: brunoricci
Date: Fri Aug 10 04:20:20 2018
New Revision: 339423
URL: http://llvm.org/viewvc/llvm-project?rev=339423&view=rev
Log:
Fix a wrong type bug in ParsedAttr::TypeTagForDatatypeData
This patch fixes a wrong type bug inside ParsedAttr::TypeTagForDatatypeData.
The details to the best
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339423: Fix a wrong type bug in
ParsedAttr::TypeTagForDatatypeData (authored by brunoricci, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50532?vs=159988&id=160086#toc
Repository:
mstorsjo added a comment.
@cdavis5x I presume the fact that this one turned out tricky is blocking
submitting the SEH unwinding patch.
Would it be worth to rework that patch to just use the basic types just like
libunwind does today, e.g. having `_Unwind_GetRegionStart` return plain
`uintptr_t
Author: hans
Date: Fri Aug 10 04:40:50 2018
New Revision: 339424
URL: http://llvm.org/viewvc/llvm-project?rev=339424&view=rev
Log:
clang-cl: accept -fcrash-diagnostics-dir=
Modified:
cfe/trunk/include/clang/Driver/Options.td
cfe/trunk/test/Driver/cl-options.c
Modified: cfe/trunk/include/
kbobyrev updated this revision to Diff 160088.
kbobyrev marked 2 inline comments as done.
https://reviews.llvm.org/D50500
Files:
clang-tools-extra/clangd/index/dex/Iterator.cpp
clang-tools-extra/clangd/index/dex/Iterator.h
clang-tools-extra/unittests/clangd/DexIndexTests.cpp
Index: clang-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339427: [clang-tidy] run-clang-tidy.py - add
synchronisation to the output (authored by Abpostelnicu, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.l
Author: omtcyfz
Date: Fri Aug 10 04:50:44 2018
New Revision: 339426
URL: http://llvm.org/viewvc/llvm-project?rev=339426&view=rev
Log:
[clangd] Allow consuming limited number of items
This patch modifies `consume` function to allow retrieval of limited
number of symbols. This is the "cheap" implem
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339426: [clangd] Allow consuming limited number of items
(authored by omtcyfz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50500?vs=160088
Author: abpostelnicu
Date: Fri Aug 10 04:50:47 2018
New Revision: 339427
URL: http://llvm.org/viewvc/llvm-project?rev=339427&view=rev
Log:
[clang-tidy] run-clang-tidy.py - add synchronisation to the output
Differential Revision: https://reviews.llvm.org/D49851
Modified:
clang-tools-extra/tru
ilya-biryukov added a comment.
Only a few NITs from my side.
Excited for this fix to get in, have been seeing duplicate in other cases too
:-)
Comment at: clangd/SourceCode.h:69
+llvm::Optional getRealPath(const FileEntry *F,
+const So
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM with a small NIT.
Comment at: clangd/ClangdLSPServer.cpp:507
+}
+LSPDiag["clangd.fixes"] = std::move(ClangdFixes);
+ }
---
theraven updated this revision to Diff 160091.
theraven added a comment.
Squashed into a single commit.
Repository:
rC Clang
https://reviews.llvm.org/D50144
Files:
include/clang/Driver/Options.td
lib/AST/MicrosoftMangle.cpp
lib/CodeGen/CGException.cpp
lib/CodeGen/CGObjCGNU.cpp
lib/
thakis added a comment.
When we updated out clang bundle in chromium (which includes libc++ headers),
our ios simulator bots regressed debug info size by ~50% due to this commit
(https://bugs.chromium.org/p/chromium/issues/detail?id=872926#c13). Is that
expected?
Repository:
rCXX libc++
ht
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:715
unsigned NumCandidates) override {
+TopN Top(
+std::numeric_limits::max());
Maybe use `vector`, followed by `std::sort` at the end?
Or is t
kbobyrev updated this revision to Diff 160093.
kbobyrev marked 8 inline comments as done.
kbobyrev added a comment.
Address issues we discussed with Eric.
https://reviews.llvm.org/D50517
Files:
clang-tools-extra/clangd/index/dex/Iterator.h
clang-tools-extra/clangd/index/dex/Trigram.cpp
cl
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for the change!
Could we add an option to clangd to switch it on? (VSCode does not work, but
our hacked-up ycm integration seems to work, right?)
Author: theraven
Date: Fri Aug 10 05:53:13 2018
New Revision: 339428
URL: http://llvm.org/viewvc/llvm-project?rev=339428&view=rev
Log:
Add Windows support for the GNUstep Objective-C ABI V2.
Summary:
Introduces funclet-based unwinding for Objective-C and fixes an issue
where global blocks can't h
Author: theraven
Date: Fri Aug 10 05:53:18 2018
New Revision: 339429
URL: http://llvm.org/viewvc/llvm-project?rev=339429&view=rev
Log:
Fix a deprecated warning in the last commit.
Done as a separate commit to make it easier to cherry pick the changes
to the release branch.
Modified:
cfe/trun
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339428: Add Windows support for the GNUstep Objective-C ABI
V2. (authored by theraven, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50144?vs=160091&id=160095#toc
Repository:
rC
alexfh added inline comments.
Comment at: clang-tidy/abseil/NoInternalDepsCheck.cpp:38
+ "depends upon internal implementation details, which violates the "
+ "abseil compatibilty guidelines. These can be found at "
+ "https://abseil.io/about/compatibility";);
-
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a couple of nits. Do you need someone to commit the patch for you?
Comment at: clang-tidy/modernize/RedundantVoidArgCheck.cpp:241
+SourceLocation End, Begin;
+
thakis added a comment.
In https://reviews.llvm.org/D46652#1174220, @mikerice wrote:
> In https://reviews.llvm.org/D46652#1164010, @thakis wrote:
>
> > Also, were you planning on also adding support for the (filename-less
> > version of) hdrstop pragma? After this change, that should probably be
Szelethus added a comment.
I'm only a beginner, but here are some things that caught my eye. I really like
the idea! :)
Comment at: lib/StaticAnalyzer/Checkers/PointerSortingChecker.cpp:28
+
+// PointerSortingVisitor class.
+class PointerSortingVisitor : public StmtVisitor {
-
deannagarcia updated this revision to Diff 160096.
deannagarcia marked 7 inline comments as done.
https://reviews.llvm.org/D50389
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/DurationDivisionCheck.cpp
clang-tidy/abseil/DurationDivisionCh
gtbercea added a comment.
> The downside of this approach is that LLVM doesn't recognize these function
> calls and doesn't perform optimizations to fold libcalls. For example `pow(a,
> 2)` is transformed into a multiplication but `__nv_pow(a, 2)` is not.
Doesn't CUDA have the same problem?
kadircet updated this revision to Diff 160097.
kadircet marked 3 inline comments as done.
kadircet added a comment.
Herald added a subscriber: mgrang.
- Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50555
Files:
clangd/CodeComplete.cpp
clangd/Quality.c
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
Ship it!
https://reviews.llvm.org/D50543
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Author: ldionne
Date: Fri Aug 10 06:24:56 2018
New Revision: 339431
URL: http://llvm.org/viewvc/llvm-project?rev=339431&view=rev
Log:
[libc++] Enable aligned allocation based on feature test macro, irrespective of
standard
Summary:
The current code enables aligned allocation functions when compi
This revision was automatically updated to reflect the committed changes.
ldionne marked an inline comment as done.
Closed by commit rL339431: [libc++] Enable aligned allocation based on feature
test macro, irrespective of… (authored by ldionne, committed by ).
Herald added a subscriber: llvm-comm
theraven created this revision.
theraven added a reviewer: rjmccall.
Herald added subscribers: cfe-commits, mgrang.
This probably fixes PR35277, though there may be other sources of
nondeterminism (this was the only case of iterating over a DenseMap).
It's difficult to provide a test case for thi
ldionne added a comment.
In https://reviews.llvm.org/D49240#1195125, @thakis wrote:
> When we updated out clang bundle in chromium (which includes libc++ headers),
> our ios simulator bots regressed debug info size by ~50% due to this commit
> (https://bugs.chromium.org/p/chromium/issues/detail
gtbercea added a comment.
> I don't want to use a fast `pow(a, 2)`, I don't want to call a library
> function for that at all.
I do believe you won't end up calling a function. If you're compiling with
optimizations on this will be inlined.
Repository:
rC Clang
https://reviews.llvm.org
Author: alexfh
Date: Fri Aug 10 06:59:33 2018
New Revision: 339433
URL: http://llvm.org/viewvc/llvm-project?rev=339433&view=rev
Log:
[clang-tidy: modernize] modernize-redundant-void-arg crashes when a function
body is in a macro
Fixes https://bugs.llvm.org/show_bug.cgi?id=28406
Patch by IdrissR
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339433: [clang-tidy: modernize] modernize-redundant-void-arg
crashes when a function… (authored by alexfh, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revie
alexfh added a comment.
I've fixed the comments and committed the patch myself. Hope that's fine by you.
Repository:
rL LLVM
https://reviews.llvm.org/D49800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
whisperity added a comment.
The basics of the heuristics look okay as comparing pointers from
non-continuous block of memory is undefined, it would be worthy to check if no
compiler warning (perhaps by specifying `-W -Wall -Wextra -Weverything` and
various others of these enable-all flags!) is
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Thanks! LGTM with a few NITs
Comment at: clangd/CodeComplete.cpp:687
+struct ScoredSignatureGreater {
+ bool operator()(const ScoredSignature &L, const ScoredS
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM, but let's land together with a dependent revision to hove some code that
actually tests it.
Comment at: include/clang/Lex/Preprocessor.h:313
+ /// Ran
ilya-biryukov added a comment.
NIT: maybe also note the number of the clangd revision in this change's
description
Repository:
rC Clang
https://reviews.llvm.org/D50443
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
JonasToth added inline comments.
Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:29
+ hasSourceExpression(ignoringParenCasts(cxxOperatorCallExpr(
+ hasOverloadedOperatorName("/"), argumentCountIs(2),
+ hasArgument(0, expr(IsDuration)),
-
kbobyrev updated this revision to Diff 160104.
kbobyrev marked 12 inline comments as done.
kbobyrev added a comment.
Address most comments.
https://reviews.llvm.org/D50337
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/DexIndex.cpp
clang-tools-extra/clan
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Trigram.cpp:33
+
+void insertChars(DenseSet &UniqueTrigrams, std::string Chars) {
+ const auto Trigram = Token(Token::Kind::Trigram, Chars);
This is probably neater as a lambda in `gene
lebedev.ri updated this revision to Diff 160106.
lebedev.ri added a comment.
Rebase (ugh, bitrot), port `test/clang-tidy/hicpp-exception-baseclass.cpp`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D36892
Files:
test/clang-tidy/check_clang_tidy.py
test/clang-tidy/hicpp-exc
lebedev.ri updated this revision to Diff 160107.
lebedev.ri added a comment.
Add docs note.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D36892
Files:
docs/clang-tidy/index.rst
test/clang-tidy/check_clang_tidy.py
test/clang-tidy/hicpp-exception-baseclass.cpp
Index: test
JonasToth added a comment.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D36892
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: lebedevri
Date: Fri Aug 10 08:05:46 2018
New Revision: 339437
URL: http://llvm.org/viewvc/llvm-project?rev=339437&view=rev
Log:
[clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix
Summary:
Currently, there is two configured prefixes: `CHECK-FIXES` and `CHECK-MESSAGES`
`CHECK-MESS
deannagarcia updated this revision to Diff 160109.
deannagarcia marked 3 inline comments as done.
https://reviews.llvm.org/D50389
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/DurationDivisionCheck.cpp
clang-tidy/abseil/DurationDivisionCh
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339437: [clang-tidy] check_clang_tidy.py: support
CHECK-NOTES prefix (authored by lebedevri, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D3
Author: ahatanak
Date: Fri Aug 10 08:09:24 2018
New Revision: 339438
URL: http://llvm.org/viewvc/llvm-project?rev=339438&view=rev
Log:
[CodeGen] Merge equivalent block copy/helper functions.
Clang generates copy and dispose helper functions for each block literal
on the stack. Often these functio
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339438: [CodeGen] Merge equivalent block copy/helper
functions. (authored by ahatanak, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50152?vs=160053&id=160110#toc
Repository:
rC
hugoeg updated this revision to Diff 160112.
hugoeg marked 10 inline comments as done.
hugoeg added a comment.
Applied corrections from first round comments
https://reviews.llvm.org/D50542
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/NoI
hugoeg added inline comments.
Comment at: clang-tidy/abseil/NoInternalDepsCheck.cpp:24
+
+ Finder->addMatcher(
+ nestedNameSpecifierLoc(loc(specifiesNamespace(namespaceDecl(
JonasToth wrote:
> Actually that one is generally useful. Accessing the `foo::inter
jhibbits added a comment.
Hi Vit,
Thanks for the feedback. I can add the -mspe=yes/no, that shouldn't be hard.
I didn't include it because it's been deprecated by GCC already as well. I can
add the -mcpu=8548 option as well. I use -mcpu=8540 on FreeBSD for the
powerpcspe target anyway (GCC
simark marked 8 inline comments as done.
simark added inline comments.
Comment at: clangd/SourceCode.h:69
+llvm::Optional getRealPath(const FileEntry *F,
+const SourceManager &SourceMgr);
ilya-biryukov wrote:
> This funct
JonasToth added a comment.
LGTM with only the formatting question.
But don't commit before any of the reviewers accepts (@alexfh @aaron.ballman
usually have the last word)
Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:50
+ *result.SourceManager, resu
deannagarcia added inline comments.
Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:50
+ *result.SourceManager, result.Context->getLangOpts()),
+ ")");
+}
JonasToth wrote:
> This line looks odd, does it come from clang-format?
justice_adams created this revision.
justice_adams added a project: clang.
When mounting LLVM source into a windows container in read-only mode, certain
tests fail. Ideally, we want all these tests to pass so that developers can
mount the same source folder into multiple (windows) containers sim
cdavis5x created this revision.
cdavis5x added reviewers: mstorsjo, rnk, compnerd, smeenai.
Herald added subscribers: cfe-commits, chrib, christof, kristof.beyls, mgorny.
Herald added a reviewer: javed.absar.
I've tested this implementation on x86-64 to ensure that it works. All
`libc++abi` tests
miyuki updated this revision to Diff 160121.
miyuki edited the summary of this revision.
miyuki added a comment.
Fix handling of homogeneous aggregates of FP16 vectors
https://reviews.llvm.org/D50507
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGen/arm-vfp16-arguments.c
test/CodeGen/arm_neo
cdavis5x added a comment.
In https://reviews.llvm.org/D50413#1195101, @mstorsjo wrote:
> @cdavis5x I presume the fact that this one turned out tricky is blocking
> submitting the SEH unwinding patch.
>
> Would it be worth to rework that patch to just use the basic types just like
> libunwind do
JonasToth added inline comments.
Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:50
+ *result.SourceManager, result.Context->getLangOpts()),
+ ")");
+}
deannagarcia wrote:
> JonasToth wrote:
> > This line looks odd, does it com
JonasToth added inline comments.
Comment at: clang-tidy/abseil/NoInternalDepsCheck.cpp:24
+
+ Finder->addMatcher(
+ nestedNameSpecifierLoc(loc(specifiesNamespace(namespaceDecl(
hugoeg wrote:
> JonasToth wrote:
> > Actually that one is generally useful. Acce
hugoeg updated this revision to Diff 160124.
https://reviews.llvm.org/D50542
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/NoInternalDepsCheck.cpp
clang-tidy/abseil/NoInternalDepsCheck.h
docs/ReleaseNotes.rst
docs/clang-tidy/checks/ab
JonasToth added a comment.
Thank you for your first contribution to LLVM btw :)
Comment at: clang-tidy/abseil/NoInternalDepsCheck.cpp:24
+
+ TODO(hugoeg): refactor matcher to be configurable or just match on any
internal access from outside the enclosing namespace.
+
--
Hi David,
revision 339428 seems to have caused failing tests on a couple of windows
build bots, any chance you can take a look please?
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/18985
Failing Tests (1):
Clang :: CodeGenObjC/
Author: vsapsai
Date: Fri Aug 10 10:03:47 2018
New Revision: 339451
URL: http://llvm.org/viewvc/llvm-project?rev=339451&view=rev
Log:
[libcxx] Mark charconv tests as failing for previous libcxx versions.
was added in r338479. Previous libcxx versions don't have
this functionality and correspondi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339451: [libcxx] Mark charconv tests as failing for previous
libcxx versions. (authored by vsapsai, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm
Author: ahatanak
Date: Fri Aug 10 10:07:27 2018
New Revision: 339452
URL: http://llvm.org/viewvc/llvm-project?rev=339452&view=rev
Log:
Make changes to the check strings so that the test I modified in r339438
passes on 32-bit targets.
Modified:
cfe/trunk/test/CodeGenCXX/block-byref-cxx-objc.cp
kbobyrev updated this revision to Diff 160133.
kbobyrev marked 7 inline comments as done.
kbobyrev added a comment.
Address issues we have discussed with Eric.
https://reviews.llvm.org/D50517
Files:
clang-tools-extra/clangd/index/dex/Iterator.h
clang-tools-extra/clangd/index/dex/Trigram.cpp
vsapsai added a comment.
Thanks for the review.
Repository:
rL LLVM
https://reviews.llvm.org/D50543
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:58
+
+ Warns Abseil users if they attempt to depend on internal details.
I think will be good idea to omit user, and just refer to code which depend on
internal details. Please synchron
1 - 100 of 179 matches
Mail list logo
