JonasToth added a comment.
Thank you for your first contribution to LLVM btw :)
================
Comment at: clang-tidy/abseil/NoInternalDepsCheck.cpp:24
+
+ TODO(hugoeg): refactor matcher to be configurable or just match on any
internal access from outside the enclosing namespace.
+
----------------
Missing //
================
Comment at: clang-tidy/abseil/NoInternalDepsCheck.cpp:35
+void NoInternalDepsCheck::check(const MatchFinder::MatchResult &Result) {
+ const auto *intr_dep =
+ Result.Nodes.getNodeAs<NestedNameSpecifierLoc>("internal_dep");
----------------
Please follow the LLVM naming convention (s/initr_dep/InternalDependency/ or
similar)
https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
for reference
https://reviews.llvm.org/D50542
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
