rjmccall added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1276
+InitVar->setSection(".CRT$XCLa");
+CGM.addUsedGlobal(InitVar);
+ }
DHowett-MSFT wrote:
> rjmccall wrote:
> > Is the priority system not good enough?
> My reading of the LLVM langu
mstorsjo added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1276
+InitVar->setSection(".CRT$XCLa");
+CGM.addUsedGlobal(InitVar);
+ }
rjmccall wrote:
> DHowett-MSFT wrote:
> > rjmccall wrote:
> > > Is the priority system not good enough?
> > My r
Author: hans
Date: Wed Aug 8 00:50:31 2018
New Revision: 339222
URL: http://llvm.org/viewvc/llvm-project?rev=339222&view=rev
Log:
Merging r339217:
r339217 | cdavis | 2018-08-08 06:21:24 +0200 (Wed, 08 Aug 2018) | 11 lines
[
hans added a comment.
In https://reviews.llvm.org/D50412#1191843, @mstorsjo wrote:
> @hans This looks 7.0-worthy to me.
Okay, r339222.
Repository:
rL LLVM
https://reviews.llvm.org/D50412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Merged to 7.0 in r339222.
On Wed, Aug 8, 2018 at 6:21 AM, Charles Davis via cfe-commits
wrote:
> Author: cdavis
> Date: Tue Aug 7 21:21:24 2018
> New Revision: 339217
>
> URL: http://llvm.org/viewvc/llvm-project?rev=339217&view=rev
> Log:
> [libunwind] Fix pointer-to-integer cast warnings on LLP
kadircet updated this revision to Diff 159648.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Resolve some more discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50193
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/Diagnostic
JonasToth added a comment.
> Could you give a concrete example of this?
vi llvm/lib/Demangle/ItaniumDemangle.cpp +1762
/home/jonas/opt/llvm/lib/Demangle/ItaniumDemangle.cpp:1762:7: warning:
variable 'num' of type 'char [FloatData::max_demangled_size]' can
be declared 'const' [cppcoreguidelines-c
theraven updated this revision to Diff 159651.
theraven marked 2 inline comments as done.
theraven added a comment.
Herald added a subscriber: mgrang.
- Address Dustin's review comments.
- Fix an issue in protocol generation.
- Fix failing test.
- [gnu-objc] Make selector order deterministic.
- Ad
theraven updated this revision to Diff 159653.
theraven added a comment.
- Revert blocks part of the patch to put in a separate review.
Repository:
rC Clang
https://reviews.llvm.org/D50144
Files:
include/clang/Driver/Options.td
lib/AST/MicrosoftMangle.cpp
lib/CodeGen/CGException.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE339224: Added functionality to suggest FixIts for
conversion of '->' to '.' and vice… (authored by
kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50193?vs=159648&id=1596
ioeric added a comment.
2 high-level questions:
1. What's the reason for having a separate `SymbolOccurrenceSlab`? Could store
occurrences as extra payload of `Symbol`?
2. Could we merge `SymbolOccurrenceCollector` into the existing
`SymbolCollector`? They look a lot alike. Having another inde
Hahnfeld added a comment.
In https://reviews.llvm.org/D47849#1190997, @gtbercea wrote:
> Don't we want to use device specific math functions?
> It's not just about avoiding some the host specific assembly, it's also
> about getting an implementation tailored to the device.
Ok, so you are alre
martong created this revision.
martong added reviewers: a_sidorin, r.stahl, xazax.hun.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs.
Repository:
rC Clang
https://reviews.llvm.org/D50428
Files:
include/clang/ASTMatchers/ASTMatchers.h
lib/AST/ASTImporter.cpp
lib/ASTMatchers/ASTM
kbobyrev updated this revision to Diff 159658.
kbobyrev added a comment.
Minor code cleanup. This is now a fully functional symbol index.
I have reflected my concerns and uncertainties in `FIXME`s, please indicate if
you think there's something to improve in this patch. In general, I believe it
balazske updated this revision to Diff 159659.
balazske added a comment.
- Added common getFieldIndex.
- Corrected test ImportUnnamedFieldsInCorrectOrder.
Repository:
rC Clang
https://reviews.llvm.org/D49796
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
test/ASTMerge/u
martong updated this revision to Diff 159662.
martong added a comment.
Remove superflous newline
Repository:
rC Clang
https://reviews.llvm.org/D50428
Files:
include/clang/ASTMatchers/ASTMatchers.h
lib/AST/ASTImporter.cpp
lib/ASTMatchers/ASTMatchersInternal.cpp
unittests/AST/ASTImport
Author: balazske
Date: Wed Aug 8 02:40:57 2018
New Revision: 339226
URL: http://llvm.org/viewvc/llvm-project?rev=339226&view=rev
Log:
[ASTImporter] Load external Decls when getting field index.
Summary:
At equality check of fields without name the index of fields is compared.
At determining the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339226: [ASTImporter] Load external Decls when getting field
index. (authored by balazske, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49796
theraven created this revision.
theraven added a reviewer: rjmccall.
Herald added a subscriber: cfe-commits.
Windows does not allow globals to be initialised to point to globals in
another DLL. Exported globals may be referenced only from code. Work
around this by creating an initialiser that ru
theraven added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1262
+ if (IsWindows) {
+auto *Init = llvm::Function::Create(llvm::FunctionType::get(CGM.VoidTy,
+ {}), llvm::GlobalValue::InternalLinkage, ".block_isa_init",
rjmccall wrote:
> the
Merged to 7.0 in r339233.
On Tue, Aug 7, 2018 at 2:02 PM, David Chisnall via cfe-commits
wrote:
> Author: theraven
> Date: Tue Aug 7 05:02:46 2018
> New Revision: 339128
>
> URL: http://llvm.org/viewvc/llvm-project?rev=339128&view=rev
> Log:
> [objc-gnustep] Don't emit .guess ivar offset vars.
>
ilya-biryukov added a comment.
+1 Sam's suggestion of configuring this during initial LSP handshake, rather
than as a command-line flag.
We could put it into `ClientCapabilities` or into `initializationOptions`. The
latter has type 'any' in LSP, so it seems to be most in-line with the protocol
hokein created this revision.
hokein added a reviewer: ilya-biryukov.
Herald added subscribers: arphaman, mgrang, jkorous, MaskRay, ioeric.
GoToDefinition returns all declaration results (implicit/explicit) that are
in the same location, and the results are returned in arbitrary order.
Some LSP c
ilya-biryukov added a comment.
In https://reviews.llvm.org/D50154#1191002, @dblaikie wrote:
> What's the motivation for clangd to differ from clang here?
The presentation of diagnostics to the users is different between clang and
clangd:
- clang diagnostics are always prefixed with the file,
Szelethus added a comment.
In https://reviews.llvm.org/D48436#1191458, @NoQ wrote:
> Ok, let's commit this and see how to fix it later.
Thanks! ^-^
> I still think it's more important to come up with clear rules of who is
> responsible for initializing fields than making sure our warnings are
Merged in r339236. Thanks!
On Wed, Aug 8, 2018 at 2:46 AM, Richard Smith wrote:
> Would be good to get this into the Clang 7 release.
>
> On Tue, 7 Aug 2018 at 17:43, Richard Smith via cfe-commits
> wrote:
>>
>> Author: rsmith
>> Date: Tue Aug 7 17:42:42 2018
>> New Revision: 339210
>>
>> URL:
Szelethus updated this revision to Diff 159687.
Szelethus added a comment.
Added a TODO.
https://reviews.llvm.org/D48436
Files:
lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp
test/Analysis/cxx-uninitialized-object.cpp
Index: test/Analysis/cxx-uninitialized-object.cpp
==
Author: szelethus
Date: Wed Aug 8 05:23:02 2018
New Revision: 339237
URL: http://llvm.org/viewvc/llvm-project?rev=339237&view=rev
Log:
[analyzer][UninitializedObjectChecker] Fixed a false negative by no longer
filtering out certain constructor calls
As of now, all constructor calls are ignored
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339237: [analyzer][UninitializedObjectChecker] Fixed a false
negative by no longer… (authored by Szelethus, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D48436
Files:
lib/StaticAnal
Szelethus added a comment.
Thanks! I plan on revisiting how heap allocated regions are handled in the
future.
https://reviews.llvm.org/D49199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
sammccall created this revision.
sammccall added reviewers: ioeric, klimek.
Herald added a subscriber: cfe-commits.
Rather than hold all the JSON source in memory, as well as the YAML structures
needed to index into it, we parse eagerly into CompileCommand structures, which
simplifies the implemen
sammccall updated this revision to Diff 159690.
sammccall added a comment.
(just updating description)
Repository:
rC Clang
https://reviews.llvm.org/D50439
Files:
include/clang/Tooling/JSONCompilationDatabase.h
lib/Tooling/JSONCompilationDatabase.cpp
test/Index/skip-parsed-bodies/compi
hokein added a comment.
Thanks for contributing to clang-tidy!
Comment at: docs/clang-tidy/checks/abseil-duration-division.rst:3
+
+abseil-duration-division
+
This is a nice document. Does abseil have similar thing in its official
gui
gtbercea added a comment.
> Ok, so you are already talking about performance. I think we should fix
> correctness first, in particular the compiler shouldn't complain whenever
> `` is included.
This patch is concerned with calling device functions when you're on the
device. The correctness i
sammccall planned changes to this revision.
sammccall added a comment.
Nevermind, this is like 5x slower to load the chromium CDB. probably because of
all the little non-arena allocations.
I'll profile and fix it when I get bored again.
Repository:
rC Clang
https://reviews.llvm.org/D50439
kzhuravl accepted this revision.
kzhuravl added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D50376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric.
Repository:
rC Clang
https://reviews.llvm.org/D50443
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/Preprocessor.cpp
Index: lib/Lex/Prepro
martong created this revision.
martong added reviewers: a_sidorin, r.stahl, xazax.hun.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs.
Currently we consider one forward declared RecordDecl and another with a
definition equal. We have to do the same in case of enums.
Repository:
rC Cla
Szelethus updated this revision to Diff 159699.
Szelethus added a comment.
Rebased to latest trunk.
https://reviews.llvm.org/D49199
Files:
lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp
test/Analysis/cxx-uninitialized-object-inheritance.cpp
test/Analysis/cxx-uninitialized-obje
ilya-biryukov added a comment.
Maybe split the commit message into multiple lines?
I suggest we wait for clangd changes to be reviewed and land them together, so
that we have the tests and usages of this code.
Other than that LG
Comment at: include/clang/Lex/Preprocessor.h:11
ioeric created this revision.
ioeric added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
This allows implementations like different symbol indexes to know what
the current active file is. For example, some customized index implementation
might decide
Author: szelethus
Date: Wed Aug 8 06:18:53 2018
New Revision: 339240
URL: http://llvm.org/viewvc/llvm-project?rev=339240&view=rev
Log:
[analyzer][UninitializedObjectChecker] Pointer/reference objects are
dereferenced according to dynamic type
This patch fixed an issue where the dynamic type of
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339240: [analyzer][UninitializedObjectChecker]
Pointer/reference objects are… (authored by Szelethus, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49199
Files:
lib/StaticAnalyzer/C
kadircet updated this revision to Diff 159703.
kadircet marked an inline comment as done.
kadircet added a comment.
- Resolve discussions.
Repository:
rC Clang
https://reviews.llvm.org/D50443
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/Preprocessor.cpp
Index: lib/Lex/Preprocessor.c
spatel added a comment.
About the bit hacking: I don't think clang should be in the optimization
business. We should be able to take the most obvious/simple representation for
this builtin and reduce it as needed (either in instcombine or the backend). So
it would be better to use the version w
Author: henrywong
Date: Wed Aug 8 06:37:28 2018
New Revision: 339244
URL: http://llvm.org/viewvc/llvm-project?rev=339244&view=rev
Log:
[analyzer] Fix a typo in `RegionStore.txt`.
Summary: The typo of the description for default bindings can be confusing.
Reviewers: NoQ, george.karpenkov
Review
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339244: [analyzer] Fix a typo in `RegionStore.txt`.
(authored by henrywong, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50382
Files:
cfe/tr
Hahnfeld added a comment.
In https://reviews.llvm.org/D47849#1192134, @gtbercea wrote:
> This patch is concerned with calling device functions when you're on the
> device. The correctness issues you mention are orthogonal to this and should
> be handled by another patch. I don't think this patc
hokein created this revision.
hokein added reviewers: ilya-biryukov, alexfh.
Herald added a subscriber: xazax.hun.
The upstream change r336737 causes a regression issue in our internal
base codebase.
Adding an option to the check allowing us whitelist these classes.
Repository:
rCTE Clang Too
olista01 added inline comments.
Comment at: test/Driver/aarch64-cpus.c:10
+// GENERIC: "-cc1"{{.*}} "-triple" "aarch64"{{.*}} "-target-cpu" "generic"
+// GENERIC-LE: "-cc1"{{.*}} "-triple" "aarch64--"{{.*}} "-target-cpu" "generic"
Why do these need new check pr
lebedev.ri added subscribers: shuaiwang, JonasToth, lebedev.ri.
lebedev.ri added a comment.
Regression is very broad term. Is it a false-positive?
Perhaps it is better to address the issue in the ExprMutationAnalyzer itself?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50447
cdavis5x added a comment.
In https://reviews.llvm.org/D50414#1191834, @mstorsjo wrote:
> Should we maybe add the same declaration of `_GCC_specific_handler` to
> clang's unwind.h? That would allow removing the forward declaration in
> libcxxabi from https://reviews.llvm.org/D49638.
Probably.
RKSimon created this revision.
RKSimon added a reviewer: theraven.
As suggested by @theraven on PR38210, this patch fixes the gcc
-Woverloaded-virtual warnings by renaming the extra CGObjCGNU::GetSelector
method to CGObjCGNU::GetTypedSelector
Repository:
rC Clang
https://reviews.llvm.org/D5
JonasToth added a comment.
If whitelisting works, thats fine. But I agree with @lebedev.ri that a
contribution/improvement to the ExprMutAnalyzer is the better option. This is
especially the case, because multiple checks (and maybe even some other parts
then clang-tidy) will utilize this analys
ilya-biryukov added a comment.
Short summary of the offline discussion: I suggest adding this parameter into
the corresponding requests of the index (FuzzyFindRequest,
FindDefinitionsRequest) instead of stashing it in the context. Context has all
the same problems as the global variables, so we
JonasToth added inline comments.
Comment at: test/clang-tidy/performance-for-range-copy.cpp:1
-// RUN: %check_clang_tidy %s performance-for-range-copy %t -- -- -std=c++11
-fno-delayed-template-parsing
+// RUN: %check_clang_tidy %s performance-for-range-copy %t
-config="{CheckOp
xbolva00 added a comment.
Thanks, this warning is really annoying.
Repository:
rC Clang
https://reviews.llvm.org/D50448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric.
Completion replies contains textEdits as well. Note that this change
relies on https://reviews.llvm.org/D50443.
Repository:
rCTE Clang Tools Extr
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/MemIndex.h:45
// Index is a set of symbols that are deduplicated by symbol IDs.
- // FIXME: build smarter index structure.
llvm::DenseMap Index;
I think this FIXME still applies here.
hokein added a comment.
In https://reviews.llvm.org/D50447#1192280, @JonasToth wrote:
> If whitelisting works, thats fine. But I agree with @lebedev.ri that a
> contribution/improvement to the ExprMutAnalyzer is the better option. This is
> especially the case, because multiple checks (and mayb
lebedev.ri added a subscriber: EricWF.
lebedev.ri added a comment.
In https://reviews.llvm.org/D50447#1192316, @hokein wrote:
> In https://reviews.llvm.org/D50447#1192280, @JonasToth wrote:
>
> > If whitelisting works, thats fine. But I agree with @lebedev.ri that a
> > contribution/improvement
SjoerdMeijer added inline comments.
Comment at: test/Driver/aarch64-cpus.c:10
+// GENERIC: "-cc1"{{.*}} "-triple" "aarch64"{{.*}} "-target-cpu" "generic"
+// GENERIC-LE: "-cc1"{{.*}} "-triple" "aarch64--"{{.*}} "-target-cpu" "generic"
olista01 wrote:
> Why do t
gtbercea added a comment.
In https://reviews.llvm.org/D47849#1192245, @Hahnfeld wrote:
> In https://reviews.llvm.org/D47849#1192134, @gtbercea wrote:
>
> > This patch is concerned with calling device functions when you're on the
> > device. The correctness issues you mention are orthogonal to th
gtbercea added a comment.
> IIRC you started to work on this to fix the problem with inline assembly (see
> https://reviews.llvm.org/D47849#1125019). AFAICS this patch fixes
> declarations of math functions but you still cannot include `math.h` which
> most "correct" codes do.
I'm not sure w
JonasToth added a comment.
Is the type important, or specifics about the variable (e.g. the name?)
The `_` variable names are sometimes used for RAII variables/lambdas
that shall just do some cleanup, e.g. gsl::finally().
It might make sense to give `ExprMutAnalyzer` an ignore-mechanism.
I wonde
JonasToth added a comment.
@alexfh or @aaron.ballman could you take a final look on this one?
https://reviews.llvm.org/D49851
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
SjoerdMeijer updated this revision to Diff 159715.
SjoerdMeijer added a comment.
Addressed comments.
https://reviews.llvm.org/D50175
Files:
test/Driver/aarch64-cpus.c
Index: test/Driver/aarch64-cpus.c
===
--- test/Driver/aarch64
ioeric added a comment.
In https://reviews.llvm.org/D50446#1192282, @ilya-biryukov wrote:
> Short summary of the offline discussion: I suggest adding this parameter into
> the corresponding requests of the index (FuzzyFindRequest,
> FindDefinitionsRequest) instead of stashing it in the context.
Hahnfeld added a comment.
In https://reviews.llvm.org/D47849#1192321, @gtbercea wrote:
> > IIRC you started to work on this to fix the problem with inline assembly
> > (see https://reviews.llvm.org/D47849#1125019). AFAICS this patch fixes
> > declarations of math functions but you still cannot
gtbercea added a comment.
In https://reviews.llvm.org/D47849#1192368, @Hahnfeld wrote:
> In https://reviews.llvm.org/D47849#1192321, @gtbercea wrote:
>
> > > IIRC you started to work on this to fix the problem with inline assembly
> > > (see https://reviews.llvm.org/D47849#1125019). AFAICS this
cdavis5x updated this revision to Diff 159722.
cdavis5x added a comment.
- Remove unneeded preprocessor condition.
Repository:
rUNW libunwind
https://reviews.llvm.org/D50414
Files:
include/unwind.h
Index: include/unwind.h
==
Hahnfeld added a comment.
In https://reviews.llvm.org/D47849#1192375, @gtbercea wrote:
> I do not get that error.
In the beginning you said that you were facing the same error. Did that go away
in the meantime?
Are you testing on x86 or Power? With optimizations enabled?
Repository:
rC Cla
martong created this revision.
martong added reviewers: a_sidorin, xazax.hun, r.stahl.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs.
Currently there are several issues with the import of class template
specializations. (1) Different TUs may have class template specializations
with the
hokein added a comment.
> That looks remarkably like google benchmark main loop. (i don't know at hand
> if making this const will break it, but probably not?)
> I wonder if instead there should be an option to not complain about the
> variables that aren't actually used?
Yeah, it is google be
JonasToth added a comment.
Given it is about the performance in loops and the optimizer?! can
better work with the copy-and-don't-use it might make sense to just
check if the variable is dereferenced in the scope of the loop (any
declRefExpr exists).
That is more userfriendly, too.
Am 08.08.2018
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339256: [AST] Check described template at structural
equivalence check. (authored by balazske, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49223?vs=159458&id=159725#toc
Repositor
Author: balazske
Date: Wed Aug 8 08:04:27 2018
New Revision: 339256
URL: http://llvm.org/viewvc/llvm-project?rev=339256&view=rev
Log:
[AST] Check described template at structural equivalence check.
Summary:
When checking a class or function the described class or function template
is checked too
gtbercea added a comment.
In https://reviews.llvm.org/D47849#1192368, @Hahnfeld wrote:
> In https://reviews.llvm.org/D47849#1192321, @gtbercea wrote:
>
> > > IIRC you started to work on this to fix the problem with inline assembly
> > > (see https://reviews.llvm.org/D47849#1125019). AFAICS this
JonasToth added a comment.
> But in our codebase, we have code intended to use like below, and it is in
> base library, and is used widely. I think it makes sense to whitelist this
> class in our internal configuration.
>
> for (auto _ : state) {
> ... // no `_` being referenced in the f
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D50414#1192267, @cdavis5x wrote:
> In https://reviews.llvm.org/D50414#1191834, @mstorsjo wrote:
>
> > Do you plan on implementing these SEH specific bits in libu
Author: cdavis
Date: Wed Aug 8 08:18:20 2018
New Revision: 339258
URL: http://llvm.org/viewvc/llvm-project?rev=339258&view=rev
Log:
[libunwind][include] Add SEH declarations to .
Summary:
Make the `_Unwind_Exception` struct correct under SEH. Add a
declaration of `_GCC_specific_handler()`, which
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339258: [libunwind][include] Add SEH declarations to
. (authored by cdavis, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50414?vs=159722&id=159728#toc
Repository:
rL L
Author: cdavis
Date: Wed Aug 8 08:18:22 2018
New Revision: 339259
URL: http://llvm.org/viewvc/llvm-project?rev=339259&view=rev
Log:
Remove unneeded preprocessor condition.
Modified:
libunwind/trunk/include/unwind.h
Modified: libunwind/trunk/include/unwind.h
URL:
http://llvm.org/viewvc/llvm
jkorous created this revision.
jkorous added reviewers: arphaman, sammccall, ilya-biryukov, simark.
Herald added subscribers: cfe-commits, dexonsmith, MaskRay, ioeric, mgorny.
Based on our internal discussions we decided to change our direction with XPC
support for clangd. We did some extra measu
gtbercea added a comment.
In https://reviews.llvm.org/D47849#1192383, @Hahnfeld wrote:
> In https://reviews.llvm.org/D47849#1192375, @gtbercea wrote:
>
> > I do not get that error.
>
>
> In the beginning you said that you were facing the same error. Did that go
> away in the meantime?
> Are you
jkorous abandoned this revision.
jkorous added a comment.
We decided to abandon this direction in favor of simpler solution.
https://reviews.llvm.org/D50452
One of the reasons is that there's a design fault - handling of
server-originated messages (notifications) in this patch.
Repository:
r
jkorous added a comment.
Hi, we decided to go with a different solution:
https://reviews.llvm.org/D50452
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48559
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
jkorous abandoned this revision.
jkorous added a comment.
We decided to go with a different solution:
https://reviews.llvm.org/D50452
https://reviews.llvm.org/D48562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:162
+WithContextValue WithFileName(kActiveFile, File);
// FIXME(ibiryukov): even if Preamble is non-null, we may want to check
ioeric wrote:
> ilya-biryukov wrote:
> > If we want
Author: rksimon
Date: Wed Aug 8 08:34:00 2018
New Revision: 339261
URL: http://llvm.org/viewvc/llvm-project?rev=339261&view=rev
Log:
Fix -Wdocumentation warnings. NFCI.
Modified:
cfe/trunk/include/clang/Basic/IdentifierTable.h
Modified: cfe/trunk/include/clang/Basic/IdentifierTable.h
URL:
cdavis5x added inline comments.
Comment at: include/unwind.h:46
+typedef uintptr_t _Unwind_Ptr;
+#endif
+
mstorsjo wrote:
> What other reference is this list of typedefs for `_Unwind_Ptr` based on? I
> don't see any of these cases in clang's unwind.h at least.
W
theraven accepted this revision.
theraven added a comment.
This revision is now accepted and ready to land.
Looks good to me. This method should probably take a StringRef rather than a
`const std::string&`, but I can make that change separately.
Repository:
rC Clang
https://reviews.llvm.org
cdavis5x marked an inline comment as done.
cdavis5x added a comment.
In https://reviews.llvm.org/D50413#1191726, @krytarowski wrote:
> NetBSD uses `typedef void *_Unwind_Ptr;` unconditionally in its
> ``... if that has to be matched.
Done.
> Additionally: `typedef long _Unwind_Word;`.
Done.
cdavis5x updated this revision to Diff 159731.
cdavis5x added a comment.
- Add NetBSD-specific definitions.
- Pull out common declaration of `__personality_routine`.
Repository:
rUNW libunwind
https://reviews.llvm.org/D50413
Files:
include/unwind.h
Index: include/unwind.h
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339264: [CGObjCGNU] Rename GetSelector helper method to fix
-Woverloaded-virtual… (authored by RKSimon, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.
Author: rksimon
Date: Wed Aug 8 08:53:14 2018
New Revision: 339264
URL: http://llvm.org/viewvc/llvm-project?rev=339264&view=rev
Log:
[CGObjCGNU] Rename GetSelector helper method to fix -Woverloaded-virtual
warning (PR38210)
As suggested by @theraven on PR38210, this patch fixes the gcc
-Woverl
On Wed, Aug 8, 2018 at 5:00 AM Ilya Biryukov via Phabricator <
revi...@reviews.llvm.org> wrote:
> ilya-biryukov added a comment.
>
> In https://reviews.llvm.org/D50154#1191002, @dblaikie wrote:
>
> > What's the motivation for clangd to differ from clang here?
>
>
> The presentation of diagnostics
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339265: [DebugInfo][OpenCL] Address post-commit review for
r338299 (authored by scott.linder, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D
Author: scott.linder
Date: Wed Aug 8 08:56:12 2018
New Revision: 339265
URL: http://llvm.org/viewvc/llvm-project?rev=339265&view=rev
Log:
[DebugInfo][OpenCL] Address post-commit review for r338299
NFC refactor of code to generate debug info for OpenCL 2.X blocks.
Differential Revision: https://
gtbercea added a comment.
@Hahnfeld do you get the same error if you compile with clang++ instead of
clang?
Repository:
rC Clang
https://reviews.llvm.org/D47849
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
1 - 100 of 190 matches
Mail list logo
