ilya-biryukov added a comment. Maybe split the commit message into multiple lines?
I suggest we wait for clangd changes to be reviewed and land them together, so that we have the tests and usages of this code. Other than that LG ================ Comment at: include/clang/Lex/Preprocessor.h:1139 + /// on. + void setCodeCompletionTokenRange(const SourceLocation start, + const SourceLocation end) { ---------------- NIT: parameters are are `UpperCamelCase` in LLVM naming conventions Repository: rC Clang https://reviews.llvm.org/D50443 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits