hamzasood created this revision.
hamzasood added reviewers: EricWF, mclow.lists, rsmith.
Herald added subscribers: cfe-commits, ldionne, christof.
This patch adds the library components needed for contracts in C++2a.
The wording says that a contract_violation object is populated in an
implementa
Author: d0k
Date: Sun Jul 22 08:55:57 2018
New Revision: 337655
URL: http://llvm.org/viewvc/llvm-project?rev=337655&view=rev
Log:
[clangd] Unbreak fuzzer build.
Modified:
clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp
Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp
U
lebedev.ri updated this revision to Diff 156705.
lebedev.ri marked 3 inline comments as done.
lebedev.ri added a comment.
Hurray, got the PCH test working!
I'm still unsure about marking *all* the immediate implicit casts as part of
the group.
Repository:
rC Clang
https://reviews.llvm.org/D4
rjmccall added a comment.
The commit message here could be better. You're passing `-target-cpu` when
running the device-mode compiler.
https://reviews.llvm.org/D49643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
jvesely created this revision.
jvesely added reviewers: arsenm, tstellar.
Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng,
kzhuravl.
This feature was removed in r335942
Repository:
rC Clang
https://reviews.llvm.org/D49650
Files:
lib/Basic/Targets/AMDGPU.cpp
Index
alxu created this revision.
Herald added a subscriber: cfe-commits.
Before this patch, it is applied in order of increasing OLD path length. This
is not a useful behavior.
After this patch, it is applied based on the command line order from right to
left, stopping on the first match.
Reposito
alxu added a comment.
Oh, I forgot to mention, this is the way that gcc does it. Therefore, I expect
that almost everybody either doesn't care about the order, or assumes the gcc
behavior.
Repository:
rC Clang
https://reviews.llvm.org/D49652
__
Author: ericwf
Date: Sun Jul 22 13:50:16 2018
New Revision: 337658
URL: http://llvm.org/viewvc/llvm-project?rev=337658&view=rev
Log:
fix test failures with older clang versions
Added:
libcxx/trunk/test/std/experimental/filesystem/class.directory_entry/directory_entry.cons/default_const.pass.
Author: ericwf
Date: Sun Jul 22 14:15:15 2018
New Revision: 337659
URL: http://llvm.org/viewvc/llvm-project?rev=337659&view=rev
Log:
Harden copy_file even more.
This patch removes the O_CREAT open flag when we first
attempt to open the destination file but we expect it to
already exist.
This the
Author: brad
Date: Sun Jul 22 14:39:54 2018
New Revision: 337660
URL: http://llvm.org/viewvc/llvm-project?rev=337660&view=rev
Log:
OpenBSD/arm has switched to float ABI SoftFP.
Modified:
cfe/trunk/lib/Driver/ToolChains/Arch/ARM.cpp
cfe/trunk/test/Driver/openbsd.c
Modified: cfe/trunk/lib/
Author: ericwf
Date: Sun Jul 22 14:56:40 2018
New Revision: 337661
URL: http://llvm.org/viewvc/llvm-project?rev=337661&view=rev
Log:
Workaround bug in GCC trunk.
For some reason GCC ToT is failing to deduce the auto type for
a static data member from its initializer in some cases.
Though I'm sur
Author: ericwf
Date: Sun Jul 22 14:58:46 2018
New Revision: 337662
URL: http://llvm.org/viewvc/llvm-project?rev=337662&view=rev
Log:
Add GCC 9 to XFAILs list for test
Modified:
libcxxabi/trunk/test/catch_member_function_pointer_02.pass.cpp
Modified: libcxxabi/trunk/test/catch_member_function
Author: brad
Date: Sun Jul 22 15:04:28 2018
New Revision: 337663
URL: http://llvm.org/viewvc/llvm-project?rev=337663&view=rev
Log:
Fix the test
Modified:
cfe/trunk/test/Driver/openbsd.c
Modified: cfe/trunk/test/Driver/openbsd.c
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/
mclow.lists added a comment.
Thanks for doing this, but it needs tests before it can land.
If I were to define `class contract_violation {};` that would pass the tests
you've provided.
(Heck, if I removed the entire definition of `contract_violation`, it would
still pass.)
Co
mclow.lists added a comment.
I get that lib++ will not make these things, but we still need some tests
showing that the whole machinery works.
Repository:
rCXX libc++
https://reviews.llvm.org/D49647
___
cfe-commits mailing list
cfe-commits@lists
Author: ericwf
Date: Sun Jul 22 19:00:52 2018
New Revision: 337664
URL: http://llvm.org/viewvc/llvm-project?rev=337664&view=rev
Log:
Implement filesystem_error::what() and improve reporting.
This patch implements the `what()` for filesystem errors. The message
includes the 'what_arg', any paths t
yaxunl added a comment.
In https://reviews.llvm.org/D49643#1171158, @rjmccall wrote:
> The commit message here could be better. You're passing `-target-cpu` when
> running the device-mode compiler.
Right. Will fix. Thanks.
https://reviews.llvm.org/D49643
_
Author: ericwf
Date: Sun Jul 22 20:06:57 2018
New Revision: 337665
URL: http://llvm.org/viewvc/llvm-project?rev=337665&view=rev
Log:
Work around various GCC 4.9 build errors
Modified:
libcxx/trunk/src/experimental/filesystem/filesystem_common.h
libcxx/trunk/src/experimental/filesystem/ope
Author: ericwf
Date: Sun Jul 22 20:41:46 2018
New Revision: 337666
URL: http://llvm.org/viewvc/llvm-project?rev=337666&view=rev
Log:
Fix use of C++14 syntax in C++11 filesystem tests.
Modified:
libcxx/trunk/test/support/format_string.hpp
Modified: libcxx/trunk/test/support/format_string.hpp
rnkovacs created this revision.
rnkovacs added reviewers: NoQ, xazax.hun, george.karpenkov.
Herald added subscribers: mikhail.ramalho, a.sidorin, dkrupp, szepet,
baloghadamsoftware, whisperity.
According to the standard, pointers referring to the elements of a
`basic_string` sequence may also be
Author: phosek
Date: Sun Jul 22 21:19:55 2018
New Revision: 337668
URL: http://llvm.org/viewvc/llvm-project?rev=337668&view=rev
Log:
[CMake] Support statically linking dependencies only to shared or static library
Currently it's possible to select whether to statically link unwinder
or the C++ AB
Author: phosek
Date: Sun Jul 22 21:19:55 2018
New Revision: 337668
URL: http://llvm.org/viewvc/llvm-project?rev=337668&view=rev
Log:
[CMake] Support statically linking dependencies only to shared or static library
Currently it's possible to select whether to statically link unwinder
or the C++ AB
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337668: [CMake] Support statically linking dependencies only
to shared or static library (authored by phosek, committed by
Author: ericwf
Date: Sun Jul 22 21:55:57 2018
New Revision: 337669
URL: http://llvm.org/viewvc/llvm-project?rev=337669&view=rev
Log:
Use possibly cached directory entry values when performing recursive directory
iteration.
Modified:
libcxx/trunk/src/experimental/filesystem/directory_iterator
Author: phosek
Date: Sun Jul 22 22:07:44 2018
New Revision: 337670
URL: http://llvm.org/viewvc/llvm-project?rev=337670&view=rev
Log:
Revert "[CMake] Support statically linking dependencies only to shared or
static library"
This reverts commit r337668: broke the cxxabi build when using Make.
Mod
Author: phosek
Date: Sun Jul 22 22:07:44 2018
New Revision: 337670
URL: http://llvm.org/viewvc/llvm-project?rev=337670&view=rev
Log:
Revert "[CMake] Support statically linking dependencies only to shared or
static library"
This reverts commit r337668: broke the cxxabi build when using Make.
Mod
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks. This looks reasonable to me.
https://reviews.llvm.org/D49643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
Hi Richard,
this commit seems to cause invalid warning in the following example:
struct foo {
foo(char *x) : x_(&x[10]) {} //
private:
char *x_;
};
The warning itself:
1.cpp:2:21: warning: initializing pointer member 'x_' with the stack
address of parameter 'x' [-Wdangling-field]
I'll rever
Author: ibiryukov
Date: Sun Jul 22 23:32:36 2018
New Revision: 337671
URL: http://llvm.org/viewvc/llvm-project?rev=337671&view=rev
Log:
Revert "Fold dangling-field warning into general initialization lifetime
checks."
This reverts commit r337627.
After the change, clang started producing invalid
Reverted in r337671
On Mon, Jul 23, 2018 at 8:24 AM Ilya Biryukov wrote:
> Hi Richard,
>
> this commit seems to cause invalid warning in the following example:
>
> struct foo {
> foo(char *x) : x_(&x[10]) {} //
> private:
> char *x_;
> };
>
> The warning itself:
> 1.cpp:2:21: warning: initia
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: arphaman, jkorous, MaskRay, ioeric, ilya-biryukov.
The implicit bool conversion could happen superisingly, e.g. when
checking `if (Loc1 == Loc2)`, the compiler will convert SymbolLocation to
bool before com
31 matches
Mail list logo
