phosek added inline comments.
Comment at: libcxx/lib/CMakeLists.txt:269
+AND (TARGET cxxabi_static OR HAVE_LIBCXXABI))
+#if ((TARGET ${LIBCXX_CXX_ABI_LIBRARY}) OR
+#(${LIBCXX_CXX_ABI_LIBRARY} MATCHES "cxxabi(_static|_shared)?" AND
HAVE_LIBCXXABI))
---
arsenm added a comment.
ping
https://reviews.llvm.org/D47154
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Thu Jul 19 14:38:56 2018
New Revision: 337498
URL: http://llvm.org/viewvc/llvm-project?rev=337498&view=rev
Log:
When we choose to use zeroinitializer for a trailing portion of an array
constant, don't convert the rest into a packed struct.
If an array constant has a large non
rnkovacs created this revision.
rnkovacs added reviewers: NoQ, xazax.hun, george.karpenkov.
Herald added subscribers: mikhail.ramalho, a.sidorin, dkrupp, szepet,
baloghadamsoftware, whisperity.
In order to avoid scanning the map at each node in the bug reporter visitor,
the `MemRegion` represent
emmettneyman updated this revision to Diff 156362.
emmettneyman added a comment.
- Switched to JIT for compilation and execution
Repository:
rC Clang
https://reviews.llvm.org/D49526
Files:
clang/tools/clang-fuzzer/CMakeLists.txt
clang/tools/clang-fuzzer/ExampleClangLLVMProtoFuzzer.cpp
emmettneyman updated this revision to Diff 156364.
emmettneyman added a comment.
- Cleaned up leftover code from mmap memcpy
Repository:
rC Clang
https://reviews.llvm.org/D49526
Files:
clang/tools/clang-fuzzer/CMakeLists.txt
clang/tools/clang-fuzzer/ExampleClangLLVMProtoFuzzer.cpp
clan
Author: devnexen
Date: Thu Jul 19 14:50:03 2018
New Revision: 337499
URL: http://llvm.org/viewvc/llvm-project?rev=337499&view=rev
Log:
[CStringSyntaxChecker] Check strlcpy sizeof syntax
The last argument is expected to be the destination buffer size (or less).
Detects if it points to destina
akyrtzi accepted this revision.
akyrtzi added a comment.
This revision is now accepted and ready to land.
Good enough, thanks for looking into this!
Repository:
rC Clang
https://reviews.llvm.org/D49476
___
cfe-commits mailing list
cfe-commits@lis
jfb added a subscriber: yaxunl.
jfb added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:3361
+if ((Form != Load && Form != LoadCopy && AtomTy.isConstQualified()) ||
AtomTy.getAddressSpace() == LangAS::opencl_constant) {
Diag(DRE->getLocStart(), diag::
xazax.hun added a comment.
Yeah, I would rather have the cleanups and do extra work in the visitor. But
lets wait what @NoQ thinks.
Repository:
rC Clang
https://reviews.llvm.org/D49568
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
0x8000- marked 3 inline comments as done.
0x8000- added inline comments.
Comment at: test/clang-tidy/readability-magic-numbers.cpp:16
+void BuggyFunction() {
+ int BadLocalInt = 6;
+ // CHECK-MESSAGES: :[[@LINE-1]]:21: warning: magic number integer literal 6
[readabili
ldionne added inline comments.
Comment at: libcxx/lib/CMakeLists.txt:269
+AND (TARGET cxxabi_static OR HAVE_LIBCXXABI))
+#if ((TARGET ${LIBCXX_CXX_ABI_LIBRARY}) OR
+#(${LIBCXX_CXX_ABI_LIBRARY} MATCHES "cxxabi(_static|_shared)?" AND
HAVE_LIBCXXABI))
--
emmettneyman updated this revision to Diff 156370.
emmettneyman added a comment.
- Fixed typo that broke build
Repository:
rC Clang
https://reviews.llvm.org/D49526
Files:
clang/tools/clang-fuzzer/CMakeLists.txt
clang/tools/clang-fuzzer/ExampleClangLLVMProtoFuzzer.cpp
clang/tools/clang-
rnkovacs created this revision.
rnkovacs added reviewers: NoQ, dcoughlin, xazax.hun, george.karpenkov.
Herald added subscribers: mikhail.ramalho, a.sidorin, dkrupp, szepet,
baloghadamsoftware, whisperity.
Following the discussion at https://reviews.llvm.org/D49360.
Added two more test cases that
morehouse added inline comments.
Comment at: clang/tools/clang-fuzzer/handle-llvm/CMakeLists.txt:21
+ set(handle_llvm_deps)
+endif()
How are you doing your diff? Some of these changes are already upstream.
Please rebase
Comment at: clang
pcc added inline comments.
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:211-224
+ std::string ErrorMsg1;
+ EngineBuilder builder1(std::move(Owner1));
+ builder1.setMArch(MArch);
+ builder1.setMCPU(getCPUStr());
+ builder1.setMAttrs(getFeatureList());
+ b
echristo added a comment.
Getting close, one inline comment.
Comment at: lib/Driver/ToolChains/Cuda.h:161
bool SupportsProfiling() const override { return false; }
+ bool supportsDebugInfoOption(const llvm::opt::Arg *) const override {
+return false;
I'
Author: maskray
Date: Thu Jul 19 15:45:41 2018
New Revision: 337505
URL: http://llvm.org/viewvc/llvm-project?rev=337505&view=rev
Log:
[docs] Correct -fvisibility-inlines-hidden description
Modified:
cfe/trunk/docs/ClangCommandLineReference.rst
cfe/trunk/include/clang/Driver/Options.td
Mo
arphaman added a comment.
In https://reviews.llvm.org/D49523#1167553, @malaperle wrote:
> Interesting! We also have a need for passing compilation commands in a
> context where there is no compile_commands.json, but we were thinking of
> putting this in a "didChangeConfiguration" message so tha
phosek updated this revision to Diff 156382.
phosek edited subscribers, added: cfe-commits; removed: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49573
Files:
libcxx/CMakeLists.txt
libcxx/lib/CMakeLists.txt
libcxxabi/CMakeLists.txt
libcxxabi/src/CMakeLists.txt
libunwin
yaxunl marked 5 inline comments as done.
yaxunl added inline comments.
Comment at: lib/CodeGen/CGCUDANV.cpp:444
+auto HandleValue =
+CtorBuilder.CreateAlignedLoad(GpuBinaryHandle, CGM.getPointerAlign());
+llvm::Constant *Zero =
llvm::Constant::getNullValue(Handle
yaxunl updated this revision to Diff 156383.
yaxunl marked 3 inline comments as done.
yaxunl added a comment.
Revised by John's comments.
https://reviews.llvm.org/D49083
Files:
lib/CodeGen/CGCUDANV.cpp
test/CodeGenCUDA/device-stub.cu
Index: test/CodeGenCUDA/device-stub.cu
=
Author: rsmith
Date: Thu Jul 19 16:24:41 2018
New Revision: 337508
URL: http://llvm.org/viewvc/llvm-project?rev=337508&view=rev
Log:
Fix typo causing assert in self-host.
Modified:
cfe/trunk/lib/CodeGen/CGExprConstant.cpp
cfe/trunk/test/CodeGen/init.c
Modified: cfe/trunk/lib/CodeGen/CGEx
tra updated this revision to Diff 156386.
tra added a comment.
Fixed inline asm syntax.
Added workaround for the bug in __vmaxs2() discovered during testing().
I've got set of tests for these functions that I'll add to test-suite shortly.
AFAICT this implementation matches nvidia's bit-to-bit.
0x8000- updated this revision to Diff 156392.
0x8000- added a comment.
Small refactoring and documentation update.
Revert built-in acceptable integers to -1, 0 and 1 and document them.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49114
Files:
clang-tidy/cppcoreguid
thomasanderson updated this revision to Diff 156399.
thomasanderson marked 5 inline comments as done.
https://reviews.llvm.org/D49109
Files:
lib/CodeGen/ItaniumCXXABI.cpp
Index: lib/CodeGen/ItaniumCXXABI.cpp
===
--- lib/CodeGen/It
tra updated this revision to Diff 156397.
tra added a comment.
Fixed the issues pointed out by bkramer@.
Apparently. sat does not matter for vabsdiff instruction with unsigned operands.
My tests were also missing __vabsssN.
https://reviews.llvm.org/D49274
Files:
clang/lib/Headers/__clang_cu
yaxunl updated this revision to Diff 156403.
yaxunl marked 5 inline comments as done.
yaxunl added a comment.
Revised by John's comments.
https://reviews.llvm.org/D49294
Files:
lib/Sema/SemaCast.cpp
lib/Sema/SemaOverload.cpp
test/CodeGenCXX/address-space-cast.cpp
Index: test/CodeGenCXX/
tra marked 2 inline comments as done.
tra added a comment.
Ben, PTAL.
Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:1080
+ unsigned int r;
+ asm("vabsdiff2.u32.u32.u32.sat %0,%1,%2,0;" : "=r"(r) : "r"(__a), "r"(__b));
+ return r;
bkramer wrot
ahatanak updated this revision to Diff 156404.
ahatanak marked 2 inline comments as done.
ahatanak added a comment.
Add a comment that explains the meaning of BLOCK_IS_NOESCAPE to the docs.
Rename function needsCopyDispose to needsCopyDisposeHelpers.
Repository:
rC Clang
https://reviews.llvm
acoomans created this revision.
Herald added a subscriber: cfe-commits.
When running clang-format on specific lines, two types of indentation could be
expectedi:
- absolute indentation: the indentation one would get if the whole file were
formatted; or
- relative indentation: keep the indentati
acoomans added a comment.
An alternative to changing the whole behavior would be to make it a parameter /
configuration option.
Repository:
rC Clang
https://reviews.llvm.org/D49580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D49109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pcc requested changes to this revision.
pcc added a comment.
This revision now requires changes to proceed.
Sorry, I noticed that this patch is missing a test case. Can you add one please?
https://reviews.llvm.org/D49109
___
cfe-commits mailing list
rjmccall added inline comments.
Comment at: lib/CodeGen/CGCUDANV.cpp:466
+ CtorBuilder.CreateStore(RegisterFatbinCall, GpuBinaryAddr);
+ CtorBuilder.CreateBr(ExitBlock);
+CtorBuilder.SetInsertPoint(ExitBlock);
I meant more putting all the code for I
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, looks good.
https://reviews.llvm.org/D49294
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks. A couple tiny things and then LGTM.
Comment at: docs/Block-ABI-Apple.rst:69
+// block is a no-op, which is exactly how global blocks are handled.
+
+
Author: ericwf
Date: Thu Jul 19 18:25:06 2018
New Revision: 337517
URL: http://llvm.org/viewvc/llvm-project?rev=337517&view=rev
Log:
cleanup test assertion inside library
Modified:
libcxx/trunk/src/experimental/filesystem/operations.cpp
Modified: libcxx/trunk/src/experimental/filesystem/oper
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:253
+ allocation_state::getContainerObjRegion(N->getState(), PtrToBuf);
+ const auto *TypedRegion = dyn_cast(ObjRegion);
+ QualType ObjTy = TypedRegion->getValueType();
---
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D49553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
phosek updated this revision to Diff 156416.
phosek marked 8 inline comments as done.
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49502
Files:
libcxx/CMakeLists.txt
libcxx/cmake/Modules/HandleLibCXXABI.cmake
libcxx/lib/CMakeLists.txt
libcxxabi
phosek created this revision.
phosek added reviewers: ldionne, EricWF.
Herald added subscribers: cfe-commits, christof, mgorny.
This is a follow-up to r335809 and r337118. While libc++ headers are now
installed into the right location in both standard as well as multiarch
runtimes layout, turned
NoQ added a comment.
Oh, this FIXME, i almost forgot about that. Not sure if we should focus on this
now because it's kinda premature optimization, especially after
@george.karpenkov has fixed a large performance problem that caused `VisitNode`
to be called like ~30 times more often than necess
phosek added inline comments.
Comment at: libcxx/lib/CMakeLists.txt:269
+AND (TARGET cxxabi_static OR HAVE_LIBCXXABI))
+#if ((TARGET ${LIBCXX_CXX_ABI_LIBRARY}) OR
+#(${LIBCXX_CXX_ABI_LIBRARY} MATCHES "cxxabi(_static|_shared)?" AND
HAVE_LIBCXXABI))
---
Author: ericwf
Date: Thu Jul 19 18:44:33 2018
New Revision: 337519
URL: http://llvm.org/viewvc/llvm-project?rev=337519&view=rev
Log:
Use _LIBCPP_UNREACHABLE to convince GCC that non-void functions actually always
return
Modified:
libcxx/trunk/include/experimental/filesystem
libcxx/trunk/
Author: ericwf
Date: Thu Jul 19 18:51:48 2018
New Revision: 337520
URL: http://llvm.org/viewvc/llvm-project?rev=337520&view=rev
Log:
Fix two test failures in
First, didn't correctly guard
against min/max macros. This adds the proper push/pop macro guards.
Second, an internal time helper had be
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/CodeGen/CGCUDANV.cpp:578
+ DtorBuilder.CreateStore(Zero, GpuBinaryAddr);
+ DtorBuilder.CreateBr(ExitBlock);
+DtorBuilder.SetInsertPoint(ExitBlock);
rjmccall wrote
0x8000- updated this revision to Diff 156422.
0x8000- added a comment.
Add a (presently failing) test for not tripping up on __LINE__ through several
layers of macro expansion (as in GoogleTest library). This creates a lot of
false positives in the unit tests and needs to be fixed.
Rep
phosek abandoned this revision.
phosek added a comment.
Herald added a subscriber: ldionne.
Replaced by https://reviews.llvm.org/D49587.
Repository:
rCXX libc++
https://reviews.llvm.org/D41755
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
phosek abandoned this revision.
phosek added a comment.
Replaced by https://reviews.llvm.org/D49587.
Repository:
rUNW libunwind
https://reviews.llvm.org/D41753
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
phosek abandoned this revision.
phosek added a comment.
Herald added a subscriber: ldionne.
Replaced by https://reviews.llvm.org/D49587.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D41754
___
cfe-commits mailing list
cfe-commits@lists.ll
yaxunl updated this revision to Diff 156424.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Revised by John's comments.
https://reviews.llvm.org/D49083
Files:
lib/CodeGen/CGCUDANV.cpp
test/CodeGenCUDA/device-stub.cu
Index: test/CodeGenCUDA/device-stub.cu
=
0x8000- updated this revision to Diff 156425.
0x8000- added a comment.
Filter out synthetic integers (such as _LINE_) from the report.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49114
Files:
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy
sepavloff created this revision.
sepavloff added reviewers: rsmith, rjmccall, ikudrin.
With this change compiler generates alignment checks for wider range
of types. Previously such checks were generated only for the record types
with non-trivial default constructor. So the types like:
struct a
0x8000- added a comment.
./tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py
-clang-tidy-binary ../llvm.rel/bin/clang-tidy
-checks="-*,readability-magic-numbers" -j 12 -p ../llvm.rel -j 12 -quiet >
/tmp/llvm.magic
grep "warning:" /tmp/llvm.magic | cut -d: -f5 | cut -d" " -f2 | s
Author: rjmccall
Date: Thu Jul 19 22:40:12 2018
New Revision: 337525
URL: http://llvm.org/viewvc/llvm-project?rev=337525&view=rev
Log:
Document -fobjc-weak as an extension.
Fixes rdar://24091053.
Modified:
cfe/trunk/docs/LanguageExtensions.rst
Modified: cfe/trunk/docs/LanguageExtensions.rst
Author: rjmccall
Date: Thu Jul 19 22:40:09 2018
New Revision: 337524
URL: http://llvm.org/viewvc/llvm-project?rev=337524&view=rev
Log:
Fix and improve the ARC spec's wording about unmanaged objects.
Modified:
cfe/trunk/docs/AutomaticReferenceCounting.rst
Modified: cfe/trunk/docs/AutomaticRef
0x8000- updated this revision to Diff 156430.
0x8000- added a comment.
Avoid parsing and reformatting the input literal - just print the original
source code.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49114
Files:
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTi
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Alright, thanks, LGTM.
https://reviews.llvm.org/D49083
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
ioeric added a comment.
In https://reviews.llvm.org/D49476#1167294, @akyrtzi wrote:
> Is it possible to add a regression test case ? I assume this is fixing some
> issue, we should make sure we don't regress again.
This fixes a downstream use case where we use `OrigD`. AFAICT, `c-index-test`
jmorse added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D48072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall added a comment.
Herald added a subscriber: arphaman.
In https://reviews.llvm.org/D49417#1166538, @omtcyfz wrote:
> Addressed all comments submitted by Eric.
>
> As discussed internally, I should also exercise my naming skills and come up
> with a better for the symbol index to substit
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/noctem/SearchToken.cpp:38
+
+// FIXME(kbobyrev): Deal with short symbol symbol names. A viable approach
would
+// be generating unigrams and bigrams here, too. This would prevent symbol
index
-
sammccall added a comment.
(just .h files. +1 to eric's comments except where noted)
Comment at: clang-tools-extra/clangd/index/noctem/SearchToken.h:2
+//===--- SearchToken.h- Symbol Search primitive --*- C++
+//-*-===//
+//
nit: something went
baloghadamsoftware created this revision.
baloghadamsoftware added a reviewer: NoQ.
Herald added subscribers: mikhail.ramalho, a.sidorin, dkrupp, rnkovacs, szepet,
xazax.hun, whisperity.
Herald added a reviewer: george.karpenkov.
Patch [[https://reviews.llvm.org/rC329780 | [Analyzer] SValBuilder
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D41938#1167639, @baloghadamsoftware wrote:
> The flag is off by default. Except the rearrangement of additive operations.
> Should we put it also behind the flag?
I did it as a temporary quick fix: https://reviews.llvm.org/D49536.
jkorous accepted this revision.
jkorous added a comment.
This revision is now accepted and ready to land.
LGTM with just a nit about comment wording.
Thanks for the patch!
Comment at: clang/lib/Lex/PPDirectives.cpp:1875
+ // Stop further preprocessing if a fatal error has occ
CarlosAlbertoEnciso updated this revision to Diff 156234.
CarlosAlbertoEnciso marked 11 inline comments as done.
CarlosAlbertoEnciso added a comment.
Address review comments from @probinson
https://reviews.llvm.org/D46190
Files:
include/clang/Sema/Lookup.h
include/clang/Sema/Sema.h
includ
CarlosAlbertoEnciso added inline comments.
Comment at: include/clang/Sema/SemaInternal.h:91
Var->markUsed(SemaRef.Context);
+ SemaRef.MarkUsingReferenced(Var, Loc, /*CXXScopeSpec*=*/nullptr, RefExpr);
}
probinson wrote:
> The comments on a nullptr parameter
CarlosAlbertoEnciso added a comment.
In https://reviews.llvm.org/D46190#1166775, @probinson wrote:
> A bunch of style comments. Maybe try clang-format-diff.
@probinson:
Thanks very much for your review.
https://reviews.llvm.org/D46190
___
cfe-c
lebedev.ri updated this revision to Diff 156235.
lebedev.ri retitled this revision from "[CodeGen]
VisitMaterializeTemporaryExpr(): don't skip NoOp Casts." to "[Sema]
Expr::skipRValueSubobjectAdjustments(): record skipped NoOp casts.".
lebedev.ri edited the summary of this revision.
lebedev.ri ad
101 - 171 of 171 matches
Mail list logo
