morehouse added inline comments.

================
Comment at: clang/tools/clang-fuzzer/handle-llvm/CMakeLists.txt:21
+  set(handle_llvm_deps)
+endif()
 
----------------
How are you doing your diff?  Some of these changes are already upstream.  
Please rebase 


================
Comment at: clang/tools/clang-fuzzer/handle-llvm/fuzzer_initialize.cpp:52
+  return 0;
+}
----------------
Can we use `fuzzer-initialize/` now?


================
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:54
+
+static std::string OptIR;
+
----------------
Unless there's a good reason for global, let's make this a local.


Repository:
  rC Clang

https://reviews.llvm.org/D49526



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to