r335814 - [Analyzer] Constraint Manager Negates Difference

Author: baloghadamsoftware Date: Thu Jun 28 00:35:23 2018 New Revision: 335814 URL: http://llvm.org/viewvc/llvm-project?rev=335814&view=rev Log: [Analyzer] Constraint Manager Negates Difference If range [m .. n] is stored for symbolic expression A - B, then we can deduce the range for B - A whic

[PATCH] D35110: [Analyzer] Constraint Manager Negates Difference

This revision was automatically updated to reflect the committed changes. Closed by commit rC335814: [Analyzer] Constraint Manager Negates Difference (authored by baloghadamsoftware, committed by ). Repository: rC Clang https://reviews.llvm.org/D35110 Files: include/clang/StaticAnalyzer/Cor

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ank added a comment. awesome, I do not have merge rights so help with merging this would be greatly appreciated Repository: rC Clang https://reviews.llvm.org/D45719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D48159: [clangd] Implement hover for "auto" and "decltype"

sammccall accepted this revision. sammccall added a subscriber: klimek. sammccall added a comment. All sounds good to me. Comment at: clangd/XRefs.cpp:559 + //- auto& i = 1; + bool VisitDeclaratorDecl(DeclaratorDecl *D) { +if (!D->getTypeSourceInfo() || m

[PATCH] D48626: New option -fwindows-filesystem, affecting #include paths.

simon_tatham added a comment. @thakis : no, the backslash support is needed for include directives //in source files//, not just on command lines, because in my experience it's not unusual for Windows-only code bases to be full of things like `#include "Subdir\Header.h"`. @mstorsjo : in this d

[PATCH] D48708: NFC Build fix in RegisterCustomCheckersTest.cpp

GBuella created this revision. GBuella added reviewers: alexfh, george.karpenkov. Herald added a subscriber: cfe-commits. `ninja-build check-clang` failed using GCC 4.8.5 with: unittests/StaticAnalyzer/RegisterCustomCheckersTest.cpp:64:12: error: could not convert ‘AnalysisConsumer’ from ‘std

[PATCH] D47846: [clangd] Implementation of textDocument/documentSymbol

sammccall added inline comments. Comment at: clangd/SourceCode.cpp:194 + if (!llvm::sys::path::is_absolute(FilePath)) { +if (!SourceMgr.getFileManager().makeAbsolutePath(FilePath)) { + log("Could not turn relative path to absolute: " + FilePath); sammcc

[PATCH] D48159: [clangd] Implement hover for "auto" and "decltype"

klimek added inline comments. Comment at: clangd/XRefs.cpp:559 + //- auto& i = 1; + bool VisitDeclaratorDecl(DeclaratorDecl *D) { +if (!D->getTypeSourceInfo() || sammccall wrote: > malaperle wrote: > > sammccall wrote: > > > out of curiosity, why not implem

[PATCH] D45444: [clang-tidy] WIP: implement new check for const-correctness

JonasToth updated this revision to Diff 153267. JonasToth added a comment. - rebase on commited ExpMutationAnalyzer - clean up, documentation Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 153268. JonasToth marked 4 inline comments as done. JonasToth added a comment. - [Misc] order in release notes Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreg

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. - fixed some comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48687: [clangd] Avoid duplicates in findDefinitions response

ilya-biryukov added a comment. Thanks for the patch! Could we try to figure out why the duplicates were there in the first place and why the paths were different? It should be easy to mock exactly the same setup you have in #37963, i.e. create a vfs with three files and compilation database tha

[PATCH] D48687: [clangd] Avoid duplicates in findDefinitions response

ilya-biryukov added a comment. Also some heads-up: this would probably conflict https://reviews.llvm.org/D47846 that moves the same function into a different file. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48687 ___ cfe-commi

[PATCH] D48707: [CMake] Disable per-target runtimes for the first stage Fuchsia build

phosek updated this revision to Diff 153270. phosek edited the summary of this revision. Repository: rC Clang https://reviews.llvm.org/D48707 Files: clang/cmake/caches/Fuchsia.cmake Index: clang/cmake/caches/Fuchsia.cmake ===

[PATCH] D48701: [CMake] Rename cxx_headers back to cxx-headers.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rCXX libc++ https://reviews.llvm.org/D48701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

Rakete updated this revision to Diff 153271. Rakete added a comment. Addressed review comments :) https://reviews.llvm.org/D36357 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseExprCXX.cpp test/Parser/cxx0x-lambda-expressions.cpp test/SemaCXX/new-delete-0x.cpp

[PATCH] D48700: [CMake] Make bootstrap and compiler-rt depend on cxx-headers.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D48700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D48701: [CMake] Rename cxx_headers back to cxx-headers.

phosek added a comment. It's not obvious to me how anything could depend on `cxx-header`s target (not the component) since that target did not exist until r334468 which has landed only recently (just before r334477). The motivation behind this change was just consistency since all other targets

[PATCH] D48710: [CMake] Don't build Linux targets on Darwin in Fuchsia toolchain

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, mgorny. This is currently breaking because Linux target sysroots rely on case sensitive filesystem which is not by default enabled on macOS. Repository: rC Clang https://reviews.llvm.org/D4

[PATCH] D48634: [clangd] Improve output of --help and --version. NFC.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D48712: [X86] Lowering integer truncation intrinsics to native IR

mike.dvoretsky created this revision. mike.dvoretsky added a reviewer: craig.topper. Herald added a subscriber: cfe-commits. This patch lowers the _mm[256|512]_cvtepi{64|32|16}_epi{32|16|8} intrinsics to native IR in cases where the result's length is less than 128 bits. The resulting IR is fold

[PATCH] D48712: [X86] Lowering integer truncation intrinsics to native IR

mike.dvoretsky updated this revision to Diff 153277. mike.dvoretsky added a comment. Uploaded the correct diff. https://reviews.llvm.org/D48712 Files: clang/lib/Headers/avx512vlbwintrin.h clang/lib/Headers/avx512vlintrin.h clang/test/CodeGen/avx512vl-builtins.c clang/test/CodeGen/avx512

[PATCH] D48574: OpenBSD driver needs ld.lld in sanitiser context

devnexen added a comment. ping :) Repository: rC Clang https://reviews.llvm.org/D48574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

JonasToth updated this revision to Diff 153280. JonasToth added a comment. - remove bad code snippet which was dead Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48714 Files: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp test/clang-tidy/hicpp-exception-baseclass.cpp Index:

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

JonasToth created this revision. JonasToth added reviewers: aaron.ballman, alexfh, hokein, ilya-biryukov. Herald added subscribers: cfe-commits, xazax.hun. JonasToth updated this revision to Diff 153280. JonasToth added a comment. - remove bad code snippet which was dead PR37913 documents wrong

[PATCH] D48715: [X86] Fix some vector cmp builtins - TRUE/FALSE predicates

GBuella created this revision. GBuella added reviewers: craig.topper, uriel.k, RKSimon, andrew.w.kaylor, spatel, scanon, efriedma. Herald added a subscriber: cfe-commits. This patch removes on optimization used with the TRUE/FALSE predicates, as was suggested in https://reviews.llvm.org/D45616 fo

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 153282. JonasToth added a comment. - Merge branch 'master' into check_const Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/ConstCheck.cpp clang-ti

[PATCH] D48661: [Fixed Point Arithmetic] Fixed Point Constant

ebevhan added inline comments. Comment at: include/clang/Basic/FixedPoint.h:23 + +class FixedPointNumber { + public: rjmccall wrote: > The established naming convention here — as seen in `APInt`, `APFloat`, > `APValue`, etc. — would call this `APFixedPoint`. Ma

[PATCH] D47814: Teach libc++ to use native NetBSD's max_align_t

krytarowski added a comment. I saw this and I think that it shall be handled in libc++. NetBSD doesn't care if c++ runtime library is libstdc++, libc++, none or a different one. Repository: rL LLVM https://reviews.llvm.org/D47814 ___ cfe-commits

[PATCH] D48626: New option -fwindows-filesystem, affecting #include paths.

mstorsjo added a comment. In https://reviews.llvm.org/D48626#1146282, @simon_tatham wrote: > Although, come to think of it, that's not good enough, because if you have > multiple directories on your include //path// then you expect a lot of > lookups to fail for reasons that have nothing to do

[PATCH] D48626: New option -fwindows-filesystem, affecting #include paths.

simon_tatham added a comment. > first check all directories in a fully case sensitive manner, just like > today. And if that fails (and we'd have a real failure that we'd otherwise > return to the caller), redo it all with case insensitivity. I agree that the integration would be a bigger heada

r335834 - [DebugInfo] Follow-up commit to improve consistency. NFC

Author: jdevlieghere Date: Thu Jun 28 03:56:40 2018 New Revision: 335834 URL: http://llvm.org/viewvc/llvm-project?rev=335834&view=rev Log: [DebugInfo] Follow-up commit to improve consistency. NFC Follow-up commit for r335757 to address some inconsistencies. Modified: cfe/trunk/lib/CodeGen/CG

r335835 - [Analyzer] Iterator Checker - Part 2: Increment, decrement operators and ahead-of-begin checks

Author: baloghadamsoftware Date: Thu Jun 28 03:58:53 2018 New Revision: 335835 URL: http://llvm.org/viewvc/llvm-project?rev=335835&view=rev Log: [Analyzer] Iterator Checker - Part 2: Increment, decrement operators and ahead-of-begin checks Add handling of the begin() funcion of containers to the

[PATCH] D32642: [Analyzer] Iterator Checker - Part 2: Increment, decrement operators and ahead-of-begin checks

This revision was automatically updated to reflect the committed changes. Closed by commit rL335835: [Analyzer] Iterator Checker - Part 2: Increment, decrement operators and ahead… (authored by baloghadamsoftware, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r335836 - [clangd] Fix a data race in TUScheduler

Author: ibiryukov Date: Thu Jun 28 04:04:45 2018 New Revision: 335836 URL: http://llvm.org/viewvc/llvm-project?rev=335836&view=rev Log: [clangd] Fix a data race in TUScheduler By recomputing CompilerInvocation instead of copying it. The problem was caused by the fact that copies of CompilerInvoca

[PATCH] D47814: Teach libc++ to use native NetBSD's max_align_t

krytarowski added a comment. It's similar to MUSL, __DEFINED_max_align_t is musl specific and they don't care about libc++ or not on top of it. Repository: rL LLVM https://reviews.llvm.org/D47814 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

hokein added inline comments. Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:191 +void templated_thrower() { throw T{}(); } +// CHECK-MESSAGES: [[@LINE-1]]:34: warning: throwing an exception whose type 'int' is not derived from 'std::exception' + I th

[PATCH] D48441: [clangd] Incorporate transitive #includes into code complete proximity scoring.

ioeric added inline comments. Comment at: clangd/FileDistance.cpp:9 +//===--===// +// +// Is this intentionally reserved? Comment at: clangd/FileDistance.cpp:51 +for (Strin

r335841 - Fix the indentation in this documentation to remove a Sphinx warning; NFC.

Author: aaronballman Date: Thu Jun 28 05:00:16 2018 New Revision: 335841 URL: http://llvm.org/viewvc/llvm-project?rev=335841&view=rev Log: Fix the indentation in this documentation to remove a Sphinx warning; NFC. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/includ

r335842 - Correct the code highlighting marker to be Objective-C rather than C++ which fixes a Sphinx build warning; NFC.

Author: aaronballman Date: Thu Jun 28 05:02:38 2018 New Revision: 335842 URL: http://llvm.org/viewvc/llvm-project?rev=335842&view=rev Log: Correct the code highlighting marker to be Objective-C rather than C++ which fixes a Sphinx build warning; NFC. Modified: cfe/trunk/docs/ClangFormatStyle

[PATCH] D48687: [clangd] Avoid duplicates in findDefinitions response

simark added a comment. In https://reviews.llvm.org/D48687#1146308, @ilya-biryukov wrote: > Thanks for the patch! > Could we try to figure out why the duplicates were there in the first place > and why the paths were different? I tried to do that, but it goes deep in the clang internals with

Re: [clang-tools-extra] r335799 - Fixup test to compile with -frtti when trying to use typeid() as the PS4 does not have it on by default and it was failing on the PS4 linux bot because of this.

Thank you for fixing the test! On Thu, Jun 28, 2018 at 2:23 AM Douglas Yung via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dyung > Date: Wed Jun 27 17:19:12 2018 > New Revision: 335799 > > URL: http://llvm.org/viewvc/llvm-project?rev=335799&view=rev > Log: > Fixup test to compile

r335843 - The :option: syntax was generating Sphinx build warnings; switched to double backticks to silence the warning; NFC.

Author: aaronballman Date: Thu Jun 28 05:05:40 2018 New Revision: 335843 URL: http://llvm.org/viewvc/llvm-project?rev=335843&view=rev Log: The :option: syntax was generating Sphinx build warnings; switched to double backticks to silence the warning; NFC. Modified: cfe/trunk/docs/ReleaseNotes

[PATCH] D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement.

alexfh added inline comments. Comment at: unittests/clang-tidy/ExprMutationAnalyzerTest.cpp:582 + + AST = tooling::buildASTFromCode("namespace std { class type_info; }" + "void f() { int x; typeid(x = 10); }"); FYI, this test had

[clang-tools-extra] r335845 - Fix formatting. NFC.

Author: alexfh Date: Thu Jun 28 05:15:17 2018 New Revision: 335845 URL: http://llvm.org/viewvc/llvm-project?rev=335845&view=rev Log: Fix formatting. NFC. Modified: clang-tools-extra/trunk/unittests/clang-tidy/ExprMutationAnalyzerTest.cpp Modified: clang-tools-extra/trunk/unittests/clang-tid

[clang-tools-extra] r335846 - Remove explicit type from an initializer list. NFC.

Author: alexfh Date: Thu Jun 28 05:18:42 2018 New Revision: 335846 URL: http://llvm.org/viewvc/llvm-project?rev=335846&view=rev Log: Remove explicit type from an initializer list. NFC. Modified: clang-tools-extra/trunk/unittests/clang-tidy/ExprMutationAnalyzerTest.cpp Modified: clang-tools-

[PATCH] D48716: [clang-format] Fix counting parameters/arguments for ObjC

jolesiak created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D48716 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp Index: lib/Format/TokenAnnotator.cpp

[PATCH] D48717: [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well

JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai. The cppcoreguidelines-pro-bounds-pointer-arithmetic warns on all occassion where pointer arithmetic is used, but does not c

[PATCH] D48716: [clang-format] Fix counting parameters/arguments for ObjC

jolesiak updated this revision to Diff 153298. jolesiak added a comment. Fix comment Repository: rC Clang https://reviews.llvm.org/D48716 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp Index: lib/Format/TokenAnnotator.cpp =

[PATCH] D48718: [clang-format] Prohibit breaking after a bracket opening ObjC method expression

jolesiak created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D48718 Files: lib/Format/ContinuationIndenter.cpp Index: lib/Format/ContinuationIndenter.cpp === --- lib/For

[PATCH] D48687: [clangd] Avoid duplicates in findDefinitions response

malaperle added a comment. In https://reviews.llvm.org/D48687#1146515, @simark wrote: > In https://reviews.llvm.org/D48687#1146308, @ilya-biryukov wrote: > > > Thanks for the patch! > > Could we try to figure out why the duplicates were there in the first > > place and why the paths were diffe

[PATCH] D48719: [clang-format] Fix split priorities for ObjC methods

jolesiak created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D48719 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp =

[PATCH] D48720: [clang-format] Put ObjC method arguments into one line when they fit

jolesiak created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D48720 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp =

[PATCH] D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments

baloghadamsoftware updated this revision to Diff 153308. baloghadamsoftware added a comment. Herald added a reviewer: george.karpenkov. Herald added a subscriber: mikhail.ramalho. Rebased to https://reviews.llvm.org/rL335835. https://reviews.llvm.org/D32747 Files: include/clang/StaticAnalyzer

r335853 - [ODRHash] Do not rely on Type* when computing the hash.

Author: vvassilev Date: Thu Jun 28 06:28:44 2018 New Revision: 335853 URL: http://llvm.org/viewvc/llvm-project?rev=335853&view=rev Log: [ODRHash] Do not rely on Type* when computing the hash. ODRHash aims to provide Cross-TU stable hashing. Making clang::Type pointer part of the hash connects (re

[PATCH] D48524: [ODRHash] Do not rely on Type* when computing the hash.

This revision was automatically updated to reflect the committed changes. Closed by commit rL335853: [ODRHash] Do not rely on Type* when computing the hash. (authored by vvassilev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48524?

r335854 - Fix unittest build with GCC older than 5.

Author: d0k Date: Thu Jun 28 06:31:36 2018 New Revision: 335854 URL: http://llvm.org/viewvc/llvm-project?rev=335854&view=rev Log: Fix unittest build with GCC older than 5. Old GCCs have an annoying bug where RVO disables the automatic conversion to base for unique_ptr. Add a pessimizing std::move

[PATCH] D48719: [clang-format] Fix split priorities for ObjC methods

jolesiak updated this revision to Diff 153312. jolesiak added a comment. Fix comment. Repository: rC Clang https://reviews.llvm.org/D48719 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestObjC.cpp Index: uni

[PATCH] D48721: Patch to fix pragma metadata for do-while loops

deepak2427 created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D48721 Files: lib/CodeGen/CGStmt.cpp Index: lib/CodeGen/CGStmt.cpp === --- lib/CodeGen/CGStmt.cpp +++ lib/

[PATCH] D48574: OpenBSD driver needs ld.lld in sanitiser context

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM PS. I really wish at some point this will lead to an OpenBSD build bot! Repository: rC Clang https://reviews.llvm.org/D48574 ___ cfe-c

[PATCH] D48719: [clang-format] Fix split priorities for ObjC methods

jolesiak updated this revision to Diff 153313. jolesiak added a comment. Fix base change. Repository: rC Clang https://reviews.llvm.org/D48719 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp =

Re: r335854 - Fix unittest build with GCC older than 5.

Thanks! I was going to push the same fix, but you also explained why it's needed ;) On Thu, Jun 28, 2018 at 3:36 PM Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Thu Jun 28 06:31:36 2018 > New Revision: 335854 > > URL: http://llvm.org/viewvc/llvm-proje

[PATCH] D32845: [Analyzer] Iterator Checker - Part 4: Mismatched iterator checker for function parameters

baloghadamsoftware updated this revision to Diff 153314. baloghadamsoftware added a comment. Herald added a reviewer: george.karpenkov. Herald added a subscriber: mikhail.ramalho. Rebased to https://reviews.llvm.org/rL335835. https://reviews.llvm.org/D32845 Files: include/clang/StaticAnalyzer

[PATCH] D48721: Patch to fix pragma metadata for do-while loops

lebedev.ri added a comment. Test? (Or was this meant to contain `[Private]` in title?) Repository: rC Clang https://reviews.llvm.org/D48721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D48574: OpenBSD driver needs ld.lld in sanitiser context

devnexen added a comment. In https://reviews.llvm.org/D48574#1146619, @dberris wrote: > LGTM > > PS. I really wish at some point this will lead to an OpenBSD build bot! Would be interesting, it can even launch ubsan minimal tests and this change will simplify things a bit. Repository: rC C

[PATCH] D48352: [clang-format] Improve ObjC method expressions formatting

jolesiak abandoned this revision. jolesiak added a comment. Split: https://reviews.llvm.org/D48716 https://reviews.llvm.org/D48718 https://reviews.llvm.org/D48719 https://reviews.llvm.org/D48720 Repository: rC Clang https://reviews.llvm.org/D48352 __

[PATCH] D48717: [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well

alexfh added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.cpp:24 + const auto AllPointerTypes = anyOf( + hasType(pointerType()), hasType(autoType(hasDeducedType(pointerType(); Can anyOf be pushed inside ha

[PATCH] D48717: [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D48687: [clangd] Avoid duplicates in findDefinitions response

hokein added a comment. > Could we try to figure out why the duplicates were there in the first place > and why the paths were different? +1, I think there are two issues here: 1. the result contains two candidates, which should be one, IIUC. 2. the absolute file path problem, we encountered si

[PATCH] D48708: NFC Build fix in RegisterCustomCheckersTest.cpp

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: unittests/StaticAnalyzer/RegisterCustomCheckersTest.cpp:64 }); -return AnalysisConsumer; +return std::unique_ptr(AnalysisConsumer.relea

[PATCH] D48574: OpenBSD driver needs ld.lld in sanitiser context

This revision was automatically updated to reflect the committed changes. Closed by commit rC335856: OpenBSD driver needs ld.lld in sanitizer context (authored by devnexen, committed by ). Repository: rC Clang https://reviews.llvm.org/D48574 Files: lib/Driver/ToolChains/OpenBSD.cpp Index:

[PATCH] D17700: [clang-format] Proposal for changes to Objective-C block formatting

Myrronth added a comment. Do you mind sharing your modified version? The fork in the discussion you mentioned (https://github.com/square/spacecommander/issues/33) seems to be out-of-date or at least does not have the AllowNewlineBeforeBlockParameter setting. https://reviews.llvm.org/D17700

[PATCH] D48721: Patch to fix pragma metadata for do-while loops

deepak2427 added a comment. It's a patch for a bug in clang. I have requested for a Bugzilla account, however thought of putting up the patch in the meantime. Do I need to mark it '[Private]'? Repository: rC Clang https://reviews.llvm.org/D48721

[PATCH] D48561: [Analyzer] Moved RangeConstraintManager to header. NFC.

mikhail.ramalho added a comment. In https://reviews.llvm.org/D48561#1146114, @george.karpenkov wrote: > After thinking about this change a bit longer, I think it does not make sense. > > Albeit poorly named, the previous design had a purpose: > `RangedConstraintManager` is a public interface, an

[PATCH] D48717: [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well

aaron.ballman requested changes to this revision. aaron.ballman added inline comments. This revision now requires changes to proceed. Comment at: test/clang-tidy/cppcoreguidelines-pro-bounds-pointer-arithmetic-pr36489.cpp:4 + +// Fix PR36489 and detect auto-deduced value correct

r335856 - OpenBSD driver needs ld.lld in sanitizer context

Author: devnexen Date: Thu Jun 28 06:49:41 2018 New Revision: 335856 URL: http://llvm.org/viewvc/llvm-project?rev=335856&view=rev Log: OpenBSD driver needs ld.lld in sanitizer context Base GNU ld is pretty ancient and does not support --dynamic-list flag. For conveniency, we can it automatically

Re: [PATCH] D48721: Patch to fix pragma metadata for do-while loops

It's a patch for a bug in clang. I have requested for a Bugzilla account, however thought of putting up the patch in the meantime. Do I need to mark it '[Private]'? On Thu, Jun 28, 2018 at 2:41 PM Roman Lebedev via Phabricator < revi...@reviews.llvm.org> wrote: > lebedev.ri added a comment. > > T

[PATCH] D48721: Patch to fix pragma metadata for do-while loops

xbolva00 added a comment. Please upload patch with full context Repository: rC Clang https://reviews.llvm.org/D48721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48721: Patch to fix pragma metadata for do-while loops

lebedev.ri added a comment. In https://reviews.llvm.org/D48721#1146662, @deepak2427 wrote: > It's a patch for a bug in clang. > I have requested for a Bugzilla account, however thought of putting up the > patch in the meantime. > Do I need to mark it '[Private]'? Phab is the correct way to s

[PATCH] D48721: Patch to fix pragma metadata for do-while loops

deepak2427 updated this revision to Diff 153316. deepak2427 added a comment. Add full context https://reviews.llvm.org/D48721 Files: lib/CodeGen/CGStmt.cpp Index: lib/CodeGen/CGStmt.cpp === --- lib/CodeGen/CGStmt.cpp +++ lib/Co

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

alexfh added inline comments. Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:191 +void templated_thrower() { throw T{}(); } +// CHECK-MESSAGES: [[@LINE-1]]:34: warning: throwing an exception whose type 'int' is not derived from 'std::exception' + hoke

[PATCH] D48721: Patch to fix pragma metadata for do-while loops

deepak2427 added a comment. > Phab is the correct way to submit patches. > But having a bugreport in bugzilla is good too. > But the test will be needed regardless of the patch submission method. > And yes, please do always upload all patches with full context (`-U9`). Sorry about the cont

[PATCH] D17700: [clang-format] Proposal for changes to Objective-C block formatting

ksuther added a comment. My fork of spacecommander has a version of clang-format with the option. It's a couple of years old at this point, but it has been running without any issues. https://reviews.llvm.org/D17700 ___ cfe-commits mailing list cfe

Re: [PATCH] D48721: Patch to fix pragma metadata for do-while loops

> > Phab is the correct way to submit patches. > But having a bugreport in bugzilla is good too. > But the test will be needed regardless of the patch submission method. > And yes, please do always upload all patches with full context (`-U9`). Sorry about the context. Can I add the test file

r335858 - Fix test that was failing on Windows due to too many backslashes

Author: filcab Date: Thu Jun 28 07:16:13 2018 New Revision: 335858 URL: http://llvm.org/viewvc/llvm-project?rev=335858&view=rev Log: Fix test that was failing on Windows due to too many backslashes Modified: cfe/trunk/test/Driver/linux-per-target-runtime-dir.c Modified: cfe/trunk/test/Driver

[PATCH] D48721: Patch to fix pragma metadata for do-while loops

lebedev.ri added a comment. In https://reviews.llvm.org/D48721#1146681, @deepak2427 wrote: > > Phab is the correct way to submit patches. > > But having a bugreport in bugzilla is good too. > > But the test will be needed regardless of the patch submission method. > > And yes, please do always

[PATCH] D48722: [ASTImporter] Update isUsed flag at Decl import.

balazske created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: a.sidorin. When a Decl is imported over an already existing similar one, the isUsed flag is updated if it is set in the imported Decl. This can happen if the Decl is used somewhere in the impor

[PATCH] D48715: [X86] Fix some vector cmp builtins - TRUE/FALSE predicates

spatel added inline comments. Comment at: test/CodeGen/avx-builtins.c:1423 - -__m256 test_mm256_cmp_ps_true(__m256 a, __m256 b) { - // CHECK-LABEL: @test_mm256_cmp_ps_true Why are we deleting tests instead of replacing the CHECK lines with the new output? Rep

[PATCH] D48615: [CUDA] Place all CUDA sections in __NV_CUDA segment on Mac.

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LGTM. These were the section names I suspected, but I wasn't able to verify back then. https://reviews.llvm.org/D48615 ___ cfe-commits maili

[PATCH] D48715: [X86] Fix some vector cmp builtins - TRUE/FALSE predicates

GBuella added inline comments. Comment at: test/CodeGen/avx-builtins.c:1423 - -__m256 test_mm256_cmp_ps_true(__m256 a, __m256 b) { - // CHECK-LABEL: @test_mm256_cmp_ps_true spatel wrote: > Why are we deleting tests instead of replacing the CHECK lines with the n

[PATCH] D17700: [clang-format] Proposal for changes to Objective-C block formatting

Myrronth added a comment. Thanks, I’ll give it a try. https://reviews.llvm.org/D17700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48724: [clangd] Log sema completion context kind and query scopes. NFC

ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48724 Files: clangd/CodeComplete.cpp Index: clangd/CodeComplete.cpp ===

[PATCH] D48687: [clangd] Avoid duplicates in findDefinitions response

ilya-biryukov added a comment. I'm somewhat familiar with the internals of clang around the FileManager/VFS, so I could try creating the repro of this issue. The bugreport has enough info to get started. (Probably tomorrow, I certainly won't get to it today). In https://reviews.llvm.org/D48687#

Re: r335781 - DR1687: When overload resolution selects a built-in operator, implicit

On Wed, Jun 27, 2018 at 10:30 PM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Wed Jun 27 13:30:34 2018 > New Revision: 335781 > > URL: http://llvm.org/viewvc/llvm-project?rev=335781&view=rev > Log: > DR1687: When overload resolution selects a built-in operator, implicit > convers

[PATCH] D48715: [X86] Fix some vector cmp builtins - TRUE/FALSE predicates

spatel added inline comments. Comment at: test/CodeGen/avx-builtins.c:1423 - -__m256 test_mm256_cmp_ps_true(__m256 a, __m256 b) { - // CHECK-LABEL: @test_mm256_cmp_ps_true GBuella wrote: > spatel wrote: > > Why are we deleting tests instead of replacing the CHEC

[PATCH] D46951: [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode

alexfh updated this revision to Diff 153327. alexfh marked 3 inline comments as done. alexfh added a comment. - Addressed review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46951 Files: clang-tidy/misc/UnusedParametersCheck.cpp clang-tidy/misc/UnusedParametersC

[PATCH] D46951: [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode

alexfh added inline comments. Comment at: clang-tidy/misc/UnusedParametersCheck.cpp:180 +// (constructor initializer counts for non-empty body). +if (StrictMode || llvm::distance(Function->getBody()->children()) > 0 || +(isa(Function) && lebedev.r

[PATCH] D48687: [clangd] Avoid duplicates in findDefinitions response

simark added a comment. Btw, this seems to happen only when the included header is in the preamble. If I put a variable declaration before `#include "first.h"`, things work as expected, we have not duplicates and the path is normalized. Repository: rCTE Clang Tools Extra https://reviews.ll

[clang-tools-extra] r335863 - [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode

Author: alexfh Date: Thu Jun 28 08:21:25 2018 New Revision: 335863 URL: http://llvm.org/viewvc/llvm-project?rev=335863&view=rev Log: [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode Summary: This addresses https://bugs.llvm.org/show_bug.cgi?id=37467. Reviewers: klimek,

[PATCH] D46951: [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode

This revision was automatically updated to reflect the committed changes. Closed by commit rL335863: [clang-tidy] misc-unused-parameters - retain old behavior under StrictMode (authored by alexfh, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm

  1   2   3   >