lebedev.ri added a comment. In https://reviews.llvm.org/D48721#1146681, @deepak2427 wrote:
> > Phab is the correct way to submit patches. > > But having a bugreport in bugzilla is good too. > > But the test will be needed regardless of the patch submission method. > > And yes, please do always upload all patches with full context (`-U99999`). > > Sorry about the context. > Can I add the test file to this patch itself? Or should that be another > patch? The test needs to be in `test/CodeGen/` (i'm guessing). See other files there for examples. (And do check that `$ ninja check-clang` passes) https://reviews.llvm.org/D48721 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
