ebevhan added a comment.
Thanks! I do not have commit access, so it would be great if someone could
commit this.
https://reviews.llvm.org/D47630
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
SjoerdMeijer added a comment.
No problem, will commit this today.
https://reviews.llvm.org/D48188
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
paulsemel added a comment.
I will for sure add tests @lebedev.ri . Fact is that, for the moment, this is
not working as expected.
This is why I am asking for a bit of help about this bitfield handling :)
Comment at: lib/CodeGen/CGBuiltin.cpp:1250
+ if (Info.IsSigned) {
+
Author: bader
Date: Wed Jun 20 01:31:24 2018
New Revision: 335103
URL: http://llvm.org/viewvc/llvm-project?rev=335103&view=rev
Log:
[Sema] Allow creating types with multiple of the same addrspace.
Summary:
The comment with the OpenCL clause about this clearly
says: "No type shall be qualified by
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335103: [Sema] Allow creating types with multiple of the
same addrspace. (authored by bader, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47630?vs=150683&id=152033#toc
Repository:
jolesiak created this revision.
Herald added a subscriber: cfe-commits.
1. Fix counting parameters/arguments for ObjC.
2. Fix split priorities for ObjC methods.
3. Fix breaking after square bracket starting ObjC method expression.
4. Fix putting ObjC method arguments into one line when they fit.
jolesiak updated this revision to Diff 152043.
jolesiak added a comment.
- Add test
Repository:
rC Clang
https://reviews.llvm.org/D48352
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestObjC.cpp
Index: unitt
Author: sjoerdmeijer
Date: Wed Jun 20 02:49:40 2018
New Revision: 335111
URL: http://llvm.org/viewvc/llvm-project?rev=335111&view=rev
Log:
[SPIR] Prevent SPIR targets from using half conversion intrinsics
The SPIR target currently allows for half precision floating point types to be
emitted using
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335111: [SPIR] Prevent SPIR targets from using half
conversion intrinsics (authored by SjoerdMeijer, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48188?vs=151938&id=152045#toc
Rep
mstorsjo created this revision.
mstorsjo added reviewers: mgorny, compnerd.
Herald added a reviewer: EricWF.
The paths output from llvm-config --cmakedir and from clang
--print-libgcc-file-name can contain backslashes, while CMake can't handle the
paths in this form.
This matches what compiler-
mstorsjo created this revision.
mstorsjo added reviewers: mgorny, compnerd.
Herald added a subscriber: chrib.
The paths output from llvm-config --cmakedir and from clang
--print-libgcc-file-name can contain backslashes, while CMake can't handle the
paths in this form.
This matches what compiler
ovmold created this revision.
ovmold added a reviewer: craig.topper.
ovmold added a project: clang.
Herald added a subscriber: cfe-commits.
In the 'detectCTLZIdiom' function support for loops that use LSHR instruction
instead of ASHR has been added.
The problem is that for the following piece of
mstorsjo created this revision.
mstorsjo added reviewers: mgorny, compnerd.
Herald added a reviewer: EricWF.
The paths output from llvm-config --cmakedir and from clang
--print-libgcc-file-name can contain backslashes, while CMake can't handle the
paths in this form.
This matches what compiler-
rogfer01 created this revision.
rogfer01 added a reviewer: asb.
Herald added subscribers: mgrang, edward-jones, zzheng, shiva0217, kito-cheng,
niosHD, sabuasal, apazos, simoncook, johnrusso, rbar.
We were calculating twice ilp32/lp64. Do this just in one place instead.
https://reviews.llvm.org/
rogfer01 added inline comments.
Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:381
+ // FIXME: currently defaults to the soft-float ABIs. Will need to be
+ // expanded to select ilp32f, ilp32d, lp64f, lp64d when appropriate.
When 64-bit is upstreamed and `l
gerazo updated this revision to Diff 152055.
gerazo added a comment.
Added @martong 's suggestions.
https://reviews.llvm.org/D47946
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
r.stahl added inline comments.
Comment at: lib/AST/ASTImporter.cpp:7058
+const SrcMgr::ExpansionInfo &FromEx = FromSLoc.getExpansion();
+SourceLocation ToSpLoc = Import(FromEx.getSpellingLoc());
+SourceLocation ToExLocS = Import(FromEx.getExpansionLocStart());
---
GBuella updated this revision to Diff 152060.
GBuella edited the summary of this revision.
https://reviews.llvm.org/D45616
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/avx-builtins.c
test/CodeGen/avx-cmp-builtins.c
test/CodeGen/avx2-builtins.c
test/CodeGen/avx512f-builtins.c
test/Cod
GBuella added a comment.
I was overzealous with the intrinsics, I lower really only the packed
comparison now.
https://reviews.llvm.org/D45616
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
krasimir created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D48363
Files:
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
===
--- lib/Format/Format.cpp
+++ lib/Forma
RKSimon added inline comments.
Comment at: test/CodeGen/avx512-reduceIntrin.c:1
// RUN: %clang_cc1 -ffreestanding %s -O2 -triple=x86_64-apple-darwin
-target-cpu skylake-avx512 -emit-llvm -o - -Wall -Werror | FileCheck %s
We're using -O2 here but most codegen
yamaguchi created this revision.
yamaguchi added reviewers: rsmith, aprantl, bruno.
Reproducer and errors:
https://bugs.llvm.org/show_bug.cgi?id=37878
lookupModule was falling back to loadSubdirectoryModuleMaps when it couldn't
find ModuleName in (proper) search paths. This was causing iteration
Author: mramalho
Date: Wed Jun 20 04:42:12 2018
New Revision: 335116
URL: http://llvm.org/viewvc/llvm-project?rev=335116&view=rev
Log:
[analyzer] Optimize constraint generation when the range is a concrete value
Summary:
If a constraint is something like:
```
$0 = [1,1]
```
it'll now be created a
Author: meinersbur
Date: Tue Jun 19 16:46:52 2018
New Revision: 335084
URL: http://llvm.org/viewvc/llvm-project?rev=335084&view=rev
Log:
Append new attributes to the end of an AttributeList.
... instead of prepending it at the beginning (the original behavior
since implemented in r122535 2010-12-
yamaguchi updated this revision to Diff 152086.
yamaguchi added a comment.
Update commmit message and comment, add ObjC2
https://reviews.llvm.org/D48367
Files:
clang/include/clang/Lex/ModuleMap.h
clang/lib/Lex/HeaderSearch.cpp
Index: clang/lib/Lex/HeaderSearch.cpp
sammccall created this revision.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov.
Injected names being ranked too high was just a bug.
The high boost for keywords was intended, but was too much given how useless
keywords are. We should probably boost them on a case-b
cryptoad created this revision.
cryptoad added a reviewer: eugenis.
Herald added a subscriber: cfe-commits.
This is the clang side of the change, there is a compiler-rt counterpart.
Scudo works with UBSan using `-fsanitize=scudo,integer` for example, and to do
so it embeds UBSan runtime. This mak
Author: nico
Date: Wed Jun 20 08:57:38 2018
New Revision: 335139
URL: http://llvm.org/viewvc/llvm-project?rev=335139&view=rev
Log:
Simplify. No behavior change.
Modified:
cfe/trunk/lib/Sema/SemaInit.cpp
Modified: cfe/trunk/lib/Sema/SemaInit.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/t
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov.
It's almost always identical to Name, and in fact we never used it (we used name
instead).
The only case where they differ is objc method selectors (foo: vs
aprantl added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:285
// directory.
-loadSubdirectoryModuleMaps(SearchDirs[Idx]);
+if (ModMap.getLangOpts().ObjC1 || ModMap.getLangOpts().ObjC2)
+ loadSubdirectoryModuleMaps(SearchDirs[Idx]);
--
Szelethus updated this revision to Diff 152105.
Szelethus added a comment.
Fixes according to inline comments.
https://reviews.llvm.org/D48291
Files:
lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp
test/Analysis/cxx-uninitialized-object.cpp
Index: test/Analysis/cxx-uninitialized
probinson added a comment.
In https://reviews.llvm.org/D47720#1136585, @gramanas wrote:
> ping! should I commit this?
@vsk accepted it, so yes go ahead.
Repository:
rC Clang
https://reviews.llvm.org/D47720
___
cfe-commits mailing list
cfe-comm
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D45616
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
bruno added a comment.
Hi Yuka, thanks for working on this.
Comment at: clang/lib/Lex/HeaderSearch.cpp:285
// directory.
-loadSubdirectoryModuleMaps(SearchDirs[Idx]);
+if (ModMap.getLangOpts().ObjC1 || ModMap.getLangOpts().ObjC2)
+ loadSubdirectoryModuleMaps(S
sammccall updated this revision to Diff 152108.
sammccall added a comment.
use foo: instead of foo:bar: for name.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48375
Files:
clangd/CodeComplete.cpp
clangd/CodeCompletionStrings.cpp
clangd/CodeCompletionStrings.h
clangd/i
tobiasvk added a comment.
@pcc, @tejohnson: Are you OK with this going in now that
https://reviews.llvm.org/D47898 has merged?
https://reviews.llvm.org/D34156
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
yunlian added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:428
+
+ if (Args.hasArg(options::OPT_gsplit_dwarf)) {
+if (!Args.getLastArg(options::OPT_gsplit_dwarf_EQ)) {
pcc wrote:
> If you make this `else if (Args.hasArg(options::OPT_gspl
tejohnson accepted this revision.
tejohnson added a comment.
LGTM with following suggestions.
Comment at: clang/lib/CodeGen/BackendUtil.cpp:776
+ bool EmitLTOSummary =
+ (CodeGenOpts.PrepareForLTO && !CodeGenOpts.PrepareForThinLTO &&
+ llvm::Triple(TheModule->getTar
Author: leonardchan
Date: Wed Jun 20 10:19:40 2018
New Revision: 335148
URL: http://llvm.org/viewvc/llvm-project?rev=335148&view=rev
Log:
[Fixed Point Arithmetic] Fixed Point Precision Bits and Fixed Point Literals
This diff includes the logic for setting the precision bits for each primary
fixe
This revision was automatically updated to reflect the committed changes.
leonardchan marked an inline comment as done.
Closed by commit rC335148: [Fixed Point Arithmetic] Fixed Point Precision Bits
and Fixed Point Literals (authored by leonardchan, committed by ).
Repository:
rC Clang
https:/
yunlian updated this revision to Diff 152120.
yunlian added a comment.
Removed redundant 'if' statement
https://reviews.llvm.org/D44788
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/lto-dwo.c
Index: test/Driver/lto-dwo.c
aaron.ballman added reviewers: echristo, rsmith, dblaikie.
aaron.ballman added a comment.
In https://reviews.llvm.org/D47953#1137375, @paulsemel wrote:
> I will for sure add tests @lebedev.ri . Fact is that, for the moment, this is
> not working as expected.
> This is why I am asking for a bit
Author: leonardchan
Date: Wed Jun 20 11:48:05 2018
New Revision: 335155
URL: http://llvm.org/viewvc/llvm-project?rev=335155&view=rev
Log:
Fixed test that failed when checking what variable a value was stored
in for fixed point types.
Modified:
cfe/trunk/test/Frontend/fixed_point_same_fbits.c
eugenis requested changes to this revision.
eugenis added a comment.
This revision now requires changes to proceed.
Please add a test.
Repository:
rC Clang
https://reviews.llvm.org/D48373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.
Looks good with the quotes added.
Comment at: cmake/Modules/HandleCompilerRT.cmake:17
string(STRIP "${LIBRARY_FILE}" LIBRARY_FILE)
+ file(TO_CMAKE_PATH ${LIBRARY_FILE}
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.
LGTM with the same comments as https://reviews.llvm.org/D48356 (add quotes, and
is the translation for LLVM_BINARY_DIR necessary?)
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D4
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.
LGTM with the same comments as https://reviews.llvm.org/D48356 (add quotes, and
is the translation for LLVM_BINARY_DIR necessary?)
Repository:
rUNW libunwind
https://reviews.llvm.org/D48
Author: leonardchan
Date: Wed Jun 20 12:34:05 2018
New Revision: 335159
URL: http://llvm.org/viewvc/llvm-project?rev=335159&view=rev
Log:
Fixed test in prior build where FileCheck tried to match against
`common` when declaring a global variable when we primarily care about
the value assigned in th
mstorsjo added inline comments.
Comment at: cmake/Modules/HandleCompilerRT.cmake:17
string(STRIP "${LIBRARY_FILE}" LIBRARY_FILE)
+ file(TO_CMAKE_PATH ${LIBRARY_FILE} LIBRARY_FILE)
string(REPLACE "builtins" "${name}" LIBRARY_FILE "${LIBRARY_FILE}")
smeenai
smeenai added inline comments.
Comment at: cmake/Modules/HandleOutOfTreeLLVM.cmake:52
else()
- set(LLVM_CMAKE_PATH
- "${LLVM_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX}/cmake/llvm")
+ file(TO_CMAKE_PATH ${LLVM_BINARY_DIR} LLVM_BINARY_DIR_CMAKE_STYLE)
+ set(L
juliehockett updated this revision to Diff 152135.
juliehockett added a comment.
Updating to reflect changes to the framework (and make it work).
https://reviews.llvm.org/D43424
Files:
clang-tools-extra/clang-doc/CMakeLists.txt
clang-tools-extra/clang-doc/Generators.cpp
clang-tools-extra/
eugenis created this revision.
eugenis added a reviewer: alekseyshl.
Mention that no_sanitize attribute can be used with globals.
https://reviews.llvm.org/D48390
Files:
clang/docs/AddressSanitizer.rst
Index: clang/docs/AddressSanitizer.rst
===
(Using the right commits list this time...)
See inline (same as previous).
> -Original Message-
> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
> Leonard Chan via cfe-commits
> Sent: Wednesday, June 20, 2018 3:34 PM
> To: cfe-commits@lists.llvm.org
> Subject:
aaron.ballman added a comment.
Do you also want to update AttrDocs.td with some similar information?
https://reviews.llvm.org/D48390
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
For that particular test I wanted to check the store value on each
declaration but tests failed on 4 different machines where for global
variables. On these machines `dso_local` was not included in the IR
output and x86_64-scei-ps4-ubuntu-fast was one of them. My quick fix
to address this was using
eugenis updated this revision to Diff 152140.
eugenis added a comment.
update AttrDocs.td
https://reviews.llvm.org/D48390
Files:
clang/docs/AddressSanitizer.rst
clang/include/clang/Basic/AttrDocs.td
Index: clang/include/clang/Basic/AttrDocs.td
=
eugenis added a comment.
In https://reviews.llvm.org/D48390#1138193, @aaron.ballman wrote:
> Do you also want to update AttrDocs.td with some similar information?
Done.
https://reviews.llvm.org/D48390
___
cfe-commits mailing list
cfe-commits@list
bruno updated this revision to Diff 152142.
bruno added a comment.
Update after Richard's review, fix python3 compatibility and check for zero
sized string table
https://reviews.llvm.org/D46485
Files:
CMakeLists.txt
test/CMakeLists.txt
test/Modules/crash-vfs-headermaps.m
test/Preproces
craig.topper updated this revision to Diff 152146.
craig.topper added a comment.
Change test to -O0
https://reviews.llvm.org/D48346
Files:
lib/Headers/avx512fintrin.h
test/CodeGen/avx512-reduceIntrin.c
Index: test/CodeGen/avx512-reduceIntrin.c
==
tra added a comment.
Using OpenCL's flag for the purpose adds a *third* way we handle denormals
flushing in clang. Now it would be HIP (which is CUDA-like) using OpenCL's flag
for denormals instead of CUDA's one.
You could change AMDGPUTargetInfo::adjustTargetOptions() to use
CGOpts.getLangOpts
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335168: [CUDA] Removed unused __nvvm_* builtins with
non-generic pointers. (authored by tra, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47845?vs=150194&id=152149#toc
Repository:
Author: tra
Date: Wed Jun 20 13:34:04 2018
New Revision: 335168
URL: http://llvm.org/viewvc/llvm-project?rev=335168&view=rev
Log:
[CUDA] Removed unused __nvvm_* builtins with non-generic pointers.
They were hot even hooked into CGBuiltin's machinery. Even if they were,
CUDA does not support AS-sp
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/clang-doc/MDGenerator.cpp:33
+ case AccessSpecifier::AS_none:
+return "";
+ }
return {};
https://reviews.llvm.org/D43424
___
cfe-commits mai
Author: mstorsjo
Date: Wed Jun 20 13:53:19 2018
New Revision: 335169
URL: http://llvm.org/viewvc/llvm-project?rev=335169&view=rev
Log:
[CMake] Convert paths to the right form in standalone builds on Windows
The paths output from llvm-config --cmakedir and from clang
--print-libgcc-file-name can c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335169: [CMake] Convert paths to the right form in
standalone builds on Windows (authored by mstorsjo, committed by ).
Herald added subscribers: llvm-commits, christof.
Changed prior to commit:
https://
Author: mstorsjo
Date: Wed Jun 20 13:59:18 2018
New Revision: 335171
URL: http://llvm.org/viewvc/llvm-project?rev=335171&view=rev
Log:
[CMake] Convert paths to the right form in standalone builds on Windows
The paths output from llvm-config --cmakedir and from clang
--print-libgcc-file-name can c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335171: [CMake] Convert paths to the right form in
standalone builds on Windows (authored by mstorsjo, committed by ).
Herald added subscribers: llvm-commits, christof.
Changed prior to commit:
https://
Author: mstorsjo
Date: Wed Jun 20 14:03:34 2018
New Revision: 335172
URL: http://llvm.org/viewvc/llvm-project?rev=335172&view=rev
Log:
[CMake] Convert paths to the right form in standalone builds on Windows
The paths output from llvm-config --cmakedir and from clang
--print-libgcc-file-name can c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335172: [CMake] Convert paths to the right form in
standalone builds on Windows (authored by mstorsjo, committed by ).
Herald added subscribers: llvm-commits, christof.
Changed prior to commit:
https://
Author: rnk
Date: Wed Jun 20 14:12:20 2018
New Revision: 335175
URL: http://llvm.org/viewvc/llvm-project?rev=335175&view=rev
Log:
[MS] Make sure __GetExceptionInfo works on types with no linkage
Fixes PR36327
Modified:
cfe/trunk/lib/Sema/Sema.cpp
cfe/trunk/test/CodeGenCXX/microsoft-abi-t
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335177: Add python tool to dump and construct header maps
(authored by bruno, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46485?vs=152142&id=152168#toc
Repository:
rC Clang
ht
Author: bruno
Date: Wed Jun 20 14:16:37 2018
New Revision: 335177
URL: http://llvm.org/viewvc/llvm-project?rev=335177&view=rev
Log:
Add python tool to dump and construct header maps
Header maps are binary files used by Xcode, which are used to map
header names or paths to other locations. Clang h
rnk added a comment.
@hans, think you'll have time to look at this with your recent dllexport PCH
experimentation?
https://reviews.llvm.org/D46652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
cryptoad updated this revision to Diff 152171.
cryptoad added a comment.
Adding tests.
Repository:
rC Clang
https://reviews.llvm.org/D48373
Files:
lib/Driver/SanitizerArgs.cpp
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/fsanitize.c
test/Driver/sanitizer-ld.c
Index: test/Driver/
anniecherk created this revision.
anniecherk added reviewers: juliehockett, jakehehrlich, mcgrathr, phosek.
Herald added a subscriber: cfe-commits.
Added a flag which, when enabled, documents only those methods and fields which
have a Public attribute.
Repository:
rCTE Clang Tools Extra
http
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
Looks great, thanks!
Repository:
rC Clang
https://reviews.llvm.org/D48373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
Author: rsmith
Date: Wed Jun 20 14:58:20 2018
New Revision: 335182
URL: http://llvm.org/viewvc/llvm-project?rev=335182&view=rev
Log:
Related to PR37768: improve diagnostics for class name shadowing.
Diagnose the name of the class being shadowed by using declarations, and
improve the diagnostics f
Author: bruno
Date: Wed Jun 20 15:11:59 2018
New Revision: 335184
URL: http://llvm.org/viewvc/llvm-project?rev=335184&view=rev
Log:
Warning for framework headers using double quote includes
Introduce -Wquoted-include-in-framework-header, which should fire a warning
whenever a quote include appear
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335184: Warning for framework headers using double quote
includes (authored by bruno, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D47157?vs
juliehockett added a comment.
Can you re-upload the patch with context? (i.e. use -U99 or similar)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48395
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
rnk added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:6597
+ (getLangOpts().CPlusPlus17 ||
+ Context.getTargetInfo().getCXXABI().isMicrosoft()))
NewVD->setImplicitlyInline();
thakis wrote:
> Is this related to /Zc:externCo
stella.stamenova added a comment.
This breaks the clang tests on Windows when building using Visual Studio as
none of the updated tests can find hmaptool.
Visual Studio as a generator supports multiple configurations, so its bin
folder varies depending on the build configuration. The generalize
Hi Stella,
On Wed, Jun 20, 2018 at 3:44 PM Stella Stamenova via Phabricator
wrote:
>
> stella.stamenova added a comment.
>
> This breaks the clang tests on Windows when building using Visual Studio as
> none of the updated tests can find hmaptool.
Yes. I contacted Galina about that but maybe it
rsmith added a comment.
Can we now remove the corresponding MSVC-specific hacks elsewhere (eg,
`ASTContext::isMSStaticDataMemberInlineDefinition`), or do we still need those
for `const`-but-not-`constexpr` static data members?
https://reviews.llvm.org/D47956
Author: ahatanak
Date: Wed Jun 20 15:56:59 2018
New Revision: 335189
URL: http://llvm.org/viewvc/llvm-project?rev=335189&view=rev
Log:
Use cast instead of dyn_cast_or_null.
This addresses John's post-commit review feedback.
https://reviews.llvm.org/rC335021#inline-2038
Modified:
cfe/trunk/l
Author: bruno
Date: Wed Jun 20 16:08:43 2018
New Revision: 335190
URL: http://llvm.org/viewvc/llvm-project?rev=335190&view=rev
Log:
Fix hmaptool cmake file to work on Windows
Unbreak a few windows buildbots:
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/11315
http://lab.llvm.org:8
Attempted a fix in r335190, watching the bots.
On Wed, Jun 20, 2018 at 3:53 PM Bruno Cardoso Lopes
wrote:
>
> Hi Stella,
>
> On Wed, Jun 20, 2018 at 3:44 PM Stella Stamenova via Phabricator
> wrote:
> >
> > stella.stamenova added a comment.
> >
> > This breaks the clang tests on Windows when buil
rnk added a comment.
In https://reviews.llvm.org/D47956#1138521, @rsmith wrote:
> Can we now remove the corresponding MSVC-specific hacks elsewhere (eg,
> `ASTContext::isMSStaticDataMemberInlineDefinition`), or do we still need
> those for `const`-but-not-`constexpr` static data members?
We s
bruno updated this revision to Diff 152198.
bruno added a comment.
Address Volodymyr's comments
https://reviews.llvm.org/D47301
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticLexKinds.td
lib/Lex/HeaderSearch.cpp
test/Modules/Inputs/framework-public-includes
Author: rsmith
Date: Wed Jun 20 16:36:55 2018
New Revision: 335191
URL: http://llvm.org/viewvc/llvm-project?rev=335191&view=rev
Log:
When a dependent alignas is applied to a non-dependent typedef,
prioritize the error for the bad subject over the error for the
dependent / non-dependent mismatch.
Author: eugenis
Date: Wed Jun 20 17:16:32 2018
New Revision: 335193
URL: http://llvm.org/viewvc/llvm-project?rev=335193&view=rev
Log:
ASan docs: no_sanitize("address") works on globals.
Summary: Mention that no_sanitize attribute can be used with globals.
Reviewers: alekseyshl
Subscribers: cfe-
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335193: ASan docs: no_sanitize("address") works on
globals. (authored by eugenis, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48390?vs=152140&id=152204#toc
Repository:
rC Clang
On Wed, Jun 20, 2018 at 5:42 PM Stella Stamenova wrote:
>
> Thanks Bruno,
>
> I ran a build as well and I can see that hmaptool is now in the correct bin
> directory. The tests still failed though because on Windows, at least, you
> need to explicitly call python to run a script e.g. "python hma
Author: bruno
Date: Wed Jun 20 18:23:42 2018
New Revision: 335194
URL: http://llvm.org/viewvc/llvm-project?rev=335194&view=rev
Log:
Revert "Fix hmaptool cmake file to work on Windows"
This reverts commit 63711c3cd337a0d22617579a904af07481139611, due to
breaking bots:
http://lab.llvm.org:8011/bui
Author: bruno
Date: Wed Jun 20 18:23:51 2018
New Revision: 335195
URL: http://llvm.org/viewvc/llvm-project?rev=335195&view=rev
Log:
Revert "Warning for framework headers using double quote includes"
This reverts commit 9b5ff2db7e31c4bb11a7d468260b068b41c7c285.
Broke bots:
http://lab.llvm.org:80
Author: bruno
Date: Wed Jun 20 18:23:58 2018
New Revision: 335196
URL: http://llvm.org/viewvc/llvm-project?rev=335196&view=rev
Log:
Revert "Add python tool to dump and construct header maps"
This reverts commit fcfa2dd517ec1a6045a81e8247e346d630a22618.
Broke bots:
http://lab.llvm.org:8011/build
Thanks Bruno,
I ran a build as well and I can see that hmaptool is now in the correct bin
directory. The tests still failed though because on Windows, at least, you need
to explicitly call python to run a script e.g. "python hmaptool".
There are a few tests in LLVM that do that, for example:
;
Yes, I can try it out. Feel free to add me to the review as well.
From: Bruno Cardoso Lopes
Sent: Wednesday, June 20, 2018 6:25 PM
To: Stella Stamenova
Cc: Richard Smith; Duncan Exon Smith; jkor...@apple.com; Michał Górny;
cfe-commits
Subject: Re: [PATCH] D46485:
apazos created this revision.
apazos added a reviewer: asb.
Herald added subscribers: rogfer01, mgrang, edward-jones, zzheng, shiva0217,
kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar.
Clang supports the GNU style ``__attribute__((interrupt))`` attribute on RISCV
targets.
Permissible
I can give it a try as well.
Thanks
Galina
On Wed, Jun 20, 2018 at 6:30 PM, Stella Stamenova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Yes, I can try it out. Feel free to add me to the review as well.
>
> --
> *From:* Bruno Cardoso Lopes
> *Sent:* Wedne
1 - 100 of 102 matches
Mail list logo
