stella.stamenova added a comment.

This breaks the clang tests on Windows when building using Visual Studio as 
none of the updated tests can find hmaptool.
Visual Studio as a generator supports multiple configurations, so its bin 
folder varies depending on the build configuration. The generalized version of 
the bin directory is: ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin. This is 
actually the proper bin directory to use for any generator because 
${CMAKE_CFG_INTDIR} is simply '.' when the generator (such as ninja) doesn't 
support multiple configurations.

I can look into a fix and submit a change for review tomorrow if you can't, but 
in the future please make sure to use the full path to the bin directory 
(${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin) to avoid missing a generator.


Repository:
  rC Clang

https://reviews.llvm.org/D46485



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D46485: A... Bruno Cardoso Lopes via Phabricator via cfe-commits
    • [PATCH] D464... Bruno Cardoso Lopes via Phabricator via cfe-commits
    • [PATCH] D464... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D464... Bruno Cardoso Lopes via Phabricator via cfe-commits
    • [PATCH] D464... Bruno Cardoso Lopes via Phabricator via cfe-commits
    • [PATCH] D464... Stella Stamenova via Phabricator via cfe-commits
      • Re: [PAT... Bruno Cardoso Lopes via cfe-commits
        • Re: ... Bruno Cardoso Lopes via cfe-commits
          • ... Stella Stamenova via cfe-commits
            • ... Bruno Cardoso Lopes via cfe-commits
              • ... Stella Stamenova via cfe-commits
                • ... Galina Kistanova via cfe-commits

Reply via email to