[PATCH] D45686: [Driver] Clean up tmp files when deleting Compilation objects

2018-05-28 Thread David Stenberg via Phabricator via cfe-commits
dstenb updated this revision to Diff 148791. dstenb added a comment. Update patch to include the clang-tools-extra test case originally added in https://reviews.llvm.org/D47251. https://reviews.llvm.org/D45686 Files: cfe/trunk/include/clang/Driver/Compilation.h cfe/trunk/lib/Driver/Compila

[PATCH] D47251: Add a lit reproducer for PR37091

2018-05-28 Thread David Stenberg via Phabricator via cfe-commits
dstenb abandoned this revision. dstenb added a comment. Merged into https://reviews.llvm.org/D45686. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D47445: [ASTImporter] Corrected diagnostic client handling in tests.

2018-05-28 Thread Balázs Kéri via Phabricator via cfe-commits
balazske created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: a.sidorin. ASTImporter tests may produce source file related warnings, the diagnostic client should be in correct state to handle it. Added 'beginSourceFile' to set the client state. Reposito

[PATCH] D47417: [analyzer] Add missing state transition in IteratorChecker

2018-05-28 Thread Henry Wong via Phabricator via cfe-commits
MTC added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:399 + + C.addTransition(State); } NoQ wrote: > MTC wrote: > > I have two questions may need @NoQ or @xazax.hun who is more familiar with > > the analyzer engine help to answ

[clang-tools-extra] r333369 - [clangd] Workaround the comments crash, reenable the test.

2018-05-28 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon May 28 02:54:51 2018 New Revision: 69 URL: http://llvm.org/viewvc/llvm-project?rev=69&view=rev Log: [clangd] Workaround the comments crash, reenable the test. This fix is still quite fragile, the underlying problem is that the code should not rely on source ran

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

2018-05-28 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus marked 4 inline comments as done. Szelethus added a comment. I decided to mark the inline comments in `isPointerOrReferenceUninit` regarding the dereferencing loop termination done for now. I left several TODO's in the function to be fixed later, with many of them depending on one anot

[PATCH] D47108: [CodeGenCXX] Add -fforce-emit-vtables

2018-05-28 Thread Krzysztof Pszeniczny via Phabricator via cfe-commits
amharc requested changes to this revision. amharc added inline comments. This revision now requires changes to proceed. Comment at: clang/test/CodeGenCXX/vtable-available-externally.cpp:445 +// after the Derived construction. +// CHECK-FORCE-EMIT-DAG: @_ZTVN6Test187DerivedE = lin

[PATCH] D35110: [Analyzer] Constraint Manager Negates Difference

2018-05-28 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware updated this revision to Diff 148804. baloghadamsoftware added a comment. I still disagree, but I want the review to continue so I did the requested modifications. https://reviews.llvm.org/D35110 Files: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp lib/StaticAnalyze

[PATCH] D45835: Add new driver mode for dumping compiler options

2018-05-28 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman marked 3 inline comments as done. aaron.ballman added inline comments. Comment at: test/Frontend/compiler-options-dump.cpp:3 +// RUN: %clang_cc1 -compiler-options-dump -std=c++17 %s -o - | FileCheck %s --check-prefix=CXX17 +// RUN: %clang_cc1 -compiler-options-dump

[clang-tools-extra] r333370 - [clangd] Fix leak sanitizers warnings in clangd

2018-05-28 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon May 28 05:11:37 2018 New Revision: 70 URL: http://llvm.org/viewvc/llvm-project?rev=70&view=rev Log: [clangd] Fix leak sanitizers warnings in clangd The commit includes two changes: 1. Set DisableFree to false when building the ParsedAST. This is sane defaul

[PATCH] D47450: [ASTImporter] Use InjectedClassNameType at import of templated record.

2018-05-28 Thread Balázs Kéri via Phabricator via cfe-commits
balazske created this revision. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: a.sidorin. At import of a record describing a template set its type to InjectedClassNameType (instead of RecordType). Repository: rC Clang https://reviews.llvm.org/D47450 Files: lib/AST

[clang-tools-extra] r333371 - [clangd] Remove accessors for top-level decls from preamble

2018-05-28 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon May 28 05:23:17 2018 New Revision: 71 URL: http://llvm.org/viewvc/llvm-project?rev=71&view=rev Log: [clangd] Remove accessors for top-level decls from preamble Summary: They cause lots of deserialization and are not actually used. The ParsedAST accessor that pr

[PATCH] D47450: [ASTImporter] Use InjectedClassNameType at import of templated record.

2018-05-28 Thread Gabor Marton via Phabricator via cfe-commits
martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. LGTM! But let's wait for someone else's review too. @a.sidorin We discovered this error during the CTU analysis of google/protobuf and we could reduce t

[PATCH] D47331: [clangd] Remove accessors for top-level decls from preamble

2018-05-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE71: [clangd] Remove accessors for top-level decls from preamble (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D47331?vs=148605&id=148806#toc Repository

[PATCH] D47450: [ASTImporter] Use InjectedClassNameType at import of templated record.

2018-05-28 Thread Gabor Marton via Phabricator via cfe-commits
martong added a reviewer: r.stahl. martong added a comment. Adding Rafael too as a reviewer, because he has been working also on the ASTImporter recently. Repository: rC Clang https://reviews.llvm.org/D47450 ___ cfe-commits mailing list cfe-comm

[PATCH] D47445: [ASTImporter] Corrected diagnostic client handling in tests.

2018-05-28 Thread Gabor Marton via Phabricator via cfe-commits
martong added reviewers: akyrtzi, ddunbar. martong added a comment. Adding Argyrios and Daniel as a reviewer for ASTUnit related changes. Repository: rC Clang https://reviews.llvm.org/D47445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47445: [ASTImporter] Corrected diagnostic client handling in tests.

2018-05-28 Thread Gabor Marton via Phabricator via cfe-commits
martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. LGTM! But let's wait the review of those people who have history in `ASTUnit.cpp`. Repository: rC Clang https://reviews.llvm.org/D47445 __

[PATCH] D47223: [clangd] Handle enumerators in named, unscoped enums similarly to scoped enums

2018-05-28 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. So to keep completion working, maybe we can give add enumerators with full qualification and have a flag that determines whether the last component of the qualifier can be ignored? This would give a simple implementation path for now, and will add a semantic signa

[PATCH] D47445: [ASTImporter] Corrected diagnostic client handling in tests.

2018-05-28 Thread Aleksei Sidorin via Phabricator via cfe-commits
a.sidorin accepted this revision. a.sidorin added a comment. Looks good to me, but the approval from AST code owners is required, I think. Repository: rC Clang https://reviews.llvm.org/D47445 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang-tools-extra] r333373 - [clangd] Remove the outdated comment. NFC

2018-05-28 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Mon May 28 05:43:20 2018 New Revision: 73 URL: http://llvm.org/viewvc/llvm-project?rev=73&view=rev Log: [clangd] Remove the outdated comment. NFC Modified: clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp Modified: clang-tools-extra/trunk/unittes

[PATCH] D46476: [HIP] Add action builder for HIP

2018-05-28 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. ping Any further changes are needed? Thanks. https://reviews.llvm.org/D46476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47450: [ASTImporter] Use InjectedClassNameType at import of templated record.

2018-05-28 Thread Rafael Stahl via Phabricator via cfe-commits
r.stahl accepted this revision. r.stahl added a comment. LGTM! I'm not really too confident to approve changes yet, but with a second opinion it should be fine. Comment at: lib/AST/ASTImporter.cpp:2139 + CXXRecordDecl *Injected = nullptr; + for (NamedDecl *F

[PATCH] D44888: [RISCV] Add -mrelax/-mno-relax flags to enable/disable RISCV linker relaxation

2018-05-28 Thread Alex Bradbury via Phabricator via cfe-commits
asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. Looks good to me, thanks! Repository: rL LLVM https://reviews.llvm.org/D44888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D46823: [analyzer] const init: handle non-explicit cases more accurately

2018-05-28 Thread Rafael Stahl via Phabricator via cfe-commits
r.stahl updated this revision to Diff 148809. r.stahl added a comment. Added FIXME tests. I know my example didn't exercise your scenario, but it was the only one I could think of where returning zero would have been straight up wrong. Note that I default initialized `a` to 3 there, so `sarr` i

[PATCH] D47450: [ASTImporter] Use InjectedClassNameType at import of templated record.

2018-05-28 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added inline comments. Comment at: lib/AST/ASTImporter.cpp:2139 + CXXRecordDecl *Injected = nullptr; + for (NamedDecl *Found : D2CXX->noload_lookup(Name)) { +auto *Record = dyn_cast(Found); r.stahl wrote: > The only thing I'

[PATCH] D47451: [analyzer] Remove the redundant check about same state transition in `ArrayBoundCheckerV2.cpp`.

2018-05-28 Thread Henry Wong via Phabricator via cfe-commits
MTC created this revision. MTC added reviewers: NoQ, xazax.hun, george.karpenkov. Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet. Since the `addTransitionImpl()` has a check about same state transition, there is no need to check it in `ArrayBoundCheckerV2.cpp`. Repository:

[PATCH] D47450: [ASTImporter] Use InjectedClassNameType at import of templated record.

2018-05-28 Thread Rafael Stahl via Phabricator via cfe-commits
r.stahl added inline comments. Comment at: lib/AST/ASTImporter.cpp:2139 + CXXRecordDecl *Injected = nullptr; + for (NamedDecl *Found : D2CXX->noload_lookup(Name)) { +auto *Record = dyn_cast(Found); balazske wrote: > r.stahl wrote: >

[PATCH] D44568: Fix emission of phony dependency targets when adding extra deps

2018-05-28 Thread David Stenberg via Phabricator via cfe-commits
dstenb updated this revision to Diff 148819. dstenb marked an inline comment as done. dstenb added a comment. Addressed vsapsai's comments. https://reviews.llvm.org/D44568 Files: lib/Frontend/DependencyFile.cpp test/Frontend/dependency-gen-extradeps-phony.c Index: test/Frontend/dependency

[PATCH] D47063: [clangd] Keep only a limited number of idle ASTs in memory

2018-05-28 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 148820. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Address review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47063 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/TUSch

[PATCH] D44568: Fix emission of phony dependency targets when adding extra deps

2018-05-28 Thread David Stenberg via Phabricator via cfe-commits
dstenb added inline comments. Comment at: test/Frontend/dependency-gen-extradeps-phony.c:6-7 + +// CHECK: dependency-gen-extradeps-phony.o: 1.extra 2.extra +// CHECK-NOT: .c: +// CHECK: 1.extra: vsapsai wrote: > I think it would be better to have a check > >

[libcxx] r333376 - Mark the template deduction tests as UNSUPPORTED on clang 5, because it deduces the wrong type.

2018-05-28 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon May 28 08:42:47 2018 New Revision: 76 URL: http://llvm.org/viewvc/llvm-project?rev=76&view=rev Log: Mark the template deduction tests as UNSUPPORTED on clang 5, because it deduces the wrong type. Modified: libcxx/trunk/test/std/containers/container.adaptor

[PATCH] D47063: [clangd] Keep only a limited number of idle ASTs in memory

2018-05-28 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/TUScheduler.cpp:71 + + /// Update the function used to compute the value. + void update(std::function()> ComputeF); sammccall wrote: > ilya-biryukov wrote: > > sammccall wrote: > > > I think I understand t

[PATCH] D47063: [clangd] Keep only a limited number of idle ASTs in memory

2018-05-28 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 148822. ilya-biryukov added a comment. - Remove ASTBuilder, make everything a helper function Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47063 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/TUScheduler.cpp clangd/

[PATCH] D47063: [clangd] Keep only a limited number of idle ASTs in memory

2018-05-28 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 148824. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - s/Params/Policy Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47063 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/TUScheduler.cp

[PATCH] D47063: [clangd] Keep only a limited number of idle ASTs in memory

2018-05-28 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. There are still a few nits I haven't addressed, but the other big change is now there: removing ASTBuilder, replacing it with free-standing functions. I'd say I liked the previous code better, since the use sites were a bit smaller and the functions have ridiculou

[PATCH] D47135: [analyzer] A checker for dangling internal buffer pointers in C++

2018-05-28 Thread Reka Kovacs via Phabricator via cfe-commits
rnkovacs updated this revision to Diff 148827. rnkovacs added a comment. Added a check for `UnknownVal` and two FIXMEs (one for the `OriginExpr` and one for the new `CheckKind`). https://reviews.llvm.org/D47135 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Che

[PATCH] D45517: [analyzer] False positive refutation with Z3

2018-05-28 Thread Mikhail Ramalho via Phabricator via cfe-commits
mikhail.ramalho updated this revision to Diff 148828. mikhail.ramalho retitled this revision from "[analyzer] WIP: False positive refutation with Z3" to "[analyzer] False positive refutation with Z3". mikhail.ramalho added a comment. Added test cases and updated the analyzer-config tests with the

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

2018-05-28 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: clang-doc/BitcodeReader.cpp:553 + +#define READINFO(INFO) \ + { \ Convert this to a tem

r333379 - [coroutines] Pass implicit object parameter to promise ctor (fix BUG37604)

2018-05-28 Thread Gor Nishanov via cfe-commits
Author: gornishanov Date: Mon May 28 11:08:47 2018 New Revision: 79 URL: http://llvm.org/viewvc/llvm-project?rev=79&view=rev Log: [coroutines] Pass implicit object parameter to promise ctor (fix BUG37604) Summary: Complete the implementation of p0914r1. Implicit object parameter should be

r333375 - Introduces --stats-only option to only show changes in statistics.

2018-05-28 Thread Mikhail R. Gadelha via cfe-commits
Author: mramalho Date: Mon May 28 08:40:39 2018 New Revision: 75 URL: http://llvm.org/viewvc/llvm-project?rev=75&view=rev Log: Introduces --stats-only option to only show changes in statistics. Modified: cfe/trunk/utils/analyzer/CmpRuns.py Modified: cfe/trunk/utils/analyzer/CmpRuns.p

[PATCH] D44954: [clangd] Add "member" symbols to the index

2018-05-28 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle added inline comments. Comment at: clangd/index/SymbolCollector.cpp:158 + translationUnitDecl(), namespaceDecl(), linkageSpecDecl(), recordDecl(), + enumDecl(), objcProtocolDecl(), objcInterfaceDecl(), objcCategoryDecl(), + objcCategoryImplDecl(), objcImp

[PATCH] D44954: [clangd] Add "member" symbols to the index

2018-05-28 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle updated this revision to Diff 148834. malaperle marked 6 inline comments as done. malaperle added a comment. Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44954 Files: clangd/CodeComplete.cpp clangd/index/Index.h clangd/index/MemIndex.cpp cl

[PATCH] D44954: [clangd] Add "member" symbols to the index

2018-05-28 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle added inline comments. Comment at: unittests/clangd/SymbolCollectorTests.cpp:141 Args.insert(Args.end(), ExtraArgs.begin(), ExtraArgs.end()); +Args.push_back(TestFileName); + This allows to override the "-xc++" with something else, i.e. -xobjec

[PATCH] D47454: [coroutines] Pass implicit object parameter to promise ctor (fix BUG37604)

2018-05-28 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov created this revision. GorNishanov added reviewers: modocache, rsmith, lewissbaker. Herald added a subscriber: EricWF. Complete the implementation of p0914r1. Implicit object parameter should be passed to a promise constructor. Fixes: https://bugs.llvm.org/show_bug.cgi?id=37604 http

[PATCH] D47454: [coroutines] Pass implicit object parameter to promise ctor (fix BUG37604)

2018-05-28 Thread Gor Nishanov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL79: [coroutines] Pass implicit object parameter to promise ctor (fix BUG37604) (authored by GorNishanov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D47454: [coroutines] Pass implicit object parameter to promise ctor (fix BUG37604)

2018-05-28 Thread Brian Gesiak via Phabricator via cfe-commits
modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Great! Thanks @GorNishanov! https://reviews.llvm.org/D47454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D44480: [Sema] Don't skip function bodies with 'auto' without trailing return type

2018-05-28 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 148835. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Address review comments. - Added one more test. Repository: rC Clang https://reviews.llvm.org/D44480 Files: lib/Sema/SemaDecl.cpp test/CodeCompletion/crash

[libcxx] r333381 - Fix up the final bits of breakage due to clang v5 generating bad implicit template deduction guides - specifically for copy-ctors

2018-05-28 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon May 28 12:20:21 2018 New Revision: 81 URL: http://llvm.org/viewvc/llvm-project?rev=81&view=rev Log: Fix up the final bits of breakage due to clang v5 generating bad implicit template deduction guides - specifically for copy-ctors Modified: libcxx/trunk/test

[PATCH] D44480: [Sema] Don't skip function bodies with 'auto' without trailing return type

2018-05-28 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. Sorry for delays with this patch, I somehow missed the email notification about it. > Expounding on my concerns a bit -- I'm worried about all the other places > calling isUndeducedType() and whether they're also at risk and thus a better > fix is to change isUnd

[PATCH] D44568: Fix emission of phony dependency targets when adding extra deps

2018-05-28 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai accepted this revision. vsapsai added a comment. This revision is now accepted and ready to land. Looks good to me. Just watch the build bots in case some of them are strict with warnings and require `(void)AddFilename(Filename)`. As for the case when the input file is also an extra depe

Re: r333141 - Use zeroinitializer for (trailing zero portion of) large array initializers

2018-05-28 Thread David Blaikie via cfe-commits
Probably nice to mention in the commit message what the fix was (& if/where there was there a test added for it?) so readers don't have to try to eyeball diff this commit against the otherone. On Wed, May 23, 2018 at 4:45 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Aut

[PATCH] D47108: [CodeGenCXX] Add -fforce-emit-vtables

2018-05-28 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek updated this revision to Diff 148839. Prazek marked an inline comment as done. Prazek added a comment. fixed test Repository: rL LLVM https://reviews.llvm.org/D47108 Files: clang/docs/ClangCommandLineReference.rst clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst clang/in

[PATCH] D45517: [analyzer] False positive refutation with Z3

2018-05-28 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov added a comment. Please resubmit with -U999 diff flag (or using arc) Comment at: include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:362 +class FalsePositiveRefutationBRVisitor final +: public BugReporterVisitorImpl { Can

[libcxx] r333384 - LWG 2969 "polymorphic_allocator::construct() shouldn't pass resource()"

2018-05-28 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon May 28 17:08:47 2018 New Revision: 84 URL: http://llvm.org/viewvc/llvm-project?rev=84&view=rev Log: LWG 2969 "polymorphic_allocator::construct() shouldn't pass resource()" Patch from Arthur O'Dwyer. In the TS, `uses_allocator` construction for `pair` tried to use

[PATCH] D47109: LWG 2969 "polymorphic_allocator::construct() shouldn't pass resource()"

2018-05-28 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF closed this revision. EricWF added a comment. Committed as r84. Repository: rCXX libc++ https://reviews.llvm.org/D47109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47111: : Implement monotonic_buffer_resource.

2018-05-28 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. FYI I have a full implementation of this laying around as https://reviews.llvm.org/D27402 (https://reviews.llvm.org/D27402). But I have never taken the time to resolve merge conflicts. Feel free to steal any of the tests if they're still relevant. Comm

[PATCH] D44888: [RISCV] Add -mrelax/-mno-relax flags to enable/disable RISCV linker relaxation

2018-05-28 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL85: [RISCV] Add -mrelax/-mno-relax flags to enable/disable RISCV linker relaxation (authored by shiva, committed by ). Changed prior to commit: https://reviews.llvm.org/D44888?vs=148548&id=148840#to

[PATCH] D47341: [Sema] Disable creating new delayed typos while correcting existing.

2018-05-28 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai updated this revision to Diff 148841. vsapsai added a comment. - Fix only infinite loop and don't touch the assertion failure. New commit message should be: [Sema] Fix infinite typo correction loop. NumTypos guard value ~0U doesn't prevent from creating new delayed typos. When you creat

[PATCH] D47341: [Sema] Disable creating new delayed typos while correcting existing.

2018-05-28 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. Some debugging details that can be useful but too specific for the commit message. When we have infinite loop, the steps are: 1. Detect typos `structVar1`, `structVar2` 2. Correct typos `structVar1`, `structVar2` 1. Replace `structVar1` with `structVar`. Add correspond

[PATCH] D47111: : Implement monotonic_buffer_resource.

2018-05-28 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added inline comments. Comment at: include/experimental/memory_resource:429 +size_t __capacity_; +size_t __alignment_; +size_t __used_; EricWF wrote: > I can't imagine we'll need more than 1 byte to represent the alignment. Even assuming f

[PATCH] D47111: : Implement monotonic_buffer_resource.

2018-05-28 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added inline comments. Comment at: include/experimental/memory_resource:428 +__monotonic_buffer_header *__next_; +size_t __capacity_; +size_t __alignment_; Can't we determine the capacity in most cases simply using `static_cast(this) - static_

[PATCH] D47111: : Implement monotonic_buffer_resource.

2018-05-28 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added inline comments. Comment at: src/experimental/memory_resource.cpp:237 + +void *result = __res_->allocate(aligned_capacity, align); +__monotonic_buffer_header *header = (__monotonic_buffer_header *)((char *)result + aligned_capacity - header_size); --

r333387 - [X86] Merge the 3 different flavors of masked vpermi2var/vpermt2var builtins to a single version without masking. Use select builtins with appropriate operand instead.

2018-05-28 Thread Craig Topper via cfe-commits
Author: ctopper Date: Mon May 28 20:26:38 2018 New Revision: 87 URL: http://llvm.org/viewvc/llvm-project?rev=87&view=rev Log: [X86] Merge the 3 different flavors of masked vpermi2var/vpermt2var builtins to a single version without masking. Use select builtins with appropriate operand ins

[PATCH] D47111: : Implement monotonic_buffer_resource.

2018-05-28 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone updated this revision to Diff 148843. Quuxplusone added a comment. Add `override`; disintegrate the unit test; adopt some tests from Eric's https://reviews.llvm.org/D27402. Also fix one QOI issue discovered by Eric's tests: if the user passes an `initial_size` to the constructor, the

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

2018-05-28 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. In https://reviews.llvm.org/D45045#1092697, @hans wrote: > This broke the Chromium build. I've uploaded a reproducer at > https://bugs.chromium.org/p/chromium/issues/detail?id=841170#c1 > > I'm guessing maybe a Clang bootstrap with debug info might also reproduce the

[PATCH] D47111: : Implement monotonic_buffer_resource.

2018-05-28 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone updated this revision to Diff 148845. Quuxplusone added a comment. Refactor to remove unused fields from the header structs. Before this change, `sizeof(monotonic_buffer_resource) == 56` and the overhead per allocated chunk was `40` bytes. After this change, `sizeof(monotonic_buffer_