Author: delena
Date: Sun May 13 00:45:58 2018
New Revision: 332193
URL: http://llvm.org/viewvc/llvm-project?rev=332193&view=rev
Log:
Added atomic_fetch_min, max, umin, umax intrinsics to clang.
These intrinsics work exactly as all other atomic_fetch_* intrinsics and allow
to create *atomicrmw* w
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332193: Added atomic_fetch_min, max, umin, umax intrinsics
to clang. (authored by delena, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46386?vs=146462&id=146502#toc
Repository:
EricWF updated this revision to Diff 146508.
EricWF marked an inline comment as done.
EricWF added a comment.
Misc cleanups.
- proof read and correct documentation.
https://reviews.llvm.org/D46740
Files:
docs/InternalsManual.rst
include/clang/Basic/Diagnostic.td
include/clang/Basic/Diagn
HLJ2009 created this revision.
HLJ2009 added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
I tested the alias attribute on my own Apple laptop (Target:
x86_64-apple-darwin17.5.0). First, I use __has_attribute to test that the alias
is usable or not. The test code is as follo
lebedev.ri added a comment.
1. Please always upload all patches with full context.
2. tests?
Repository:
rC Clang
https://reviews.llvm.org/D46805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
mikerice added a comment.
Thanks for taking a look at the patch. I added a warning as suggested. I also
fixed skipping so it ignores all directives except #include and now #define.
Repository:
rC Clang
https://reviews.llvm.org/D46652
___
cfe-co
mikerice updated this revision to Diff 146513.
mikerice added a comment.
Added warning when macro is defined when skipping. Also fixed skipping so
directives are completely ignored expect for #include and #define.
https://reviews.llvm.org/D46652
Files:
include/clang/Basic/DiagnosticLexKinds
shuaiwang updated this revision to Diff 146514.
shuaiwang marked 10 inline comments as done.
shuaiwang added a comment.
Rename to readability-simplify-subscript-expr and addressed other comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45702
Files:
clang-tidy/readabili
Quuxplusone created this revision.
Quuxplusone added a reviewer: EricWF.
Herald added a subscriber: cfe-commits.
`__user_alloc_construct_impl` is used by , but
this `__user_alloc_construct` is never used.
Repository:
rCXX libc++
https://reviews.llvm.org/D46806
Files:
include/__functional_
Quuxplusone created this revision.
Quuxplusone added reviewers: EricWF, mclow.lists.
Herald added subscribers: cfe-commits, christof.
This makes room for a new "test_memory_resource.hpp", very similar to the old
one, but testing the C++17 header instead of the experimental header.
Repository:
aaron.ballman updated this revision to Diff 146524.
aaron.ballman added a comment.
Look through atomic types when checking type completeness during template
instantiation.
https://reviews.llvm.org/D46112
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/AST/Type.cpp
lib/Sema/SemaChec
aaron.ballman marked an inline comment as done.
aaron.ballman added inline comments.
Comment at: test/SemaCXX/atomic-type.cpp:5
template struct atomic {
- _Atomic(T) value;
+ _Atomic(T) value; // expected-error {{field has incomplete type
'_Atomic(user::inner)'}}
--
aaron.ballman updated this revision to Diff 146529.
aaron.ballman marked 3 inline comments as done.
aaron.ballman added a comment.
Updated based on review feedback.
https://reviews.llvm.org/D45835
Files:
include/clang/Basic/Features.def
include/clang/Driver/CC1Options.td
include/clang/Fro
aaron.ballman added inline comments.
Comment at: lib/Frontend/FrontendActions.cpp:779
+ {
+std::string Str;
+#define FEATURE(Name, Predicate)
\
lebedev.ri wrote:
> This is likely to do an allocation for each fea
lebedev.ri added inline comments.
Comment at: lib/Frontend/FrontendActions.cpp:779
+ {
+std::string Str;
+#define FEATURE(Name, Predicate)
\
aaron.ballman wrote:
> lebedev.ri wrote:
> > This is likely to do an a
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a few minor nits to be fixed.
Comment at: clang-tidy/readability/SimplifySubscriptExprCheck.cpp:53-54
+ const auto *Call = Result.Nodes.getNodeAs("ca
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D45093
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D46639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
aaron.ballman added a comment.
Thank you for working on this patch -- be sure to add tests that ensure the
attribute is properly prohibited on the expected targets.
Comment at: include/clang/Basic/Attr.td:299-300
list ObjectFormats;
+ // It indicates that a certain attribu
rsmith added inline comments.
Comment at: include/clang/Basic/Attr.td:566-567
-def Alias : Attr {
+// We do not support alias attribute on Apple platform, so we exclude the
platform.
+def Alias : Attr, TargetSpecificAttr {
let Spellings = [GCC<"alias">];
Is
rsmith added inline comments.
Comment at: lib/Sema/SemaType.cpp:7604-7608
+ // When instantiating a class template and reaching an atomic type, the check
+ // for type completeness should occur on the underlying type and not the
+ // atomic type itself (which is always incompl
shuaiwang updated this revision to Diff 146531.
shuaiwang marked 3 inline comments as done.
shuaiwang added a comment.
Handle unevaluated expressions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45679
Files:
clang-tidy/utils/CMakeLists.txt
clang-tidy/utils/ExprMutationAn
shuaiwang updated this revision to Diff 146532.
shuaiwang marked 3 inline comments as done.
shuaiwang added a comment.
Addressed review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45702
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/Readabi
Author: ctopper
Date: Sun May 13 16:03:30 2018
New Revision: 332203
URL: http://llvm.org/viewvc/llvm-project?rev=332203&view=rev
Log:
[X86] Emit better code for _mm_cvtu32_sd, _mm_cvtu64_sd, _mm_cvtu32_ss, and
_mm_cvtu64_ss.
We can use direct C code for these that will use uitofp and inserteleme
kito-cheng added inline comments.
Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:130
+ // which may override the defaults.
+ handleTargetFeaturesGroup(Args, Features,
options::OPT_m_riscv_Features_Group);
}
This part should move to the begin of the functio
craig.topper added a comment.
Yeah the others will need codegen work. So I'm starting with the easy cases.
Repository:
rC Clang
https://reviews.llvm.org/D46742
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Author: ctopper
Date: Sun May 13 21:05:06 2018
New Revision: 332210
URL: http://llvm.org/viewvc/llvm-project?rev=332210&view=rev
Log:
[X86] Use __builtin_convertvector to implement _mm512_cvtps_pd.
If we're using default rounding mode we can let __builtin_convertvector to
generate an fpextend. T
Author: ctopper
Date: Sun May 13 21:57:46 2018
New Revision: 332213
URL: http://llvm.org/viewvc/llvm-project?rev=332213&view=rev
Log:
[X86] Use select instrution and fpextend in the implementation of
_mm512_mask_cvtps_pd and _mm512_maskz_cvtps_pd.
Modified:
cfe/trunk/lib/Headers/avx512fintri
28 matches
Mail list logo
