rsmith added inline comments.

================
Comment at: include/clang/Basic/Attr.td:566-567
 
-def Alias : Attr {
+// We do not support alias attribute on Apple platform, so we exclude the 
platform.
+def Alias : Attr, TargetSpecificAttr<TargetDarwinNegative> {
   let Spellings = [GCC<"alias">];
----------------
Is this really specific to Darwin? I would expect it instead to be specific to 
the `ObjectFormat`. And I think listing the object formats that *do* support 
aliases seems reasonable (as there's only three of them to list -- assuming 
that WAsm actually supports aliases, which I don't know -- and we'd probably 
want future object file formats to opt in rather than opting out).


Repository:
  rC Clang

https://reviews.llvm.org/D46805



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to